Re: [PR] Create API to list Quota credits [cloudstack]

2025-01-16 Thread via GitHub
DaanHoogland merged PR #9590: URL: https://github.com/apache/cloudstack/pull/9590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

Re: [PR] Create API to list Quota credits [cloudstack]

2025-01-15 Thread via GitHub
winterhazel commented on PR #9590: URL: https://github.com/apache/cloudstack/pull/9590#issuecomment-2593463747 > @winterhazel , clear, your call..! This one should be good for merge as well 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] Create API to list Quota credits [cloudstack]

2025-01-15 Thread via GitHub
DaanHoogland commented on PR #9590: URL: https://github.com/apache/cloudstack/pull/9590#issuecomment-2593182480 > Hey @DaanHoogland, my idea of removing the credits listing from `quotaBalance` was to make each API have a single responsibility and make credits-related code changes easier in

Re: [PR] Create API to list Quota credits [cloudstack]

2025-01-09 Thread via GitHub
DaanHoogland commented on PR #9590: URL: https://github.com/apache/cloudstack/pull/9590#issuecomment-2579465227 test_vm_life_cycle has a more generic problem especially in the secure chapter. The errors are different both times and probably environmental by nature. -- This is an automate

Re: [PR] Create API to list Quota credits [cloudstack]

2025-01-08 Thread via GitHub
blueorangutan commented on PR #9590: URL: https://github.com/apache/cloudstack/pull/9590#issuecomment-2578892423 [SF] Trillian test result (tid-12058) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 52614 seconds Marvin logs: https://github.com/

Re: [PR] Create API to list Quota credits [cloudstack]

2025-01-08 Thread via GitHub
blueorangutan commented on PR #9590: URL: https://github.com/apache/cloudstack/pull/9590#issuecomment-2577049609 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] Create API to list Quota credits [cloudstack]

2025-01-08 Thread via GitHub
DaanHoogland commented on PR #9590: URL: https://github.com/apache/cloudstack/pull/9590#issuecomment-2577044797 @blueorangutan test keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Create API to list Quota credits [cloudstack]

2025-01-08 Thread via GitHub
DaanHoogland commented on PR #9590: URL: https://github.com/apache/cloudstack/pull/9590#issuecomment-2577043633 applying insanity -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] Create API to list Quota credits [cloudstack]

2025-01-08 Thread via GitHub
blueorangutan commented on PR #9590: URL: https://github.com/apache/cloudstack/pull/9590#issuecomment-2576999577 [SF] Trillian test result (tid-12057) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 64498 seconds Marvin logs: https://github.com/

Re: [PR] Create API to list Quota credits [cloudstack]

2025-01-07 Thread via GitHub
blueorangutan commented on PR #9590: URL: https://github.com/apache/cloudstack/pull/9590#issuecomment-2575301386 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] Create API to list Quota credits [cloudstack]

2025-01-07 Thread via GitHub
DaanHoogland commented on PR #9590: URL: https://github.com/apache/cloudstack/pull/9590#issuecomment-2575299497 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Create API to list Quota credits [cloudstack]

2025-01-07 Thread via GitHub
blueorangutan commented on PR #9590: URL: https://github.com/apache/cloudstack/pull/9590#issuecomment-2575292219 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12004 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Create API to list Quota credits [cloudstack]

2025-01-07 Thread via GitHub
blueorangutan commented on PR #9590: URL: https://github.com/apache/cloudstack/pull/9590#issuecomment-2575141983 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] Create API to list Quota credits [cloudstack]

2025-01-07 Thread via GitHub
DaanHoogland commented on PR #9590: URL: https://github.com/apache/cloudstack/pull/9590#issuecomment-2575139851 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Create API to list Quota credits [cloudstack]

2025-01-06 Thread via GitHub
bernardodemarco commented on code in PR #9590: URL: https://github.com/apache/cloudstack/pull/9590#discussion_r1904372721 ## engine/schema/src/main/resources/META-INF/db/schema-42010to42100.sql: ## @@ -24,3 +24,10 @@ CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.console_session',

Re: [PR] Create API to list Quota credits [cloudstack]

2024-12-05 Thread via GitHub
blueorangutan commented on PR #9590: URL: https://github.com/apache/cloudstack/pull/9590#issuecomment-2521274400 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Create API to list Quota credits [cloudstack]

2024-12-05 Thread via GitHub
blueorangutan commented on PR #9590: URL: https://github.com/apache/cloudstack/pull/9590#issuecomment-2521161307 @winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Create API to list Quota credits [cloudstack]

2024-12-05 Thread via GitHub
winterhazel commented on PR #9590: URL: https://github.com/apache/cloudstack/pull/9590#issuecomment-2521158527 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Create API to list Quota credits [cloudstack]

2024-12-03 Thread via GitHub
github-actions[bot] commented on PR #9590: URL: https://github.com/apache/cloudstack/pull/9590#issuecomment-2516395350 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

Re: [PR] Create API to list Quota credits [cloudstack]

2024-08-30 Thread via GitHub
DaanHoogland commented on PR #9590: URL: https://github.com/apache/cloudstack/pull/9590#issuecomment-2320502436 ok, @winterhazel . I know you and your are the most heavy users of quota so I am not going to -1 this by any means, but my advice would be to leave it in and shout about removing

Re: [PR] Create API to list Quota credits [cloudstack]

2024-08-29 Thread via GitHub
winterhazel commented on PR #9590: URL: https://github.com/apache/cloudstack/pull/9590#issuecomment-2319699739 Hey @DaanHoogland, my idea of removing the credits listing from `quotaBalance` was to make each API have a single responsibility and make credits-related code changes easier in the

Re: [PR] Create API to list Quota credits [cloudstack]

2024-08-29 Thread via GitHub
DaanHoogland commented on PR #9590: URL: https://github.com/apache/cloudstack/pull/9590#issuecomment-2316889519 @winterhazel , I think this is good to go safe one concern; removing response data from an API response is a backwards incompatibility. I can not judge the gravity (and haven't te

Re: [PR] Create API to list Quota credits [cloudstack]

2024-08-28 Thread via GitHub
blueorangutan commented on PR #9590: URL: https://github.com/apache/cloudstack/pull/9590#issuecomment-2316346762 [SF] Trillian test result (tid-11210) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 48891 seconds Marvin logs: https://github.com/

Re: [PR] Create API to list Quota credits [cloudstack]

2024-08-28 Thread via GitHub
blueorangutan commented on PR #9590: URL: https://github.com/apache/cloudstack/pull/9590#issuecomment-2314627065 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] Create API to list Quota credits [cloudstack]

2024-08-28 Thread via GitHub
DaanHoogland commented on PR #9590: URL: https://github.com/apache/cloudstack/pull/9590#issuecomment-2314624559 @blueorangutan test keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Create API to list Quota credits [cloudstack]

2024-08-26 Thread via GitHub
blueorangutan commented on PR #9590: URL: https://github.com/apache/cloudstack/pull/9590#issuecomment-2310084149 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10810 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Create API to list Quota credits [cloudstack]

2024-08-26 Thread via GitHub
codecov[bot] commented on PR #9590: URL: https://github.com/apache/cloudstack/pull/9590#issuecomment-2309990508 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9590?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] Create API to list Quota credits [cloudstack]

2024-08-26 Thread via GitHub
blueorangutan commented on PR #9590: URL: https://github.com/apache/cloudstack/pull/9590#issuecomment-2309979345 @winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Create API to list Quota credits [cloudstack]

2024-08-26 Thread via GitHub
winterhazel commented on PR #9590: URL: https://github.com/apache/cloudstack/pull/9590#issuecomment-2309975960 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Create API to list Quota credits [cloudstack]

2024-08-26 Thread via GitHub
winterhazel opened a new pull request, #9590: URL: https://github.com/apache/cloudstack/pull/9590 ### Description When credits are added to an account, an entry that represents the operation is created in `cloud_usage.quota_credits`. Some information about these entries is currently