Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

BryanMLima commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-2163740396 @DaanHoogland, my bad, I did not see the comment at https://github.com/apache/cloudstack/pull/8878#issuecomment-2162594804, you can ignore my other comments. -- This is an

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

BryanMLima commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-2163734772 @weizhouapache, are your concerns met? @DaanHoogland, could you trigger the CI one last time? -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

gpordeus closed pull request #8689: Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow URL: https://github.com/apache/cloudstack/pull/8689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

gpordeus commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-2155234774 @DaanHoogland Fixed, thanks for letting me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

DaanHoogland commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-2154379222 not sure why the bot removed the conflict sticker, but you still have some @gpordeus -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

blueorangutan commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-2154354494 Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9817 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

blueorangutan commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-2154299872 Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9816 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

blueorangutan commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-2154297304 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

DaanHoogland commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-2154296482 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

gpordeus opened a new pull request, #8689: URL: https://github.com/apache/cloudstack/pull/8689 ### Description This PR adds a role access check to the `expungeVirtualMachine` command when calling `destroyVirtualMachine` with the expunge parameter. Currently, if you are an

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

gpordeus closed pull request #8689: Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow URL: https://github.com/apache/cloudstack/pull/8689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

github-actions[bot] commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-2100847555 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

codecov-commenter commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-2097673417 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8689?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

github-actions[bot] commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-2097671336 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

DaanHoogland commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-2071893746 @weizhouapache are all your concerns met? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

blueorangutan commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-2033366912 [SF] Trillian test result (tid-9650) Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9 Total time taken: 54702 seconds Marvin logs:

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

DaanHoogland commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-2031512207 @blueorangutan test alma9 kvm-alma9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

blueorangutan commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-2031513300 @DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

blueorangutan commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-2027330541 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9091 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

blueorangutan commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-2027242187 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

DaanHoogland commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-2027241774 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

gpordeus commented on code in PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#discussion_r1537971268 ## test/integration/smoke/test_vm_life_cycle.py: ## @@ -955,6 +956,92 @@ def test_12_start_vm_multiple_volumes_allocated(self): "Check virtual machine

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

DaanHoogland commented on code in PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#discussion_r1537274611 ## test/integration/smoke/test_vm_life_cycle.py: ## @@ -955,6 +956,92 @@ def test_12_start_vm_multiple_volumes_allocated(self): "Check virtual

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

gpordeus commented on code in PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#discussion_r1529192893 ## test/integration/smoke/test_vm_life_cycle.py: ## @@ -955,6 +956,92 @@ def test_12_start_vm_multiple_volumes_allocated(self): "Check virtual machine

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

DaanHoogland commented on code in PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#discussion_r1526511501 ## test/integration/smoke/test_vm_life_cycle.py: ## @@ -955,6 +956,92 @@ def test_12_start_vm_multiple_volumes_allocated(self): "Check virtual

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

gpordeus commented on code in PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#discussion_r1526394427 ## test/integration/smoke/test_vm_life_cycle.py: ## @@ -955,6 +956,92 @@ def test_12_start_vm_multiple_volumes_allocated(self): "Check virtual machine

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

DaanHoogland commented on code in PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#discussion_r1526376403 ## test/integration/smoke/test_vm_life_cycle.py: ## @@ -955,6 +956,92 @@ def test_12_start_vm_multiple_volumes_allocated(self): "Check virtual

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

gpordeus commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-1991871732 @DaanHoogland I've added the integration test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

blueorangutan commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-1988683682 [SF] Trillian Build Failed (tid-9434) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

blueorangutan commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-1988670933 @DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

DaanHoogland commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-1988667559 @blueorangutan test alma9 kvm-alma9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

blueorangutan commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-1983284106 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8874 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

blueorangutan commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-1983160730 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

weizhouapache commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-1983157479 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

lucas-a-martins commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-1981725455 I manually tested, lgtm. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

blueorangutan commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-1964246862 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8787 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

blueorangutan commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-1963885840 Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 8780 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

blueorangutan commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-1962057441 Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 8764 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

blueorangutan commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-1962047621 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

weizhouapache commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-1962045647 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

gpordeus commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-1961364011 > @gpordeus , this sounds like a good use case for an integration test. Will you consider that? Sure, on it. -- This is an automated message from the Apache Git Service. To

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

DaanHoogland commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-1961283712 @gpordeus , this sounds like a good use case for an integration test. Will you considder that? -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

blueorangutan commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-1961269765 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8755 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

blueorangutan commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-1960979261 Packaging result [SF]: ✔️ el7 ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 8745 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

DaanHoogland commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-1960897760 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

blueorangutan commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-1960899608 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

gpordeus commented on code in PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#discussion_r1497796941 ## server/src/main/java/com/cloud/vm/UserVmManagerImpl.java: ## @@ -3303,17 +3305,38 @@ public UserVm rebootVirtualMachine(RebootVMCmd cmd) throws

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

codecov[bot] commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-1956775149 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8689?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

weizhouapache commented on code in PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#discussion_r1497658232 ## server/src/main/java/com/cloud/vm/UserVmManagerImpl.java: ## @@ -3303,17 +3305,38 @@ public UserVm rebootVirtualMachine(RebootVMCmd cmd) throws

[PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

gpordeus opened a new pull request, #8689: URL: https://github.com/apache/cloudstack/pull/8689 ### Description This PR adds a role access check to the `expungeVirtualMachine` command when calling `destroyVirtualMachine` with the expunge parameter. Currently, if you are an