Re: [PR] Fixup: Optimize getRouterHealthChecksConfig method [cloudstack]

2024-02-21 Thread via GitHub
DaanHoogland merged PR #8677: URL: https://github.com/apache/cloudstack/pull/8677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

Re: [PR] Fixup: Optimize getRouterHealthChecksConfig method [cloudstack]

2024-02-20 Thread via GitHub
blueorangutan commented on PR #8677: URL: https://github.com/apache/cloudstack/pull/8677#issuecomment-1954668517 [SF] Trillian test result (tid-9302) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39247 seconds Marvin logs: https://github.com

Re: [PR] Fixup: Optimize getRouterHealthChecksConfig method [cloudstack]

2024-02-19 Thread via GitHub
blueorangutan commented on PR #8677: URL: https://github.com/apache/cloudstack/pull/8677#issuecomment-1953530529 @vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To resp

Re: [PR] Fixup: Optimize getRouterHealthChecksConfig method [cloudstack]

2024-02-19 Thread via GitHub
vishesh92 commented on PR #8677: URL: https://github.com/apache/cloudstack/pull/8677#issuecomment-1953528955 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Fixup: Optimize getRouterHealthChecksConfig method [cloudstack]

2024-02-19 Thread via GitHub
blueorangutan commented on PR #8677: URL: https://github.com/apache/cloudstack/pull/8677#issuecomment-1952363897 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8711 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Fixup: Optimize getRouterHealthChecksConfig method [cloudstack]

2024-02-19 Thread via GitHub
codecov[bot] commented on PR #8677: URL: https://github.com/apache/cloudstack/pull/8677#issuecomment-1952314640 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8677?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [PR] Fixup: Optimize getRouterHealthChecksConfig method [cloudstack]

2024-02-19 Thread via GitHub
blueorangutan commented on PR #8677: URL: https://github.com/apache/cloudstack/pull/8677#issuecomment-1952123406 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Fixup: Optimize getRouterHealthChecksConfig method [cloudstack]

2024-02-19 Thread via GitHub
vishesh92 commented on PR #8677: URL: https://github.com/apache/cloudstack/pull/8677#issuecomment-1952122392 @blueorangutan packge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[PR] Fixup: Optimize getRouterHealthChecksConfig method [cloudstack]

2024-02-19 Thread via GitHub
vishesh92 opened a new pull request, #8677: URL: https://github.com/apache/cloudstack/pull/8677 ### Description This PR optimizes the query in getRouterHealthChecksConfig by moving the state filter from for loop to the query itself.