Re: [PR] Refactor configuration SystemVMDefaultHypervisor [cloudstack]

2024-06-12 Thread via GitHub
weizhouapache commented on code in PR #8934: URL: https://github.com/apache/cloudstack/pull/8934#discussion_r1637060650 ## engine/components-api/src/main/java/com/cloud/resource/ResourceManager.java: ## @@ -61,6 +61,11 @@ public interface ResourceManager extends

Re: [PR] Refactor configuration SystemVMDefaultHypervisor [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8934: URL: https://github.com/apache/cloudstack/pull/8934#issuecomment-2163772637 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9908 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Refactor configuration SystemVMDefaultHypervisor [cloudstack]

2024-06-12 Thread via GitHub
codecov[bot] commented on PR #8934: URL: https://github.com/apache/cloudstack/pull/8934#issuecomment-2163662662 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8934?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] Refactor configuration SystemVMDefaultHypervisor [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8934: URL: https://github.com/apache/cloudstack/pull/8934#issuecomment-2163652888 @BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Refactor configuration SystemVMDefaultHypervisor [cloudstack]

2024-06-12 Thread via GitHub
BryanMLima commented on PR #8934: URL: https://github.com/apache/cloudstack/pull/8934#issuecomment-2163650795 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Refactor configuration SystemVMDefaultHypervisor [cloudstack]

2024-06-12 Thread via GitHub
GaOrtiga opened a new pull request, #8934: URL: https://github.com/apache/cloudstack/pull/8934 ### Description The configuration `SystemVMDefaultHypervisor` is not dynamic, it is necessary to restart the management server after each alteration to its value. Besides, its input is a

Re: [PR] Refactor configuration SystemVMDefaultHypervisor [cloudstack]

2024-06-12 Thread via GitHub
BryanMLima closed pull request #8934: Refactor configuration SystemVMDefaultHypervisor URL: https://github.com/apache/cloudstack/pull/8934 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Refactor configuration SystemVMDefaultHypervisor [cloudstack]

2024-04-20 Thread via GitHub
blueorangutan commented on PR #8934: URL: https://github.com/apache/cloudstack/pull/8934#issuecomment-2067596532 [SF] Trillian test result (tid-9929) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47242 seconds Marvin logs:

Re: [PR] Refactor configuration SystemVMDefaultHypervisor [cloudstack]

2024-04-19 Thread via GitHub
blueorangutan commented on PR #8934: URL: https://github.com/apache/cloudstack/pull/8934#issuecomment-2066499758 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] Refactor configuration SystemVMDefaultHypervisor [cloudstack]

2024-04-19 Thread via GitHub
DaanHoogland commented on PR #8934: URL: https://github.com/apache/cloudstack/pull/8934#issuecomment-2066497076 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Refactor configuration SystemVMDefaultHypervisor [cloudstack]

2024-04-19 Thread via GitHub
GaOrtiga commented on code in PR #8934: URL: https://github.com/apache/cloudstack/pull/8934#discussion_r1572296935 ## engine/components-api/src/main/java/com/cloud/resource/ResourceManager.java: ## @@ -61,6 +61,11 @@ public interface ResourceManager extends ResourceService,

Re: [PR] Refactor configuration SystemVMDefaultHypervisor [cloudstack]

2024-04-18 Thread via GitHub
blueorangutan commented on PR #8934: URL: https://github.com/apache/cloudstack/pull/8934#issuecomment-2063463470 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9306 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Refactor configuration SystemVMDefaultHypervisor [cloudstack]

2024-04-18 Thread via GitHub
blueorangutan commented on PR #8934: URL: https://github.com/apache/cloudstack/pull/8934#issuecomment-2063312144 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] Refactor configuration SystemVMDefaultHypervisor [cloudstack]

2024-04-18 Thread via GitHub
sureshanaparti commented on code in PR #8934: URL: https://github.com/apache/cloudstack/pull/8934#discussion_r1570244460 ## engine/components-api/src/main/java/com/cloud/resource/ResourceManager.java: ## @@ -61,6 +61,11 @@ public interface ResourceManager extends

Re: [PR] Refactor configuration SystemVMDefaultHypervisor [cloudstack]

2024-04-18 Thread via GitHub
sureshanaparti commented on PR #8934: URL: https://github.com/apache/cloudstack/pull/8934#issuecomment-2063308435 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Refactor configuration SystemVMDefaultHypervisor [cloudstack]

2024-04-18 Thread via GitHub
sureshanaparti commented on code in PR #8934: URL: https://github.com/apache/cloudstack/pull/8934#discussion_r1570244460 ## engine/components-api/src/main/java/com/cloud/resource/ResourceManager.java: ## @@ -61,6 +61,11 @@ public interface ResourceManager extends

[PR] refactor configuration SystemVMDefaultHypervisor [cloudstack]

2024-04-17 Thread via GitHub
GaOrtiga opened a new pull request, #8934: URL: https://github.com/apache/cloudstack/pull/8934 ### Description The configuration `SystemVMDefaultHypervisor` is not dynamic, it is necessary to restart the management server after each alteration to its value. Besides, its input is a