Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-2165732794 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9930 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-2165538746 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

sureshanaparti commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-2165535175 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-2164992200 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9915 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-2164797796 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

sureshanaparti commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-2164788919 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

sureshanaparti commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-2164771976 > @JoaoJandre can you check the changes on your remarks? @JoaoJandre pls check your remarks. thanks. -- This is an automated message from the Apache Git Service. To

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

sureshanaparti commented on code in PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#discussion_r1637678897 ## engine/userdata/src/main/java/org/apache/cloudstack/userdata/UserDataManagerImpl.java: ## @@ -90,49 +90,54 @@ public String concatenateUserData(String

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

sureshanaparti commented on code in PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#discussion_r1637677947 ## engine/userdata/src/main/java/org/apache/cloudstack/userdata/UserDataManagerImpl.java: ## @@ -90,49 +90,54 @@ public String concatenateUserData(String

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

sureshanaparti commented on code in PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#discussion_r1637677947 ## engine/userdata/src/main/java/org/apache/cloudstack/userdata/UserDataManagerImpl.java: ## @@ -90,49 +90,54 @@ public String concatenateUserData(String

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-2163375272 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9903 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

JoaoJandre commented on code in PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#discussion_r1636636454 ## engine/userdata/src/main/java/org/apache/cloudstack/userdata/UserDataManagerImpl.java: ## @@ -90,49 +90,54 @@ public String concatenateUserData(String

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-2163185942 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

sureshanaparti commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-2163181584 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

DaanHoogland commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-2162576279 @JoaoJandre can you check the changes on your remarks? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-2160704455 Packaging result [SF]: ✖️ el7 ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 9866 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-2160593293 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

sureshanaparti commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-2160591225 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-2155188936 [SF] Trillian Build Failed (tid-10392) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-2155154591 @sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service.

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

sureshanaparti commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-2155152992 @blueorangutan test keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-2154804857 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9819 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-2154700328 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

sureshanaparti commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-2154698396 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

codecov-commenter commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-2036423262 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8418?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

github-actions[bot] commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-2036417471 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1945663951 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8662 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1945568700 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

sureshanaparti commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1945560259 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1900103482 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

sureshanaparti commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1900101219 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1893855787 [SF] Trillian Build Failed (tid-8854) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1893840501 @sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service.

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

sureshanaparti commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1893839109 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1889300411 Packaging result [SF]: ✔️ el7 ✔️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 8303 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1889093621 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

sureshanaparti commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1889090095 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

sureshanaparti commented on code in PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#discussion_r1450380154 ## engine/userdata/src/main/java/org/apache/cloudstack/userdata/UserDataManagerImpl.java: ## @@ -90,49 +88,50 @@ public String concatenateUserData(String

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

JoaoJandre commented on code in PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#discussion_r1447253910 ## engine/userdata/src/main/java/org/apache/cloudstack/userdata/UserDataManagerImpl.java: ## @@ -90,49 +88,50 @@ public String concatenateUserData(String

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

sureshanaparti commented on code in PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#discussion_r1446943616 ## engine/userdata/src/main/java/org/apache/cloudstack/userdata/UserDataManagerImpl.java: ## @@ -90,49 +88,50 @@ public String concatenateUserData(String

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1877028818 @sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service.

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

sureshanaparti commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1877019500 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1876981680 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8199 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1876895785 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

sureshanaparti commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1876894054 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

sureshanaparti commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1876893306 > @sureshanaparti, along with these changes is it better to call the registerUserData API using POST from UI ? changes done -- This is an automated message from the

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

sureshanaparti commented on code in PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#discussion_r1441565124 ## engine/userdata/src/main/java/org/apache/cloudstack/userdata/UserDataManagerImpl.java: ## @@ -90,49 +90,50 @@ public String concatenateUserData(String

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1875422883 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8189 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1875306092 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

rohityadavcloud commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1875305346 @sureshanaparti can you review the outstanding comments? @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1871871814 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8164 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

DaanHoogland commented on code in PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#discussion_r1438096794 ## engine/userdata/src/main/java/org/apache/cloudstack/userdata/UserDataManagerImpl.java: ## @@ -90,49 +90,50 @@ public String concatenateUserData(String

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

codecov[bot] commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1871835961 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8418?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1871833135 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

sureshanaparti commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1871832696 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] User data content size validation with actual length only, and some code improvements [cloudstack]

sureshanaparti opened a new pull request, #8418: URL: https://github.com/apache/cloudstack/pull/8418 ### Description This PR validate user data with actual length only, and has some code improvements. Partially fixes #8415