rohityadavcloud merged PR #9191:
URL: https://github.com/apache/cloudstack/pull/9191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
DaanHoogland commented on code in PR #9191:
URL: https://github.com/apache/cloudstack/pull/9191#discussion_r1637586046
##
api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java:
##
@@ -56,7 +56,7 @@ public class CreateServiceOfferingCmd
BryanMLima commented on code in PR #9191:
URL: https://github.com/apache/cloudstack/pull/9191#discussion_r1637011378
##
api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java:
##
@@ -56,7 +56,7 @@ public class CreateServiceOfferingCmd
BryanMLima commented on code in PR #9191:
URL: https://github.com/apache/cloudstack/pull/9191#discussion_r1637011378
##
api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java:
##
@@ -56,7 +56,7 @@ public class CreateServiceOfferingCmd
BryanMLima commented on code in PR #9191:
URL: https://github.com/apache/cloudstack/pull/9191#discussion_r1637011378
##
api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java:
##
@@ -56,7 +56,7 @@ public class CreateServiceOfferingCmd
DaanHoogland commented on PR #9191:
URL: https://github.com/apache/cloudstack/pull/9191#issuecomment-2160735274
I don't think this needs a lot of testing but a second review is very
welcome, @BryanMLima !
--
This is an automated message from the Apache Git Service.
To respond to the
weizhouapache commented on code in PR #9191:
URL: https://github.com/apache/cloudstack/pull/9191#discussion_r1634379120
##
api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java:
##
@@ -56,7 +56,7 @@ public class
DaanHoogland commented on code in PR #9191:
URL: https://github.com/apache/cloudstack/pull/9191#discussion_r1634367237
##
api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java:
##
@@ -56,7 +56,7 @@ public class CreateServiceOfferingCmd
weizhouapache commented on code in PR #9191:
URL: https://github.com/apache/cloudstack/pull/9191#discussion_r1633138413
##
api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java:
##
@@ -56,7 +56,7 @@ public class
codecov[bot] commented on PR #9191:
URL: https://github.com/apache/cloudstack/pull/9191#issuecomment-2157314778
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9191?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
DaanHoogland opened a new pull request, #9191:
URL: https://github.com/apache/cloudstack/pull/9191
### Description
This PR adds to the `cpuSpeed` parameter of `CreateServiceOfferingCmd` a
description how it will be interpreted in the case cgroups are being used on
KVM.
Fixes:
11 matches
Mail list logo