Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-13 Thread via GitHub
rohityadavcloud merged PR #9177: URL: https://github.com/apache/cloudstack/pull/9177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2166868850 [SF] Trillian test result (tid-10430) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43903 seconds Marvin logs:

Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2165107857 @rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service.

Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-13 Thread via GitHub
rohityadavcloud commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2165106120 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2165072113 [SF] Trillian Build Failed (tid-10429) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2164998307 @rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service.

Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-13 Thread via GitHub
rohityadavcloud commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2164993799 Requesting re-review as code has changed a bit @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2164831630 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9914 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2164644255 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9177 (QA-JID-373) -- This is an automated message from the Apache Git Service. To respond

Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2164591956 @rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To

Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-13 Thread via GitHub
rohityadavcloud commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2164590083 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2164582100 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-13 Thread via GitHub
rohityadavcloud commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2164580635 Amusing, we're going in circles now and obstinately determined about it. I've tried my part, got non-technical and discourteous reasons to block the PR, coerced to

Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-12 Thread via GitHub
GutoVeronezi commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2163430400 @rohityadavcloud, I did not judge your change of opinion. If you read it carefully, you will see that what I am doing is pointing out that there was no consensus on the change of

Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-12 Thread via GitHub
rohityadavcloud commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2162393074 @GutoVeronezi by your own admission I changed my stand, closed my PR to support Joao's, and built support and consensus with others on Joao's PR and merge his PR. I also don't

Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-11 Thread via GitHub
GutoVeronezi commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2161243596 > @GutoVeronezi , I understand your point, but we do not have a simple usable procedure yet. The implicit procedure was "we don't introduce any backwards incompatability, ..

Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-11 Thread via GitHub
DaanHoogland commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2160625659 @GutoVeronezi , I understand your point, but we do not have a simple usable procedure yet. The implicit procedure was "we don't introduce any backwards incompatability, .. unless

Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-10 Thread via GitHub
GutoVeronezi commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2158201023 @rohityadavcloud, let me build the story line for you: - at first, you said that the default behavior should not be changed and a configuration should be introduced:

Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-10 Thread via GitHub
rohityadavcloud commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2158019038 @GutoVeronezi this isn't a vote, could you explain why you're opposing now that the default value change when we've agreed in #8782 to address this via documentation of the

Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-07 Thread via GitHub
GutoVeronezi commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2154233759 -1 on changing the `list.vm.default.details.stats` default value. Refer to the discussion in #8782. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-06 Thread via GitHub
blueorangutan commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2153440394 [SF] Trillian test result (tid-10375) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 49031 seconds Marvin logs:

Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-06 Thread via GitHub
codecov[bot] commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2151672639 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9177?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-06 Thread via GitHub
blueorangutan commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2151588735 @rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service.

Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-06 Thread via GitHub
rohityadavcloud commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2151587878 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-05 Thread via GitHub
blueorangutan commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2149968171 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9796 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-05 Thread via GitHub
blueorangutan commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2149721270 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-05 Thread via GitHub
rohityadavcloud commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2149717245 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-05 Thread via GitHub
rohityadavcloud opened a new pull request, #9177: URL: https://github.com/apache/cloudstack/pull/9177 ### Description - Changes behaviour of details param handling via global setting: - listVirtualMachines API: when the details param is not provided, it returns `all` details