DaanHoogland commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2082231182
I think I got it right and running a test compile now. if that passes , I'll
push.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
rp- commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2082221255
> @rp- , this is causing some conflicts in merge forward. Can you advise how
`tryDisconnectLinstor` should be implemented in main?
>
> I think I know but please review in main once I
DaanHoogland commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2082191504
@rp- , this is causing some conflicts in merge forward. Can you advise how
`tryDisconnectLinstor` should be implemented in main?
--
This is an automated message from the Apache
DaanHoogland merged PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cl
rp- commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2079129750
@DaanHoogland can we merge this now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
blueorangutan commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2063199476
[SF] Trillian test result (tid-9885)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 49564 seconds
Marvin logs:
https://github.com/
blueorangutan commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2061792144
@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has
been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respo
DaanHoogland commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2061788892
@blueorangutan test alma9 kvm-alma9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
blueorangutan commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2061366968
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
DaanHoogland commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2061236716
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
blueorangutan commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2061238978
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will
be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress
rp- commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2061218217
I have fixed a NPE if the device paths had been null (reported from Linstor,
because a node was down)
--
This is an automated message from the Apache Git Service.
To respond to the messa
blueorangutan commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2057916275
[SF] Trillian test result (tid-9832)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 43639 seconds
Marvin logs:
https://github.com/
blueorangutan commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2056413246
@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has
been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respo
DaanHoogland commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2056410401
@blueorangutan test alma9 kvm-alma9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
blueorangutan commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2056185207
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
blueorangutan commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2055887217
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will
be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress
DaanHoogland commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2055878785
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
github-actions[bot] commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2051756466
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
JoaoJandre commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2047553931
> @JoaoJandre I will start smoke tests on the other PR, but as @rp-
mentions, this is now far better tested and had a lot of eyes on it. I think we
should go with this one. (regress
blueorangutan commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2047051021
[LL]Trillian test result (tid-6917)
Environment: kvm-alma8 (x2), Advanced Networking with Mgmt server a8
Total time taken: 37965 seconds
Marvin logs:
https://github.com/b
DaanHoogland commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2047041669
@JoaoJandre I will start smoke tests on the other PR, but as @rp- mentions,
this is now far better tested and had a lot of eyes on it. I think we should go
with this one. (regress
slavkap commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2046814009
@NuxRo, unfortunately, I don't have the environment to test it right now
(according to the conversation it's a bit urgent to do it). From what I saw in
the code this will fix a possibl
rp- commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2046694350
But TBH, this PR is now far more tested.
As I also included this already in some builds for our customers.
And the other functional changes are Linstor only related anyway.
--
This
rp- commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2046683501
> @rp- to expedite the 4.18.2.0 process, could you create a separate PR to
fix the bug with the return value of disconnectPhysicalDiskByPath? And leave
this one only for cleaning the diskl
blueorangutan commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2046658264
[SF] Trillian test result (tid-9767)
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 40612 seconds
Marvin logs:
https://github.com
NuxRo commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2046198569
@slavkap any thoughts on this issue? It might affect Storpool, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
JoaoJandre commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2045931907
@rp- to expedite the 4.18.2.0 process, could you create a separate PR to fix
the bug with the return value of disconnectPhysicalDiskByPath? And leave this
one only for cleaning the
codecov-commenter commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2044672869
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8790?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+com
DaanHoogland closed pull request #8790: linstor: cleanup diskless nodes on
disconnect
URL: https://github.com/apache/cloudstack/pull/8790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
blueorangutan commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2044604396
[SF] Trillian Build Failed (tid-9764)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
blueorangutan commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2044544244
[SF] Trillian Build Failed (tid-9763)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
blueorangutan commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2044481779
[SF] Trillian Build Failed (tid-9762)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
blueorangutan commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2044435408
@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7)
has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To r
DaanHoogland commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2044432949
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
blueorangutan commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2044267823
[SF] Trillian Build Failed (tid-9761)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
blueorangutan commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2044228452
@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has
been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respo
DaanHoogland commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2044225859
@blueorangutan test alma9 kvm-alma9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
JoaoJandre commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2043562941
@DaanHoogland can we run the CI here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
blueorangutan commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2042948485
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
blueorangutan commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2042795851
@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
JoaoJandre commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2042790802
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
JoaoJandre commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2034415301
> > > > > > > @JoaoJandre , as @rp- describes this will prevent a bug being
introduced. Can we add it to 4.18.2?
> > > > > >
> > > > > >
> > > > > > @DaanHoogland sure, bu
DaanHoogland commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2033825891
> > > > > > @JoaoJandre , as @rp- describes this will prevent a bug being
introduced. Can we add it to 4.18.2?
> > > > >
> > > > >
> > > > > @DaanHoogland sure, but some
rp- commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2032575216
> > > > > @JoaoJandre , as @rp- describes this will prevent a bug being
introduced. Can we add it to 4.18.2?
> > > >
> > > >
> > > > @DaanHoogland sure, but some third party test
JoaoJandre commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2032476883
> > > > @JoaoJandre , as @rp- describes this will prevent a bug being
introduced. Can we add it to 4.18.2?
> > >
> > >
> > > @DaanHoogland sure, but some third party testi
DaanHoogland commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2032434515
> > > @JoaoJandre , as @rp- describes this will prevent a bug being
introduced. Can we add it to 4.18.2?
> >
> >
> > @DaanHoogland sure, but some third party testing wou
rp- commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2032040214
> > @JoaoJandre , as @rp- describes this will prevent a bug being
introduced. Can we add it to 4.18.2?
>
> @DaanHoogland sure, but some third party testing would be good.
Anyw
JoaoJandre commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2029641000
> @JoaoJandre , as @rp- describes this will prevent a bug being introduced.
Can we add it to 4.18.2?
@DaanHoogland sure, but some third party testing would be good.
--
This
DaanHoogland commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2027328768
@JoaoJandre , as @rp- describes this will prevent a bug being introduced.
Can we add it to 4.18.2?
--
This is an automated message from the Apache Git Service.
To respond to the
rp- commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2023166476
@DaanHoogland
Is this planned for 4.18.2.0?
As described, if not, this will introduce a bug with
`disconnectPhysicalDiskByPath` for other storage providers
--
This is an automated
sureshanaparti commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2018014666
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
rp- commented on code in PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#discussion_r1537437204
##
plugins/storage/volume/linstor/src/main/java/com/cloud/hypervisor/kvm/storage/LinstorStorageAdaptor.java:
##
@@ -302,26 +308,89 @@ public boolean connectPhysicalDisk(
DaanHoogland commented on code in PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#discussion_r1537322738
##
plugins/storage/volume/linstor/src/main/java/com/cloud/hypervisor/kvm/storage/LinstorStorageAdaptor.java:
##
@@ -302,26 +308,89 @@ public boolean connectPhys
rp- commented on code in PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#discussion_r1532014623
##
plugins/storage/volume/linstor/src/main/java/com/cloud/hypervisor/kvm/storage/LinstorStorageAdaptor.java:
##
@@ -302,26 +308,89 @@ public boolean connectPhysicalDisk(
sureshanaparti commented on code in PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#discussion_r1528761276
##
plugins/storage/volume/linstor/src/main/java/com/cloud/hypervisor/kvm/storage/LinstorStorageAdaptor.java:
##
@@ -302,26 +308,89 @@ public boolean connectPh
rp- commented on code in PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#discussion_r1527581742
##
plugins/storage/volume/linstor/src/main/java/com/cloud/hypervisor/kvm/storage/LinstorStorageAdaptor.java:
##
@@ -302,26 +308,89 @@ public boolean connectPhysicalDisk(
codecov[bot] commented on PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-159573
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8790?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments
DaanHoogland commented on code in PR #8790:
URL: https://github.com/apache/cloudstack/pull/8790#discussion_r1526436053
##
plugins/storage/volume/linstor/src/main/java/com/cloud/hypervisor/kvm/storage/LinstorStorageAdaptor.java:
##
@@ -302,26 +308,89 @@ public boolean connectPhys
rp- opened a new pull request, #8790:
URL: https://github.com/apache/cloudstack/pull/8790
### Description
If disconnect is running on a diskless node, try to cleanup the resource.
Also fix a bug with the return value of disconnectPhysicalDiskByPath that
was introduced with 56f0
60 matches
Mail list logo
