sureshanaparti commented on PR #9138:
URL: https://github.com/apache/cloudstack/pull/9138#issuecomment-2165160083
> Hmm you can check the basic ui stuff, if you don't have Linstor, you will
just not be able to create the primary storage.
> But the Linstor UI options should be in the "Crea
sureshanaparti merged PR #9138:
URL: https://github.com/apache/cloudstack/pull/9138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@
blueorangutan commented on PR #9138:
URL: https://github.com/apache/cloudstack/pull/9138#issuecomment-2164921848
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9138 (QA-JID-376)
--
This is an automated message from the Apache Git Service.
To respond t
blueorangutan commented on PR #9138:
URL: https://github.com/apache/cloudstack/pull/9138#issuecomment-2164874059
@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep
you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respo
sureshanaparti commented on PR #9138:
URL: https://github.com/apache/cloudstack/pull/9138#issuecomment-2164872836
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
blueorangutan commented on PR #9138:
URL: https://github.com/apache/cloudstack/pull/9138#issuecomment-2164640479
@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep
you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respo
sureshanaparti commented on PR #9138:
URL: https://github.com/apache/cloudstack/pull/9138#issuecomment-2164638778
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
rp- commented on code in PR #9138:
URL: https://github.com/apache/cloudstack/pull/9138#discussion_r1637598369
##
ui/src/views/infra/AddPrimaryStorage.vue:
##
@@ -162,7 +162,7 @@
+(form.protocol === 'PreSetup' && hypervisorType === 'VMware') ||
fo
rp- commented on PR #9138:
URL: https://github.com/apache/cloudstack/pull/9138#issuecomment-2164499737
> > @sureshanaparti , do you dare to merge?
>
> Hi @rp- Code looks good, but I'm not able to check UI with Linstor plugin,
possible to share any screenshot showing resource group fie
sureshanaparti commented on PR #9138:
URL: https://github.com/apache/cloudstack/pull/9138#issuecomment-2163092802
> @sureshanaparti , do you dare to merge?
Hi @rp- Code looks good, but I'm not able to check UI with Linstor plugin,
possible to share any screenshot showing resource grou
sureshanaparti commented on code in PR #9138:
URL: https://github.com/apache/cloudstack/pull/9138#discussion_r1636510486
##
ui/src/views/infra/AddPrimaryStorage.vue:
##
@@ -162,7 +162,7 @@
+(form.protocol === 'PreSetup' && hypervisorType === 'VMwa
DaanHoogland commented on PR #9138:
URL: https://github.com/apache/cloudstack/pull/9138#issuecomment-2149354254
@sureshanaparti , do you dare to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
blueorangutan commented on PR #9138:
URL: https://github.com/apache/cloudstack/pull/9138#issuecomment-2149164210
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9138 (QA-JID-367)
--
This is an automated message from the Apache Git Service.
To respond t
blueorangutan commented on PR #9138:
URL: https://github.com/apache/cloudstack/pull/9138#issuecomment-2149131289
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep
you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond
DaanHoogland commented on PR #9138:
URL: https://github.com/apache/cloudstack/pull/9138#issuecomment-2149129551
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
rp- commented on code in PR #9138:
URL: https://github.com/apache/cloudstack/pull/9138#discussion_r1627130337
##
ui/src/views/infra/AddPrimaryStorage.vue:
##
@@ -870,6 +864,16 @@ export default {
params['details[0].api_password'] = values.flashArrayPassword
DaanHoogland commented on code in PR #9138:
URL: https://github.com/apache/cloudstack/pull/9138#discussion_r1623942555
##
ui/src/views/infra/AddPrimaryStorage.vue:
##
@@ -870,6 +864,16 @@ export default {
params['details[0].api_password'] = values.flashArrayPassword
codecov[bot] commented on PR #9138:
URL: https://github.com/apache/cloudstack/pull/9138#issuecomment-2136794396
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9138?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments
rp- opened a new pull request, #9138:
URL: https://github.com/apache/cloudstack/pull/9138
### Description
Fixes Linstor related fields not showing in add primary storage, while using
custom protocol.
Fixes: #8550
### Types of changes
- [ ] Breakin
19 matches
Mail list logo
