Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2165905723 [SF] Trillian Build Failed (tid-10435) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]

2024-06-13 Thread via GitHub
weizhouapache commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2165812577 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2165816766 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2165618633 [SF] Trillian test result (tid-10424) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 65335 seconds Marvin logs:

Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2163636740 @shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]

2024-06-12 Thread via GitHub
shwstppr commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2163635744 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2157924675 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9839 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]

2024-06-10 Thread via GitHub
weizhouapache commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2157768742 > @weizhouapache added tests Currently only used in KVM VM definitions. I couldn't find any reference in other hypervisor plugins thanks code lgtm -- This is an

Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2157762172 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]

2024-06-10 Thread via GitHub
shwstppr commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2157760876 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]

2024-06-10 Thread via GitHub
shwstppr commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2157742504 @weizhouapache added tests Currently only used in KVM VM definitions. I couldn't find any reference in other hypervisor plugins -- This is an automated message from the Apache

Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]

2024-06-10 Thread via GitHub
weizhouapache commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2157581319 > @rohityadavcloud marked it ready > > A note about cloud-init behaviour is added in the global config descriptions and in the doc PR thanks @shwstppr

Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]

2024-06-10 Thread via GitHub
shwstppr commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2157568535 @rohityadavcloud marked it ready A note about cloud-init behaviour is added in the global config descriptions and in the doc PR -- This is an automated message from the

Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2157557647 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9833 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2157404760 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]

2024-06-10 Thread via GitHub
rohityadavcloud commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2157402665 @shwstppr is this ready for review or still need some work (as the PR is in draft) @blueorangutan package -- This is an automated message from the Apache Git Service.

Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]

2024-06-10 Thread via GitHub
rohityadavcloud closed pull request #9163: orchestration,hypervisor: allow custom manufacturer, product for vm metadata URL: https://github.com/apache/cloudstack/pull/9163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]

2024-06-05 Thread via GitHub
blueorangutan commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2149968165 Packaging result [SF]: ✖️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9795 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]

2024-06-05 Thread via GitHub
blueorangutan commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2149703435 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]

2024-06-05 Thread via GitHub
shwstppr commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2149702799 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]

2024-06-05 Thread via GitHub
shwstppr commented on code in PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#discussion_r1627660626 ## engine/api/src/main/java/com/cloud/vm/VirtualMachineManager.java: ## @@ -87,6 +87,20 @@ public interface VirtualMachineManager extends Manager { ConfigKey