Re: [PR] Add password enabled during ISO register and update [cloudstack]

2024-05-02 Thread via GitHub
DaanHoogland merged PR #8992: URL: https://github.com/apache/cloudstack/pull/8992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add password enabled during ISO register and update [cloudstack]

2024-05-02 Thread via GitHub
DaanHoogland commented on PR #8992: URL: https://github.com/apache/cloudstack/pull/8992#issuecomment-2089811127 tested ok, updating a ISO and leaving the view to return shows the right value which means the backend stored it. -- This is an automated message from the Apache Git Service.

Re: [PR] Add password enabled during ISO register and update [cloudstack]

2024-05-01 Thread via GitHub
blueorangutan commented on PR #8992: URL: https://github.com/apache/cloudstack/pull/8992#issuecomment-203891 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8992 (QA-JID-332) -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Add password enabled during ISO register and update [cloudstack]

2024-05-01 Thread via GitHub
blueorangutan commented on PR #8992: URL: https://github.com/apache/cloudstack/pull/8992#issuecomment-2088863605 @DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To

Re: [PR] Add password enabled during ISO register and update [cloudstack]

2024-05-01 Thread via GitHub
DaanHoogland commented on PR #8992: URL: https://github.com/apache/cloudstack/pull/8992#issuecomment-2088862693 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Add password enabled during ISO register and update [cloudstack]

2024-05-01 Thread via GitHub
GaOrtiga commented on PR #8992: URL: https://github.com/apache/cloudstack/pull/8992#issuecomment-2088822092 @DaanHoogland I have commited the requested changes ![image](https://github.com/apache/cloudstack/assets/49285692/134495d2-d2e7-4870-a3fe-41bbbf9bc915) -- This is an

Re: [PR] Add password enabled during ISO register and update [cloudstack]

2024-04-30 Thread via GitHub
GaOrtiga commented on PR #8992: URL: https://github.com/apache/cloudstack/pull/8992#issuecomment-2086236981 > @GaOrtiga , should the flag also be added to the UI/output? (or do we create an issue and merge as is?) @DaanHoogland Good catch, thanks. Since this is a simple addition, I

Re: [PR] Add password enabled during ISO register and update [cloudstack]

2024-04-30 Thread via GitHub
DaanHoogland commented on PR #8992: URL: https://github.com/apache/cloudstack/pull/8992#issuecomment-2084768623 @GaOrtiga , should the flag also be added to the UI/output? (or do we create an issue and merge as is?) -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Add password enabled during ISO register and update [cloudstack]

2024-04-29 Thread via GitHub
blueorangutan commented on PR #8992: URL: https://github.com/apache/cloudstack/pull/8992#issuecomment-2082070497 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8992 (QA-JID-326) -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Add password enabled during ISO register and update [cloudstack]

2024-04-29 Thread via GitHub
blueorangutan commented on PR #8992: URL: https://github.com/apache/cloudstack/pull/8992#issuecomment-2082048232 @DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To

Re: [PR] Add password enabled during ISO register and update [cloudstack]

2024-04-29 Thread via GitHub
DaanHoogland commented on PR #8992: URL: https://github.com/apache/cloudstack/pull/8992#issuecomment-2082046350 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Add password enabled during ISO register and update [cloudstack]

2024-04-26 Thread via GitHub
codecov-commenter commented on PR #8992: URL: https://github.com/apache/cloudstack/pull/8992#issuecomment-2079732337 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8992?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)

[PR] add password enabled during ISO register and update [cloudstack]

2024-04-26 Thread via GitHub
GaOrtiga opened a new pull request, #8992: URL: https://github.com/apache/cloudstack/pull/8992 ### Description The parameter `passwordenabled` is available on the APIs that register and update ISOs, however, it had not been added to the UI yet. This parameter was added to the