This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-email.git

commit 1e20524893a29e1500ff4b04c4cc45bcb2caa1d5
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sat Dec 16 14:38:24 2023 -0500

    Better parameter name
---
 src/main/java/org/apache/commons/mail/MultiPartEmail.java | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/main/java/org/apache/commons/mail/MultiPartEmail.java 
b/src/main/java/org/apache/commons/mail/MultiPartEmail.java
index 540b6c0..a9a69df 100644
--- a/src/main/java/org/apache/commons/mail/MultiPartEmail.java
+++ b/src/main/java/org/apache/commons/mail/MultiPartEmail.java
@@ -149,7 +149,7 @@ public class MultiPartEmail extends Email {
     /**
      * Attaches a file specified as a DataSource interface.
      *
-     * @param ds          A DataSource interface for the file.
+     * @param dataSource  A DataSource interface for the file.
      * @param name        The name field for the attachment.
      * @param description A description for the attachment.
      * @param disposition Either mixed or inline.
@@ -157,16 +157,16 @@ public class MultiPartEmail extends Email {
      * @throws EmailException see javax.mail.internet.MimeBodyPart for 
definitions
      * @since 1.0
      */
-    public MultiPartEmail attach(final DataSource ds, String name, final 
String description, final String disposition) throws EmailException {
+    public MultiPartEmail attach(final DataSource dataSource, String name, 
final String description, final String disposition) throws EmailException {
         if (EmailUtils.isEmpty(name)) {
-            name = ds.getName();
+            name = dataSource.getName();
         }
         try {
             final BodyPart bodyPart = createBodyPart();
             bodyPart.setDisposition(disposition);
             bodyPart.setFileName(MimeUtility.encodeText(name));
             bodyPart.setDescription(description);
-            bodyPart.setDataHandler(new DataHandler(ds));
+            bodyPart.setDataHandler(new DataHandler(dataSource));
             getContainer().addBodyPart(bodyPart);
         } catch (final UnsupportedEncodingException | MessagingException me) {
             // in case the file name could not be encoded

Reply via email to