Repository: commons-rng Updated Branches: refs/heads/master 6b84fea81 -> e6e9cf4db
Replace FindBugs with SpotBugs As per the discussion in [1], FindBugs has been discontinued, and SpotBugs has taken its place. This patch updates the Commons RNG project to use SpotBugs accordingly. [1] http://mail-archives.apache.org/mod_mbox/commons-dev/201802.mbox/raw/%3C4131eded52b31d3c9114fa5cbae48c4a%40scarlet.be%3E/ spotbgus Project: http://git-wip-us.apache.org/repos/asf/commons-rng/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-rng/commit/52ab4ee9 Tree: http://git-wip-us.apache.org/repos/asf/commons-rng/tree/52ab4ee9 Diff: http://git-wip-us.apache.org/repos/asf/commons-rng/diff/52ab4ee9 Branch: refs/heads/master Commit: 52ab4ee9c83ed1c4b8f181cfe3fcb002402b7342 Parents: 6b84fea Author: Allon Mureinik <amure...@redhat.com> Authored: Fri Feb 16 20:34:56 2018 +0200 Committer: Allon Mureinik <amure...@redhat.com> Committed: Fri Feb 16 20:54:16 2018 +0200 ---------------------------------------------------------------------- .travis.yml | 2 +- pom.xml | 14 ++++----- .../findbugs/findbugs-exclude-filter.xml | 28 ------------------ .../spotbugs/spotbugs-exclude-filter.xml | 31 ++++++++++++++++++++ 4 files changed, 39 insertions(+), 36 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-rng/blob/52ab4ee9/.travis.yml ---------------------------------------------------------------------- diff --git a/.travis.yml b/.travis.yml index 1fe22f5..a7ec732 100644 --- a/.travis.yml +++ b/.travis.yml @@ -22,4 +22,4 @@ jdk: - oraclejdk9 after_success: - - mvn clean test pmd:pmd findbugs:findbugs checkstyle:checkstyle jacoco:report coveralls:report + - mvn clean test pmd:pmd spotbugs:spotbugs checkstyle:checkstyle jacoco:report coveralls:report http://git-wip-us.apache.org/repos/asf/commons-rng/blob/52ab4ee9/pom.xml ---------------------------------------------------------------------- diff --git a/pom.xml b/pom.xml index 840c6bb..547ebd5 100644 --- a/pom.xml +++ b/pom.xml @@ -100,7 +100,7 @@ <maven.compiler.source>1.6</maven.compiler.source> <maven.compiler.target>1.6</maven.compiler.target> <rng.pmd.version>3.9.0</rng.pmd.version> - <rng.findbugs.version>3.0.5</rng.findbugs.version> + <rng.spotbugs.version>3.1.1</rng.spotbugs.version> <rng.checkstyle.version>3.0.0</rng.checkstyle.version> <rng.clirr.version>2.8</rng.clirr.version> <rng.mathjax.version>2.7.2</rng.mathjax.version> @@ -214,9 +214,9 @@ </executions> </plugin> <plugin> - <groupId>org.codehaus.mojo</groupId> - <artifactId>findbugs-maven-plugin</artifactId> - <version>${rng.findbugs.version}</version> + <groupId>com.github.spotbugs</groupId> + <artifactId>spotbugs-maven-plugin</artifactId> + <version>${rng.spotbugs.version}</version> </plugin> <plugin> <groupId>org.apache.rat</groupId> @@ -319,12 +319,12 @@ </plugin> <plugin> <groupId>org.codehaus.mojo</groupId> - <artifactId>findbugs-maven-plugin</artifactId> - <version>${rng.findbugs.version}</version> + <artifactId>spotbugs-maven-plugin</artifactId> + <version>${rng.spotbugs.version}</version> <configuration> <threshold>Normal</threshold> <effort>Default</effort> - <excludeFilterFile>${rng.parent.dir}/src/main/resources/findbugs/findbugs-exclude-filter.xml</excludeFilterFile> + <excludeFilterFile>${rng.parent.dir}/src/main/resources/spotbugs/spotbugs-exclude-filter.xml</excludeFilterFile> </configuration> </plugin> <plugin> http://git-wip-us.apache.org/repos/asf/commons-rng/blob/52ab4ee9/src/main/resources/findbugs/findbugs-exclude-filter.xml ---------------------------------------------------------------------- diff --git a/src/main/resources/findbugs/findbugs-exclude-filter.xml b/src/main/resources/findbugs/findbugs-exclude-filter.xml deleted file mode 100644 index 8a9c858..0000000 --- a/src/main/resources/findbugs/findbugs-exclude-filter.xml +++ /dev/null @@ -1,28 +0,0 @@ -<?xml version="1.0"?> -<!-- - Licensed to the Apache Software Foundation (ASF) under one or more - contributor license agreements. See the NOTICE file distributed with - this work for additional information regarding copyright ownership. - The ASF licenses this file to You under the Apache License, Version 2.0 - (the "License"); you may not use this file except in compliance with - the License. You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - - Unless required by applicable law or agreed to in writing, software - distributed under the License is distributed on an "AS IS" BASIS, - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - See the License for the specific language governing permissions and - limitations under the License. ---> - -<!-- - This file contains some false positive bugs detected by findbugs. Their - false positive nature has been analyzed individually and they have been - put here to instruct findbugs it must ignore them. ---> -<FindBugsFilter> - - <Class name="~.*\.jmh\.generated\..*" /> - -</FindBugsFilter> http://git-wip-us.apache.org/repos/asf/commons-rng/blob/52ab4ee9/src/main/resources/spotbugs/spotbugs-exclude-filter.xml ---------------------------------------------------------------------- diff --git a/src/main/resources/spotbugs/spotbugs-exclude-filter.xml b/src/main/resources/spotbugs/spotbugs-exclude-filter.xml new file mode 100644 index 0000000..9993593 --- /dev/null +++ b/src/main/resources/spotbugs/spotbugs-exclude-filter.xml @@ -0,0 +1,31 @@ +<?xml version="1.0"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> + +<!-- + This file contains some false positive bugs detected by spotbugs. Their + false positive nature has been analyzed individually and they have been + put here to instruct spotbugs it must ignore them. +--> +<FindBugsFilter + xmlns="https://github.com/spotbugs/filter/3.1.0" + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" + xsi:schemaLocation="https://github.com/spotbugs/filter/3.1.0 https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd"> + + <Class name="~.*\.jmh\.generated\..*" /> + +</FindBugsFilter>