This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-crypto.git
commit 7ac44567ed446bf8eb5175f2454d2907f53fac0d Author: Gary Gregory <garydgreg...@gmail.com> AuthorDate: Sun Dec 11 19:40:58 2022 -0500 Address TODOs in package private class --- .../org/apache/commons/crypto/jna/OpenSslNativeJna.java | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/src/main/java/org/apache/commons/crypto/jna/OpenSslNativeJna.java b/src/main/java/org/apache/commons/crypto/jna/OpenSslNativeJna.java index 57929d8..f5ab128 100644 --- a/src/main/java/org/apache/commons/crypto/jna/OpenSslNativeJna.java +++ b/src/main/java/org/apache/commons/crypto/jna/OpenSslNativeJna.java @@ -87,14 +87,12 @@ class OpenSslNativeJna { return JnaImplementation._ENGINE_by_id(string); } - // TODO: native method returns int - public static void ENGINE_finish(final PointerByReference rdrandEngine) { - JnaImplementation._ENGINE_finish(rdrandEngine); + public static int ENGINE_finish(final PointerByReference rdrandEngine) { + return JnaImplementation._ENGINE_finish(rdrandEngine); } - // TODO: native method returns int - public static void ENGINE_free(final PointerByReference rdrandEngine) { - JnaImplementation._ENGINE_free(rdrandEngine); + public static int ENGINE_free(final PointerByReference rdrandEngine) { + return JnaImplementation._ENGINE_free(rdrandEngine); } public static int ENGINE_init(final PointerByReference rdrandEngine) { @@ -105,8 +103,7 @@ class OpenSslNativeJna { return JnaImplementation._ENGINE_set_default(rdrandEngine, eNGINE_METHOD_RAND); } - // TODO: native method expects char[] buffer - public static String ERR_error_string(final NativeLong err, final Object object) { + public static String ERR_error_string(final NativeLong err, final char[] object) { return JnaImplementation._ERR_error_string(err, null); }