This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbutils.git
commit ef8881ff80c9558ea499a3d4b2f5ed06b87401f9
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Mon Oct 9 09:20:26 2023 -0400
Allow Checkstyle to fail a build
---
pom.xml | 1 -
src/conf/checkstyle/checkstyle-suppressions.xml | 5 ++++-
src/conf/checkstyle/checkstyle.xml | 1 -
3 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/pom.xml b/pom.xml
index 59f870b..5de9fcd 100644
--- a/pom.xml
+++ b/pom.xml
@@ -283,7 +283,6 @@
<headerLocation>${checkstyle.header.file}</headerLocation>
<suppressionsLocation>${basedir}/src/conf/checkstyle/checkstyle-suppressions.xml</suppressionsLocation>
<suppressionsFileExpression>${basedir}/src/conf/checkstyle/checkstyle-suppressions.xml</suppressionsFileExpression>
- <failOnViolation>false</failOnViolation>
</configuration>
</plugin>
<plugin>
diff --git a/src/conf/checkstyle/checkstyle-suppressions.xml
b/src/conf/checkstyle/checkstyle-suppressions.xml
index 635ac17..9169a32 100644
--- a/src/conf/checkstyle/checkstyle-suppressions.xml
+++ b/src/conf/checkstyle/checkstyle-suppressions.xml
@@ -19,7 +19,8 @@
<suppressions>
<suppress checks="Header" files="NOTICE.txt" />
<suppress checks="Header" files="LICENSE.txt" />
- <suppress checks="Header" files="target/.*" />
+ <suppress checks="Header"
files="target[/\\]classes[/\\]META-INF[/\\]maven[/\\]commons-dbutils[/\\]commons-dbutils[/\\]pom.properties"
/>
+ <suppress checks="Header"
files="target[/\\]maven-archiver[/\\]pom.properties" />
<suppress checks="Header" files=".*[/\\]TestQueries.properties" />
<suppress checks="HideUtilityClassConstructor" files="DbUtils.java" />
<suppress checks="Javadoc" files=".*[/\\]test[/\\].*" />
@@ -28,4 +29,6 @@
<suppress checks="LineLength" files="QueryRunner.java" />
<suppress checks="MagicNumber" files=".*[/\\]test[/\\].*" />
<suppress checks="MethodName" files=".*[/\\]test[/\\].*" />
+ <suppress checks="VisibilityModifier" files="AbstractQueryRunner"
lines="54"/>
+ <suppress checks="VisibilityModifier" files="KeyedHandler" lines="58, 63,
69"/>
</suppressions>
\ No newline at end of file
diff --git a/src/conf/checkstyle/checkstyle.xml
b/src/conf/checkstyle/checkstyle.xml
index bad8bb3..3003ffd 100644
--- a/src/conf/checkstyle/checkstyle.xml
+++ b/src/conf/checkstyle/checkstyle.xml
@@ -121,7 +121,6 @@
<!-- Checks for whitespace -->
<!-- See http://checkstyle.sf.net/config_whitespace.html -->
<module name="EmptyForIteratorPad" />
- <module name="NoWhitespaceAfter" />
<module name="NoWhitespaceBefore" />
<!-- module name="OperatorWrap"/ -->
<module name="WhitespaceAfter">
