Author: sebb
Date: Fri Mar 11 15:45:56 2011
New Revision: 1080620

URL: http://svn.apache.org/viewvc?rev=1080620&view=rev
Log:
Findbugs: cannot compare byte with int=255

Modified:
    
commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/Telnet.java

Modified: 
commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/Telnet.java
URL: 
http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/Telnet.java?rev=1080620&r1=1080619&r2=1080620&view=diff
==============================================================================
--- 
commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/Telnet.java
 (original)
+++ 
commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/Telnet.java
 Fri Mar 11 15:45:56 2011
@@ -794,7 +794,7 @@ class Telnet extends SocketClient
             for (int ii = 0; ii < subn.length; ii++)
             {
                 byte b = (byte) subn[ii];
-                if (b == TelnetCommand.IAC) {
+                if (b == (byte) TelnetCommand.IAC) { // cast is necessary 
because IAC is outside the signed byte range
                     _output_.write(b); // double any IAC bytes
                 }
                 _output_.write(b);


Reply via email to