Author: ggregory Date: Sun Sep 29 18:06:03 2013 New Revision: 1527373 URL: http://svn.apache.org/r1527373 Log: Eat own dog food: use StringUtils.isEmpty().
Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/text/StrSubstitutor.java Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java?rev=1527373&r1=1527372&r2=1527373&view=diff ============================================================================== --- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java (original) +++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java Sun Sep 29 18:06:03 2013 @@ -5737,7 +5737,7 @@ public class StringUtils { * @since 3.0 Changed "" to return false and not true */ public static boolean isAlpha(final CharSequence cs) { - if (cs == null || cs.length() == 0) { + if (isEmpty(cs)) { return false; } final int sz = cs.length(); @@ -5807,7 +5807,7 @@ public class StringUtils { * @since 3.0 Changed "" to return false and not true */ public static boolean isAlphanumeric(final CharSequence cs) { - if (cs == null || cs.length() == 0) { + if (isEmpty(cs)) { return false; } final int sz = cs.length(); @@ -5924,7 +5924,7 @@ public class StringUtils { * @since 3.0 Changed "" to return false and not true */ public static boolean isNumeric(final CharSequence cs) { - if (cs == null || cs.length() == 0) { + if (isEmpty(cs)) { return false; } final int sz = cs.length(); Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/text/StrSubstitutor.java URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/text/StrSubstitutor.java?rev=1527373&r1=1527372&r2=1527373&view=diff ============================================================================== --- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/text/StrSubstitutor.java (original) +++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/text/StrSubstitutor.java Sun Sep 29 18:06:03 2013 @@ -23,6 +23,8 @@ import java.util.List; import java.util.Map; import java.util.Properties; +import org.apache.commons.lang3.StringUtils; + /** * Substitutes variables within a string by values. * <p> @@ -1126,7 +1128,7 @@ public class StrSubstitutor { * @return this, to enable chaining */ public StrSubstitutor setValueDelimiter(final String valueDelimiter) { - if (valueDelimiter == null || valueDelimiter.length() == 0) { + if (StringUtils.isEmpty(valueDelimiter)) { setValueDelimiterMatcher(null); return this; }