(commons-crypto) branch master updated: Document behaviour [skip ci]

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-crypto.git


The following commit(s) were added to refs/heads/master by this push:
     new d134bcf8 Document behaviour [skip ci]
d134bcf8 is described below

commit d134bcf8b1609f84eab272b2f1f00530bb0fcd3d
Author: Sebb <s...@apache.org>
AuthorDate: Sat Dec 2 00:58:00 2023 +0000

    Document behaviour [skip ci]
---
 .../java/org/apache/commons/crypto/cipher/CryptoCipherFactory.java   | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git 
a/src/main/java/org/apache/commons/crypto/cipher/CryptoCipherFactory.java 
b/src/main/java/org/apache/commons/crypto/cipher/CryptoCipherFactory.java
index a0de8250..c2afe12b 100644
--- a/src/main/java/org/apache/commons/crypto/cipher/CryptoCipherFactory.java
+++ b/src/main/java/org/apache/commons/crypto/cipher/CryptoCipherFactory.java
@@ -147,11 +147,12 @@ public class CryptoCipherFactory {
      *
      * @param props The {@code Properties} class represents a set of
      *        properties.
-     * @return the cipher class based on the props.
+     * @return the cipher class based on the property {@link 
CryptoCipherFactory.CLASSES_KEY}
+     * If the property is missing or empty, {@link CLASSES_DEFAULT} is returned
      */
     private static String getCipherClassString(final Properties props) {
         String cipherClassString = 
props.getProperty(CryptoCipherFactory.CLASSES_KEY, CLASSES_DEFAULT);
-        if (cipherClassString.isEmpty()) { // TODO does it make sense to treat 
the empty string as the default?
+        if (cipherClassString.isEmpty()) {
             cipherClassString = CLASSES_DEFAULT;
         }
         return cipherClassString;