(commons-imaging) 03/03: Use final and blocks

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-imaging.git

commit c1fbb3eba9f32af19c73d110eb02aa01a6f21e23
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sun Apr 14 16:26:47 2024 -0400

    Use final and blocks
---
 .../formats/jpeg/exif/ExifRewriterRoundtripTest.java        | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git 
a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/ExifRewriterRoundtripTest.java
 
b/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/ExifRewriterRoundtripTest.java
index c6a8dd27..85644bbc 100644
--- 
a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/ExifRewriterRoundtripTest.java
+++ 
b/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/ExifRewriterRoundtripTest.java
@@ -90,11 +90,13 @@ public class ExifRewriterRoundtripTest extends 
AbstractExifTest {
                 final List<Integer> sourceTags = new ArrayList<>();
                 final List<Integer> duplicatedTags = new ArrayList<>();
 
-                for (TiffOutputField field : sourceFields)
+                for (final TiffOutputField field : sourceFields) {
                     sourceTags.add(field.tag);
+                }
 
-                for (TiffOutputField field : duplicateFields)
+                for (final TiffOutputField field : duplicateFields) {
                     duplicatedTags.add(field.tag);
+                }
 
                 final List<Integer> missingTags = new ArrayList<>(sourceTags);
                 missingTags.removeAll(duplicatedTags);
@@ -106,7 +108,7 @@ public class ExifRewriterRoundtripTest extends 
AbstractExifTest {
                 assertTrue(missingTags.isEmpty(), "Missing tags: " + 
missingTags);
             }
 
-            for (TiffOutputField sourceField : sourceFields) {
+            for (final TiffOutputField sourceField : sourceFields) {
                 final boolean isOffsetField =
                         sourceField.tag == 
ExifTagConstants.EXIF_TAG_EXIF_OFFSET.tag ||
                                 sourceField.tag == 
ExifTagConstants.EXIF_TAG_GPSINFO.tag ||
@@ -117,10 +119,11 @@ public class ExifRewriterRoundtripTest extends 
AbstractExifTest {
                  * Ignore offset fields. They may not be needed after rewrite
                  * and their value changes anyway.
                  */
-                if (isOffsetField)
+                if (isOffsetField) {
                     continue;
+                }
 
-                TiffOutputField duplicateField = 
duplicateDirectory.findField(sourceField.tag);
+                final TiffOutputField duplicateField = 
duplicateDirectory.findField(sourceField.tag);
 
                 assertNotNull(duplicateField, "Field is missing: " + 
sourceField.tagInfo);