[GitHub] jay-b commented on issue #87: CB-13311: (iOS) Statusbar does not overlay correctly on iPhone X

jay-b commented on issue #87: CB-13311: (iOS) Statusbar does not overlay correctly on iPhone X URL: https://github.com/apache/cordova-plugin-statusbar/pull/87#issuecomment-344783469 Hi folks. In my Ionic v1 app, I've installed this PR, have `viewport-fit=cover` in my www/index.html,

[GitHub] jay-b commented on issue #87: CB-13311: (iOS) Statusbar does not overlay correctly on iPhone X

jay-b commented on issue #87: CB-13311: (iOS) Statusbar does not overlay correctly on iPhone X URL: https://github.com/apache/cordova-plugin-statusbar/pull/87#issuecomment-344783469 Hi folks. In my Ionic v1 app, I've installed this PR, have `viewport-fit=cover` in my www/index.html,

[GitHub] codecov-io commented on issue #417: CB-13580: (android) fix build for multiple apks (different product flavors)

codecov-io commented on issue #417: CB-13580: (android) fix build for multiple apks (different product flavors) URL: https://github.com/apache/cordova-android/pull/417#issuecomment-344782111 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/417?src=pr=h1) Report > Merging

[GitHub] DavidStrausz commented on issue #417: CB-13580: (android) fix build for multiple apks (different product flavors)

DavidStrausz commented on issue #417: CB-13580: (android) fix build for multiple apks (different product flavors) URL: https://github.com/apache/cordova-android/pull/417#issuecomment-344781050 @infil00p Done! ? Yeah it also took me some time to figure it out. But the migration guide was

[GitHub] infil00p commented on issue #417: CB-13580: (android) fix build for multiple apks (different product flavors)

infil00p commented on issue #417: CB-13580: (android) fix build for multiple apks (different product flavors) URL: https://github.com/apache/cordova-android/pull/417#issuecomment-344778138 @DavidStrausz Fix the lint errors and I'll merge this in. I tried adding more flavours and it kept

[GitHub] infil00p commented on issue #417: CB-13580: (android) fix build for multiple apks (different product flavors)

infil00p commented on issue #417: CB-13580: (android) fix build for multiple apks (different product flavors) URL: https://github.com/apache/cordova-android/pull/417#issuecomment-344778138 @DavidStrausz Fix the lint errors and I'll merge this in. I tried adding more flavours and it kept

[GitHub] infil00p commented on issue #417: CB-13580: (android) fix build for multiple apks (different product flavors)

infil00p commented on issue #417: CB-13580: (android) fix build for multiple apks (different product flavors) URL: https://github.com/apache/cordova-android/pull/417#issuecomment-344778138 @DavidStrausz Fix the lint errors and I'll merge this in. I tried adding more flavours and it kept

[GitHub] DavidStrausz opened a new pull request #417: CB-13580: (android) fix build for multiple apks (different product flavors)

DavidStrausz opened a new pull request #417: CB-13580: (android) fix build for multiple apks (different product flavors) URL: https://github.com/apache/cordova-android/pull/417 ### Platforms affected cordova-android ### What does this PR do? This PR fixes the build if

[GitHub] heymartinadams commented on a change in pull request #722: Update index.md

heymartinadams commented on a change in pull request #722: Update index.md URL: https://github.com/apache/cordova-docs/pull/722#discussion_r151288058 ## File path: www/docs/en/6.x/guide/platforms/android/index.md ## @@ -310,7 +310,7 @@ To sign an app, you need the

[GitHub] heymartinadams opened a new pull request #764: See PR #722

heymartinadams opened a new pull request #764: See PR #722 URL: https://github.com/apache/cordova-docs/pull/764 See: https://github.com/apache/cordova-docs/pull/722 This is an automated message from the Apache Git Service. To

[GitHub] heymartinadams opened a new pull request #763: See PR #722

heymartinadams opened a new pull request #763: See PR #722 URL: https://github.com/apache/cordova-docs/pull/763 See: https://github.com/apache/cordova-docs/pull/722 This is an automated message from the Apache Git Service. To

[GitHub] heymartinadams commented on a change in pull request #722: Update index.md

heymartinadams commented on a change in pull request #722: Update index.md URL: https://github.com/apache/cordova-docs/pull/722#discussion_r151287002 ## File path: www/docs/en/6.x/guide/platforms/android/index.md ## @@ -310,7 +310,7 @@ To sign an app, you need the

[GitHub] heymartinadams commented on a change in pull request #722: Update index.md

heymartinadams commented on a change in pull request #722: Update index.md URL: https://github.com/apache/cordova-docs/pull/722#discussion_r151286945 ## File path: www/docs/en/6.x/guide/platforms/android/index.md ## @@ -310,7 +310,7 @@ To sign an app, you need the

[GitHub] jcesarmobile closed pull request #97: The problem of continuous call of beep()

jcesarmobile closed pull request #97: The problem of continuous call of beep() URL: https://github.com/apache/cordova-plugin-dialogs/pull/97 This is an automated message from the Apache Git Service. To respond to the

[GitHub] jcesarmobile commented on issue #97: The problem of continuous call of beep()

jcesarmobile commented on issue #97: The problem of continuous call of beep() URL: https://github.com/apache/cordova-plugin-dialogs/pull/97#issuecomment-344758930 Hi. You have created a pull request by mistake. Can you report the issue on issues.cordova.io?

svn commit: r23118 - in /dev/cordova/CB-13579: ./ cordova-ios-4.5.4.tgz cordova-ios-4.5.4.tgz.asc cordova-ios-4.5.4.tgz.md5 cordova-ios-4.5.4.tgz.sha512

Author: surajpindoria Date: Wed Nov 15 22:25:03 2017 New Revision: 23118 Log: CB-13579 Uploading release candidates for ios release Added: dev/cordova/CB-13579/ dev/cordova/CB-13579/cordova-ios-4.5.4.tgz (with props) dev/cordova/CB-13579/cordova-ios-4.5.4.tgz.asc

[GitHub] jcesarmobile commented on issue #98: CB-13555 (ios) Present notification view controller by inappbrowser view controller

jcesarmobile commented on issue #98: CB-13555 (ios) Present notification view controller by inappbrowser view controller URL: https://github.com/apache/cordova-plugin-dialogs/pull/98#issuecomment-344748040 Merged, thanks for the PR!

[cordova-ios] tag 4.5.4 created (now acf9107)

This is an automated email from the ASF dual-hosted git repository. surajpindoria pushed a change to tag 4.5.4 in repository https://gitbox.apache.org/repos/asf/cordova-ios.git. at acf9107 (commit) No new revisions were added by this update. -- To stop receiving notification emails

[cordova-ios] 06/06: Set VERSION to 4.5.4 (via coho)

This is an automated email from the ASF dual-hosted git repository. surajpindoria pushed a commit to branch 4.5.x in repository https://gitbox.apache.org/repos/asf/cordova-ios.git commit acf91073e5c106679d2127cfc2692191a39a0bf4 Author: Suraj Pindoria AuthorDate: Wed

[cordova-ios] branch master updated (5cb8bd1 -> 24bfb73)

This is an automated email from the ASF dual-hosted git repository. surajpindoria pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-ios.git. from 5cb8bd1 CB-13523: Add flag for Xcode-managed provisioning new 6eaf06e CB-13579 Updated checked in

[cordova-ios] branch 4.5.x updated (ce2ab96 -> acf9107)

This is an automated email from the ASF dual-hosted git repository. surajpindoria pushed a change to branch 4.5.x in repository https://gitbox.apache.org/repos/asf/cordova-ios.git. from ce2ab96 Set VERSION to 4.5.3 (via coho) new 9ddcd88 CB-13505: adjust storyboard constraints

[cordova-ios] 01/06: CB-13505: adjust storyboard constraints

This is an automated email from the ASF dual-hosted git repository. surajpindoria pushed a commit to branch 4.5.x in repository https://gitbox.apache.org/repos/asf/cordova-ios.git commit 9ddcd885be159f253f40b1bebc55652f8c68244f Author: mhartington AuthorDate: Fri Oct

[cordova-ios] 02/06: CB-13505: (ios) adjust storyboard constraints

This is an automated email from the ASF dual-hosted git repository. surajpindoria pushed a commit to branch 4.5.x in repository https://gitbox.apache.org/repos/asf/cordova-ios.git commit 1661d9f42c24d86ec6a0181f4783150a88659215 Author: mhartington AuthorDate: Fri Oct

[cordova-ios] 03/05: Added 4.5.4 to CDVAvailability.h (via coho).

This is an automated email from the ASF dual-hosted git repository. surajpindoria pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-ios.git commit 21f820d80580ccf206f895f1372076d6fb38e321 Author: Suraj Pindoria AuthorDate: Wed

[cordova-ios] 03/06: Fix compile error when compile source as objective-c++

This is an automated email from the ASF dual-hosted git repository. surajpindoria pushed a commit to branch 4.5.x in repository https://gitbox.apache.org/repos/asf/cordova-ios.git commit 6150e770c967c686d62f7911744502e13d60a00e Author: 葛威 AuthorDate: Mon Oct 30 16:03:24

[cordova-ios] 05/05: Update JS snapshot to version 4.6.0-dev (via coho)

This is an automated email from the ASF dual-hosted git repository. surajpindoria pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-ios.git commit 24bfb734d5af0747c27cdbb9b122931ee808112f Author: Suraj Pindoria AuthorDate: Wed

[cordova-ios] 04/05: Set VERSION to 4.6.0-dev (via coho)

This is an automated email from the ASF dual-hosted git repository. surajpindoria pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-ios.git commit 54b4d1fa3bd5cd9b3fec68a4e71e7f598634b50a Author: Suraj Pindoria AuthorDate: Wed

[cordova-ios] 02/05: CB-13579 Updated RELEASENOTES and Version for release 4.5.4

This is an automated email from the ASF dual-hosted git repository. surajpindoria pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-ios.git commit b7a5524c886ba21a3cbdccd2881407199eed795d Author: Suraj Pindoria AuthorDate: Wed

[cordova-plugin-dialogs] branch master updated: CB-13555 (ios) Present notification view controller by inappbrowser view controller (#98)

This is an automated email from the ASF dual-hosted git repository. jcesarmobile pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-dialogs.git The following commit(s) were added to refs/heads/master by this push: new 5a03f7f CB-13555 (ios)

[GitHub] jcesarmobile closed pull request #98: CB-13555 (ios) Present notification view controller by inappbrowser view controller

jcesarmobile closed pull request #98: CB-13555 (ios) Present notification view controller by inappbrowser view controller URL: https://github.com/apache/cordova-plugin-dialogs/pull/98 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] janpio commented on a change in pull request #722: Update index.md

janpio commented on a change in pull request #722: Update index.md URL: https://github.com/apache/cordova-docs/pull/722#discussion_r151243239 ## File path: www/docs/en/6.x/guide/platforms/android/index.md ## @@ -310,7 +310,7 @@ To sign an app, you need the following

[GitHub] janpio commented on a change in pull request #722: Update index.md

janpio commented on a change in pull request #722: Update index.md URL: https://github.com/apache/cordova-docs/pull/722#discussion_r151243239 ## File path: www/docs/en/6.x/guide/platforms/android/index.md ## @@ -310,7 +310,7 @@ To sign an app, you need the following

[GitHub] janpio closed pull request #739: CB-13323: Cordova-Android 6.3.0 Release Announcement

janpio closed pull request #739: CB-13323: Cordova-Android 6.3.0 Release Announcement URL: https://github.com/apache/cordova-docs/pull/739 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep?

janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep? URL: https://github.com/apache/cordova-docs/pull/760#discussion_r151238364 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,20 @@

[GitHub] codecov-io commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit

codecov-io commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389#issuecomment-316205218 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=h1) Report > Merging

svn commit: r1815360 - /cordova/site/public/feed.xml

Author: steven Date: Wed Nov 15 19:44:02 2017 New Revision: 1815360 URL: http://svn.apache.org/viewvc?rev=1815360=rev Log: Updated docs Modified: cordova/site/public/feed.xml Modified: cordova/site/public/feed.xml URL:

[GitHub] stevengill commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep?

stevengill commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep? URL: https://github.com/apache/cordova-docs/pull/760#discussion_r151231646 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0

[GitHub] dblotsky commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep?

dblotsky commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep? URL: https://github.com/apache/cordova-docs/pull/760#discussion_r151229142 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,20

[GitHub] janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep?

janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep? URL: https://github.com/apache/cordova-docs/pull/760#discussion_r151228684 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,20 @@

[GitHub] dblotsky commented on issue #760: CB-13543 : updated instructions/documentation around travis build/dep?

dblotsky commented on issue #760: CB-13543 : updated instructions/documentation around travis build/dep? URL: https://github.com/apache/cordova-docs/pull/760#issuecomment-344702130 @audreyso yep, the question about infra still remains open. Are Apache Infra OK with us having SVN

[GitHub] stevengill commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep?

stevengill commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep? URL: https://github.com/apache/cordova-docs/pull/760#discussion_r151225869 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0

[cordova-docs] 01/01: Merge pull request #761 from apache/janpio-patch-1

This is an automated email from the ASF dual-hosted git repository. steven pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-docs.git commit 05933c1a275c2b57f3eae86db1a686ed5f7619c6 Merge: 4a67f2b c27171b Author: Steve Gill

[GitHub] stevengill closed pull request #761: CB-13573: Clarify Cordova Android 6.4.0 blog post

stevengill closed pull request #761: CB-13573: Clarify Cordova Android 6.4.0 blog post URL: https://github.com/apache/cordova-docs/pull/761 This is an automated message from the Apache Git Service. To respond to the

[cordova-docs] branch master updated (4a67f2b -> 05933c1)

This is an automated email from the ASF dual-hosted git repository. steven pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-docs.git. from 4a67f2b Merge pull request #757 from infil00p/6.4.0_announce add c27171b CB-13573: Clarify Cordova

[GitHub] stevengill commented on issue #761: CB-13573: Clarify Cordova Android 6.4.0 blog post

stevengill commented on issue #761: CB-13573: Clarify Cordova Android 6.4.0 blog post URL: https://github.com/apache/cordova-docs/pull/761#issuecomment-344698544 I wouldn't worry about the failures too much. Lets merge it in and keep an eye on travis for master to see if that passes.

[GitHub] dpogue commented on issue #762: CB-13523: Add automaticProvisioning to iOS signing docs

dpogue commented on issue #762: CB-13523: Add automaticProvisioning to iOS signing docs URL: https://github.com/apache/cordova-docs/pull/762#issuecomment-344690609 The `--automaticProvisioning` flag won't be available until the next iOS release

[GitHub] stevengill commented on issue #762: CB-13523: Add automaticProvisioning to iOS signing docs

stevengill commented on issue #762: CB-13523: Add automaticProvisioning to iOS signing docs URL: https://github.com/apache/cordova-docs/pull/762#issuecomment-344690096 LGTM. @dpogue ready to merge or wait until after next iOS release?

[cordova-android] branch master updated (83601dc -> 3760616)

This is an automated email from the ASF dual-hosted git repository. bowserj pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git. from 83601dc Update JS snapshot to version 6.5.0-dev (via coho) add 026dce5 CB-13558: Upgrading the

[cordova-android] 01/01: Merge pull request #416 from infil00p/bintray_fix

This is an automated email from the ASF dual-hosted git repository. bowserj pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git commit 3760616639eb8d264edc99c3b5c8794c4d378bc8 Merge: 83601dc 026dce5 Author: Joe Bowser

[GitHub] infil00p closed pull request #416: CB-13558: Upgrading the gradle so we can upload the AAR

infil00p closed pull request #416: CB-13558: Upgrading the gradle so we can upload the AAR URL: https://github.com/apache/cordova-android/pull/416 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] codecov-io commented on issue #416: CB-13558: Upgrading the gradle so we can upload the AAR

codecov-io commented on issue #416: CB-13558: Upgrading the gradle so we can upload the AAR URL: https://github.com/apache/cordova-android/pull/416#issuecomment-344684272 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/416?src=pr=h1) Report > Merging

[GitHub] infil00p opened a new pull request #416: CB-13558: Upgrading the gradle so we can upload the AAR

infil00p opened a new pull request #416: CB-13558: Upgrading the gradle so we can upload the AAR URL: https://github.com/apache/cordova-android/pull/416 ### Platforms affected Cordova-Android ### What does this PR do? Fixes the Framework Gradle so that we can upload

[GitHub] janpio commented on issue #761: CB-13573: Clarify Cordova Android 6.4.0 blog post

janpio commented on issue #761: CB-13573: Clarify Cordova Android 6.4.0 blog post URL: https://github.com/apache/cordova-docs/pull/761#issuecomment-344536870 @audreyso Could you have a look at the first failing Travis CI build here please? No idea what is happening and why. Update

[GitHub] janpio commented on issue #761: CB-13573: Clarify Cordova Android 6.4.0 blog post

janpio commented on issue #761: CB-13573: Clarify Cordova Android 6.4.0 blog post URL: https://github.com/apache/cordova-docs/pull/761#issuecomment-344536870 @audreyso Could you have a look at the first failing Travis CI build here please? No idea what is happening and why. Update

[GitHub] Reneoh commented on issue #140: Update CDVSplashScreen.h

Reneoh commented on issue #140: Update CDVSplashScreen.h URL: https://github.com/apache/cordova-plugin-splashscreen/pull/140#issuecomment-344632388 I know, I don't know how to put changes on two files in one pull request... sorry... looking into it now.

[GitHub] Reneoh commented on issue #139: Update CDVSplashScreen.m

Reneoh commented on issue #139: Update CDVSplashScreen.m URL: https://github.com/apache/cordova-plugin-splashscreen/pull/139#issuecomment-344631778 Thanks, missed that one...! This is an automated message from the Apache Git

[GitHub] shazron commented on issue #140: Update CDVSplashScreen.h

shazron commented on issue #140: Update CDVSplashScreen.h URL: https://github.com/apache/cordova-plugin-splashscreen/pull/140#issuecomment-344601726 Saw the other PR. The other one is dependent on this one -- both should be in one PR. Also follow the PR Template.

[GitHub] nadavmos commented on issue #139: Update CDVSplashScreen.m

nadavmos commented on issue #139: Update CDVSplashScreen.m URL: https://github.com/apache/cordova-plugin-splashscreen/pull/139#issuecomment-344570981 .. and you are also missing the asset catalog version prefix for iphoneX, see below: // Add Asset Catalog specific prefixes

[GitHub] Reneoh commented on issue #140: Update CDVSplashScreen.h

Reneoh commented on issue #140: Update CDVSplashScreen.h URL: https://github.com/apache/cordova-plugin-splashscreen/pull/140#issuecomment-344558445 I'm totally new on github. I've made some changes to the splashscreen.m and .h files to support the iphone x screen. Sorry for messing things

[GitHub] shazron commented on issue #140: Update CDVSplashScreen.h

shazron commented on issue #140: Update CDVSplashScreen.h URL: https://github.com/apache/cordova-plugin-splashscreen/pull/140#issuecomment-344557573 This patch exists in a vacuum - what issue is this supposed to solve? Can you clarify. Thanks. Follow the template that was presented

[GitHub] janpio commented on issue #761: CB-13573: Clarify Cordova Android 6.4.0 blog post

janpio commented on issue #761: CB-13573: Clarify Cordova Android 6.4.0 blog post URL: https://github.com/apache/cordova-docs/pull/761#issuecomment-344536870 @audreyso Could you have a look at the first failing Travis CI build here please? No idea what is happening and why.

[GitHub] janpio commented on issue #761: CB-13573: Clarify Cordova Android 6.4.0 blog post

janpio commented on issue #761: CB-13573: Clarify Cordova Android 6.4.0 blog post URL: https://github.com/apache/cordova-docs/pull/761#issuecomment-344536870 @audreyso Could you have a look at the first filaing Travis CI build here please? No idea what is happening and why.

[GitHub] janpio commented on issue #761: CB-13573: Clarify Cordova Android 6.4.0 blog post

janpio commented on issue #761: CB-13573: Clarify Cordova Android 6.4.0 blog post URL: https://github.com/apache/cordova-docs/pull/761#issuecomment-344536870 @audreyso Could you have a look at the first filaing Travis CI build here? No idea what is happening and why.

[GitHub] Reneoh opened a new pull request #140: Update CDVSplashScreen.h

Reneoh opened a new pull request #140: Update CDVSplashScreen.h URL: https://github.com/apache/cordova-plugin-splashscreen/pull/140 Added a BOOL for iPhoneX This is an automated message from the Apache Git Service. To respond

[GitHub] nadavmos commented on issue #139: Update CDVSplashScreen.m

nadavmos commented on issue #139: Update CDVSplashScreen.m URL: https://github.com/apache/cordova-plugin-splashscreen/pull/139#issuecomment-344530591 you haven't pushed your changes in CDVSplashScreen.h This is an automated