[GitHub] talksea opened a new pull request #248: Android cannot support open the camera

2017-11-17 Thread GitBox
talksea opened a new pull request #248: Android cannot support open the camera URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/248 IOS can support open the camera,or choose local picture, but Android cannot support open the camera,only support choose local file. How can

[GitHub] janpio commented on issue #210: CB-12367: Modernize styling of iOS InAppBrowser view

2017-11-17 Thread GitBox
janpio commented on issue #210: CB-12367: Modernize styling of iOS InAppBrowser view URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/210#issuecomment-345231914 There are still some unanswered comments from a reviewer. Also some reviews from other people - and stories

[GitHub] alsorokin commented on issue #239: CB-13175: fixing windows8.1 crash on startup

2017-11-17 Thread GitBox
alsorokin commented on issue #239: CB-13175: fixing windows8.1 crash on startup URL: https://github.com/apache/cordova-windows/pull/239#issuecomment-345221549 @janpio thanks and good luck with the release! I'll try and find some time to test it when vote is out ? -

[GitHub] janpio closed pull request #239: CB-13175: fixing windows8.1 crash on startup

2017-11-17 Thread GitBox
janpio closed pull request #239: CB-13175: fixing windows8.1 crash on startup URL: https://github.com/apache/cordova-windows/pull/239 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fo

[GitHub] janpio commented on issue #239: CB-13175: fixing windows8.1 crash on startup

2017-11-17 Thread GitBox
janpio commented on issue #239: CB-13175: fixing windows8.1 crash on startup URL: https://github.com/apache/cordova-windows/pull/239#issuecomment-345221329 Ok, then we can close this. Thanks for the Pull Request @kaplanmaxe. I will try to push for a release of cordova-windows that wi

[GitHub] janpio commented on issue #239: CB-13175: fixing windows8.1 crash on startup

2017-11-17 Thread GitBox
janpio commented on issue #239: CB-13175: fixing windows8.1 crash on startup URL: https://github.com/apache/cordova-windows/pull/239#issuecomment-345219547 > I can't understand why the current npm package still doesn't include a hotfix merged six month ago.. Because nobody did a rele

[GitHub] janpio commented on issue #235: CB-11968: Add support for config-file in config.xml

2017-11-17 Thread GitBox
janpio commented on issue #235: CB-11968: Add support for config-file in config.xml URL: https://github.com/apache/cordova-windows/pull/235#issuecomment-345220538 What is the state of this PR now? All requirements merged? Thi

[GitHub] alsorokin commented on issue #239: CB-13175: fixing windows8.1 crash on startup

2017-11-17 Thread GitBox
alsorokin commented on issue #239: CB-13175: fixing windows8.1 crash on startup URL: https://github.com/apache/cordova-windows/pull/239#issuecomment-345220700 @janpio there is no need to merge this PR, because the release process includes automatic update of `cordova.js` by coho. -

[GitHub] janpio commented on issue #239: CB-13175: fixing windows8.1 crash on startup

2017-11-17 Thread GitBox
janpio commented on issue #239: CB-13175: fixing windows8.1 crash on startup URL: https://github.com/apache/cordova-windows/pull/239#issuecomment-345220131 @alsorokin So this PR's changes to `template/www/cordova.js` are good to merge as well so they would appear in the next release? -

[GitHub] janpio commented on issue #239: CB-13175: fixing windows8.1 crash on startup

2017-11-17 Thread GitBox
janpio commented on issue #239: CB-13175: fixing windows8.1 crash on startup URL: https://github.com/apache/cordova-windows/pull/239#issuecomment-345219547 > I can't understand why the current npm package still doesn't include a hotfix merged six month ago.. Because nobody did a rele

[GitHub] spacepope commented on issue #239: CB-13175: fixing windows8.1 crash on startup

2017-11-17 Thread GitBox
spacepope commented on issue #239: CB-13175: fixing windows8.1 crash on startup URL: https://github.com/apache/cordova-windows/pull/239#issuecomment-345174514 > What exactly do you mean by that? @janpio i meant that if you now do a `cordova platform add windows` you get the latest ve