[GitHub] jaapjanfrans commented on issue #247: CB-13498 added closebutton option for ios

2017-11-29 Thread GitBox
jaapjanfrans commented on issue #247: CB-13498 added closebutton option for ios URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/247#issuecomment-348110795 I understand your concern @surajpindoria I think we're save with our app because of the way we add some function

[GitHub] jaapjanfrans closed pull request #247: CB-13498 added closebutton option for ios

2017-11-29 Thread GitBox
jaapjanfrans closed pull request #247: CB-13498 added closebutton option for ios URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/247 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] prashkorane commented on issue #46: CB-13435: fix merges directory support for browser

2017-11-29 Thread GitBox
prashkorane commented on issue #46: CB-13435: fix merges directory support for browser URL: https://github.com/apache/cordova-browser/pull/46#issuecomment-348105651 We are facing issue while creating platform browser with "**cordova platform add browser**" with the latest cordova version (

svn commit: r1816668 - /cordova/site/public/feed.xml

2017-11-29 Thread audreyso
Author: audreyso Date: Thu Nov 30 01:41:30 2017 New Revision: 1816668 URL: http://svn.apache.org/viewvc?rev=1816668&view=rev Log: Updated docs Modified: cordova/site/public/feed.xml Modified: cordova/site/public/feed.xml URL: http://svn.apache.org/viewvc/cordova/site/public/feed.xml?rev=181

svn commit: r1816665 [1/2] - in /cordova/site/public: ./ blog/ docs/en/dev/guide/support/ docs/en/dev/reference/cordova-plugin-contacts/ docs/en/dev/reference/cordova-plugin-legacy-whitelist/ news/201

2017-11-29 Thread audreyso
Author: audreyso Date: Thu Nov 30 00:36:33 2017 New Revision: 1816665 URL: http://svn.apache.org/viewvc?rev=1816665&view=rev Log: Updated docs Added: cordova/site/public/news/2017/11/20/ cordova/site/public/news/2017/11/20/migrate-from-cordova-globalization-plugin.html Modified: cord

svn commit: r1816665 [2/2] - in /cordova/site/public: ./ blog/ docs/en/dev/guide/support/ docs/en/dev/reference/cordova-plugin-contacts/ docs/en/dev/reference/cordova-plugin-legacy-whitelist/ news/201

2017-11-29 Thread audreyso
Modified: cordova/site/public/static/js/plugins.js URL: http://svn.apache.org/viewvc/cordova/site/public/static/js/plugins.js?rev=1816665&r1=1816664&r2=1816665&view=diff == --- cordova/site/public/static/js/plugins.js (ori

[cordova-docs] 02/02: CB-13608: Updated the blog sections

2017-11-29 Thread macdonst
This is an automated email from the ASF dual-hosted git repository. macdonst pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-docs.git commit d00ff035a7026356716c2e85dcc2b5633c21bd9d Author: maverickmishra AuthorDate: Mon Nov 27 15:23:42 2017 -0800

[cordova-docs] branch master updated (4b951dc -> d00ff03)

2017-11-29 Thread macdonst
This is an automated email from the ASF dual-hosted git repository. macdonst pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-docs.git. from 4b951dc CB-13066: Removed references of contacts plugin new c35674d CB-13608: Added blog post about de

[GitHub] macdonst closed pull request #773: CB-13608: Added blog post about deprecation of cordova-plugin-contacts

2017-11-29 Thread GitBox
macdonst closed pull request #773: CB-13608: Added blog post about deprecation of cordova-plugin-contacts URL: https://github.com/apache/cordova-docs/pull/773 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of pr

[cordova-docs] 01/02: CB-13608: Added blog post about deprecation of cordova-plugin-contacts

2017-11-29 Thread macdonst
This is an automated email from the ASF dual-hosted git repository. macdonst pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-docs.git commit c35674d88b76f9743be0e768c6f1181f0517e578 Author: maverickmishra AuthorDate: Mon Nov 27 12:06:19 2017 -0800

[GitHub] surajpindoria opened a new pull request #251: CB-12875: (ios) Magnifiying glass is showing wrong content with inapp?

2017-11-29 Thread GitBox
surajpindoria opened a new pull request #251: CB-12875: (ios) Magnifiying glass is showing wrong content with inapp? URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/251 ?browser window ### Platforms affected iOS ### What does this PR do? Pushes th

[GitHub] surajpindoria commented on issue #247: CB-13498 added closebutton option for ios

2017-11-29 Thread GitBox
surajpindoria commented on issue #247: CB-13498 added closebutton option for ios URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/247#issuecomment-348008734 @jaapjanfrans, I had a feeling that this is what you were trying to accomplish by removing the close button. An

[cordova-android] branch master updated: CB-13741: Updating checked-in node_modules, otherwise plugin installation fails

2017-11-29 Thread bowserj
This is an automated email from the ASF dual-hosted git repository. bowserj pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git The following commit(s) were added to refs/heads/master by this push: new 3642ffb CB-13741: Updating checked-in

[cordova-android] branch master updated (59018ab -> 3dcc319)

2017-11-29 Thread bowserj
This is an automated email from the ASF dual-hosted git repository. bowserj pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git. from 59018ab Merge pull request #389 from infil00p/StudioProjectCompat add 8484f7b CB-13615: Fix paths to

[cordova-android] 01/01: Merge pull request #419 from dpogue/signing-fix

2017-11-29 Thread bowserj
This is an automated email from the ASF dual-hosted git repository. bowserj pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git commit 3dcc319cd2be8b42a06124169ea4ec3c9aa21a2b Merge: 59018ab 8484f7b Author: Joe Bowser AuthorDate: Wed Nov 29 12:2

[GitHub] infil00p closed pull request #419: CB-13615: Fix paths to signing properties files

2017-11-29 Thread GitBox
infil00p closed pull request #419: CB-13615: Fix paths to signing properties files URL: https://github.com/apache/cordova-android/pull/419 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this i

[cordova-android] branch 6.4.x updated: A git conflict slipped into the repo, fixing

2017-11-29 Thread bowserj
This is an automated email from the ASF dual-hosted git repository. bowserj pushed a commit to branch 6.4.x in repository https://gitbox.apache.org/repos/asf/cordova-android.git The following commit(s) were added to refs/heads/6.4.x by this push: new c0c3b76 A git conflict slipped into the

[cordova-android] branch 6.4.x updated (7a27ee4 -> fae39dd)

2017-11-29 Thread bowserj
This is an automated email from the ASF dual-hosted git repository. bowserj pushed a change to branch 6.4.x in repository https://gitbox.apache.org/repos/asf/cordova-android.git. from 7a27ee4 Set VERSION to 6.4.0 (via coho) add 05aeaf1 Set VERSION to 6.5.0-dev (via coho) add 8360

[cordova-android] 01/01: Merge branch 'master' into 6.4.x

2017-11-29 Thread bowserj
This is an automated email from the ASF dual-hosted git repository. bowserj pushed a commit to branch 6.4.x in repository https://gitbox.apache.org/repos/asf/cordova-android.git commit fae39dd2e58cf8f9fa81c9aa542628a2f7b0de21 Merge: 7a27ee4 3ad1ed7 Author: Joe Bowser AuthorDate: Tue Nov 28 10:39

[GitHub] codecov-io commented on issue #419: CB-13615: Fix paths to signing properties files

2017-11-29 Thread GitBox
codecov-io commented on issue #419: CB-13615: Fix paths to signing properties files URL: https://github.com/apache/cordova-android/pull/419#issuecomment-347970883 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/419?src=pr&el=h1) Report > Merging [#419](https://codecov.io

[GitHub] janpio commented on issue #247: CB-13498 added closebutton option for ios

2017-11-29 Thread GitBox
janpio commented on issue #247: CB-13498 added closebutton option for ios URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/247#issuecomment-347968748 Not OP, but my idea I got when seeing this: * OAuth signup + login flow, with prev / next buttons * App catches "Can

[GitHub] janpio commented on issue #247: CB-13498 added closebutton option for ios

2017-11-29 Thread GitBox
janpio commented on issue #247: CB-13498 added closebutton option for ios URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/247#issuecomment-347968748 Not OP, but my idea I got when seeing this: * OAuth signup + login flow * App catches "Cancel" button or redirection

[GitHub] jaapjanfrans commented on issue #247: CB-13498 added closebutton option for ios

2017-11-29 Thread GitBox
jaapjanfrans commented on issue #247: CB-13498 added closebutton option for ios URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/247#issuecomment-347968656 Hey thanks for chiming in! **Why would a developer want to have an inappbrowser window with no close button?**

[GitHub] surajpindoria commented on issue #247: CB-13498 added closebutton option for ios

2017-11-29 Thread GitBox
surajpindoria commented on issue #247: CB-13498 added closebutton option for ios URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/247#issuecomment-347965530 The code for this looks fine and it works as described. But I am struggling to really find a reason for adding this fe

[GitHub] dpogue opened a new pull request #419: CB-13615: Fix paths to signing properties files

2017-11-29 Thread GitBox
dpogue opened a new pull request #419: CB-13615: Fix paths to signing properties files URL: https://github.com/apache/cordova-android/pull/419 ### Platforms affected Android ### What does this PR do? Fixes keysigning via properties files ### What testing has been

[GitHub] infil00p closed pull request #389: CB-11244: Studio Project Compatibility: Now with merge commit

2017-11-29 Thread GitBox
infil00p closed pull request #389: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenan

[cordova-android] 01/01: Merge pull request #389 from infil00p/StudioProjectCompat

2017-11-29 Thread bowserj
This is an automated email from the ASF dual-hosted git repository. bowserj pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git commit 59018ab632e99b3e45a0bf9657c70282aeeac7bf Merge: 3ad1ed7 c6cfeb1 Author: Joe Bowser AuthorDate: Wed Nov 29 09:5

[cordova-android] branch master updated (3ad1ed7 -> 59018ab)

2017-11-29 Thread bowserj
This is an automated email from the ASF dual-hosted git repository. bowserj pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git. from 3ad1ed7 Merge pull request #418 from dpogue/splash-compress add d88df59 Adding the Studio Builder to

[GitHub] codecov-io commented on issue #351: Prevent a memory leak when converting to JSON

2017-11-29 Thread GitBox
codecov-io commented on issue #351: Prevent a memory leak when converting to JSON URL: https://github.com/apache/cordova-ios/pull/351#issuecomment-347893707 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/351?src=pr&el=h1) Report > Merging [#351](https://codecov.io/gh/apache/

[GitHub] shaneomack91 opened a new pull request #351: Prevent a memory leak when converting to JSON

2017-11-29 Thread GitBox
shaneomack91 opened a new pull request #351: Prevent a memory leak when converting to JSON URL: https://github.com/apache/cordova-ios/pull/351 The use of JSONObjectWithData in these methods leaks 4KB each time when used for sending plugin results. Wrapping them in an autoreleasepool fixes

[GitHub] sjyMystery opened a new pull request #250: Browser Close Controll

2017-11-29 Thread GitBox
sjyMystery opened a new pull request #250: Browser Close Controll URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/250 ### Platforms affected Android ### What does this PR do? Make authors can control whether user can close the Browser ### W