[GitHub] chemerisuk closed pull request #440: Basic support for annotation CordovaMethod

2018-05-14 Thread GitBox
chemerisuk closed pull request #440: Basic support for annotation CordovaMethod URL: https://github.com/apache/cordova-android/pull/440 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] chemerisuk commented on issue #440: Basic support for annotation CordovaMethod

2018-05-14 Thread GitBox
chemerisuk commented on issue #440: Basic support for annotation CordovaMethod URL: https://github.com/apache/cordova-android/pull/440#issuecomment-388785948 After some thinking I created a separate plugin [cordova-support-android-plugin](https://github.com/chemerisuk/cordova-support-androi

[GitHub] janpio commented on issue #274: MSBuild v4.0 Not supported and possibly why all these other MSBuild issues are happening.

2018-05-14 Thread GitBox
janpio commented on issue #274: MSBuild v4.0 Not supported and possibly why all these other MSBuild issues are happening. URL: https://github.com/apache/cordova-windows/issues/274#issuecomment-388790557 `cordova-windows` uses multiple methods to try to figure out a matching MSBuild version

[GitHub] janpio commented on issue #274: MSBuild v4.0 Not supported and possibly why all these other MSBuild issues are happening.

2018-05-14 Thread GitBox
janpio commented on issue #274: MSBuild v4.0 Not supported and possibly why all these other MSBuild issues are happening. URL: https://github.com/apache/cordova-windows/issues/274#issuecomment-388790557 `cordova-windows` uses multiple methods to try to figure out a matching MSBuild version

[GitHub] royalrex commented on issue #50: corrected path for config.xml

2018-05-14 Thread GitBox
royalrex commented on issue #50: corrected path for config.xml URL: https://github.com/apache/cordova-browser/pull/50#issuecomment-388799032 Just found this fix. Was having the same problem of running a cordova (ionic) web app from a subdir and it failed to load config.xml and consequently

[GitHub] royalrex commented on issue #50: corrected path for config.xml

2018-05-14 Thread GitBox
royalrex commented on issue #50: corrected path for config.xml URL: https://github.com/apache/cordova-browser/pull/50#issuecomment-388799032 Just found this fix. @janpio I was having the same problem of running a cordova (ionic) web app from a subdir and it failed to load config.xml

[GitHub] royalrex commented on issue #50: corrected path for config.xml

2018-05-14 Thread GitBox
royalrex commented on issue #50: corrected path for config.xml URL: https://github.com/apache/cordova-browser/pull/50#issuecomment-388799032 Just found this fix. @janpio I was having the same problem of running a cordova (ionic) web app from a subdir and it failed to load config.xml

[GitHub] royalrex commented on issue #50: corrected path for config.xml

2018-05-14 Thread GitBox
royalrex commented on issue #50: corrected path for config.xml URL: https://github.com/apache/cordova-browser/pull/50#issuecomment-388799032 Just found this fix. @janpio I was having the same problem of running a cordova (ionic) web app from a subdir and it failed to load config.xml

[GitHub] royalrex opened a new pull request #151: Use FadeSplashScreenDuration from config.xml on browser platform

2018-05-14 Thread GitBox
royalrex opened a new pull request #151: Use FadeSplashScreenDuration from config.xml on browser platform URL: https://github.com/apache/cordova-plugin-splashscreen/pull/151 ### Platforms affected Browser ### What does this PR do? Use FadeSplashScreenDuration from confi

[GitHub] jcesarmobile closed pull request #106: CB-14085: Fix iOS usage description

2018-05-14 Thread GitBox
jcesarmobile closed pull request #106: CB-14085: Fix iOS usage description URL: https://github.com/apache/cordova-plugin-geolocation/pull/106 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] jcesarmobile commented on issue #106: CB-14085: Fix iOS usage description

2018-05-14 Thread GitBox
jcesarmobile commented on issue #106: CB-14085: Fix iOS usage description URL: https://github.com/apache/cordova-plugin-geolocation/pull/106#issuecomment-388824486 Thanks for the PR, but we removed this on purpose because plugin variables cause conflicts with other plugins setting the same

[GitHub] joshchandler opened a new pull request #441: CB-14089: (android) Add Kotlin support

2018-05-14 Thread GitBox
joshchandler opened a new pull request #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441 ### Platforms affected Android ### What does this PR do? This adds support for the Kotlin programming language. Plugins can start

[GitHub] joshchandler commented on a change in pull request #441: CB-14089: (android) Add Kotlin support

2018-05-14 Thread GitBox
joshchandler commented on a change in pull request #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#discussion_r188038113 ## File path: bin/templates/project/Activity.kt ## @@ -0,0 +1,38 @@ +/* Review comment: I'm n

[GitHub] dpolivy opened a new pull request #365: CB-14076: (ios) Setting UIWebViewDelegate on CDVWebViewEngineProtocol doesn't work

2018-05-14 Thread GitBox
dpolivy opened a new pull request #365: CB-14076: (ios) Setting UIWebViewDelegate on CDVWebViewEngineProtocol doesn't work URL: https://github.com/apache/cordova-ios/pull/365 Attempts to use `CDVWebViewEngineProtocol::updateWithInfo` to set a new `UIWebViewDelegate` were not working; inste

[GitHub] codecov-io commented on issue #365: CB-14076: (ios) Setting UIWebViewDelegate on CDVWebViewEngineProtocol doesn't work

2018-05-14 Thread GitBox
codecov-io commented on issue #365: CB-14076: (ios) Setting UIWebViewDelegate on CDVWebViewEngineProtocol doesn't work URL: https://github.com/apache/cordova-ios/pull/365#issuecomment-388978333 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/365?src=pr&el=h1) Report > Merging

[GitHub] shazron commented on issue #365: CB-14076: (ios) Setting UIWebViewDelegate on CDVWebViewEngineProtocol doesn't work

2018-05-14 Thread GitBox
shazron commented on issue #365: CB-14076: (ios) Setting UIWebViewDelegate on CDVWebViewEngineProtocol doesn't work URL: https://github.com/apache/cordova-ios/pull/365#issuecomment-389014172 Sorry I take that back, it is already set to the default in `pluginInitialize` ---

[cordova-ios] branch master updated: CB-14076: Setting UIWebViewDelegate on CDVWebViewEngineProtocol doesn't work (#365)

2018-05-14 Thread shazron
This is an automated email from the ASF dual-hosted git repository. shazron pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-ios.git The following commit(s) were added to refs/heads/master by this push: new 191c17e CB-14076: Setting UIWebViewDelega

[GitHub] shazron closed pull request #365: CB-14076: (ios) Setting UIWebViewDelegate on CDVWebViewEngineProtocol doesn't work

2018-05-14 Thread GitBox
shazron closed pull request #365: CB-14076: (ios) Setting UIWebViewDelegate on CDVWebViewEngineProtocol doesn't work URL: https://github.com/apache/cordova-ios/pull/365 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the