[GitHub] shazron commented on issue #363: CB-14045 - reinit url after app freezes

2018-05-15 Thread GitBox
shazron commented on issue #363: CB-14045 - reinit url after app freezes URL: https://github.com/apache/cordova-ios/pull/363#issuecomment-389401996 Made a mistake - didn't realize this was based off 4.5.x branch so it was pulled into that. Reverted the change to 4.5.x and applied to master

[cordova-ios] branch 4.5.x updated: Revert "CB-14045 - Reinit url after app freezes (#363)"

2018-05-15 Thread shazron
This is an automated email from the ASF dual-hosted git repository. shazron pushed a commit to branch 4.5.x in repository https://gitbox.apache.org/repos/asf/cordova-ios.git The following commit(s) were added to refs/heads/4.5.x by this push: new 00a4b27 Revert "CB-14045 - Reinit url after

[GitHub] knight9999 opened a new pull request #166: fix tests code for fix stream url and remove browser

2018-05-15 Thread GitBox
knight opened a new pull request #166: fix tests code for fix stream url and remove browser URL: https://github.com/apache/cordova-plugin-media/pull/166 ### Platforms affected Tests code only Browser (test) iOS (test) ### What does this PR do? Removing

[cordova-ios] branch master updated: CB-14045 - Reinit url after app freezes (#363)

2018-05-15 Thread shazron
This is an automated email from the ASF dual-hosted git repository. shazron pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-ios.git The following commit(s) were added to refs/heads/master by this push: new 6e790af CB-14045 - Reinit url after app f

[cordova-ios] branch 4.5.x updated: CB-14045 - Reinit url after app freezes (#363)

2018-05-15 Thread shazron
This is an automated email from the ASF dual-hosted git repository. shazron pushed a commit to branch 4.5.x in repository https://gitbox.apache.org/repos/asf/cordova-ios.git The following commit(s) were added to refs/heads/4.5.x by this push: new 6b3f10f CB-14045 - Reinit url after app fre

[GitHub] shazron closed pull request #363: CB-14045 - reinit url after app freezes

2018-05-15 Thread GitBox
shazron closed pull request #363: CB-14045 - reinit url after app freezes URL: https://github.com/apache/cordova-ios/pull/363 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pu

[GitHub] codecov-io commented on issue #363: reinit url after app freezes

2018-05-15 Thread GitBox
codecov-io commented on issue #363: reinit url after app freezes URL: https://github.com/apache/cordova-ios/pull/363#issuecomment-383522512 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/363?src=pr&el=h1) Report > Merging [#363](https://codecov.io/gh/apache/cordova-ios/pull/3

[GitHub] codecov-io commented on issue #363: reinit url after app freezes

2018-05-15 Thread GitBox
codecov-io commented on issue #363: reinit url after app freezes URL: https://github.com/apache/cordova-ios/pull/363#issuecomment-383522512 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/363?src=pr&el=h1) Report > Merging [#363](https://codecov.io/gh/apache/cordova-ios/pull/3

[GitHub] codecov-io commented on issue #363: reinit url after app freezes

2018-05-15 Thread GitBox
codecov-io commented on issue #363: reinit url after app freezes URL: https://github.com/apache/cordova-ios/pull/363#issuecomment-383522512 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/363?src=pr&el=h1) Report > Merging [#363](https://codecov.io/gh/apache/cordova-ios/pull/3

[GitHub] shazron commented on issue #363: reinit url after app freezes

2018-05-15 Thread GitBox
shazron commented on issue #363: reinit url after app freezes URL: https://github.com/apache/cordova-ios/pull/363#issuecomment-389397225 Never mind, I just did a push and it was successful. Looks like it was checked by default. --

[GitHub] shazron commented on issue #363: reinit url after app freezes

2018-05-15 Thread GitBox
shazron commented on issue #363: reinit url after app freezes URL: https://github.com/apache/cordova-ios/pull/363#issuecomment-389387442 @svalaskevicius sure, will do. Can you make sure the checkbox "allow maintainers to make edits" is checked? Thanks: https://blog.github.com/2016-09-07-im

[cordova-lib] 01/01: Merge pull request #612 from raphinesse/drop-node4

2018-05-15 Thread dpogue
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-lib.git commit 10a48258431bdd632cd4b26db01cf6c1e6d6bd0f Merge: 9fcf84b 61395d2 Author: Darryl Pogue AuthorDate: Tue May 15 20:10:5

[cordova-lib] branch master updated (9fcf84b -> 10a4825)

2018-05-15 Thread dpogue
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-lib.git. from 9fcf84b Merge pull request #611 from dpogue/dependency-cleanup add 61395d2 CB-14065: Drop support for Nod

[cordova-cli] branch master updated: CB-14068: Drop support for Node 4 and add Node 10 to CI

2018-05-15 Thread dpogue
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-cli.git The following commit(s) were added to refs/heads/master by this push: new f567c26 CB-14068: Drop support for Node 4

[GitHub] codecov-io commented on issue #363: reinit url after app freezes

2018-05-15 Thread GitBox
codecov-io commented on issue #363: reinit url after app freezes URL: https://github.com/apache/cordova-ios/pull/363#issuecomment-383522512 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/363?src=pr&el=h1) Report > Merging [#363](https://codecov.io/gh/apache/cordova-ios/pull/3

[GitHub] codecov-io commented on issue #363: reinit url after app freezes

2018-05-15 Thread GitBox
codecov-io commented on issue #363: reinit url after app freezes URL: https://github.com/apache/cordova-ios/pull/363#issuecomment-383522512 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/363?src=pr&el=h1) Report > Merging [#363](https://codecov.io/gh/apache/cordova-ios/pull/3

[GitHub] svalaskevicius commented on issue #363: reinit url after app freezes

2018-05-15 Thread GitBox
svalaskevicius commented on issue #363: reinit url after app freezes URL: https://github.com/apache/cordova-ios/pull/363#issuecomment-389210263 Hi @shazron , I've changed the function as requested, however I'm having problems with the test... I've tried adding this test: ``` -(

[GitHub] ghenry22 commented on issue #149: CB-13445: (ios) Streaming media can take up to 8-10 seconds to start - fixed!

2018-05-15 Thread GitBox
ghenry22 commented on issue #149: CB-13445: (ios) Streaming media can take up to 8-10 seconds to start - fixed! URL: https://github.com/apache/cordova-plugin-media/pull/149#issuecomment-346538770 wrap it like so: ``` if ([NSProcessInfo.processInfo isOperatingSystemAtLeastVersion

[GitHub] ghenry22 commented on issue #149: CB-13445: (ios) Streaming media can take up to 8-10 seconds to start - fixed!

2018-05-15 Thread GitBox
ghenry22 commented on issue #149: CB-13445: (ios) Streaming media can take up to 8-10 seconds to start - fixed! URL: https://github.com/apache/cordova-plugin-media/pull/149#issuecomment-389078075 @pbirsinger yes what I typed is the only change that is needed. Once that change is made the