[GitHub] shazron closed pull request #284: Update CameraProxy.js

2018-05-23 Thread GitBox
shazron closed pull request #284: Update CameraProxy.js URL: https://github.com/apache/cordova-plugin-camera/pull/284 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] shazron commented on issue #284: Update CameraProxy.js

2018-05-23 Thread GitBox
shazron commented on issue #284: Update CameraProxy.js URL: https://github.com/apache/cordova-plugin-camera/pull/284#issuecomment-391595147 Lol, now Appveyor passes but Travis has one build in its matrix that does not (looks to be a too many accesses error, needs an npm update). Since the

[cordova-plugin-camera] branch master updated: Update CameraProxy.js (#284)

2018-05-23 Thread shazron
This is an automated email from the ASF dual-hosted git repository. shazron pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-camera.git The following commit(s) were added to refs/heads/master by this push: new 36343a8 Update CameraProxy.js

[GitHub] shazron closed pull request #284: Update CameraProxy.js

2018-05-23 Thread GitBox
shazron closed pull request #284: Update CameraProxy.js URL: https://github.com/apache/cordova-plugin-camera/pull/284 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] ZenPylon opened a new pull request #284: Update CameraProxy.js

2018-05-23 Thread GitBox
ZenPylon opened a new pull request #284: Update CameraProxy.js URL: https://github.com/apache/cordova-plugin-camera/pull/284 Remove audio flag from getUserMedia on the browser. Including audio resulted in some nasty audio feedback, and audio isn't really needed for taking pictures

[GitHub] shazron commented on issue #284: Update CameraProxy.js

2018-05-23 Thread GitBox
shazron commented on issue #284: Update CameraProxy.js URL: https://github.com/apache/cordova-plugin-camera/pull/284#issuecomment-391589815 Still stuck. Will close and re-open again, sigh This is an automated message from

[GitHub] shazron commented on a change in pull request #288: CB-13384: (browser) Added deprecation of video.src compatibility

2018-05-23 Thread GitBox
shazron commented on a change in pull request #288: CB-13384: (browser) Added deprecation of video.src compatibility URL: https://github.com/apache/cordova-plugin-camera/pull/288#discussion_r190466889 ## File path: src/browser/CameraProxy.js ## @@ -102,7 +102,11 @@

[GitHub] ZenPylon commented on issue #284: Update CameraProxy.js

2018-05-23 Thread GitBox
ZenPylon commented on issue #284: Update CameraProxy.js URL: https://github.com/apache/cordova-plugin-camera/pull/284#issuecomment-391538345 Ok, just closed and reopened! This is an automated message from the Apache Git

[GitHub] ZenPylon closed pull request #284: Update CameraProxy.js

2018-05-23 Thread GitBox
ZenPylon closed pull request #284: Update CameraProxy.js URL: https://github.com/apache/cordova-plugin-camera/pull/284 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] ZenPylon opened a new pull request #284: Update CameraProxy.js

2018-05-23 Thread GitBox
ZenPylon opened a new pull request #284: Update CameraProxy.js URL: https://github.com/apache/cordova-plugin-camera/pull/284 Remove audio flag from getUserMedia on the browser. Including audio resulted in some nasty audio feedback, and audio isn't really needed for taking pictures

[GitHub] mvandervliet commented on issue #288: CB-13384: (browser) Added deprecation of video.src compatibility

2018-05-23 Thread GitBox
mvandervliet commented on issue #288: CB-13384: (browser) Added deprecation of video.src compatibility URL: https://github.com/apache/cordova-plugin-camera/pull/288#issuecomment-391382754 Thanks @charlesverge - Yes that would work as well, effectively the same functionally, perhaps more

[GitHub] charlesverge commented on issue #288: CB-13384: (browser) Added deprecation of video.src compatibility

2018-05-23 Thread GitBox
charlesverge commented on issue #288: CB-13384: (browser) Added deprecation of video.src compatibility URL: https://github.com/apache/cordova-plugin-camera/pull/288#issuecomment-391378721 @mvandervliet The solution I used is ``` localMediaStream = stream;

[GitHub] jcesarmobile commented on issue #78: Bluetooth MAC Address

2018-05-23 Thread GitBox
jcesarmobile commented on issue #78: Bluetooth MAC Address URL: https://github.com/apache/cordova-plugin-device/pull/78#issuecomment-391299898 Thanks for the PR, but this only works on Android M and newer, and on Android O it requires a permission to work. Also the code doesn't compile.