shazron commented on issue #166: CB-14091: fix tests code for stream url and
remove browser
URL:
https://github.com/apache/cordova-plugin-media/pull/166#issuecomment-398271806
Follow the discussion here:
https://lists.apache.org/thread.html/3178fd3d36491e6e0777d8ee104de93e2aef09c7c3ec19db
This is an automated email from the ASF dual-hosted git repository.
shazron pushed a commit to branch master
in repository
https://gitbox.apache.org/repos/asf/cordova-new-committer-and-pmc.git
The following commit(s) were added to refs/heads/master by this push:
new 75dd9dc Update ISSUE_T
This is an automated email from the ASF dual-hosted git repository.
shazron pushed a commit to branch master
in repository
https://gitbox.apache.org/repos/asf/cordova-new-committer-and-pmc.git
The following commit(s) were added to refs/heads/master by this push:
new 4c9c409 Update README.
This is an automated email from the ASF dual-hosted git repository.
shazron pushed a commit to branch master
in repository
https://gitbox.apache.org/repos/asf/cordova-new-committer-and-pmc.git
The following commit(s) were added to refs/heads/master by this push:
new 03d5e77 Update README.
codecov-io edited a comment on issue #448: CB-13685 android: Adaptive Icon
Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-397924030
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=h1)
Report
> Merging
[#448](https://codecov.io/
codecov-io edited a comment on issue #448: CB-13685 android: Adaptive Icon
Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-397924030
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=h1)
Report
> Merging
[#448](https://codecov.io/
This is an automated email from the ASF dual-hosted git repository.
shazron pushed a commit to branch master
in repository
https://gitbox.apache.org/repos/asf/cordova-apache-board-reports.git
The following commit(s) were added to refs/heads/master by this push:
new 43e3c2d Update README.m
This is an automated email from the ASF dual-hosted git repository.
brodybits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-common.git
The following commit(s) were added to refs/heads/master by this push:
new c104401 .travis.yml add spacing
c104
brodybits commented on a change in pull request #832: CB-14138: add
cordova-common@2.2.4 blog post
URL: https://github.com/apache/cordova-docs/pull/832#discussion_r196264799
##
File path: www/_posts/2018-06-15-common-release-2.2.4.md
##
@@ -0,0 +1,23 @@
+---
+layout: post
raphinesse commented on issue #445: (android) Add unit tests for run and
retryPromise
URL: https://github.com/apache/cordova-android/pull/445#issuecomment-398236038
> I would have looked into replacing retryPromise but I didn't want to be
ripping things out in one of my first commits.
dpogue commented on a change in pull request #832: CB-14138: add
cordova-common@2.2.4 blog post
URL: https://github.com/apache/cordova-docs/pull/832#discussion_r196263949
##
File path: www/_posts/2018-06-15-common-release-2.2.4.md
##
@@ -0,0 +1,23 @@
+---
+layout: post
+au
raphinesse commented on a change in pull request #445: (android) Add unit tests
for run and retryPromise
URL: https://github.com/apache/cordova-android/pull/445#discussion_r196261306
##
File path: spec/unit/run.spec.js
##
@@ -17,22 +17,217 @@
under the License.
*/
codecov-io edited a comment on issue #445: (android) Add unit tests for run and
retryPromise
URL: https://github.com/apache/cordova-android/pull/445#issuecomment-397915162
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/445?src=pr&el=h1)
Report
> Merging
[#445](https://c
Menardi commented on issue #445: (android) Add unit tests for run and
retryPromise
URL: https://github.com/apache/cordova-android/pull/445#issuecomment-398231286
Thanks for the detailed review, I really appreciate it. I would have looked
into replacing `retryPromise` but I didn't want to b
Menardi commented on a change in pull request #445: (android) Add unit tests
for run and retryPromise
URL: https://github.com/apache/cordova-android/pull/445#discussion_r196256813
##
File path: spec/unit/run.spec.js
##
@@ -17,22 +17,217 @@
under the License.
*/
-va
Menardi commented on a change in pull request #445: (android) Add unit tests
for run and retryPromise
URL: https://github.com/apache/cordova-android/pull/445#discussion_r196257410
##
File path: spec/unit/retry.spec.js
##
@@ -0,0 +1,66 @@
+/**
+Licensed to the Apache So
Menardi commented on a change in pull request #445: (android) Add unit tests
for run and retryPromise
URL: https://github.com/apache/cordova-android/pull/445#discussion_r196257195
##
File path: spec/unit/retry.spec.js
##
@@ -0,0 +1,66 @@
+/**
+Licensed to the Apache So
Menardi commented on a change in pull request #445: (android) Add unit tests
for run and retryPromise
URL: https://github.com/apache/cordova-android/pull/445#discussion_r196256991
##
File path: spec/unit/run.spec.js
##
@@ -17,22 +17,217 @@
under the License.
*/
-va
raphinesse closed pull request #453: Lint JS w/out extension too
URL: https://github.com/apache/cordova-android/pull/453
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull re
This is an automated email from the ASF dual-hosted git repository.
raphinesse pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-android.git
The following commit(s) were added to refs/heads/master by this push:
new 393dad6 Lint JS files w/out extens
This is an automated email from the ASF dual-hosted git repository.
raphinesse pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-cli.git
The following commit(s) were added to refs/heads/master by this push:
new bbb14fb Proper error code and message
brodybits commented on issue #155: 4.2.4 patch update
URL: https://github.com/apache/cordova-js/pull/155#issuecomment-398166090
Changed my mind yet again: need to fix some more npm build/test issues and
maybe propose the changes in smaller parts. Closing for now, at least.
Apologies to wat
brodybits closed pull request #155: 4.2.4 patch update
URL: https://github.com/apache/cordova-js/pull/155
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a f
brodybits opened a new pull request #155: 4.2.4 patch update
URL: https://github.com/apache/cordova-js/pull/155
### Platforms affected
All
### What does this PR do?
Proposed changes for `4.2.x` branch (NOT for master):
- Use npm@5 on AppVeyor to resolve is
brodybits closed pull request #61: CB-7949 add cordova-local to tools release
process
URL: https://github.com/apache/cordova-coho/pull/61
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is
brodybits commented on issue #61: CB-7949 add cordova-local to tools release
process
URL: https://github.com/apache/cordova-coho/pull/61#issuecomment-398102374
> Why not use `npx cordova`?
- extra typing
- not everyone has `npx` (Node 6)
I think the ideal solution would be
raphinesse commented on issue #61: CB-7949 add cordova-local to tools release
process
URL: https://github.com/apache/cordova-coho/pull/61#issuecomment-39806
Why not use `npx cordova`?
This is an automated message from the
brodybits opened a new pull request #172: 1.0.1 update
URL: https://github.com/apache/cordova-coho/pull/172
### Platforms affected
All
### What does this PR do?
- tests working again
- update devDependencies to resolve npm audit warnings
- Update version &
brodybits commented on issue #61: CB-7949 add cordova-local to tools release
process
URL: https://github.com/apache/cordova-coho/pull/61#issuecomment-398064956
What a shame that nobody reviewed this wonderful contribution from 3 years
ago, would like to revive it when I get some spare cycl
codecov-io commented on issue #453: Lint JS w/out extension too
URL: https://github.com/apache/cordova-android/pull/453#issuecomment-398054512
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/453?src=pr&el=h1)
Report
> Merging
[#453](https://codecov.io/gh/apache/cordova-an
codecov-io commented on issue #453: Lint JS w/out extension too
URL: https://github.com/apache/cordova-android/pull/453#issuecomment-398054512
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/453?src=pr&el=h1)
Report
> Merging
[#453](https://codecov.io/gh/apache/cordova-an
raphinesse opened a new pull request #453: Lint JS w/out extension too
URL: https://github.com/apache/cordova-android/pull/453
This is an automated message from the Apache Git Service.
To respond to the message, please log on
raphinesse commented on issue #445: (android) Add unit tests for run and
retryPromise
URL: https://github.com/apache/cordova-android/pull/445#issuecomment-398050765
Another note: when we finally have unbundled dependencies, we probably
should replace `retryPromise` with
[p-retry](https://
This is an automated email from the ASF dual-hosted git repository.
brodybits pushed a change to tag 4.2.3
in repository https://gitbox.apache.org/repos/asf/cordova-js.git.
at 61a5190 (commit)
No new revisions were added by this update.
--
To stop receiving notification emails like this
This is an automated email from the ASF dual-hosted git repository.
brodybits pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-js.git.
from 4450a4c Merge pull request #150 from audreyso/CB-13501
add 948c29f remove grunt jshint artifacts not ne
brodybits closed pull request #154: Finish version 4.2.3
URL: https://github.com/apache/cordova-js/pull/154
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a
This is an automated email from the ASF dual-hosted git repository.
brodybits pushed a change to branch 4.2.x
in repository https://gitbox.apache.org/repos/asf/cordova-js.git.
from 7c5fcc5 CB-12358 Incremented package version to -dev
add 7ef9f9c CB-12748 - Update CI to test node 4 and
brodybits opened a new pull request #154: Finish version 4.2.3
URL: https://github.com/apache/cordova-js/pull/154
### Platforms affected
All
### What does this PR do?
- remove grunt jshint artifacts not needed (resolves some of the npm audit
warnings)
- `.tra
brodybits commented on issue #153: cordova-js@4.x cleanup
URL: https://github.com/apache/cordova-js/pull/153#issuecomment-398027904
Changed my mind again, closing
This is an automated message from the Apache Git Service.
To re
brodybits closed pull request #153: cordova-js@4.x cleanup
URL: https://github.com/apache/cordova-js/pull/153
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from
codecov-io commented on issue #445: (android) Add unit tests for run and
retryPromise
URL: https://github.com/apache/cordova-android/pull/445#issuecomment-397915162
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/445?src=pr&el=h1)
Report
> Merging
[#445](https://codecov.
codecov-io commented on issue #445: (android) Add unit tests for run and
retryPromise
URL: https://github.com/apache/cordova-android/pull/445#issuecomment-397915162
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/445?src=pr&el=h1)
Report
> Merging
[#445](https://codecov.
codecov-io commented on issue #445: (android) Add unit tests for run and
retryPromise
URL: https://github.com/apache/cordova-android/pull/445#issuecomment-397915162
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/445?src=pr&el=h1)
Report
> Merging
[#445](https://codecov.
raphinesse commented on a change in pull request #445: (android) Add unit tests
for run and retryPromise
URL: https://github.com/apache/cordova-android/pull/445#discussion_r196005635
##
File path: spec/unit/retry.spec.js
##
@@ -0,0 +1,66 @@
+/**
+Licensed to the Apache
raphinesse commented on a change in pull request #445: (android) Add unit tests
for run and retryPromise
URL: https://github.com/apache/cordova-android/pull/445#discussion_r196005635
##
File path: spec/unit/retry.spec.js
##
@@ -0,0 +1,66 @@
+/**
+Licensed to the Apache
raphinesse commented on a change in pull request #445: (android) Add unit tests
for run and retryPromise
URL: https://github.com/apache/cordova-android/pull/445#discussion_r196010900
##
File path: spec/unit/retry.spec.js
##
@@ -0,0 +1,66 @@
+/**
+Licensed to the Apache
raphinesse commented on a change in pull request #445: (android) Add unit tests
for run and retryPromise
URL: https://github.com/apache/cordova-android/pull/445#discussion_r196008171
##
File path: spec/unit/retry.spec.js
##
@@ -0,0 +1,66 @@
+/**
+Licensed to the Apache
raphinesse commented on a change in pull request #445: (android) Add unit tests
for run and retryPromise
URL: https://github.com/apache/cordova-android/pull/445#discussion_r196017308
##
File path: spec/unit/retry.spec.js
##
@@ -0,0 +1,66 @@
+/**
+Licensed to the Apache
raphinesse commented on a change in pull request #445: (android) Add unit tests
for run and retryPromise
URL: https://github.com/apache/cordova-android/pull/445#discussion_r196025543
##
File path: spec/unit/run.spec.js
##
@@ -17,22 +17,217 @@
under the License.
*/
raphinesse commented on a change in pull request #445: (android) Add unit tests
for run and retryPromise
URL: https://github.com/apache/cordova-android/pull/445#discussion_r196041729
##
File path: spec/unit/run.spec.js
##
@@ -17,22 +17,217 @@
under the License.
*/
raphinesse commented on a change in pull request #445: (android) Add unit tests
for run and retryPromise
URL: https://github.com/apache/cordova-android/pull/445#discussion_r196005635
##
File path: spec/unit/retry.spec.js
##
@@ -0,0 +1,66 @@
+/**
+Licensed to the Apache
raphinesse commented on a change in pull request #445: (android) Add unit tests
for run and retryPromise
URL: https://github.com/apache/cordova-android/pull/445#discussion_r196003736
##
File path: spec/unit/retry.spec.js
##
@@ -0,0 +1,66 @@
+/**
+Licensed to the Apache
purplecabbage commented on issue #118: CB-9366 Log error.stack as it helps with
diagnosing the source of the…
URL: https://github.com/apache/cordova-js/pull/118#issuecomment-397989478
I am okay if you want to merge it, my initial point of view was just that
there are other ways of handling
brodybits commented on issue #451: Minor release with cordova-common@2.2.x
update, etc. WIP
URL: https://github.com/apache/cordova-android/pull/451#issuecomment-397982861
> @brodybits Can we do these updates for the next minor on top of the 7.1.x
branch?
Will do.
--
brodybits commented on issue #118: CB-9366 Log error.stack as it helps with
diagnosing the source of the…
URL: https://github.com/apache/cordova-js/pull/118#issuecomment-397979799
Looks like it would be really nice to have this enhancement, maybe for the
next major release.
--
dpogue commented on issue #451: Minor release items: cordova-common 2.2.3
update with node 4 enabled again
URL: https://github.com/apache/cordova-android/pull/451#issuecomment-397969814
We can't drop support for node 4 in a minor version update, but I agree that
we should keep master movin
56 matches
Mail list logo
