[GitHub] Menardi commented on a change in pull request #848: Remove deprecated platforms from plugin page

Menardi commented on a change in pull request #848: Remove deprecated platforms from plugin page URL: https://github.com/apache/cordova-docs/pull/848#discussion_r203585595 ## File path: www/static/plugins/supportedplatforms.jsx ## @@ -1,83 +1,32 @@ -var Preact =

[GitHub] Menardi commented on a change in pull request #848: Remove deprecated platforms from plugin page

Menardi commented on a change in pull request #848: Remove deprecated platforms from plugin page URL: https://github.com/apache/cordova-docs/pull/848#discussion_r203585595 ## File path: www/static/plugins/supportedplatforms.jsx ## @@ -1,83 +1,32 @@ -var Preact =

[GitHub] erisu commented on issue #848: Remove deprecated platforms from plugin page

erisu commented on issue #848: Remove deprecated platforms from plugin page URL: https://github.com/apache/cordova-docs/pull/848#issuecomment-406133057 @janpio Let me know if you also have any thoughts, questions, or concerns with this change. At this stage, I think it's good to go unless

[GitHub] brodybits commented on issue #274: CB-14187: (ios) Change the InAppBrowser to allow custom schemes

brodybits commented on issue #274: CB-14187: (ios) Change the InAppBrowser to allow custom schemes URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-406127713 Thanks @wvengen. Unfortunately I had some real trouble getting a test demo to work on iOS. A quick

[GitHub] erisu commented on issue #848: Remove deprecated platforms from plugin page

erisu commented on issue #848: Remove deprecated platforms from plugin page URL: https://github.com/apache/cordova-docs/pull/848#issuecomment-406112813 I was also thinking about generating the keyword on the fly for filtering but just couldn't decide what others would really like ha.

[GitHub] raphinesse edited a comment on issue #848: Remove deprecated platforms from plugin page

raphinesse edited a comment on issue #848: Remove deprecated platforms from plugin page URL: https://github.com/apache/cordova-docs/pull/848#issuecomment-406104396 @erisu Of course, stupid bug. Thanks for fixing! And thanks for explaining what's actually happening, too :+1: I

[GitHub] raphinesse commented on issue #848: Remove deprecated platforms from plugin page

raphinesse commented on issue #848: Remove deprecated platforms from plugin page URL: https://github.com/apache/cordova-docs/pull/848#issuecomment-406104396 @erisu Of course, stupid bug. Thanks for fixing! And thanks for explaining what's actually happening, too :+1: I probably

[GitHub] erisu commented on issue #848: Remove deprecated platforms from plugin page

erisu commented on issue #848: Remove deprecated platforms from plugin page URL: https://github.com/apache/cordova-docs/pull/848#issuecomment-406102987 @raphinesse I updated the proposal. I added the platform keyword to the sortedPlatforms collection. Example: ` {keyword:

[GitHub] wvengen edited a comment on issue #276: CB-14188: add beforeload event, catching navigation before it happens

wvengen edited a comment on issue #276: CB-14188: add beforeload event, catching navigation before it happens URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/276#issuecomment-405965660 Thanks a lot for your review and comments, @brodybits. I agree that the current

[GitHub] wvengen edited a comment on issue #276: CB-14188: add beforeload event, catching navigation before it happens

wvengen edited a comment on issue #276: CB-14188: add beforeload event, catching navigation before it happens URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/276#issuecomment-405965660 Thanks a lot for your review and comments, @brodybits. I agree that the current

[GitHub] wvengen commented on issue #276: CB-14188: add beforeload event, catching navigation before it happens

wvengen commented on issue #276: CB-14188: add beforeload event, catching navigation before it happens URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/276#issuecomment-405965660 Thanks a lot for your review, @brodybits. I agree that the current approach is not ideal, and

[GitHub] wvengen commented on issue #274: CB-14187: (ios) Change the InAppBrowser to allow custom schemes

wvengen commented on issue #274: CB-14187: (ios) Change the InAppBrowser to allow custom schemes URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-405962280 Thanks for your review, @brodybits! I've added a test and some documentation. I opted for a manual

[GitHub] raphinesse commented on issue #848: Remove deprecated platforms from plugin page

raphinesse commented on issue #848: Remove deprecated platforms from plugin page URL: https://github.com/apache/cordova-docs/pull/848#issuecomment-405952844 I've tried to make this a bit more straightforward. Did not test since I've never built the docs before. Might be a matter of taste.

[GitHub] janpio commented on issue #824: Remove deprecated platforms from plugin page

janpio commented on issue #824: Remove deprecated platforms from plugin page URL: https://github.com/apache/cordova-docs/pull/824#issuecomment-405951350 @brodybits, @erisu deleted/lost the branch in his fork which is why he couldn't work on it any more ;)

[GitHub] brodybits commented on issue #824: Remove deprecated platforms from plugin page

brodybits commented on issue #824: Remove deprecated platforms from plugin page URL: https://github.com/apache/cordova-docs/pull/824#issuecomment-405949220 FYI procedure to fetch the commits from a PR is described in: -

[GitHub] erisu edited a comment on issue #824: Remove deprecated platforms from plugin page

erisu edited a comment on issue #824: Remove deprecated platforms from plugin page URL: https://github.com/apache/cordova-docs/pull/824#issuecomment-405941884 Closing this PR and replaced with PR #848. This PR's branch/repo had been lost.

[GitHub] erisu commented on a change in pull request #824: Remove deprecated platforms from plugin page

erisu commented on a change in pull request #824: Remove deprecated platforms from plugin page URL: https://github.com/apache/cordova-docs/pull/824#discussion_r203390059 ## File path: www/static/plugins/supportedplatforms.jsx ## @@ -6,74 +6,34 @@ var Preact =

[GitHub] erisu commented on a change in pull request #824: Remove deprecated platforms from plugin page

erisu commented on a change in pull request #824: Remove deprecated platforms from plugin page URL: https://github.com/apache/cordova-docs/pull/824#discussion_r203390059 ## File path: www/static/plugins/supportedplatforms.jsx ## @@ -6,74 +6,34 @@ var Preact =

[GitHub] erisu closed pull request #824: Remove deprecated platforms from plugin page

erisu closed pull request #824: Remove deprecated platforms from plugin page URL: https://github.com/apache/cordova-docs/pull/824 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] erisu commented on issue #824: Remove deprecated platforms from plugin page

erisu commented on issue #824: Remove deprecated platforms from plugin page URL: https://github.com/apache/cordova-docs/pull/824#issuecomment-405941884 Closing this PR and replaced with PR #848. This PR's branch had been lost.

[GitHub] erisu commented on a change in pull request #824: Remove deprecated platforms from plugin page

erisu commented on a change in pull request #824: Remove deprecated platforms from plugin page URL: https://github.com/apache/cordova-docs/pull/824#discussion_r203390059 ## File path: www/static/plugins/supportedplatforms.jsx ## @@ -6,74 +6,34 @@ var Preact =

[GitHub] erisu opened a new pull request #848: Remove deprecated platforms from plugin page

erisu opened a new pull request #848: Remove deprecated platforms from plugin page URL: https://github.com/apache/cordova-docs/pull/848 ### Platforms affected None ### What does this PR do? Update plugin list page to remove deprecated platforms. This PR replaces PR

[GitHub] aszmyd commented on issue #98: Add `getStatusBarHeight` method for Android

aszmyd commented on issue #98: Add `getStatusBarHeight` method for Android URL: https://github.com/apache/cordova-plugin-statusbar/pull/98#issuecomment-405918855 When you use `StatusBar.overlaysWebView(true);` method to have "transparent" statusbar and you want to pull down contents so

[GitHub] oliversalzburg commented on issue #98: Add `getStatusBarHeight` method for Android

oliversalzburg commented on issue #98: Add `getStatusBarHeight` method for Android URL: https://github.com/apache/cordova-plugin-statusbar/pull/98#issuecomment-405917962 What is the purpose of the method? At what point do you need this information in your app? If anything, I would

[GitHub] aszmyd commented on a change in pull request #99: Make transparency of statusbar persistent when hiding and showing sta…

aszmyd commented on a change in pull request #99: Make transparency of statusbar persistent when hiding and showing sta… URL: https://github.com/apache/cordova-plugin-statusbar/pull/99#discussion_r203354504 ## File path: src/android/StatusBar.java ## @@ -227,20 +236,22

[GitHub] aszmyd commented on a change in pull request #99: Make transparency of statusbar persistent when hiding and showing sta…

aszmyd commented on a change in pull request #99: Make transparency of statusbar persistent when hiding and showing sta… URL: https://github.com/apache/cordova-plugin-statusbar/pull/99#discussion_r203354559 ## File path: src/android/StatusBar.java ## @@ -96,7 +101,11 @@

[GitHub] aszmyd commented on a change in pull request #99: Make transparency of statusbar persistent when hiding and showing sta…

aszmyd commented on a change in pull request #99: Make transparency of statusbar persistent when hiding and showing sta… URL: https://github.com/apache/cordova-plugin-statusbar/pull/99#discussion_r203354176 ## File path: src/android/StatusBar.java ## @@ -227,20 +236,22

[GitHub] janpio commented on a change in pull request #99: Make transparency of statusbar persistent when hiding and showing sta…

janpio commented on a change in pull request #99: Make transparency of statusbar persistent when hiding and showing sta… URL: https://github.com/apache/cordova-plugin-statusbar/pull/99#discussion_r203352753 ## File path: src/android/StatusBar.java ## @@ -96,7 +101,11 @@

[GitHub] janpio commented on a change in pull request #99: Make transparency of statusbar persistent when hiding and showing sta…

janpio commented on a change in pull request #99: Make transparency of statusbar persistent when hiding and showing sta… URL: https://github.com/apache/cordova-plugin-statusbar/pull/99#discussion_r203352553 ## File path: src/android/StatusBar.java ## @@ -227,20 +236,22

[GitHub] janpio commented on a change in pull request #99: Make transparency of statusbar persistent when hiding and showing sta…

janpio commented on a change in pull request #99: Make transparency of statusbar persistent when hiding and showing sta… URL: https://github.com/apache/cordova-plugin-statusbar/pull/99#discussion_r203352364 ## File path: src/android/StatusBar.java ## @@ -227,20 +236,22

[GitHub] aszmyd commented on issue #96: Persistent transparency + getStatusBarHeight method

aszmyd commented on issue #96: Persistent transparency + getStatusBarHeight method URL: https://github.com/apache/cordova-plugin-statusbar/pull/96#issuecomment-405899490 I'm closing this one as two separate PR has been made for it.

[GitHub] aszmyd closed pull request #96: Persistent transparency + getStatusBarHeight method

aszmyd closed pull request #96: Persistent transparency + getStatusBarHeight method URL: https://github.com/apache/cordova-plugin-statusbar/pull/96 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] aszmyd commented on issue #96: Persistent transparency + getStatusBarHeight method

aszmyd commented on issue #96: Persistent transparency + getStatusBarHeight method URL: https://github.com/apache/cordova-plugin-statusbar/pull/96#issuecomment-405899392 @janpio here you go: https://github.com/apache/cordova-plugin-statusbar/pull/99 and

[GitHub] aszmyd opened a new pull request #99: Make transparency of statusbar persistent when hiding and showing sta…

aszmyd opened a new pull request #99: Make transparency of statusbar persistent when hiding and showing sta… URL: https://github.com/apache/cordova-plugin-statusbar/pull/99 ### Platforms affected Android ### What does this PR do? 1. It makes statusbar transparency persisten.

[GitHub] aszmyd opened a new pull request #98: Add `getStatusBarHeight` method for Android

aszmyd opened a new pull request #98: Add `getStatusBarHeight` method for Android URL: https://github.com/apache/cordova-plugin-statusbar/pull/98 ### Platforms affected Android ### What does this PR do? Added StatusBar.getStatusBarHeight method (Android only) that gets

svn commit: r1836158 - in /cordova/site/public: ./ docs/en/6.x/reference/cordova-cli/ docs/en/6.x/reference/cordova-plugin-battery-status/ docs/en/6.x/reference/cordova-plugin-camera/ docs/en/6.x/refe

Author: steven Date: Wed Jul 18 10:58:51 2018 New Revision: 1836158 URL: http://svn.apache.org/viewvc?rev=1836158=rev Log: Updated docs Modified: cordova/site/public/docs/en/6.x/reference/cordova-cli/index.html

svn commit: r1836157 - in /cordova/site/public: ./ docs/en/6.x/reference/cordova-cli/ docs/en/6.x/reference/cordova-plugin-battery-status/ docs/en/6.x/reference/cordova-plugin-camera/ docs/en/6.x/refe

Author: steven Date: Wed Jul 18 10:53:56 2018 New Revision: 1836157 URL: http://svn.apache.org/viewvc?rev=1836157=rev Log: Updated docs Modified: cordova/site/public/docs/en/6.x/reference/cordova-cli/index.html

svn commit: r1836156 - in /cordova/site/public: docs/en/dev/guide/next/index.html docs/en/dev/guide/platforms/android/index.html feed.xml index.html static/img/tools/instabug.png

Author: steven Date: Wed Jul 18 10:51:22 2018 New Revision: 1836156 URL: http://svn.apache.org/viewvc?rev=1836156=rev Log: Updated docs Added: cordova/site/public/static/img/tools/instabug.png (with props) Modified: cordova/site/public/docs/en/dev/guide/next/index.html

[GitHub] janpio commented on issue #831: Incorrect Link

janpio commented on issue #831: Incorrect Link URL: https://github.com/apache/cordova-docs/issues/831#issuecomment-405889054 I fixed the links in the `cordova-plugin-globalization` README, so this should fix itself in the docs with the next deploy.

[GitHub] janpio closed issue #831: Incorrect Link

janpio closed issue #831: Incorrect Link URL: https://github.com/apache/cordova-docs/issues/831 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above

[cordova-plugin-globalization] branch master updated: fix CI badges in README

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-globalization.git The following commit(s) were added to refs/heads/master by this push: new aa626da fix CI badges

[GitHub] janpio commented on issue #833: Missing documentation for OSX icons

janpio commented on issue #833: Missing documentation for OSX icons URL: https://github.com/apache/cordova-docs/issues/833#issuecomment-405888333 Hey @jazbek, did you find out any information in the meantime that could be added to the docs?

[cordova-docs] branch master updated: quicker dev build (#801)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-docs.git The following commit(s) were added to refs/heads/master by this push: new 0c5f113 quicker dev build (#801) 0c5f113

[cordova-docs] branch janpio-quicker_dev_build deleted (was 09768af)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch janpio-quicker_dev_build in repository https://gitbox.apache.org/repos/asf/cordova-docs.git. was 09768af Update _dev.yml The revisions that were on this branch are still contained in

[GitHub] janpio closed pull request #801: quicker dev build

janpio closed pull request #801: quicker dev build URL: https://github.com/apache/cordova-docs/pull/801 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

[GitHub] janpio closed pull request #813: Update index.md

janpio closed pull request #813: Update index.md URL: https://github.com/apache/cordova-docs/pull/813 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] janpio commented on issue #813: Update index.md

janpio commented on issue #813: Update index.md URL: https://github.com/apache/cordova-docs/pull/813#issuecomment-405887064 Why the plural @antosmaman? The whole page is the guide, so singular should be fine. This is an

[GitHub] janpio commented on a change in pull request #824: Remove deprecated platforms from plugin page

janpio commented on a change in pull request #824: Remove deprecated platforms from plugin page URL: https://github.com/apache/cordova-docs/pull/824#discussion_r203329213 ## File path: www/static/plugins/supportedplatforms.jsx ## @@ -6,74 +6,34 @@ var Preact =

[GitHub] janpio opened a new issue #847: "Tooling" page

janpio opened a new issue #847: "Tooling" page URL: https://github.com/apache/cordova-docs/issues/847 Currently the start page lists a number of tools that work with Cordova. But space is limited, and it should be in our interest to be able to list as many tools and services as possible.

[GitHub] janpio closed pull request #827: Added Instabug to the list of Cordova tools.

janpio closed pull request #827: Added Instabug to the list of Cordova tools. URL: https://github.com/apache/cordova-docs/pull/827 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[cordova-docs] branch master updated: Added Instabug to the list of Cordova tools. (#827)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-docs.git The following commit(s) were added to refs/heads/master by this push: new d76e2a6 Added Instabug to the list of

[cordova-docs] branch master updated: CB-14026 (android): Update Android SDK instructions (#836)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-docs.git The following commit(s) were added to refs/heads/master by this push: new 3f94715 CB-14026 (android): Update

[GitHub] janpio closed pull request #836: CB-14026 (android): Update Android SDK instructions

janpio closed pull request #836: CB-14026 (android): Update Android SDK instructions URL: https://github.com/apache/cordova-docs/pull/836 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[cordova-docs] branch master updated: Update Next Steps with more up-to-date information (#842)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-docs.git The following commit(s) were added to refs/heads/master by this push: new 8b14b4b Update Next Steps with more

svn commit: r1836155 - in /cordova/site/public: docs/en/dev/guide/support/index.html docs/en/dev/reference/cordova-plugin-statusbar/index.html feed.xml

Author: steven Date: Wed Jul 18 10:14:38 2018 New Revision: 1836155 URL: http://svn.apache.org/viewvc?rev=1836155=rev Log: Updated docs Modified: cordova/site/public/docs/en/dev/guide/support/index.html cordova/site/public/docs/en/dev/reference/cordova-plugin-statusbar/index.html

[cordova-docs] branch master updated: Improve platform support table

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-docs.git The following commit(s) were added to refs/heads/master by this push: new 9017500 Improve platform support table

[cordova-plugin-statusbar] branch master updated: remove second title headline

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-statusbar.git The following commit(s) were added to refs/heads/master by this push: new ecf8ccd remove second title

[GitHub] janpio edited a comment on issue #97: Add Android overlay support to README

janpio edited a comment on issue #97: Add Android overlay support to README URL: https://github.com/apache/cordova-plugin-statusbar/pull/97#issuecomment-405870797 @ManigandanRaamanathan http://issues.cordova.io is the correct place to talk about this, not a PR. Thank you.

[GitHub] janpio commented on issue #97: Add Android overlay support to README

janpio commented on issue #97: Add Android overlay support to README URL: https://github.com/apache/cordova-plugin-statusbar/pull/97#issuecomment-405870797 @ManigandanRaamanathan issues.cordova.io is the correct place to talk about this, not a PR. Thank you.

[GitHub] janpio commented on issue #96: Persistent transparency + getStatusBarHeight method

janpio commented on issue #96: Persistent transparency + getStatusBarHeight method URL: https://github.com/apache/cordova-plugin-statusbar/pull/96#issuecomment-405870114 Hey @aszmyd , this looks like a great PR. Could you maybe invest the time to make separate PRs for the separate

[GitHub] janpio commented on issue #67: CB-12024: Browser platform support

janpio commented on issue #67: CB-12024: Browser platform support URL: https://github.com/apache/cordova-plugin-statusbar/pull/67#issuecomment-405869122 Looking pretty good @dudeofawesome. I left a question, could you also maybe _again_ rebase on master to get rid of the README conflict?

[GitHub] janpio commented on a change in pull request #67: CB-12024: Browser platform support

janpio commented on a change in pull request #67: CB-12024: Browser platform support URL: https://github.com/apache/cordova-plugin-statusbar/pull/67#discussion_r203309656 ## File path: README.md ## @@ -30,7 +30,7 @@ description: Control the device status bar. StatusBar

[GitHub] ManigandanRaamanathan commented on issue #97: Add Android overlay support to README

ManigandanRaamanathan commented on issue #97: Add Android overlay support to README URL: https://github.com/apache/cordova-plugin-statusbar/pull/97#issuecomment-405868429 Will it work after the latest commit? The below fix did not work:- overlaysWebView(true);

[GitHub] janpio commented on issue #56: TypeScript Definition Created

janpio commented on issue #56: TypeScript Definition Created URL: https://github.com/apache/cordova-plugin-statusbar/pull/56#issuecomment-405867721 Are these still up to date? Is this still the way to create and keep typescript definitions?

[GitHub] janpio edited a comment on issue #37: CB-9841 - Allow iOS statusbar to animate hide/show

janpio edited a comment on issue #37: CB-9841 - Allow iOS statusbar to animate hide/show URL: https://github.com/apache/cordova-plugin-statusbar/pull/37#issuecomment-405867454 Yes, someone could create a new PR where the merged conflict is resolved please, then someone could take a look

[GitHub] janpio commented on issue #37: CB-9841 - Allow iOS statusbar to animate hide/show

janpio commented on issue #37: CB-9841 - Allow iOS statusbar to animate hide/show URL: https://github.com/apache/cordova-plugin-statusbar/pull/37#issuecomment-405867454 Yes, someone could create a new PR where the merged conflict is resolved please, then someone could take a look.

[cordova-plugin-statusbar] branch master updated (b8e0b01 -> 053a902)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-statusbar.git. from b8e0b01 Set VERSION to 2.4.3-dev (via coho) add e0256b2 Add Android overlay support to

[GitHub] janpio closed pull request #97: Add Android overlay support to README

janpio closed pull request #97: Add Android overlay support to README URL: https://github.com/apache/cordova-plugin-statusbar/pull/97 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[cordova-plugin-statusbar] 01/01: Merge pull request #97 from Menardi/Menardi-patch-1

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-statusbar.git commit 053a90249ade45e2a14c42d1da367dd6ff327f1d Merge: b8e0b01 e0256b2 Author: Jan Piotrowski AuthorDate: