[GitHub] Menardi commented on issue #98: Add `getStatusBarHeight` method for Android

Menardi commented on issue #98: Add `getStatusBarHeight` method for Android URL: https://github.com/apache/cordova-plugin-statusbar/pull/98#issuecomment-406760493 Personally I think the split-screen logic should be in the core, because there are more use cases for it apart from the status

[GitHub] brodybits commented on issue #274: CB-14187: (ios) Change the InAppBrowser to allow custom schemes

brodybits commented on issue #274: CB-14187: (ios) Change the InAppBrowser to allow custom schemes URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-406739430 I gotta say that I am still not able to get it to work on either Android or iOS in my test project

[GitHub] macdonst commented on issue #237: CB-14197: (all) Fix for createFile/writeFile silently failing to send 'write' action

macdonst commented on issue #237: CB-14197: (all) Fix for createFile/writeFile silently failing to send 'write' action URL: https://github.com/apache/cordova-plugin-file/pull/237#issuecomment-406715606 Thanks for the PR @wfairclough, good catch.

[cordova-plugin-file] branch master updated: require FileReader in FileWriter to fix 'write' exec not being called (#237)

This is an automated email from the ASF dual-hosted git repository. macdonst pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-file.git The following commit(s) were added to refs/heads/master by this push: new 4a92bbb require FileReader in

[GitHub] macdonst closed pull request #237: CB-14197: (all) Fix for createFile/writeFile silently failing to send 'write' action

macdonst closed pull request #237: CB-14197: (all) Fix for createFile/writeFile silently failing to send 'write' action URL: https://github.com/apache/cordova-plugin-file/pull/237 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed

[GitHub] brodybits commented on issue #237: CB-14197: (all) Fix for createFile/writeFile silently failing to send 'write' action

brodybits commented on issue #237: CB-14197: (all) Fix for createFile/writeFile silently failing to send 'write' action URL: https://github.com/apache/cordova-plugin-file/pull/237#issuecomment-406646565 > @stevengill Would you be able to review this PR for me? You may want to ping

[GitHub] aszmyd commented on issue #98: Add `getStatusBarHeight` method for Android

aszmyd commented on issue #98: Add `getStatusBarHeight` method for Android URL: https://github.com/apache/cordova-plugin-statusbar/pull/98#issuecomment-406555305 The main issue is that when statusbar is transparent and overlapping webview, app does not know how much space it needs to

[GitHub] Menardi commented on issue #98: Add `getStatusBarHeight` method for Android

Menardi commented on issue #98: Add `getStatusBarHeight` method for Android URL: https://github.com/apache/cordova-plugin-statusbar/pull/98#issuecomment-406549521 True, but I think that is a different scenario in a way. I'm not sure Cordova apps even officially support split screen mode.

[GitHub] aszmyd commented on issue #98: Add `getStatusBarHeight` method for Android

aszmyd commented on issue #98: Add `getStatusBarHeight` method for Android URL: https://github.com/apache/cordova-plugin-statusbar/pull/98#issuecomment-406545322 @Menardi i thought about that too but how would user app detect split mode issue? If user statically set 24px then even in

[GitHub] Menardi commented on issue #98: Add `getStatusBarHeight` method for Android

Menardi commented on issue #98: Add `getStatusBarHeight` method for Android URL: https://github.com/apache/cordova-plugin-statusbar/pull/98#issuecomment-406543015 @aszmyd I was was more thinking that since it's always 24px, there's no need for the `getStatusBarHeight` function at all.