[GitHub] grinmax commented on issue #183: Response time and play mp3 samples

2018-09-12 Thread GitBox
grinmax commented on issue #183: Response time and play mp3 samples URL: https://github.com/apache/cordova-plugin-media/issues/183#issuecomment-420900356 @janpio I think this plugin does not know how to do it, is it possible?

[GitHub] grinmax commented on issue #183: Response time and play mp3 samples

2018-09-12 Thread GitBox
grinmax commented on issue #183: Response time and play mp3 samples URL: https://github.com/apache/cordova-plugin-media/issues/183#issuecomment-420900185 @janpio android & ios, plugin version is latest. This is an automated m

[GitHub] shazron commented on issue #405: Cocoapods support improvement, using podspec tag in plugin.xml

2018-09-12 Thread GitBox
shazron commented on issue #405: Cocoapods support improvement, using podspec tag in plugin.xml URL: https://github.com/apache/cordova-ios/pull/405#issuecomment-420887773 Thanks! This can be reviewed and tested, but can't be accepted to be merged until the production release of cordova-com

[GitHub] knight9999 commented on issue #405: Cocoapods support improvement, using podspec tag in plugin.xml

2018-09-12 Thread GitBox
knight commented on issue #405: Cocoapods support improvement, using podspec tag in plugin.xml URL: https://github.com/apache/cordova-ios/pull/405#issuecomment-420884505 I have rebased master. The above comments are also updated. For tests, only `cordova-common` in `package.json

[GitHub] knight9999 edited a comment on issue #405: Cocoapods support improvement, using podspec tag in plugin.xml

2018-09-12 Thread GitBox
knight edited a comment on issue #405: Cocoapods support improvement, using podspec tag in plugin.xml URL: https://github.com/apache/cordova-ios/pull/405#issuecomment-420884505 I have rebased master. The above my comments are also updated. For tests, only `cordova-common` in `pa

[GitHub] knight9999 edited a comment on issue #405: Cocoapods support improvement, using podspec tag in plugin.xml

2018-09-12 Thread GitBox
knight edited a comment on issue #405: Cocoapods support improvement, using podspec tag in plugin.xml URL: https://github.com/apache/cordova-ios/pull/405#issuecomment-420650061 @shazron Thanks for testing, and I am sorry to trouble you. This PR depends on PR apache/cordova-common#48.

[cordova-apache-board-reports] branch master updated: Update 2018-09.md

2018-09-12 Thread shazron
This is an automated email from the ASF dual-hosted git repository. shazron pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-apache-board-reports.git The following commit(s) were added to refs/heads/master by this push: new 600bdc0 Update 2018-09.

[GitHub] vancuren commented on issue #114: Not working on Android devices

2018-09-12 Thread GitBox
vancuren commented on issue #114: Not working on Android devices URL: https://github.com/apache/cordova-plugin-geolocation/issues/114#issuecomment-420870399 Same issue. It's intermittently on S9 and Note 8 devices. This is an

[GitHub] ddsky commented on issue #329: Exif data lost when correctOrientation is true

2018-09-12 Thread GitBox
ddsky commented on issue #329: Exif data lost when correctOrientation is true URL: https://github.com/apache/cordova-plugin-camera/issues/329#issuecomment-420868725 Is there a roadmap on when this might be fixed? This is an a

[cordova-apache-board-reports] branch master updated: From template - to be filled in

2018-09-12 Thread shazron
This is an automated email from the ASF dual-hosted git repository. shazron pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-apache-board-reports.git The following commit(s) were added to refs/heads/master by this push: new 9a40c34 From template -

[cordova-apache-board-reports] branch master updated: Create 2018-09.md

2018-09-12 Thread shazron
This is an automated email from the ASF dual-hosted git repository. shazron pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-apache-board-reports.git The following commit(s) were added to refs/heads/master by this push: new add83e5 Create 2018-09.

[cordova-osx] branch master updated (cb425a9 -> 6395749)

2018-09-12 Thread erisu
This is an automated email from the ASF dual-hosted git repository. erisu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-osx.git. from cb425a9 Merge pull request #56 from erisu/test-framework-consistency add d40939e package.json use xcode@1

[GitHub] erisu closed pull request #57: package.json use xcode@1 (1.x.x)

2018-09-12 Thread GitBox
erisu closed pull request #57: package.json use xcode@1 (1.x.x) URL: https://github.com/apache/cordova-osx/pull/57 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[cordova-osx] 01/01: Merge pull request #57 from erisu/bump-xcode-dependency

2018-09-12 Thread erisu
This is an automated email from the ASF dual-hosted git repository. erisu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-osx.git commit 63957496470c07452d4b65d4e6637024658ae30d Merge: cb425a9 d40939e Author: エリス AuthorDate: Thu Sep 13 09:49:37 2018 +09

[cordova-osx] branch master updated (4f2915a -> cb425a9)

2018-09-12 Thread erisu
This is an automated email from the ASF dual-hosted git repository. erisu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-osx.git. from 4f2915a Upgrade cordova-common (#55) add e5616c8 package*.json migrate from jasmine-node to jasmine a

[cordova-osx] 01/01: Merge pull request #56 from erisu/test-framework-consistency

2018-09-12 Thread erisu
This is an automated email from the ASF dual-hosted git repository. erisu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-osx.git commit cb425a9940b1fea206bf2e8f23b795788ee1c820 Merge: 4f2915a 5553910 Author: エリス AuthorDate: Thu Sep 13 09:43:42 2018 +09

[GitHub] erisu closed pull request #56: Test framework consistency

2018-09-12 Thread GitBox
erisu closed pull request #56: Test framework consistency URL: https://github.com/apache/cordova-osx/pull/56 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from

[GitHub] erisu commented on issue #56: Test framework consistency

2018-09-12 Thread GitBox
erisu commented on issue #56: Test framework consistency URL: https://github.com/apache/cordova-osx/pull/56#issuecomment-420843191 @brodybits Since I have updated the dep. to reflect what we talked about, `"jasmine": "^3.2.0",` I will go ahead and merge this in after I fix the package-lock

[cordova-template-reference] branch deprecate created (now d18924b)

2018-09-12 Thread raphinesse
This is an automated email from the ASF dual-hosted git repository. raphinesse pushed a change to branch deprecate in repository https://gitbox.apache.org/repos/asf/cordova-template-reference.git. at d18924b Add deprecation notice to README This branch includes the following new commits

[cordova-template-reference] 01/01: Add deprecation notice to README

2018-09-12 Thread raphinesse
This is an automated email from the ASF dual-hosted git repository. raphinesse pushed a commit to branch deprecate in repository https://gitbox.apache.org/repos/asf/cordova-template-reference.git commit d18924b6fdecc4408a00dfbd5b7395c8ac993134 Author: Raphael von der Grün AuthorDate: Thu Sep 13

[GitHub] janpio commented on issue #199: Add previous patch dependency note

2018-09-12 Thread GitBox
janpio commented on issue #199: Add previous patch dependency note URL: https://github.com/apache/cordova-coho/pull/199#issuecomment-420826834 Does this only apply to tools? This is an automated message from the Apache Git Ser

[GitHub] janpio commented on a change in pull request #199: Add previous patch dependency note

2018-09-12 Thread GitBox
janpio commented on a change in pull request #199: Add previous patch dependency note URL: https://github.com/apache/cordova-coho/pull/199#discussion_r217216127 ## File path: docs/tools-release-process.md ## @@ -53,6 +53,8 @@ This document describes how to release all tool

[GitHub] janpio commented on a change in pull request #199: Add previous patch dependency note

2018-09-12 Thread GitBox
janpio commented on a change in pull request #199: Add previous patch dependency note URL: https://github.com/apache/cordova-coho/pull/199#discussion_r217216127 ## File path: docs/tools-release-process.md ## @@ -53,6 +53,8 @@ This document describes how to release all tool

[GitHub] brodybits opened a new pull request #199: Add previous patch dependency note

2018-09-12 Thread GitBox
brodybits opened a new pull request #199: Add previous patch dependency note URL: https://github.com/apache/cordova-coho/pull/199 for reference: - apache/cordova-osx#55 - apache/cordova-create#31 - https://lists.apache.org/thread.html/49fc931d20033465f7a2202e5f7009fa04d28bd856ac518

[GitHub] janpio commented on issue #55: Upgrade cordova common

2018-09-12 Thread GitBox
janpio commented on issue #55: Upgrade cordova common URL: https://github.com/apache/cordova-osx/pull/55#issuecomment-420824672 Nothing here that could block a merge - if there is a _better_ way to do things, this can be done in a new, additional PR anyway.

[GitHub] brodybits commented on issue #55: Upgrade cordova common

2018-09-12 Thread GitBox
brodybits commented on issue #55: Upgrade cordova common URL: https://github.com/apache/cordova-osx/pull/55#issuecomment-420824790 Fine with me This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] erisu commented on issue #55: Upgrade cordova common

2018-09-12 Thread GitBox
erisu commented on issue #55: Upgrade cordova common URL: https://github.com/apache/cordova-osx/pull/55#issuecomment-420824049 From the dev mailing list discussion, I believe it was decided to not use nightly builds. If this is correct can the PR now be accepted so we can fix at least the

[GitHub] mwargan closed issue #53: iPhone X initial height issue

2018-09-12 Thread GitBox
mwargan closed issue #53: iPhone X initial height issue URL: https://github.com/apache/cordova-plugin-wkwebview-engine/issues/53 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] mwargan commented on issue #53: iPhone X initial height issue

2018-09-12 Thread GitBox
mwargan commented on issue #53: iPhone X initial height issue URL: https://github.com/apache/cordova-plugin-wkwebview-engine/issues/53#issuecomment-420793382 My issue was related to #45 which has now been merged - so closing ;) --

[cordova-lib] branch start-9.0.0-dev deleted (was 133ee29)

2018-09-12 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a change to branch start-9.0.0-dev in repository https://gitbox.apache.org/repos/asf/cordova-lib.git. was 133ee29 Start 9.0.0-dev The revisions that were on this branch are still contained in other refere

[cordova-lib] branch master updated: Start 9.0.0-dev (#690)

2018-09-12 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-lib.git The following commit(s) were added to refs/heads/master by this push: new 87e9f5c Start 9.0.0-dev (#690) 87e9f5c

[GitHub] janpio commented on issue #183: Response time and play mp3 samples

2018-09-12 Thread GitBox
janpio commented on issue #183: Response time and play mp3 samples URL: https://github.com/apache/cordova-plugin-media/issues/183#issuecomment-420755003 What platform and plugin version? This is an automated message from the

[cordova-create] branch brodybits-readme-whitespace-cleanup-1 deleted (was 3467a89)

2018-09-12 Thread raphinesse
This is an automated email from the ASF dual-hosted git repository. raphinesse pushed a change to branch brodybits-readme-whitespace-cleanup-1 in repository https://gitbox.apache.org/repos/asf/cordova-create.git. was 3467a89 README.md remove trailing whitespace The revisions that were on

[cordova-create] branch master updated: README.md remove trailing whitespace (#29)

2018-09-12 Thread raphinesse
This is an automated email from the ASF dual-hosted git repository. raphinesse pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-create.git The following commit(s) were added to refs/heads/master by this push: new 987b3da README.md remove trailing w

[cordova-create] branch master updated: Fix version in package-lock.json (#30)

2018-09-12 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-create.git The following commit(s) were added to refs/heads/master by this push: new f40c995 Fix version in package-lock.

[cordova-create] 01/01: README.md remove trailing whitespace

2018-09-12 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch brodybits-readme-whitespace-cleanup-1 in repository https://gitbox.apache.org/repos/asf/cordova-create.git commit 3467a8998c4f3c97c6711538beaddf73a43ec19a Author: Chris Brody AuthorDate: Wed S

[cordova-create] branch brodybits-readme-whitespace-cleanup-1 created (now 3467a89)

2018-09-12 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a change to branch brodybits-readme-whitespace-cleanup-1 in repository https://gitbox.apache.org/repos/asf/cordova-create.git. at 3467a89 README.md remove trailing whitespace This branch includes the fol

[cordova-create] branch master updated: Commit package-lock.json (#28)

2018-09-12 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-create.git The following commit(s) were added to refs/heads/master by this push: new cf4a88a Commit package-lock.json (#2

[GitHub] brodybits commented on issue #4: Commit package-lock.json

2018-09-12 Thread GitBox
brodybits commented on issue #4: Commit package-lock.json URL: https://github.com/apache/cordova/issues/4#issuecomment-420728477 FYI agreement was already reached in [[1]](https://lists.apache.org/thread.html/7f92561d382f143aaf49e083bbe215dcf95a3f4d8b6e3cbb6089a5f3@%3Cdev.cordova.apache.org

[GitHub] brodybits commented on issue #3: Define how Cordova handles `package-lock.json`

2018-09-12 Thread GitBox
brodybits commented on issue #3: Define how Cordova handles `package-lock.json` URL: https://github.com/apache/cordova/issues/3#issuecomment-420726868 FYI we had already reached agreement in [[1]](https://lists.apache.org/thread.html/7f92561d382f143aaf49e083bbe215dcf95a3f4d8b6e3cbb6089a5f3@

[cordova-create] branch master updated: Mark 2.0.0-dev (major update) (#27)

2018-09-12 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-create.git The following commit(s) were added to refs/heads/master by this push: new 234e523 Mark 2.0.0-dev (major update

[cordova-create] branch brodybits-mark-2.0.0-dev deleted (was 20ad01f)

2018-09-12 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a change to branch brodybits-mark-2.0.0-dev in repository https://gitbox.apache.org/repos/asf/cordova-create.git. was 20ad01f Mark 2.0.0-dev (major update) The revisions that were on this branch are still

[cordova-create] branch brodybits-mark-2.0.0-dev created (now 20ad01f)

2018-09-12 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a change to branch brodybits-mark-2.0.0-dev in repository https://gitbox.apache.org/repos/asf/cordova-create.git. at 20ad01f Mark 2.0.0-dev (major update) This branch includes the following new commits:

[cordova-create] 01/01: Mark 2.0.0-dev (major update)

2018-09-12 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch brodybits-mark-2.0.0-dev in repository https://gitbox.apache.org/repos/asf/cordova-create.git commit 20ad01fb552021e184205579da215f907bebe9bc Author: Chris Brody AuthorDate: Wed Sep 12 11:49:0

[GitHub] grinmax opened a new issue #183: Response time and play mp3 samples

2018-09-12 Thread GitBox
grinmax opened a new issue #183: Response time and play mp3 samples URL: https://github.com/apache/cordova-plugin-media/issues/183 Hi Guys, help us please. I have two problems when I use this plugin: 1. I can not play one and the same mp3 parallel and at the same time 2. I can n

[GitHub] ffMathy commented on issue #100: CB-13683: (android) cordova-plugin-media-capture rotates pictures with some devices

2018-09-12 Thread GitBox
ffMathy commented on issue #100: CB-13683: (android) cordova-plugin-media-capture rotates pictures with some devices URL: https://github.com/apache/cordova-plugin-media-capture/pull/100#issuecomment-420687143 It has been 19 days and this fixes a critical issue. Can we merge it? --

[GitHub] alan-grixti commented on issue #296: App freezing after opening the InAppBrowser on specific URLs / Inputs

2018-09-12 Thread GitBox
alan-grixti commented on issue #296: App freezing after opening the InAppBrowser on specific URLs / Inputs URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/296#issuecomment-420675129 Sadly no, this issue is still present in version 2.0.2. -

[cordova-docs] branch master updated: About SwiftSupport

2018-09-12 Thread dpogue
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-docs.git The following commit(s) were added to refs/heads/master by this push: new e887138 About SwiftSupport e887138 is des

[GitHub] dpogue closed pull request #880: About SwiftSupport

2018-09-12 Thread GitBox
dpogue closed pull request #880: About SwiftSupport URL: https://github.com/apache/cordova-docs/pull/880 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fo

[GitHub] dpogue closed pull request #406: Added Back Missing unorm Dependency

2018-09-12 Thread GitBox
dpogue closed pull request #406: Added Back Missing unorm Dependency URL: https://github.com/apache/cordova-ios/pull/406 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull re

[cordova-ios] 01/01: Merge pull request #406 from erisu/add-missing-unorm-dependency

2018-09-12 Thread dpogue
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-ios.git commit 11170612a51b9cbeb32f550e6a07791ac7814646 Merge: ff1bcd0 aea6b4a Author: Darryl Pogue AuthorDate: Wed Sep 12 07:05:2

[cordova-ios] branch master updated (ff1bcd0 -> 1117061)

2018-09-12 Thread dpogue
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-ios.git. from ff1bcd0 Merge pull request #388 from brodybits/cb-14242-remove-bundled-dependencies-and-node-modules add

[GitHub] brodybits commented on issue #884: Embedding Android WebView doc looks broken

2018-09-12 Thread GitBox
brodybits commented on issue #884: Embedding Android WebView doc looks broken URL: https://github.com/apache/cordova-docs/issues/884#issuecomment-420660027 ref: - -

[GitHub] brodybits closed pull request #883: Full android.util.Config class name for Android

2018-09-12 Thread GitBox
brodybits closed pull request #883: Full android.util.Config class name for Android URL: https://github.com/apache/cordova-docs/pull/883 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] brodybits commented on issue #883: Full android.util.Config class name for Android

2018-09-12 Thread GitBox
brodybits commented on issue #883: Full android.util.Config class name for Android URL: https://github.com/apache/cordova-docs/pull/883#issuecomment-420659552 Does not look right to me, closing ref: #884 This is an automated

[GitHub] brodybits opened a new issue #884: Embedding Android WebView doc looks broken

2018-09-12 Thread GitBox
brodybits opened a new issue #884: Embedding Android WebView doc looks broken URL: https://github.com/apache/cordova-docs/issues/884 **Issue Type** [x] Bug [ ] Feature Request **Priority** [ ] Minor [x] Major [ ] Critical [ ] Blocker **Environment*

[GitHub] brodybits opened a new pull request #883: Full android.util.Config class name for Android

2018-09-12 Thread GitBox
brodybits opened a new pull request #883: Full android.util.Config class name for Android URL: https://github.com/apache/cordova-docs/pull/883 in embedding Android webview doc to avoid the following potential pitfalls: - use of "config" with small 'c' - failure to explicitly im

[GitHub] knight9999 edited a comment on issue #405: Cocoapods support improvement, using podspec tag in plugin.xml

2018-09-12 Thread GitBox
knight edited a comment on issue #405: Cocoapods support improvement, using podspec tag in plugin.xml URL: https://github.com/apache/cordova-ios/pull/405#issuecomment-420650061 @shazron Thanks for testing, and I am sorry to trouble you. This PR depends on PR apache/cordova-common#48.

[GitHub] knight9999 commented on issue #405: Cocoapods support improvement, using podspec tag in plugin.xml

2018-09-12 Thread GitBox
knight commented on issue #405: Cocoapods support improvement, using podspec tag in plugin.xml URL: https://github.com/apache/cordova-ios/pull/405#issuecomment-420650061 @shazron Thanks for testing, and I am sorry to trouble you. This PR depends other PR apache/cordova-common#48.

svn commit: r1840670 - in /cordova/site/public: docs/en/dev/guide/cli/template.html feed.xml

2018-09-12 Thread steven
Author: steven Date: Wed Sep 12 12:25:01 2018 New Revision: 1840670 URL: http://svn.apache.org/viewvc?rev=1840670&view=rev Log: Updated docs Modified: cordova/site/public/docs/en/dev/guide/cli/template.html cordova/site/public/feed.xml Modified: cordova/site/public/docs/en/dev/guide/cli/

[GitHub] shazron commented on issue #49: CB-12815: (ios) Fix bug nativeCallback not executed when app is in background

2018-09-12 Thread GitBox
shazron commented on issue #49: CB-12815: (ios) Fix bug nativeCallback not executed when app is in background URL: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/49#issuecomment-420626748 @jcesarmobile see the [JIRA Issue](https://issues.apache.org/jira/browse/CB-12815?foc

[cordova-docs] branch master updated: Link to cordova-app-hello-world as template reference (#882)

2018-09-12 Thread raphinesse
This is an automated email from the ASF dual-hosted git repository. raphinesse pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-docs.git The following commit(s) were added to refs/heads/master by this push: new 597b760 Link to cordova-app-hello-wor

[GitHub] raphinesse closed pull request #882: Link to cordova-app-hello-world as template reference

2018-09-12 Thread GitBox
raphinesse closed pull request #882: Link to cordova-app-hello-world as template reference URL: https://github.com/apache/cordova-docs/pull/882 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As t

[cordova-android] branch master updated: Update comments (#496)

2018-09-12 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git The following commit(s) were added to refs/heads/master by this push: new 73edf4d Update comments (#496) 73ed

[cordova] branch master updated: Deprecate template-reference in favor of app-hello-world (#11)

2018-09-12 Thread raphinesse
This is an automated email from the ASF dual-hosted git repository. raphinesse pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova.git The following commit(s) were added to refs/heads/master by this push: new 700fc05 Deprecate template-reference in fa

[cordova-android] branch brodybits-gradle-patch-1 deleted (was 905acf8)

2018-09-12 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a change to branch brodybits-gradle-patch-1 in repository https://gitbox.apache.org/repos/asf/cordova-android.git. was 905acf8 Update comments The revisions that were on this branch are still contained in

[GitHub] raphinesse closed pull request #11: Deprecate template-reference in favor of app-hello-world

2018-09-12 Thread GitBox
raphinesse closed pull request #11: Deprecate template-reference in favor of app-hello-world URL: https://github.com/apache/cordova/pull/11 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] brodybits closed pull request #496: Update comments in build.gradle

2018-09-12 Thread GitBox
brodybits closed pull request #496: Update comments in build.gradle URL: https://github.com/apache/cordova-android/pull/496 This is an automated message from the Apache Git Service. To respond to the message, please log on Gi

[cordova-app-hello-world] branch master updated: Absorb cordova-template-reference (#24)

2018-09-12 Thread raphinesse
This is an automated email from the ASF dual-hosted git repository. raphinesse pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-app-hello-world.git The following commit(s) were added to refs/heads/master by this push: new 427a987 Absorb cordova-tem

[GitHub] brodybits commented on a change in pull request #56: Test framework consistency

2018-09-12 Thread GitBox
brodybits commented on a change in pull request #56: Test framework consistency URL: https://github.com/apache/cordova-osx/pull/56#discussion_r216998464 ## File path: package.json ## @@ -41,7 +41,7 @@ "eslint-plugin-node": "^5.0.0", "eslint-plugin-promise": "^3.5.

[GitHub] raphinesse opened a new issue #58: Release version 5.0.0

2018-09-12 Thread GitBox
raphinesse opened a new issue #58: Release version 5.0.0 URL: https://github.com/apache/cordova-osx/issues/58 This issue should list all tasks that need to be completed in before forking off a release branch for the next major version. ## Tasks - [ ] Update dependencies

[GitHub] brodybits commented on a change in pull request #56: Test framework consistency

2018-09-12 Thread GitBox
brodybits commented on a change in pull request #56: Test framework consistency URL: https://github.com/apache/cordova-osx/pull/56#discussion_r216997822 ## File path: package.json ## @@ -41,7 +41,7 @@ "eslint-plugin-node": "^5.0.0", "eslint-plugin-promise": "^3.5.

[GitHub] erisu edited a comment on issue #55: Upgrade cordova common

2018-09-12 Thread GitBox
erisu edited a comment on issue #55: Upgrade cordova common URL: https://github.com/apache/cordova-osx/pull/55#issuecomment-420614221 @brodybits There is no `cordova-common@3` in the NPM registry. I can't change it to something that doesn't exist. Also, if this PR is not pushed, then

[GitHub] brodybits commented on issue #55: Upgrade cordova common

2018-09-12 Thread GitBox
brodybits commented on issue #55: Upgrade cordova common URL: https://github.com/apache/cordova-osx/pull/55#issuecomment-420616731 Since cordova-common@3.0.0-nightly versions are already published, I would suggest the following alternatives: - cordova-common@3.0.x - cordova-common@3.x

[GitHub] erisu edited a comment on issue #55: Upgrade cordova common

2018-09-12 Thread GitBox
erisu edited a comment on issue #55: Upgrade cordova common URL: https://github.com/apache/cordova-osx/pull/55#issuecomment-420614221 @brodybits There is no `cordova-common@3` in the NPM registry. I cant change it to something that doesn't exist. Also, if this PR is not pushed, th

[GitHub] erisu edited a comment on issue #55: Upgrade cordova common

2018-09-12 Thread GitBox
erisu edited a comment on issue #55: Upgrade cordova common URL: https://github.com/apache/cordova-osx/pull/55#issuecomment-420614221 There is no cordova-common@3 in the NPM registry. If I do that now, then tests will fail. If this PR is not pushed, then NPM audit will always show secur

[GitHub] brodybits opened a new pull request #497: Better cdvMinSdkVersion fix in build.gradle

2018-09-12 Thread GitBox
brodybits opened a new pull request #497: Better cdvMinSdkVersion fix in build.gradle URL: https://github.com/apache/cordova-android/pull/497 Second followup to GH-495 NOT TESTED, needs review This is an automated mess

[cordova-android] branch brodybits-gradle-patch-2 created (now 80b0134)

2018-09-12 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a change to branch brodybits-gradle-patch-2 in repository https://gitbox.apache.org/repos/asf/cordova-android.git. at 80b0134 Better cdvMinSdkVersion fix in build.gradle This branch includes the followin

[cordova-android] 01/01: Better cdvMinSdkVersion fix in build.gradle

2018-09-12 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch brodybits-gradle-patch-2 in repository https://gitbox.apache.org/repos/asf/cordova-android.git commit 80b0134bace72a9d6f1a7c6912e61f0bac098558 Author: Chris Brody AuthorDate: Wed Sep 12 07:31:

[GitHub] raphinesse opened a new pull request #11: Deprecate template-reference in favor of app-hello-world

2018-09-12 Thread GitBox
raphinesse opened a new pull request #11: Deprecate template-reference in favor of app-hello-world URL: https://github.com/apache/cordova/pull/11 See https://github.com/apache/cordova-discuss/issues/91 This is an automated me

[GitHub] erisu edited a comment on issue #55: Upgrade cordova common

2018-09-12 Thread GitBox
erisu edited a comment on issue #55: Upgrade cordova common URL: https://github.com/apache/cordova-osx/pull/55#issuecomment-420614221 There is no cordova-common@3 in the NPM registry. If I do that now, then tests will fail. If this PR is not pushed, then NPM audit will always show secur

[GitHub] brodybits opened a new pull request #496: Update comments in build.gradle

2018-09-12 Thread GitBox
brodybits opened a new pull request #496: Update comments in build.gradle URL: https://github.com/apache/cordova-android/pull/496 as followup to GH-495 This is an automated message from the Apache Git Service. To respond to th

[cordova-android] 01/01: Update comments

2018-09-12 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch brodybits-gradle-patch-1 in repository https://gitbox.apache.org/repos/asf/cordova-android.git commit 905acf852fbaff758ef8f17b869c3d187b44cc24 Author: Chris Brody AuthorDate: Wed Sep 12 07:27:

[GitHub] erisu commented on issue #55: Upgrade cordova common

2018-09-12 Thread GitBox
erisu commented on issue #55: Upgrade cordova common URL: https://github.com/apache/cordova-osx/pull/55#issuecomment-420614221 There is no common@3 in the NPM registry. If I do that now, then tests will fail. If this PR is not pushed, then NPM audit will always show security risk until

[cordova-android] branch brodybits-gradle-patch-1 created (now 905acf8)

2018-09-12 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a change to branch brodybits-gradle-patch-1 in repository https://gitbox.apache.org/repos/asf/cordova-android.git. at 905acf8 Update comments This branch includes the following new commits: new 905

[GitHub] erisu commented on a change in pull request #56: Test framework consistency

2018-09-12 Thread GitBox
erisu commented on a change in pull request #56: Test framework consistency URL: https://github.com/apache/cordova-osx/pull/56#discussion_r216991838 ## File path: package.json ## @@ -41,7 +41,7 @@ "eslint-plugin-node": "^5.0.0", "eslint-plugin-promise": "^3.5.0",

[GitHub] erisu commented on a change in pull request #56: Test framework consistency

2018-09-12 Thread GitBox
erisu commented on a change in pull request #56: Test framework consistency URL: https://github.com/apache/cordova-osx/pull/56#discussion_r216991838 ## File path: package.json ## @@ -41,7 +41,7 @@ "eslint-plugin-node": "^5.0.0", "eslint-plugin-promise": "^3.5.0",

[GitHub] brodybits commented on issue #495: Incorrect default sdk version issue fix

2018-09-12 Thread GitBox
brodybits commented on issue #495: Incorrect default sdk version issue fix URL: https://github.com/apache/cordova-android/pull/495#issuecomment-420611996 The change looks right, thanks. I edited the description to update the checklist and automatically close #489 as resolved. -

[cordova-android] branch master updated (eadcd33 -> cfa58a5)

2018-09-12 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git. from eadcd33 Merge pull request #493 from raphinesse/remove-bundled-dependencies add 905bff3 Incorrect

[cordova-android] 01/01: Merge pull request #495 from Darshan-Chauhan/incorrect-default-sdk-version

2018-09-12 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git commit cfa58a5661184e868091ba9640bc7f1bc7148446 Merge: eadcd33 905bff3 Author: Chris Brody AuthorDate: Wed Sep 12 0

[GitHub] brodybits closed issue #489: Incorrect default min SDK version ternary in build.gradle

2018-09-12 Thread GitBox
brodybits closed issue #489: Incorrect default min SDK version ternary in build.gradle URL: https://github.com/apache/cordova-android/issues/489 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] brodybits closed pull request #495: Incorrect default sdk version issue fix

2018-09-12 Thread GitBox
brodybits closed pull request #495: Incorrect default sdk version issue fix URL: https://github.com/apache/cordova-android/pull/495 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fore

[GitHub] raphinesse opened a new pull request #882: Link to cordova-app-hello-world as template reference

2018-09-12 Thread GitBox
raphinesse opened a new pull request #882: Link to cordova-app-hello-world as template reference URL: https://github.com/apache/cordova-docs/pull/882 See https://github.com/apache/cordova-discuss/issues/91 This is an automate

[GitHub] brodybits commented on a change in pull request #56: Test framework consistency

2018-09-12 Thread GitBox
brodybits commented on a change in pull request #56: Test framework consistency URL: https://github.com/apache/cordova-osx/pull/56#discussion_r216988067 ## File path: package.json ## @@ -41,7 +41,7 @@ "eslint-plugin-node": "^5.0.0", "eslint-plugin-promise": "^3.5.

[GitHub] codecov-io edited a comment on issue #406: Added Back Missing unorm Dependency

2018-09-12 Thread GitBox
codecov-io edited a comment on issue #406: Added Back Missing unorm Dependency URL: https://github.com/apache/cordova-ios/pull/406#issuecomment-420603050 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/406?src=pr&el=h1) Report > Merging [#406](https://codecov.io/gh/apache/cord

[GitHub] codecov-io commented on issue #406: Added Back Missing unorm Dependency

2018-09-12 Thread GitBox
codecov-io commented on issue #406: Added Back Missing unorm Dependency URL: https://github.com/apache/cordova-ios/pull/406#issuecomment-420603050 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/406?src=pr&el=h1) Report > Merging [#406](https://codecov.io/gh/apache/cordova-ios

[GitHub] erisu opened a new pull request #406: Added Back Missing unorm Dependency

2018-09-12 Thread GitBox
erisu opened a new pull request #406: Added Back Missing unorm Dependency URL: https://github.com/apache/cordova-ios/pull/406 ### Platforms affected ios ### What does this PR do? The goal of this PR is to re-add the missing dependency so cordova-ios does not fail with cordova-c

[GitHub] brodybits commented on issue #494: Change from CordovaWebView to SystemWebView in latest Cordova not working

2018-09-12 Thread GitBox
brodybits commented on issue #494: Change from CordovaWebView to SystemWebView in latest Cordova not working URL: https://github.com/apache/cordova-android/issues/494#issuecomment-420595583 > but it's not present in latest version of Cordova. So I changed to it by below lines This l

[GitHub] jcesarmobile commented on issue #49: CB-12815: (ios) Fix bug nativeCallback not executed when app is in background

2018-09-12 Thread GitBox
jcesarmobile commented on issue #49: CB-12815: (ios) Fix bug nativeCallback not executed when app is in background URL: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/49#issuecomment-420590640 Why is the promise needed? isn't it enough just to remove the setTimeout? --

[GitHub] si-harps edited a comment on issue #182: iOS - Playback failure from device filesystem

2018-09-12 Thread GitBox
si-harps edited a comment on issue #182: iOS - Playback failure from device filesystem URL: https://github.com/apache/cordova-plugin-media/issues/182#issuecomment-420588699 Thanks for the quick response. Yes i am able to open the file using a link in the application, also via the browser

  1   2   >