[cordova-lib] branch master updated: Add Electron Platform (#744)

2018-12-10 Thread erisu
This is an automated email from the ASF dual-hosted git repository. erisu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-lib.git The following commit(s) were added to refs/heads/master by this push: new a478ce3 Add Electron Platform (#744)

[cordova-lib] branch master updated: Updated Platform Config Git URL Paths (#743)

2018-12-10 Thread erisu
This is an automated email from the ASF dual-hosted git repository. erisu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-lib.git The following commit(s) were added to refs/heads/master by this push: new a8a8671 Updated Platform Config Git URL

[cordova-apache-board-reports] branch master updated: Update 2018-12.md

2018-12-10 Thread shazron
This is an automated email from the ASF dual-hosted git repository. shazron pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-apache-board-reports.git The following commit(s) were added to refs/heads/master by this push: new cfbd065 Update

[cordova-apache-board-reports] branch master updated: Update README.md

2018-12-10 Thread shazron
This is an automated email from the ASF dual-hosted git repository. shazron pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-apache-board-reports.git The following commit(s) were added to refs/heads/master by this push: new b983c92 Update

[GitHub] keenan35i commented on issue #359: beforeload causing POST failure

2018-12-10 Thread GitBox
keenan35i commented on issue #359: beforeload causing POST failure URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/359#issuecomment-445983506 Just tested it seems to be working great, `POST` is ignored when `beforeload=get`.

[GitHub] keenan35i commented on issue #359: beforeload causing POST failure

2018-12-10 Thread GitBox
keenan35i commented on issue #359: beforeload causing POST failure URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/359#issuecomment-445974404 ah ok thanks, will test it out and let you know if it works for my app.

[GitHub] dpa99c commented on issue #359: beforeload causing POST failure

2018-12-10 Thread GitBox
dpa99c commented on issue #359: beforeload causing POST failure URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/359#issuecomment-445972876 Don't be misled by the name: the repo is called `cordova-plugin-themeablebrowser` because it's originally a fork of

[GitHub] keenan35i commented on issue #359: beforeload causing POST failure

2018-12-10 Thread GitBox
keenan35i commented on issue #359: beforeload causing POST failure URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/359#issuecomment-445953515 The link you provided is for themeable browser plugin not in app browser plugin?

[GitHub] dpogue commented on issue #417: Keyboard Dismissal Leaves Viewport Shifted in iOS 12 / XCode 10

2018-12-10 Thread GitBox
dpogue commented on issue #417: Keyboard Dismissal Leaves Viewport Shifted in iOS 12 / XCode 10 URL: https://github.com/apache/cordova-ios/issues/417#issuecomment-445952665 In an attempt to bump up the priority on this, I've also filed https://bugs.webkit.org/show_bug.cgi?id=192564

[GitHub] ehorodyski commented on issue #470: InAppBrowser + Keyboard Issue XCode 10

2018-12-10 Thread GitBox
ehorodyski commented on issue #470: InAppBrowser + Keyboard Issue XCode 10 URL: https://github.com/apache/cordova-ios/issues/470#issuecomment-445945596 > Please understand that having an additional Ionic (Native) layer in the reproduction sample increases complexity and might hinder

[GitHub] janpio commented on issue #470: InAppBrowser + Keyboard Issue XCode 10

2018-12-10 Thread GitBox
janpio commented on issue #470: InAppBrowser + Keyboard Issue XCode 10 URL: https://github.com/apache/cordova-ios/issues/470#issuecomment-445931983 Please understand that having an additional Ionic (Native) layer in the reproduction sample increases complexity and might hinder another user

[GitHub] ehorodyski commented on issue #470: InAppBrowser + Keyboard Issue XCode 10

2018-12-10 Thread GitBox
ehorodyski commented on issue #470: InAppBrowser + Keyboard Issue XCode 10 URL: https://github.com/apache/cordova-ios/issues/470#issuecomment-445922914 > Ok, so this is an Ionic project that reproduces the problem. Yes, you've annotated the lines correctly. Because the issue is

[GitHub] janpio edited a comment on issue #470: InAppBrowser + Keyboard Issue XCode 10

2018-12-10 Thread GitBox
janpio edited a comment on issue #470: InAppBrowser + Keyboard Issue XCode 10 URL: https://github.com/apache/cordova-ios/issues/470#issuecomment-445920615 Ok, so this is an Ionic project that reproduces the problem.

[GitHub] janpio commented on issue #470: InAppBrowser + Keyboard Issue XCode 10

2018-12-10 Thread GitBox
janpio commented on issue #470: InAppBrowser + Keyboard Issue XCode 10 URL: https://github.com/apache/cordova-ios/issues/470#issuecomment-445920615 Ok, so this is an Ionic project that reproduces the problem. This is an

[GitHub] dpa99c commented on issue #362: (iOS & Android) Add postMessage API support

2018-12-10 Thread GitBox
dpa99c commented on issue #362: (iOS & Android) Add postMessage API support URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/362#issuecomment-445886901 The Travis CI tests seem quite flaky: another couple of failures for no good reason 

[GitHub] dpa99c commented on issue #359: beforeload causing POST failure

2018-12-10 Thread GitBox
dpa99c commented on issue #359: beforeload causing POST failure URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/359#issuecomment-445885267 I've created a PR to address the cause of this issue and to leave the future possibility open of supporting interception of POST

[GitHub] dpa99c opened a new pull request #367: GH-359: Fix beforeload to work with POST requests

2018-12-10 Thread GitBox
dpa99c opened a new pull request #367: GH-359: Fix beforeload to work with POST requests URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/367 ### Platforms affected iOS and Android ### What does this PR do? Fixes the behaviour of `beforeload` to resolve the

[GitHub] janpio commented on issue #366: Create an issue template

2018-12-10 Thread GitBox
janpio commented on issue #366: Create an issue template URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/366#issuecomment-445881843 The first link I commented includes the templates, the are pretty much ready. I am currently just blocked by not wanting to copy that to 30

[GitHub] dpa99c commented on issue #366: Create an issue template

2018-12-10 Thread GitBox
dpa99c commented on issue #366: Create an issue template URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/366#issuecomment-445880313 I'll leave it up to you guys since it looks like you're developing a standardised template for all the Cordova plugins, so I wouldn't want

[GitHub] janpio commented on issue #366: Create an issue template

2018-12-10 Thread GitBox
janpio commented on issue #366: Create an issue template URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/366#issuecomment-445879046 If you are in a hurry, feel free to create a PR adding those here yourself, that can be merged pretty quickly. Thanks.

[GitHub] dpa99c commented on issue #359: beforeload causing POST failure

2018-12-10 Thread GitBox
dpa99c commented on issue #359: beforeload causing POST failure URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/359#issuecomment-445862917 OK, I've figured it out: on Android `shouldOverrideUrlLoading()` is not called on initial navigation (to the initial URL passed in

[GitHub] janpio commented on issue #30: Add two version badges

2018-12-10 Thread GitBox
janpio commented on issue #30: Add two version badges URL: https://github.com/apache/cordova-plugin-test-framework/pull/30#issuecomment-445852137 Forgotten to publish on npm. Happens. The badge makes sure people will ask about the mismatch.

[GitHub] oliversalzburg commented on issue #30: Add two version badges

2018-12-10 Thread GitBox
oliversalzburg commented on issue #30: Add two version badges URL: https://github.com/apache/cordova-plugin-test-framework/pull/30#issuecomment-445850210 Oh, I see. Would there be any reason why that would be different from the npm version though?

[GitHub] janpio closed issue #603: black screen after build success with cocoon ads android admob plugin

2018-12-10 Thread GitBox
janpio closed issue #603: black screen after build success with cocoon ads android admob plugin URL: https://github.com/apache/cordova-android/issues/603 This is an automated message from the Apache Git Service. To respond

[GitHub] janpio commented on issue #603: black screen after build success with cocoon ads android admob plugin

2018-12-10 Thread GitBox
janpio commented on issue #603: black screen after build success with cocoon ads android admob plugin URL: https://github.com/apache/cordova-android/issues/603#issuecomment-445839170 That sounds like a problem with the plugin then - please report it to their GitHub repo. Feel free to open

[GitHub] krestia commented on issue #603: black screen after build success with cocoon ads android admob plugin

2018-12-10 Thread GitBox
krestia commented on issue #603: black screen after build success with cocoon ads android admob plugin URL: https://github.com/apache/cordova-android/issues/603#issuecomment-445813336 > Is this reproducible in a new, plain Cordova app? A minimal reproduction repository would really help

[GitHub] janpio commented on issue #603: black screen after build success with cocoon ads android admob plugin

2018-12-10 Thread GitBox
janpio commented on issue #603: black screen after build success with cocoon ads android admob plugin URL: https://github.com/apache/cordova-android/issues/603#issuecomment-445798689 Is this reproducible in a new, plain Cordova app? A minimal reproduction repository would really help to

[GitHub] janpio commented on issue #603: black screen after build success with cocoon ads android admob plugin

2018-12-10 Thread GitBox
janpio commented on issue #603: black screen after build success with cocoon ads android admob plugin URL: https://github.com/apache/cordova-android/issues/603#issuecomment-445798610 That is the reason why there are newer versions of `cordova-android` - fixing stuff that is now broken

[GitHub] krestia edited a comment on issue #603: black screen after build success with cocoon ads android admob plugin

2018-12-10 Thread GitBox
krestia edited a comment on issue #603: black screen after build success with cocoon ads android admob plugin URL: https://github.com/apache/cordova-android/issues/603#issuecomment-445791082 > `cordova-android` moved a lot of stuff around, plugins have to support that. > Did it work

[GitHub] Carlosps commented on issue #393: allowEdit not working when sourceType is PHOTOLIBRARY

2018-12-10 Thread GitBox
Carlosps commented on issue #393: allowEdit not working when sourceType is PHOTOLIBRARY URL: https://github.com/apache/cordova-plugin-camera/issues/393#issuecomment-445794223 Any updates on that? This is an automated

[GitHub] bharathikannano opened a new issue #221: IOS 12 file download says file corrpted

2018-12-10 Thread GitBox
bharathikannano opened a new issue #221: IOS 12 file download says file corrpted URL: https://github.com/apache/cordova-plugin-file-transfer/issues/221 hi while downloading file in ios 12 devices, after downloading opeing a pdf file it says file corrupted. help me to close this

[GitHub] krestia commented on issue #603: black screen after build success with cocoon ads android admob plugin

2018-12-10 Thread GitBox
krestia commented on issue #603: black screen after build success with cocoon ads android admob plugin URL: https://github.com/apache/cordova-android/issues/603#issuecomment-445791082 > `cordova-android` moved a lot of stuff around, plugins have to support that. > Did it work with

[GitHub] dpa99c commented on issue #366: Create an issue template

2018-12-10 Thread GitBox
dpa99c commented on issue #366: Create an issue template URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/366#issuecomment-445789286 That will be a massive help This is an automated message from the Apache

[GitHub] janpio edited a comment on issue #366: Create an issue template

2018-12-10 Thread GitBox
janpio edited a comment on issue #366: Create an issue template URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/366#issuecomment-445788541 Work is in progress for this: https://github.com/apache/cordova-contribute/blob/master/github-templates.md You can test these

[GitHub] janpio commented on issue #366: Create an issue template

2018-12-10 Thread GitBox
janpio commented on issue #366: Create an issue template URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/366#issuecomment-445788541 Work is in progress for this: https://github.com/apache/cordova-contribute/blob/master/github-templates.md This part here is missing:

[GitHub] janpio commented on issue #603: black screen after build success with cocoon ads android admob plugin

2018-12-10 Thread GitBox
janpio commented on issue #603: black screen after build success with cocoon ads android admob plugin URL: https://github.com/apache/cordova-android/issues/603#issuecomment-445774576 `cordova-android` moved a lot of stuff around, plugins have to support that. Did it work with

[GitHub] krestia commented on issue #603: black screen after build success with cocoon ads android admob plugin

2018-12-10 Thread GitBox
krestia commented on issue #603: black screen after build success with cocoon ads android admob plugin URL: https://github.com/apache/cordova-android/issues/603#issuecomment-445772468 > Did this work with an earlier version of `cordova-android`? yes, i was build with cordova 8.0.0,

[GitHub] janpio commented on issue #603: black screen after build success with cocoon ads android admob plugin

2018-12-10 Thread GitBox
janpio commented on issue #603: black screen after build success with cocoon ads android admob plugin URL: https://github.com/apache/cordova-android/issues/603#issuecomment-445770847 Did this work with an earlier version of `cordova-android`?

[GitHub] janpio closed issue #173: how to add video in splash screen? Is there any way to add it?

2018-12-10 Thread GitBox
janpio closed issue #173: how to add video in splash screen? Is there any way to add it? URL: https://github.com/apache/cordova-plugin-splashscreen/issues/173 This is an automated message from the Apache Git Service. To

[GitHub] janpio commented on issue #173: how to add video in splash screen? Is there any way to add it?

2018-12-10 Thread GitBox
janpio commented on issue #173: how to add video in splash screen? Is there any way to add it? URL: https://github.com/apache/cordova-plugin-splashscreen/issues/173#issuecomment-445770451 This plugin doesn't support video.

[GitHub] dpa99c commented on issue #364: open url about:blank doest trigger events

2018-12-10 Thread GitBox
dpa99c commented on issue #364: open url about:blank doest trigger events URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/364#issuecomment-445756074 Can you give some more information: - What platform were you testing on? (e.g iOS, Android) - What platform

[GitHub] dpa99c opened a new issue #366: Create an issue template

2018-12-10 Thread GitBox
dpa99c opened a new issue #366: Create an issue template URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/366 Currently this repo has a [PR template](https://github.com/apache/cordova-plugin-inappbrowser/blob/master/.github/PULL_REQUEST_TEMPLATE.md) but not an issues

[GitHub] merbin2012 opened a new issue #365: ERR_UNKNOWN_URL_SCHEME while access external css js file

2018-12-10 Thread GitBox
merbin2012 opened a new issue #365: ERR_UNKNOWN_URL_SCHEME while access external css js file URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/365 I have opened a .html file from file manager and it will return the following url

[GitHub] erisu closed issue #391: CocoaPods Improvement

2018-12-10 Thread GitBox
erisu closed issue #391: CocoaPods Improvement URL: https://github.com/apache/cordova-ios/issues/391 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] erisu commented on issue #391: CocoaPods Improvement

2018-12-10 Thread GitBox
erisu commented on issue #391: CocoaPods Improvement URL: https://github.com/apache/cordova-ios/issues/391#issuecomment-445726889 Closing out the ticket as all related PRs had been merged. This should be made available when Cordova 9 has been released.