breautek commented on issue #189: Variable for Require GPS Hardware
URL:
https://github.com/apache/cordova-plugin-geolocation/pull/189#issuecomment-600626552
All green. Thanks @timbru31 for taking the time to review :tada:
T
breautek commented on issue #189: Variable for Require GPS Hardware
URL:
https://github.com/apache/cordova-plugin-geolocation/pull/189#issuecomment-600617365
> Besides the small README suggestion, LGTM!
> I've done a quick test, the AndroidManifest file is changed as expected.
>
>
breautek commented on issue #189: Variable for Require GPS Hardware
URL:
https://github.com/apache/cordova-plugin-geolocation/pull/189#issuecomment-597710349
> Also it dosent work with PascalCase .
If you install a plugin with --variable switch, which we need here, it
automaticly become
breautek commented on issue #189: Variable for Require GPS Hardware
URL:
https://github.com/apache/cordova-plugin-geolocation/pull/189#issuecomment-597231035
Those aren't apache's codebases.
This is an automated message from
breautek commented on issue #189: Variable for Require GPS Hardware
URL:
https://github.com/apache/cordova-plugin-geolocation/pull/189#issuecomment-597178340
> why isn't this merged ? this or #171 @breautek
Two main reasons:
1. Because both PRs introduce preference in a `UPPER
