[GitHub] [cordova-plugin-inappbrowser] RafaelKr commented on issue #647: feat(android): Ask for file permission when opening a download link (CB-12834) (rebased)

2020-03-18 Thread GitBox
RafaelKr commented on issue #647: feat(android): Ask for file permission when opening a download link (CB-12834) (rebased) URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/647#issuecomment-600850358 I think using Android String resources would be the best way. Default

[GitHub] [cordova-plugin-inappbrowser] RafaelKr commented on issue #647: feat(android): Ask for file permission when opening a download link (CB-12834) (rebased)

2020-03-18 Thread GitBox
RafaelKr commented on issue #647: feat(android): Ask for file permission when opening a download link (CB-12834) (rebased) URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/647#issuecomment-600809545 Maybe the Toast message text should be configurable (translatable). ---

[GitHub] [cordova-plugin-inappbrowser] RafaelKr commented on issue #647: feat(android): Ask for file permission when opening a download link (CB-12834) (rebased)

2020-03-18 Thread GitBox
RafaelKr commented on issue #647: feat(android): Ask for file permission when opening a download link (CB-12834) (rebased) URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/647#issuecomment-600807102 Awesome work! If you're able to request a review, you should add @janpio