yesenarman opened a new pull request #647: feat(android): Ask for file permission when opening a download link (CB-12834) (rebased) URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/647 <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected Android ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> See #201 and #204. ### Description <!-- Describe your changes in detail --> I wanted to bring back attention to apache/cordova-plugin-inappbrowser#244, but noticed that the original PR contains some merge conflicts and is quite behind the master branch. I also noticed that there are a lot of formatting changes in that PR that are not quite related to the added feature, so thought that maybe creating a new PR without the formatting changes will make it easier to review and merge. This PR also contains the cookies passing improvement by @RafaelKR. ### Testing <!-- Please describe in detail how you tested your changes. --> - Tested in the app where I needed to have this feature. - It asks for the file storage permissions when you try to download a file for the first time. - If the permissions were given, it shows a toast with a message that the file download started. You can observe the download progress through notification drawer and you can also cancel the download from there. - If the permissions were not given, it shows a toast with an error message. - Followed the testing instructions from CONTRIBUTING.md - Auto Tests completed successfully. - There were some issues with Manual Tests on my device, but it seems that same issues also happen when compiling from upstream master branch. ### Checklist - [x] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
