GitHub user dpa99c opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/245
CB-7179 (iOS): Finish off WKWebView implementation <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected iOS ### What does this PR do? This PR builds on the initial work done by [Shazron](https://github.com/shazron) in https://github.com/apache/cordova-plugin-inappbrowser/tree/wkwebview: - Adds shared cookie pool via CDVWKProcessPoolFactory, enabling app Webview to share cookies with IAB Webviews (pulled from [Niklas Merz](https://github.com/NiklasMerz/cordova-plugin-inappbrowser/tree/add-webview)) - Implements WKWebView delegates to make event handlers and script injection work - Replaces iframe bridge with WKScriptMessageHandler bridge - Adds a dependency on cordova-plugin-wkwebview-engine, since the new implementation relies on it to provide a WKWebView. - Updates other platforms of the wkwebview branch to align with master at 902427525f896ae80b11cc0061a9e2420a00662d ### What testing has been done on this change? Run automated tests as [outlined here](https://github.com/apache/cordova-plugin-inappbrowser/blob/master/CONTRIBUTING.md#running-plugin-tests). All tests pass for iOS platform: <img src="https://user-images.githubusercontent.com/2345062/30917703-86c513ac-a394-11e7-8e21-bc642e9df100.png" width="300"/> Note: other platforms not tested because they have not been changed. ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - https://issues.apache.org/jira/browse/CB-7179 - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. - CB-7179 (iOS): Rework iOS implementation to use WKWebView instead of UIWebView. Adds dependency on cordova-plugin-wkwebview-engine. - [x] Added automated test coverage as appropriate for this change. - No additional test coverage needed as no functionality has changed, just the implementation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dpa99c/cordova-plugin-themeablebrowser wkwebview Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/245.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #245 ---- commit ac9c64964e17e66075c8b9170a61916b5ac01acb Author: SomaticIT <cont...@somatic.fr> Date: 2014-07-11T19:43:37Z Update windows proxy to be both compatible with windows 8 and 8.1 commit ea6a4fc80a2bc5b1cc74964e921df8b367e5876f Author: SomaticIT <cont...@somatic.fr> Date: 2014-07-11T19:48:21Z Update doc to add Windows 8 commit 6e38667320cda5f5c199a5d6a038a001be491bdd Author: SomaticIT <cont...@somatic.fr> Date: 2014-07-11T19:48:31Z Update french translation commit d828197de45f724ad41135c3ca8f0767a0990582 Author: SomaticIT <cont...@somatic.fr> Date: 2014-07-11T19:54:25Z Clean plugin.xml commit c2c94f315b956a6179d45013b30653b4689ad19d Author: Tracktl <tracktl@macbook-pro-de-tracktl.local> Date: 2014-08-05T13:50:49Z phonegap events supported for _blank target commit 97e0eac60366fcf22055e7bd23f5bfffe76b7b87 Author: Tracktl <tracktl@macbook-pro-de-tracktl.local> Date: 2014-08-05T13:53:45Z inappbrowser _blank target position is fixed commit 69ca780772b406ab02ec1bd1a8e4dca70052e926 Author: Archana Naik <na...@lab126.com> Date: 2014-08-14T18:57:00Z amazon-fireos related changes. commit 315a0e30db3639a16bbf989bab49d71b5e1cf283 Author: Piotr Zalewa <pi...@zalewa.info> Date: 2014-08-26T11:49:51Z Merge remote-tracking branch 'machard/fixed_position' commit 2c018a34609d99cb6557c9acf80a7ce41eab58f3 Author: Piotr Zalewa <pi...@zalewa.info> Date: 2014-08-27T11:48:50Z Merge remote-tracking branch 'machard/events_suppport' commit 683937872dbe9bfb002ed032d5d2c9505fe63830 Author: Staci Cooper <smcoo...@us.ibm.com> Date: 2014-07-14T19:21:41Z CB-7133 port inappbrowser to plugin-test-framework also added resources and fixed file paths, renamed test dir, added nested plugin.xml github: close 55 commit 81161ebe668a14f87e1ef4b57f2d300a609b9a8b Author: Marcel Kinard <cmarc...@gmail.com> Date: 2014-08-27T18:11:43Z Add just a bit more logging commit 4f957919c76205e33569c11f0cd71555c9166ec8 Author: Marcel Kinard <cmarc...@gmail.com> Date: 2014-08-27T19:56:46Z CB-7133 fix up the tests for Android - move the resources from /resources to /cdvtests/iab-resources - change the url of the resources from absolute to relative - explicitly set the background color of local.html to be white because it was inheriting black - add the js to display the user-agent on the tests menu - change the www.google.com URL from http to https to avoid an unexpected redirect commit 832ff5f2e9f0b6e46b9cf5c9d598429f0fd84ce3 Author: Marcel Kinard <cmarc...@gmail.com> Date: 2014-08-27T21:07:07Z CB-7133 more fixup of tests on Android - fix the paths to the injected resources - update the urls to Google home page to use https to avoid redirects - get the user agent to display on the inject.html page commit 5fc1beed0d3cbc4fbe34764d7a4614878240a2ec Author: Marcel Kinard <cmarc...@gmail.com> Date: 2014-08-27T21:15:55Z CB-7133 clarify that anchor1 doesn't exist commit faf37db5dac360f7107b0cc05b86636db3026001 Author: Shazron Abdullah <shaz...@apache.org> Date: 2014-08-29T21:03:25Z CB-7424 - Wrong docs: anchor tags are not supported by the InAppBrowser commit ec8c4527b907d5b3a2a2a6d34cc18b5190849b4b Author: Lisa Seacat DeLuca <ldel...@us.ibm.com> Date: 2014-09-05T02:31:14Z CB-7249 cordova-plugin-inappbrowser documentation translation: cordova-plugin-inappbrowser commit f90e5714304235f739a4afabeea990ecb4869868 Author: Vladimir Kotikov <v-vlk...@microsoft.com> Date: 2014-09-08T10:43:19Z CB-7490 Fixes InAppBrowser manual tests crash on windows platform commit 720123718e924914176f3baf143d46d14fefa3ea Author: Jelle Kralt <je...@jellekralt.nl> Date: 2014-09-11T08:46:47Z Added option to disable/enable zoom controls This change supports Android and Amazon Fire OS commit df90a6acc4f9f1f3964ca1b26b59a9d9ab7f2026 Author: Lisa Seacat DeLuca <ldel...@us.ibm.com> Date: 2014-09-15T21:26:46Z CB-7471 cordova-plugin-inappbrowser documentation translation: cordova-plugin-inappbrowser commit 8ce6b497fa803936784629187e9c66ebaddfbe1b Author: Marcel Kinard <cmarc...@gmail.com> Date: 2014-09-17T19:27:43Z CB-7571 Updated version and RELEASENOTES.md for release 0.5.2 commit f47f5449c2c1839345e7f57840173b3121cb8956 Author: Marcel Kinard <cmarc...@gmail.com> Date: 2014-09-17T19:35:02Z CB-7571 Incremented plugin version. commit 6e0ea336fc531b51fc82e04bca3130a1e339ec98 Author: Marcel Kinard <cmarc...@gmail.com> Date: 2014-09-17T20:27:16Z CB-7571 Bump version of nested plugin to match parent plugin commit 22b3f0ccd469b690e1f6db015cafe085e80ecea0 Author: Jesse MacFadyen <purplecabb...@gmail.com> Date: 2014-09-18T23:44:04Z Merge branch 'CB-5109' of https://github.com/Touchit/cordova-plugin-inappbrowser commit ac0bdee8e6f024be67df0331db9820b41d000054 Author: Jesse MacFadyen <purplecabb...@gmail.com> Date: 2014-09-18T23:52:40Z renamed InAppBrowser back to inappbrowser for case sensitive operating systems commit 4b3a838704ce44e879983087ddf23d326361bc98 Author: Piotr Zalewa <pi...@zalewa.info> Date: 2014-09-19T05:51:42Z zIndex fixed commit 43592a4789d9b88c9cc8b3b43e619c17ba1ab7b4 Author: Piotr Zalewa <pi...@zalewa.info> Date: 2014-09-19T05:52:56Z Merge branch 'fix_zindex' commit 32c0e41c431ac79ab18033c8b536c966b37e0db4 Author: sgrebnov <v-seg...@microsoft.com> Date: 2014-09-19T06:33:53Z Windows implementation fixes and improvements commit e9eb23468360eb9cd36a7b041fea8218b904b1f1 Author: Victor Sosa <victo...@mx1.ibm.com> Date: 2014-09-19T19:31:22Z CB-7471 cordova-plugin-inappbrowser documentation translation: cordova-plugin-inappbrowser commit a0785deff8e68dc7a28f2ea493073355d0abcaf2 Author: Prabhjot Singh <prabh...@amazon.com> Date: 2014-09-24T20:28:14Z Amazon Specific changes: Added logs and corrected indentation according to 81161ebe668a14f87e1ef4b57f2d300a609b9a8b commit 0d79919aa5c9e49b70293a6d199e149640f4d5bf Author: Victor Sosa <victo...@mx1.ibm.com> Date: 2014-10-02T23:12:35Z CB-7700 cordova-plugin-inappbrowser documentation translation: cordova-plugin-inappbrowser ---- --- --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org