[GitHub] erisu commented on a change in pull request #441: CB-14089: (android) Add Kotlin support

2018-09-11 Thread GitBox
erisu commented on a change in pull request #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#discussion_r216679161 ## File path: bin/templates/project/app/build.gradle ## @@ -30,13 +32,14 @@ buildscript {

[GitHub] erisu commented on a change in pull request #441: CB-14089: (android) Add Kotlin support

2018-09-05 Thread GitBox
erisu commented on a change in pull request #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#discussion_r215496283 ## File path: bin/templates/project/Activity.kt ## @@ -0,0 +1,38 @@ +/* Review comment: If we make

[GitHub] erisu commented on a change in pull request #441: CB-14089: (android) Add Kotlin support

2018-09-05 Thread GitBox
erisu commented on a change in pull request #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#discussion_r215494867 ## File path: test/gradle/wrapper/gradle-wrapper.properties ## @@ -1,6 +1,5 @@ -#Wed Oct 25 11:17:25 PDT

[GitHub] erisu commented on a change in pull request #441: CB-14089: (android) Add Kotlin support

2018-09-05 Thread GitBox
erisu commented on a change in pull request #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#discussion_r215495327 ## File path: bin/templates/project/app/build.gradle ## @@ -30,13 +32,14 @@ buildscript {

[GitHub] erisu commented on a change in pull request #441: CB-14089: (android) Add Kotlin support

2018-09-05 Thread GitBox
erisu commented on a change in pull request #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#discussion_r215495532 ## File path: bin/templates/project/app/build.gradle ## @@ -30,13 +32,14 @@ buildscript {