[GitHub] erisu commented on a change in pull request #490: Fixes build & run related bugs from builder refactor

2018-09-05 Thread GitBox
erisu commented on a change in pull request #490: Fixes build & run related bugs from builder refactor URL: https://github.com/apache/cordova-android/pull/490#discussion_r215476043 ## File path: bin/templates/cordova/lib/build.js ## @@ -276,12 +262,10 @@

[GitHub] erisu commented on a change in pull request #490: Fixes build & run related bugs from builder refactor

2018-09-05 Thread GitBox
erisu commented on a change in pull request #490: Fixes build & run related bugs from builder refactor URL: https://github.com/apache/cordova-android/pull/490#discussion_r215144913 ## File path: bin/templates/cordova/Api.js ## @@ -208,17 +208,13 @@ Api.prototype.addPlugin

[GitHub] erisu commented on a change in pull request #490: Fixes build & run related bugs from builder refactor

2018-09-04 Thread GitBox
erisu commented on a change in pull request #490: Fixes build & run related bugs from builder refactor URL: https://github.com/apache/cordova-android/pull/490#discussion_r215131334 ## File path: bin/templates/cordova/lib/builders/builders.js ## @@ -17,29 +17,18 @@