codecov-io edited a comment on issue #465: CB-14201: (android) Removes Gradle
property in-line command arguments…
URL: https://github.com/apache/cordova-android/pull/465#issuecomment-404037636
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/465?src=pr=h1)
Report
>
erisu commented on a change in pull request #441: CB-14089: (android) Add
Kotlin support
URL: https://github.com/apache/cordova-android/pull/441#discussion_r215496283
##
File path: bin/templates/project/Activity.kt
##
@@ -0,0 +1,38 @@
+/*
Review comment:
If we make
erisu commented on a change in pull request #441: CB-14089: (android) Add
Kotlin support
URL: https://github.com/apache/cordova-android/pull/441#discussion_r215494867
##
File path: test/gradle/wrapper/gradle-wrapper.properties
##
@@ -1,6 +1,5 @@
-#Wed Oct 25 11:17:25 PDT
erisu commented on a change in pull request #441: CB-14089: (android) Add
Kotlin support
URL: https://github.com/apache/cordova-android/pull/441#discussion_r215495327
##
File path: bin/templates/project/app/build.gradle
##
@@ -30,13 +32,14 @@ buildscript {
erisu commented on a change in pull request #441: CB-14089: (android) Add
Kotlin support
URL: https://github.com/apache/cordova-android/pull/441#discussion_r215495532
##
File path: bin/templates/project/app/build.gradle
##
@@ -30,13 +32,14 @@ buildscript {
erisu commented on a change in pull request #438: Add support for
EnableGoogleServicesPlugin
URL: https://github.com/apache/cordova-android/pull/438#discussion_r215494090
##
File path: bin/templates/project/app/build.gradle
##
@@ -30,6 +30,7 @@ buildscript {
erisu closed issue #488: Run command fails if build is skipped
URL: https://github.com/apache/cordova-android/issues/488
This is an automated message from the Apache Git Service.
To respond to the message, please log on
erisu closed pull request #490: Fixes build & run related bugs from builder
refactor
URL: https://github.com/apache/cordova-android/pull/490
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As
This is an automated email from the ASF dual-hosted git repository.
erisu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-android.git
The following commit(s) were added to refs/heads/master by this push:
new 23b2449 Fixes build & run related bugs
erisu commented on a change in pull request #490: Fixes build & run related
bugs from builder refactor
URL: https://github.com/apache/cordova-android/pull/490#discussion_r215476043
##
File path: bin/templates/cordova/lib/build.js
##
@@ -276,12 +262,10 @@
codecov-io commented on issue #403: fix#402 Line separator (U+2028) and
paragraph separator (U+2029) Got …
URL: https://github.com/apache/cordova-ios/pull/403#issuecomment-418936431
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/403?src=pr=h1)
Report
> Merging
codecov-io edited a comment on issue #403: fix#402 Line separator (U+2028) and
paragraph separator (U+2029) Got …
URL: https://github.com/apache/cordova-ios/pull/403#issuecomment-418936431
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/403?src=pr=h1)
Report
> Merging
crmo opened a new pull request #403: fix#402 Line separator (U+2028) and
paragraph separator (U+2029) Got …
URL: https://github.com/apache/cordova-ios/pull/403
…JS Exception SyntaxError
### Platforms affected
iOS
### What does this PR do?
Fix Issus #402 Line
crmo opened a new issue #402: Line separator (U+2028) and paragraph separator
(U+2029) Got JS Exception SyntaxError
URL: https://github.com/apache/cordova-ios/issues/402
When Objective-c call JavaScript use function
`stringByEvaluatingJavaScriptFromString:` with Line separator (U+2028)
Menardi commented on a change in pull request #490: Fixes build & run related
bugs from builder refactor
URL: https://github.com/apache/cordova-android/pull/490#discussion_r215467410
##
File path: bin/templates/cordova/lib/build.js
##
@@ -276,12 +262,10 @@
Menardi commented on a change in pull request #490: Fixes build & run related
bugs from builder refactor
URL: https://github.com/apache/cordova-android/pull/490#discussion_r215467615
##
File path: bin/templates/cordova/lib/builders/builders.js
##
@@ -17,29 +17,18 @@
This is an automated email from the ASF dual-hosted git repository.
raphinesse pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-test-platform.git
The following commit(s) were added to refs/heads/master by this push:
new fe9f4fb Fix test script
raphinesse commented on issue #196: GH-195: Ensure synchronous operation
URL: https://github.com/apache/cordova-coho/pull/196#issuecomment-418905656
> `it('should clone coho as the first step in the build', () => {});`
:grin:
Alright, then let's see what happens...
dpogue commented on issue #196: GH-195: Ensure synchronous operation
URL: https://github.com/apache/cordova-coho/pull/196#issuecomment-418905043
It should clone coho as the first step in the build
This is an automated message
raphinesse commented on issue #196: GH-195: Ensure synchronous operation
URL: https://github.com/apache/cordova-coho/pull/196#issuecomment-418901839
@dpogue Do we have to do something to make Jenkins use this?
This is an
raphinesse closed issue #195: Nightly builds are sometimes broken
URL: https://github.com/apache/cordova-coho/issues/195
This is an automated message from the Apache Git Service.
To respond to the message, please log on
raphinesse closed pull request #196: GH-195: Ensure synchronous operation
URL: https://github.com/apache/cordova-coho/pull/196
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign
This is an automated email from the ASF dual-hosted git repository.
raphinesse pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-coho.git
The following commit(s) were added to refs/heads/master by this push:
new 2ae50f2 GH-195: Ensure synchronous
raphinesse commented on issue #196: GH-195: Ensure synchronous operation
URL: https://github.com/apache/cordova-coho/pull/196#issuecomment-418901109
On a side note: OMG, these tests are horrible! :scream: :joy:
This is an
oliversalzburg commented on issue #196: GH-195: Ensure synchronous operation
URL: https://github.com/apache/cordova-coho/pull/196#issuecomment-418882295
@raphinesse Should go green now
This is an automated message from the
raphinesse commented on issue #196: GH-195: Ensure synchronous operation
URL: https://github.com/apache/cordova-coho/pull/196#issuecomment-418874947
Looks like you need to adapt the spies in the test:
oliversalzburg opened a new pull request #196: GH-195: Ensure synchronous
operation
URL: https://github.com/apache/cordova-coho/pull/196
Performing the read asynchronously introduces a race condition that can
cause the changes to not have been made yet
when they are checked by git.
hvaughan3 opened a new issue #294: Android - Footer Overlaps WebView
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/294
On Android, when setting `footer` to `yes`, the footer bar overlaps the
WebView content, causing it to cover up the bottom slice of the WebView.
raphinesse commented on a change in pull request #5: [WIP] Architecture Overview
URL: https://github.com/apache/cordova-contribute/pull/5#discussion_r215365258
##
File path: architecture-overview.md
##
@@ -0,0 +1,58 @@
+# Architecture overview
+
+To get an architecture
raphinesse commented on a change in pull request #5: [WIP] Architecture Overview
URL: https://github.com/apache/cordova-contribute/pull/5#discussion_r215365782
##
File path: architecture-overview.md
##
@@ -0,0 +1,58 @@
+# Architecture overview
+
+To get an architecture
JaviRpo commented on issue #114: Not working on Android devices
URL:
https://github.com/apache/cordova-plugin-geolocation/issues/114#issuecomment-418767382
The same for me, the plugin doesn't work
This is an automated
janpio opened a new pull request #5: [WIP] Architecture Overview
URL: https://github.com/apache/cordova-contribute/pull/5
Description how Cordova works on the inside.
@raphinesse Could you please read over this first draft of the beginning of
an article and tell me if I got this
This is an automated email from the ASF dual-hosted git repository.
janpio pushed a change to branch janpio-architecture
in repository https://gitbox.apache.org/repos/asf/cordova-contribute.git.
at b239d90 initial draft of first quarter of article
This branch includes the following new
This is an automated email from the ASF dual-hosted git repository.
janpio pushed a commit to branch janpio-architecture
in repository https://gitbox.apache.org/repos/asf/cordova-contribute.git
commit b239d90772fa5b487dbe04b745c80c102f31197f
Author: Jan Piotrowski
AuthorDate: Wed Sep 5 16:49:12
chiefego commented on issue #34: lock on IOS does not work right after device
ready event
URL:
https://github.com/apache/cordova-plugin-screen-orientation/issues/34#issuecomment-418754923
Sorry, what I mean is that when the phone's orientation is `portrait` and
you call
janpio commented on issue #34: lock on IOS does not work right after device
ready event
URL:
https://github.com/apache/cordova-plugin-screen-orientation/issues/34#issuecomment-418752208
What does "is not getting forced" mean?
chiefego opened a new issue #34: lock on IOS does not work right after device
ready event
URL: https://github.com/apache/cordova-plugin-screen-orientation/issues/34
When calling screen.lock immediately after device ready event fires in iOS,
the screen is not getting forced. However, it
kamalsamra opened a new issue #102: Android 8 - capture.captureAudio cause No
Activity found to handle Intent { act=android.provider.MediaStore.RECORD_SOUND
URL: https://github.com/apache/cordova-plugin-media-capture/issues/102
Android 8 - capture.captureAudio cause No Activity found to
siege-nnn commented on issue #115: Frequency/Interval feature
URL:
https://github.com/apache/cordova-plugin-geolocation/issues/115#issuecomment-418741913
@janpio apologies, thought it was obvious.
watchPosition method is pulling every 1s.
Example:
var options = {
This is an automated email from the ASF dual-hosted git repository.
janpio pushed a change to branch janpio-update
in repository https://gitbox.apache.org/repos/asf/cordova-status.git.
from b5f05a6 remove deprecated repositories
add 58478df remove "Organization / Apache"
No new
janpio commented on issue #115: Frequency/Interval feature
URL:
https://github.com/apache/cordova-plugin-geolocation/issues/115#issuecomment-418737665
What method is currently polling every 1000ms?
What platform?
This is
This is an automated email from the ASF dual-hosted git repository.
janpio pushed a change to branch janpio-update
in repository https://gitbox.apache.org/repos/asf/cordova-status.git.
from 92c1c2e fix appveyor links
add b5f05a6 remove deprecated repositories
No new revisions were
siege-nnn opened a new issue #115: Frequency/Interval feature
URL: https://github.com/apache/cordova-plugin-geolocation/issues/115
Hi,
Currently the plugin pulls updates every 1000ms (or 1s). Is there any
intention to add frequency as a parameter?
(I can make a hack to ignore
sachinGAcharya opened a new issue #114: Not working on Android devices
URL: https://github.com/apache/cordova-plugin-geolocation/issues/114
$ ionic cordova plugin add cordova-plugin-geolocation --variable
GEOLOCATION_USAGE_DESCRIPTION="To locate you"
$ npm install --save
This is an automated email from the ASF dual-hosted git repository.
janpio pushed a commit to branch janpio-update
in repository https://gitbox.apache.org/repos/asf/cordova-status.git
The following commit(s) were added to refs/heads/janpio-update by this push:
new 92c1c2e fix appveyor
This is an automated email from the ASF dual-hosted git repository.
janpio pushed a commit to branch janpio-update
in repository https://gitbox.apache.org/repos/asf/cordova-status.git
The following commit(s) were added to refs/heads/janpio-update by this push:
new a07b527 all the repos!
This is an automated email from the ASF dual-hosted git repository.
janpio pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova.git
The following commit(s) were added to refs/heads/master by this push:
new 85b3696 update README with generated markdown
This is an automated email from the ASF dual-hosted git repository.
janpio pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova.git
The following commit(s) were added to refs/heads/master by this push:
new 27c0011 add cordova-contribute
27c0011 is
This is an automated email from the ASF dual-hosted git repository.
janpio pushed a change to branch janpio-update
in repository https://gitbox.apache.org/repos/asf/cordova-status.git.
at 62e4120 add travic-ci badges for all
This branch includes the following new commits:
new
This is an automated email from the ASF dual-hosted git repository.
janpio pushed a commit to branch janpio-update
in repository https://gitbox.apache.org/repos/asf/cordova-status.git
commit 62e41201881541f0778bb950e43bcd13b0e97991
Author: Jan Piotrowski
AuthorDate: Wed Sep 5 12:47:42 2018
This is an automated email from the ASF dual-hosted git repository.
raphinesse pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-lib.git.
from bf0d698 Merge pull request #674 from
raphinesse/plugman_install-cleanup
add a112fbe Delete totally
This is an automated email from the ASF dual-hosted git repository.
raphinesse pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-lib.git
commit f79c277f73ae1f181f3ddeb75ac34fde108f
Merge: bf0d698 877bf45
Author: Raphael von der Grün
AuthorDate: Wed
This is an automated email from the ASF dual-hosted git repository.
raphinesse pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-lib.git.
from 92e832e Merge pull request #672 from
raphinesse/plugman_uninstall-cleanup
add 2369766 Organize
This is an automated email from the ASF dual-hosted git repository.
raphinesse pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-lib.git
commit bf0d6980303133cc6e5e6833e3b066ef84daac7f
Merge: 92e832e f8fa90c
Author: Raphael von der Grün
AuthorDate: Wed
This is an automated email from the ASF dual-hosted git repository.
raphinesse pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-lib.git.
from d4c8e02 Merge pull request #613 from dpogue/fs-extra
add 68c6312 Remove unused functionality
This is an automated email from the ASF dual-hosted git repository.
raphinesse pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-lib.git
commit 92e832e346c0d5347335cfe22da498e4b78af1d9
Merge: d4c8e02 4b0d8f2
Author: Raphael von der Grün
AuthorDate: Wed
This is an automated email from the ASF dual-hosted git repository.
raphinesse pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-cli.git
commit 5f36967168fe2e6485a082005b2c6c08a97b9e02
Merge: c9f29c6 645c1bf
Author: Raphael von der Grün
AuthorDate: Wed
This is an automated email from the ASF dual-hosted git repository.
raphinesse pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-cli.git.
from c9f29c6 Remove callback parameter of main CLI function (#316)
add d9db003 Simplify telemetry test
This is an automated email from the ASF dual-hosted git repository.
raphinesse pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-cli.git
The following commit(s) were added to refs/heads/master by this push:
new c9f29c6 Remove callback parameter of
This is an automated email from the ASF dual-hosted git repository.
raphinesse pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-cli.git
commit 7abc2b83cb7d44a047f4c0eac3962576a7b7facc
Merge: 2d92035 7593582
Author: Raphael von der Grün
AuthorDate: Wed
This is an automated email from the ASF dual-hosted git repository.
raphinesse pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-cli.git.
from 2d92035 Don't do 'nightly testing' & simplify CI configs
add 73a2541 Cleanup create
add b69e549
nosTa1337 closed issue #82: New Function request - Show CPU Architecture
URL: https://github.com/apache/cordova-plugin-device/issues/82
This is an automated message from the Apache Git Service.
To respond to the message,
nosTa1337 commented on issue #82: New Function request - Show CPU Architecture
URL:
https://github.com/apache/cordova-plugin-device/issues/82#issuecomment-418659103
ok thanks for you time :)
This is an automated message from
janpio commented on issue #82: New Function request - Show CPU Architecture
URL:
https://github.com/apache/cordova-plugin-device/issues/82#issuecomment-418647520
As this is a very Android specific thing, I think you might be better of
creating a tiny new plugin that only returns this
nosTa1337 edited a comment on issue #82: New Function request - Show CPU
Architecture
URL:
https://github.com/apache/cordova-plugin-device/issues/82#issuecomment-418646591
Here is a code example what this command returns.
private static String determineTermuxArchName() {
nosTa1337 commented on issue #82: New Function request - Show CPU Architecture
URL:
https://github.com/apache/cordova-plugin-device/issues/82#issuecomment-418646591
Here is a code example what this command returns.
private static String determineTermuxArchName() {
//
Author: steven
Date: Wed Sep 5 08:33:08 2018
New Revision: 1840102
URL: http://svn.apache.org/viewvc?rev=1840102=rev
Log:
Updated docs
Modified:
cordova/site/public/docs/en/dev/config_ref/index.html
cordova/site/public/docs/en/dev/guide/platforms/ios/index.html
janpio commented on issue #82: New Function request - Show CPU Architecture
URL:
https://github.com/apache/cordova-plugin-device/issues/82#issuecomment-418643873
What does `ABIS` mean?
This is an automated message from the
nosTa1337 opened a new issue #82: New Function request - Show CPU Architecture
URL: https://github.com/apache/cordova-plugin-device/issues/82
Hi,
is it possible that you include the function SUPPORTED_ABIS
nicolashenry commented on issue #293: GH-292 android: SSL errors handling in
Android
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/293#issuecomment-418642236
Yes, exactly.
This is an automated message from
janpio commented on issue #293: GH-292 android: SSL errors handling in Android
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/293#issuecomment-418641722
Ah ok, so the PR makes sure the error is not just swallowed but bubbles up
to the web app and can be handled there?
janpio commented on issue #491: Embedding cordova application on Android native
application
URL: https://github.com/apache/cordova-android/issues/491#issuecomment-418641248
Yey, those docs are very much out of date. If you figure it out (I think I
have seen some StackOverflow answers
nicolashenry commented on issue #293: GH-292 android: SSL errors handling in
Android
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/293#issuecomment-418641159
Before the change, the events came like this :
```js
{type: "loadstart", url: "https://ourdomain.com/"}
StavrosSkourtis opened a new issue #491: Embedding cordova application on
Android native application
URL: https://github.com/apache/cordova-android/issues/491
I'm not sure if this is the correct place to put this, please tell where to
ask if it isn't.
What I'm trying to do is embed
erisu edited a comment on issue #490: Fixes build & run related bugs from
builder refactor
URL: https://github.com/apache/cordova-android/pull/490#issuecomment-418364367
### Remaining Tasks
- [x] **Revet Build Order**
Removing the first build process would have been a better
janpio commented on a change in pull request #490: Fixes build & run related
bugs from builder refactor
URL: https://github.com/apache/cordova-android/pull/490#discussion_r215165622
##
File path: bin/templates/cordova/lib/builders/builders.js
##
@@ -17,29 +17,18 @@
erisu commented on a change in pull request #490: Fixes build & run related
bugs from builder refactor
URL: https://github.com/apache/cordova-android/pull/490#discussion_r215144913
##
File path: bin/templates/cordova/Api.js
##
@@ -208,17 +208,13 @@ Api.prototype.addPlugin
77 matches
Mail list logo
