Shanedell commented on PR #117:
URL: https://github.com/apache/daffodil-vscode/pull/117#issuecomment-1132972725
> > I would not be able to these PRs out until next week if that is the
route we wish to go.
>
> I don't feel strongly bout it. If others are fine with reviewing it this
wa
stevedlawrence commented on PR #117:
URL: https://github.com/apache/daffodil-vscode/pull/117#issuecomment-1132955042
> I would not be able to these PRs out until next week if that is the route
we wish to go.
I don't feel strongly bout it. If others are fine with reviewing it this way
tuxji merged PR #795:
URL: https://github.com/apache/daffodil/pull/795
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@daffodil.apac
Shanedell commented on PR #117:
URL: https://github.com/apache/daffodil-vscode/pull/117#issuecomment-1132876879
> Any chance the omega edit and DFDL language features could be split into
separate PRs? I believe they are completely unrelated, it would probably make
reviewing and getting this
stevedlawrence commented on code in PR #117:
URL: https://github.com/apache/daffodil-vscode/pull/117#discussion_r878049102
##
LICENSE:
##
@@ -1,182 +1,181 @@
-
Apache License
Version 2.0, January 2004
stevedlawrence commented on code in PR #117:
URL: https://github.com/apache/daffodil-vscode/pull/117#discussion_r878048639
##
.gitignore:
##
@@ -32,6 +32,9 @@ package-lock.json
# build
src/version.ts
+# IDEs
+.idea/
+
Review Comment:
IDE specific files should not go in t
stevedlawrence commented on PR #117:
URL: https://github.com/apache/daffodil-vscode/pull/117#issuecomment-1132792449
Any chance the omega edit and DFDL language features could be split into
separate PRs? I believe they are completely unrelated, it would probably make
reviewing and getting t