stevedlawrence merged PR #1228:
URL: https://github.com/apache/daffodil/pull/1228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mbeckerle commented on code in PR #1228:
URL: https://github.com/apache/daffodil/pull/1228#discussion_r1586513111
##
daffodil-runtime1/src/main/scala/org/apache/daffodil/runtime1/processors/parsers/ElementCombinator1.scala:
##
@@ -198,6 +197,14 @@ abstract class
stevedlawrence commented on code in PR #1228:
URL: https://github.com/apache/daffodil/pull/1228#discussion_r1586490568
##
daffodil-runtime1/src/main/scala/org/apache/daffodil/runtime1/processors/parsers/ElementCombinator1.scala:
##
@@ -198,6 +197,14 @@ abstract class
mbeckerle commented on code in PR #1228:
URL: https://github.com/apache/daffodil/pull/1228#discussion_r1586482595
##
daffodil-runtime1/src/main/scala/org/apache/daffodil/runtime1/processors/parsers/ElementCombinator1.scala:
##
@@ -198,6 +197,14 @@ abstract class
stevedlawrence commented on PR #1228:
URL: https://github.com/apache/daffodil/pull/1228#issuecomment-2088677276
Agreed, I don't think I want to mess with early returns in this PR. We do
have DAFFODIL-1492 to find all the uses of returns and replace them. We'll
probably want to do that all
stevedlawrence opened a new pull request, #1228:
URL: https://github.com/apache/daffodil/pull/1228
Currently, restriction validation logic takes place in a finally block of
the ElementParserBase combinator when the parse status is "success". However,
if an exception is thrown (e.g. Runtime
