bllmo commented on issue #333:
URL:
https://github.com/apache/datasketches-cpp/issues/333#issuecomment-1398245925
I did the whl on a AWS AMI linux arm64 machine
`datasketches-4.0.0-cp37-cp37m-linux_aarch64.whl`
but when I run the script on glue I receive this error:
```
jmalkin commented on issue #333:
URL:
https://github.com/apache/datasketches-cpp/issues/333#issuecomment-1397617578
Ok, the first quick attempts did not work. This might take longer than I'd
expected.
--
This is an automated message from the Apache Git Service.
To respond to the message,
AlexanderSaydakov commented on code in PR #325:
URL: https://github.com/apache/datasketches-cpp/pull/325#discussion_r1081692282
##
count/include/count_min_impl.hpp:
##
@@ -0,0 +1,241 @@
+#ifndef COUNT_MIN_IMPL_HPP_
+#define COUNT_MIN_IMPL_HPP_
+
+#include "MurmurHash3.h"
+#inclu
jmalkin commented on issue #333:
URL:
https://github.com/apache/datasketches-cpp/issues/333#issuecomment-1397457166
I don't have an immediate fix, unfortunately. I'm running the change to the
build workflow, although I don't think I have a way to test it beyond trying to
trigger a "wrong a
AlexanderSaydakov commented on code in PR #325:
URL: https://github.com/apache/datasketches-cpp/pull/325#discussion_r1081690971
##
count/include/count_min.hpp:
##
@@ -0,0 +1,189 @@
+#ifndef COUNT_MIN_HPP_
+#define COUNT_MIN_HPP_
+
+#include
+#include "common_defs.hpp"
+
+namesp
AlexanderSaydakov commented on code in PR #325:
URL: https://github.com/apache/datasketches-cpp/pull/325#discussion_r1081689905
##
count/include/count_min.hpp:
##
@@ -0,0 +1,189 @@
+#ifndef COUNT_MIN_HPP_
+#define COUNT_MIN_HPP_
+
+#include
+#include "common_defs.hpp"
+
+namesp
AlexanderSaydakov commented on code in PR #325:
URL: https://github.com/apache/datasketches-cpp/pull/325#discussion_r1081689445
##
count/include/count_min.hpp:
##
@@ -0,0 +1,189 @@
+#ifndef COUNT_MIN_HPP_
+#define COUNT_MIN_HPP_
+
+#include
+#include "common_defs.hpp"
+
+namesp
AlexanderSaydakov commented on code in PR #325:
URL: https://github.com/apache/datasketches-cpp/pull/325#discussion_r1081688920
##
count/include/count_min.hpp:
##
@@ -0,0 +1,189 @@
+#ifndef COUNT_MIN_HPP_
+#define COUNT_MIN_HPP_
+
+#include
+#include "common_defs.hpp"
+
+namesp
bllmo commented on issue #333:
URL:
https://github.com/apache/datasketches-cpp/issues/333#issuecomment-1397447809
thanks for the reply, I need a whl to use on aws glue job that accepts
libraries with Python/C only a whl format (aarch64manylinux)
[https://docs.aws.amazon.com/glue/latest/dg/
dependabot[bot] opened a new pull request, #171:
URL: https://github.com/apache/datasketches-memory/pull/171
Bumps [testng](https://github.com/cbeust/testng) from 7.5 to 7.7.0.
Release notes
Sourced from https://github.com/cbeust/testng/releases";>testng's releases.
TestNG v7
jmalkin commented on issue #333:
URL:
https://github.com/apache/datasketches-cpp/issues/333#issuecomment-1397400142
It looks like we don't have ARM64 on linux as part of the cibuildwheel
configuration. I'll fix that going forward.
That said, the error is that it's not finding a compi
bllmo opened a new issue, #333:
URL: https://github.com/apache/datasketches-cpp/issues/333
I have some trouble to install python `datasketches==4.0.0` on Linux ARM64,
I receive the following error when I run `pip3 install datasketches==4.0.0`
```
Building wheels for collected pack
c-dickens commented on code in PR #325:
URL: https://github.com/apache/datasketches-cpp/pull/325#discussion_r1073963195
##
count/include/count_min.hpp:
##
@@ -0,0 +1,166 @@
+#ifndef COUNT_MIN_HPP_
+#define COUNT_MIN_HPP_
+
+#include
+#include
+#include
+#include
+
+#include
c-dickens commented on code in PR #325:
URL: https://github.com/apache/datasketches-cpp/pull/325#discussion_r1073962927
##
count/include/count_min.hpp:
##
@@ -0,0 +1,166 @@
+#ifndef COUNT_MIN_HPP_
+#define COUNT_MIN_HPP_
+
+#include
+#include
+#include
+#include
+
+#include
c-dickens commented on code in PR #325:
URL: https://github.com/apache/datasketches-cpp/pull/325#discussion_r1071110716
##
count/include/count_min.hpp:
##
@@ -0,0 +1,166 @@
+#ifndef COUNT_MIN_HPP_
+#define COUNT_MIN_HPP_
+
+#include
+#include
+#include
+#include
+
+#include
c-dickens commented on code in PR #325:
URL: https://github.com/apache/datasketches-cpp/pull/325#discussion_r1071094476
##
count/include/count_min.hpp:
##
@@ -0,0 +1,166 @@
+#ifndef COUNT_MIN_HPP_
+#define COUNT_MIN_HPP_
+
+#include
+#include
+#include
+#include
+
+#include
leerho commented on PR #170:
URL:
https://github.com/apache/datasketches-memory/pull/170#issuecomment-1382632142
And "mvn clean test" runs OK locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
leerho commented on PR #170:
URL:
https://github.com/apache/datasketches-memory/pull/170#issuecomment-1382631591
This is complaining that Java 11 is an invalid version. Not sure yet how to
fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
leerho opened a new pull request, #170:
URL: https://github.com/apache/datasketches-memory/pull/170
While working on the Java 17 migration, I discovered a bug in memory in how
regions were being handled. It only occurs in rare cases but it was a bug
nonetheless. And in digging in to figur
coveralls commented on PR #332:
URL: https://github.com/apache/datasketches-cpp/pull/332#issuecomment-1382429193
## Pull Request Test Coverage Report for [Build
3915134361](https://coveralls.io/builds/55942143)
* **2621** of **2626** **(99.81%)** changed or added relevant lines in
jmalkin merged PR #331:
URL: https://github.com/apache/datasketches-cpp/pull/331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@dat
AlexanderSaydakov commented on PR #325:
URL: https://github.com/apache/datasketches-cpp/pull/325#issuecomment-1381058373
I think that overflowing seeed is fine. It still achieves seeding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AlexanderSaydakov commented on code in PR #325:
URL: https://github.com/apache/datasketches-cpp/pull/325#discussion_r1068519801
##
count/include/count_min.hpp:
##
@@ -0,0 +1,166 @@
+#ifndef COUNT_MIN_HPP_
+#define COUNT_MIN_HPP_
+
+#include
+#include
+#include
+#include
+
+#
coveralls commented on PR #331:
URL: https://github.com/apache/datasketches-cpp/pull/331#issuecomment-1379727629
## Pull Request Test Coverage Report for [Build
3898496971](https://coveralls.io/builds/55872511)
* **0** of **0** changed or added relevant lines in **0** files are
cov
jmalkin opened a new pull request, #331:
URL: https://github.com/apache/datasketches-cpp/pull/331
uint8_t can never be < 0 so this addresses a warning from gcc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
coveralls commented on PR #330:
URL: https://github.com/apache/datasketches-cpp/pull/330#issuecomment-1379719576
## Pull Request Test Coverage Report for [Build
3898418904](https://coveralls.io/builds/55872270)
* **0** of **0** changed or added relevant lines in **0** files are
cov
jmalkin opened a new pull request, #330:
URL: https://github.com/apache/datasketches-cpp/pull/330
This adds tuple sketch support to the python library, and specifically
provides an arbitrary python object as the summary, as well as custom python
policies for set operations.
A few bas
coveralls commented on PR #329:
URL: https://github.com/apache/datasketches-cpp/pull/329#issuecomment-1378108812
## Pull Request Test Coverage Report for [Build
3888687714](https://coveralls.io/builds/55829590)
* **0** of **0** changed or added relevant lines in **0** files are
cov
jmalkin closed pull request #329: Python tuple sketch support
URL: https://github.com/apache/datasketches-cpp/pull/329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
jmalkin commented on PR #329:
URL: https://github.com/apache/datasketches-cpp/pull/329#issuecomment-1378105094
Oh! Just realized I have no tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
jmalkin opened a new pull request, #329:
URL: https://github.com/apache/datasketches-cpp/pull/329
This adds tuple sketch support to the python library, and specifically
provides an arbitrary python object as the summary, as well as custom python
policies for set operations.
A few bas
jmalkin commented on issue #328:
URL:
https://github.com/apache/datasketches-cpp/issues/328#issuecomment-1377937269
Not sure exactly when we'll get to this, but this is a good point. We only
target C++11, which is prior to deprecation, but these changes won't break
compatibility with that
AlexanderSaydakov merged PR #327:
URL: https://github.com/apache/datasketches-cpp/pull/327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsub
AlexanderSaydakov merged PR #326:
URL: https://github.com/apache/datasketches-cpp/pull/326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsub
jbapple opened a new issue, #328:
URL: https://github.com/apache/datasketches-cpp/issues/328
`std::iterator` is deprecated; see
https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2016/p0174r2.html#2.1. It
is used ten times in datasketches-cpp:
```
$ git grep -c std::iterator
f
coveralls commented on PR #327:
URL: https://github.com/apache/datasketches-cpp/pull/327#issuecomment-1376159312
## Pull Request Test Coverage Report for [Build
3876955097](https://coveralls.io/builds/55775389)
* **3** of **3** **(100.0%)** changed or added relevant lines in **2**
jbapple opened a new pull request, #327:
URL: https://github.com/apache/datasketches-cpp/pull/327
In clang-16, there are warnings like this upon build:
warning: implicit conversion from 'const uint64_t' (aka 'const
unsigned long') to 'double' changes value from 9223372036854
coveralls commented on PR #326:
URL: https://github.com/apache/datasketches-cpp/pull/326#issuecomment-1376151332
## Pull Request Test Coverage Report for [Build
3876909400](https://coveralls.io/builds/55775138)
* **0** of **0** changed or added relevant lines in **0** files are
cov
jbapple opened a new pull request, #326:
URL: https://github.com/apache/datasketches-cpp/pull/326
theta_helpers.hpp uses theta_constants::MAX_THETA, which is declared in
theta_constants.hpp. This patch #includes it as well as alphabetizes the
standard headers.
--
This is an automated mes
jmalkin merged PR #324:
URL: https://github.com/apache/datasketches-cpp/pull/324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@dat
jmalkin commented on PR #324:
URL: https://github.com/apache/datasketches-cpp/pull/324#issuecomment-1376028816
waiting for the CI job, then will merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
jmalkin commented on code in PR #324:
URL: https://github.com/apache/datasketches-cpp/pull/324#discussion_r1064930859
##
sampling/include/var_opt_sketch_impl.hpp:
##
@@ -752,18 +752,16 @@ string var_opt_sketch::items_to_string(bool
print_gap) const {
std::ostringstream os;
jbapple commented on code in PR #324:
URL: https://github.com/apache/datasketches-cpp/pull/324#discussion_r1064916022
##
sampling/include/var_opt_sketch_impl.hpp:
##
@@ -752,18 +752,16 @@ string var_opt_sketch::items_to_string(bool
print_gap) const {
std::ostringstream os;
c-dickens opened a new pull request, #325:
URL: https://github.com/apache/datasketches-cpp/pull/325
An initial attempt at cpp count min sketch.
Specific feedback that might be helpful:
- `get_sketch()` would this be better as an iterator over the sketch table,
rather than retur
jmalkin commented on code in PR #324:
URL: https://github.com/apache/datasketches-cpp/pull/324#discussion_r1064868895
##
sampling/include/var_opt_sketch_impl.hpp:
##
@@ -752,18 +752,16 @@ string var_opt_sketch::items_to_string(bool
print_gap) const {
std::ostringstream os;
jbapple commented on code in PR #324:
URL: https://github.com/apache/datasketches-cpp/pull/324#discussion_r1064779030
##
sampling/include/var_opt_sketch_impl.hpp:
##
@@ -752,18 +752,16 @@ string var_opt_sketch::items_to_string(bool
print_gap) const {
std::ostringstream os;
jmalkin commented on PR #324:
URL: https://github.com/apache/datasketches-cpp/pull/324#issuecomment-1375263982
Thanks for reporting this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
jmalkin commented on code in PR #324:
URL: https://github.com/apache/datasketches-cpp/pull/324#discussion_r1064379687
##
sampling/include/var_opt_sketch_impl.hpp:
##
@@ -752,18 +752,16 @@ string var_opt_sketch::items_to_string(bool
print_gap) const {
std::ostringstream os;
coveralls commented on PR #324:
URL: https://github.com/apache/datasketches-cpp/pull/324#issuecomment-1375071185
## Pull Request Test Coverage Report for [Build
3870562108](https://coveralls.io/builds/55745213)
* **0** of **0** changed or added relevant lines in **0** files are
cov
jbapple opened a new pull request, #324:
URL: https://github.com/apache/datasketches-cpp/pull/324
These variables were never read, which causes warning when compiling with
clang 16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
AlexanderSaydakov merged PR #323:
URL: https://github.com/apache/datasketches-cpp/pull/323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsub
AlexanderSaydakov merged PR #322:
URL: https://github.com/apache/datasketches-cpp/pull/322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsub
jmalkin commented on code in PR #322:
URL: https://github.com/apache/datasketches-cpp/pull/322#discussion_r1062762503
##
python/tests/vo_test.py:
##
@@ -45,6 +45,13 @@ def test_vo_example(self):
items = vo.get_samples()
self.assertEqual(len(items), k)
+count = 0
AlexanderSaydakov commented on code in PR #322:
URL: https://github.com/apache/datasketches-cpp/pull/322#discussion_r1061977242
##
python/src/quantiles_wrapper.cpp:
##
@@ -114,12 +34,27 @@ void bind_quantiles_sketch(py::module &m, const char*
name) {
py::class_>(m, name)
AlexanderSaydakov commented on code in PR #322:
URL: https://github.com/apache/datasketches-cpp/pull/322#discussion_r1061976333
##
python/src/fi_wrapper.cpp:
##
@@ -105,15 +53,55 @@ void bind_fi_sketch(py::module &m, const char* name) {
"Returns the guaranteed upper bo
coveralls commented on PR #323:
URL: https://github.com/apache/datasketches-cpp/pull/323#issuecomment-1371529966
## Pull Request Test Coverage Report for [Build
3842299036](https://coveralls.io/builds/55652729)
* **0** of **0** changed or added relevant lines in **0** files are
cov
jmalkin commented on code in PR #322:
URL: https://github.com/apache/datasketches-cpp/pull/322#discussion_r1061817824
##
python/src/quantiles_wrapper.cpp:
##
@@ -114,12 +34,27 @@ void bind_quantiles_sketch(py::module &m, const char*
name) {
py::class_>(m, name)
.def(py:
leerho commented on issue #423:
URL:
https://github.com/apache/datasketches-java/issues/423#issuecomment-1370101440
Hello Arik,
We would be very interested in you contributing to our library. From your
paper it appears you wrote this sketch in C++, would your contribution be the
C
coveralls commented on PR #322:
URL: https://github.com/apache/datasketches-cpp/pull/322#issuecomment-1370098723
## Pull Request Test Coverage Report for [Build
3832015948](https://coveralls.io/builds/55608574)
* **0** of **0** changed or added relevant lines in **0** files are
cov
AlexanderSaydakov opened a new pull request, #322:
URL: https://github.com/apache/datasketches-cpp/pull/322
added iterators, rearranged and simplified existing code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
ArikRinberg opened a new issue, #423:
URL: https://github.com/apache/datasketches-java/issues/423
I was considering contributing a concurrent Quantiles sketch to the
framework, as detailed here: https://arxiv.org/abs/2208.09265
Would this be of interest to the library?
The impl
leerho merged PR #422:
URL: https://github.com/apache/datasketches-java/pull/422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@dat
leerho commented on PR #422:
URL:
https://github.com/apache/datasketches-java/pull/422#issuecomment-1351787674
CodeQL and Checkstyle are still quite different with different objectives. I
think we need both.
--
This is an automated message from the Apache Git Service.
To respond to the m
github-code-scanning[bot] commented on code in PR #422:
URL: https://github.com/apache/datasketches-java/pull/422#discussion_r1044930202
##
src/test/java/org/apache/datasketches/hll/UnionTest.java:
##
@@ -467,7 +467,7 @@
WritableMemory wmem = WritableMemory.allocate(bytes);
leerho opened a new pull request, #422:
URL: https://github.com/apache/datasketches-java/pull/422
CodeQL. However, there were some that I classified as "Won't Fix" and "False
Positive". But I'm not sure if CodeQL will remember those markings.
--
This is an automated message from the Apac
leerho merged PR #421:
URL: https://github.com/apache/datasketches-java/pull/421
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@dat
AlexanderSaydakov commented on issue #46:
URL:
https://github.com/apache/datasketches-postgresql/issues/46#issuecomment-1341464387
@developerwxl did you have a chance to gather some more information about
this?
--
This is an automated message from the Apache Git Service.
To respond to th
AlexanderSaydakov merged PR #57:
URL: https://github.com/apache/datasketches-postgresql/pull/57
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-
jmalkin merged PR #321:
URL: https://github.com/apache/datasketches-cpp/pull/321
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@dat
coveralls commented on PR #321:
URL: https://github.com/apache/datasketches-cpp/pull/321#issuecomment-1329782719
## Pull Request Test Coverage Report for [Build
3568235807](https://coveralls.io/builds/54629881)
* **0** of **0** changed or added relevant lines in **0** files are
cov
AlexanderSaydakov merged PR #320:
URL: https://github.com/apache/datasketches-cpp/pull/320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsub
coveralls commented on PR #320:
URL: https://github.com/apache/datasketches-cpp/pull/320#issuecomment-1314624827
## Pull Request Test Coverage Report for [Build
346647](https://coveralls.io/builds/54211925)
* **0** of **0** changed or added relevant lines in **0** files are
cov
AlexanderSaydakov opened a new pull request, #320:
URL: https://github.com/apache/datasketches-cpp/pull/320
to avoid warnings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
AlexanderSaydakov merged PR #319:
URL: https://github.com/apache/datasketches-cpp/pull/319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsub
jmalkin commented on code in PR #319:
URL: https://github.com/apache/datasketches-cpp/pull/319#discussion_r1019711386
##
kll/include/kll_sketch.hpp:
##
@@ -588,12 +588,14 @@ class kll_sketch {
template
class kll_sketch::const_iterator: public
std::iterator {
public:
+ using
AlexanderSaydakov commented on code in PR #319:
URL: https://github.com/apache/datasketches-cpp/pull/319#discussion_r1019710453
##
kll/include/kll_sketch.hpp:
##
@@ -588,12 +588,14 @@ class kll_sketch {
template
class kll_sketch::const_iterator: public
std::iterator {
public
jmalkin commented on code in PR #319:
URL: https://github.com/apache/datasketches-cpp/pull/319#discussion_r1019608915
##
kll/include/kll_sketch.hpp:
##
@@ -588,12 +588,14 @@ class kll_sketch {
template
class kll_sketch::const_iterator: public
std::iterator {
public:
+ using
andyndang commented on issue #54:
URL:
https://github.com/apache/datasketches-postgresql/issues/54#issuecomment-1308253974
@AlexanderSaydakov the fix works! Thank you! I'll close the issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
andyndang closed issue #54: Segfault when querying pre-built
frequent_items_string sketch
URL: https://github.com/apache/datasketches-postgresql/issues/54
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
AlexanderSaydakov commented on issue #54:
URL:
https://github.com/apache/datasketches-postgresql/issues/54#issuecomment-1308022991
@andyndang Did you have a chance to give this a go? I would like to close
this issue if the problem is resolved. Thank you.
--
This is an automated message f
p- opened a new pull request, #421:
URL: https://github.com/apache/datasketches-java/pull/421
Hi `apache/datasketches-java`!
This is not an automatic, 🤖-generated PR, as you can check in my [GitHub
profile](https://github.com/p-), I work for GitHub and I am part of the [GitHub
Securi
coveralls commented on PR #319:
URL: https://github.com/apache/datasketches-cpp/pull/319#issuecomment-1306447242
## Pull Request Test Coverage Report for [Build
3415357368](https://coveralls.io/builds/53988957)
* **0** of **0** changed or added relevant lines in **0** files are
cov
AlexanderSaydakov merged PR #56:
URL: https://github.com/apache/datasketches-postgresql/pull/56
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-
jmalkin merged PR #318:
URL: https://github.com/apache/datasketches-cpp/pull/318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@dat
jmalkin commented on code in PR #318:
URL: https://github.com/apache/datasketches-cpp/pull/318#discussion_r1015922588
##
common/include/version.hpp.in:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreemen
will-lauer commented on code in PR #318:
URL: https://github.com/apache/datasketches-cpp/pull/318#discussion_r1015917716
##
common/include/version.hpp.in:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agree
jmalkin commented on code in PR #318:
URL: https://github.com/apache/datasketches-cpp/pull/318#discussion_r1015915382
##
.gitignore:
##
@@ -1,3 +1,7 @@
+# output of configured files
+version.cfg
+common/include/version.hpp
Review Comment:
should be fixed now
--
This is a
jmalkin commented on code in PR #318:
URL: https://github.com/apache/datasketches-cpp/pull/318#discussion_r1015740131
##
.gitignore:
##
@@ -1,3 +1,7 @@
+# output of configured files
+version.cfg
+common/include/version.hpp
Review Comment:
what about version.cfg? and will it
will-lauer commented on code in PR #318:
URL: https://github.com/apache/datasketches-cpp/pull/318#discussion_r1015731454
##
.gitignore:
##
@@ -1,3 +1,7 @@
+# output of configured files
+version.cfg
+common/include/version.hpp
Review Comment:
generally, I wouldn't suggest cre
jmalkin commented on issue #260:
URL:
https://github.com/apache/datasketches-cpp/issues/260#issuecomment-1304608975
3.4.0 did not actually work, but 3.5.1 does. I was able to confirm that this
is now properly resolved.
--
This is an automated message from the Apache Git Service.
To respo
jmalkin commented on issue #286:
URL:
https://github.com/apache/datasketches-cpp/issues/286#issuecomment-1304608645
I know this was closed a while ago. We have looked into the issue and are
and trying to ensure the next major release will be able to support this, but
we don't yet have a ti
jmalkin closed issue #304: The Python package for ARM MacOS has an x86_64
datasketches.so in it
URL: https://github.com/apache/datasketches-cpp/issues/304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
jmalkin commented on issue #304:
URL:
https://github.com/apache/datasketches-cpp/issues/304#issuecomment-1304608401
At long last, this has been resolved. Pypi now has v3.5.1, which fixes this.
At least it worked when I tested it just now.
Apologies for the delay. The issue was very m
AlexanderSaydakov merged PR #55:
URL: https://github.com/apache/datasketches-postgresql/pull/55
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-
AlexanderSaydakov commented on issue #54:
URL:
https://github.com/apache/datasketches-postgresql/issues/54#issuecomment-1302904904
@andyndang If I am right, this is a small and subtle mistake of mine. Take a
look at the pull request: just removing "std::" prefix in one place should fix
thi
AlexanderSaydakov opened a new pull request, #55:
URL: https://github.com/apache/datasketches-postgresql/pull/55
hopefully fixes issue #54
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
AlexanderSaydakov commented on issue #54:
URL:
https://github.com/apache/datasketches-postgresql/issues/54#issuecomment-1302890129
I managed to reproduce the problem, and I think I know the cause. I will fix
shortly.
--
This is an automated message from the Apache Git Service.
To respond
jmalkin commented on code in PR #318:
URL: https://github.com/apache/datasketches-cpp/pull/318#discussion_r1013487650
##
CMakeLists.txt:
##
@@ -16,10 +16,24 @@
# under the License.
cmake_minimum_required(VERSION 3.16.0)
+
+string(TIMESTAMP DT %Y%m%d UTC)
+string(TIMESTAMP HH
AlexanderSaydakov commented on code in PR #318:
URL: https://github.com/apache/datasketches-cpp/pull/318#discussion_r1013481687
##
CMakeLists.txt:
##
@@ -16,10 +16,24 @@
# under the License.
cmake_minimum_required(VERSION 3.16.0)
+
+string(TIMESTAMP DT %Y%m%d UTC)
+string(TI
leerho closed pull request #169: Fix interaction between DefaultMemoryFactory
and
URL: https://github.com/apache/datasketches-memory/pull/169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
1 - 100 of 1247 matches
Mail list logo
