Re: [PR] Fix UBSan report while compiling with clang-18 [datasketches-cpp]

2024-05-16 Thread via GitHub
jmalkin merged PR #432: URL: https://github.com/apache/datasketches-cpp/pull/432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@dat

Re: [PR] Fix UBSan report while compiling with clang-18 [datasketches-cpp]

2024-05-16 Thread via GitHub
jmalkin commented on PR #432: URL: https://github.com/apache/datasketches-cpp/pull/432#issuecomment-2115884634 This makes sense. I don't think the existing code is unsafe, but UBSan has trouble determining that and (validly) complains. -- This is an automated message from the Apache Git S

Re: [PR] Fix UBSan report while compiling with clang-18 [datasketches-cpp]

2024-05-15 Thread via GitHub
coveralls commented on PR #432: URL: https://github.com/apache/datasketches-cpp/pull/432#issuecomment-2113705534 ## Pull Request Test Coverage Report for [Build 9103733837](https://coveralls.io/builds/67518255) ### Details * **1** of **1** **(100.0%)** changed or added r

[PR] Fix UBSan report while compiling with clang-18 [datasketches-cpp]

2024-05-15 Thread via GitHub
alexey-milovidov opened a new pull request, #432: URL: https://github.com/apache/datasketches-cpp/pull/432 This is a benign report. But clang-18 started to complain. See https://github.com/ClickHouse/ClickHouse/issues/63858 -- This is an automated message from the Apache Git Service