[GitHub] [incubator-dolphinscheduler] shitoubiao commented on issue #3584: [Bug][API] The Spark task runs in Cluster mode, executes successfully but the status of the task is shown to fail

2020-08-24 Thread GitBox
shitoubiao commented on issue #3584: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3584#issuecomment-679840756 The Spark task runs in Cluster mode, executes successfully then the status of the task is shown to submit success. ---

[GitHub] [incubator-dolphinscheduler] hsupu opened a new pull request #3587: [Improvement][server] unit test for SubProcessTask

2020-08-24 Thread GitBox
hsupu opened a new pull request #3587: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3587 ## What is the purpose of the pull request add the unit test for SubProcessTask ## Brief change log - add and enable the unit test for SubProcessTask ## Veri

[GitHub] [incubator-dolphinscheduler] breeze0812 commented on issue #3584: [Bug][API] The Spark task runs in Cluster mode, executes successfully but the status of the task is shown to fail

2020-08-24 Thread GitBox
breeze0812 commented on issue #3584: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3584#issuecomment-679817124 I checked the log on yarn and found no errors, what are the criteria for determining the execution state of the current Spark task? --

[GitHub] [incubator-dolphinscheduler] lgcareer commented on pull request #3053: [Feature-2154][api] Workflow version control

2020-08-24 Thread GitBox
lgcareer commented on pull request #3053: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3053#issuecomment-679798141 > > @yangyichao-mango Hi,So sorry for response so late,Because the process definition json includes datasource and resources,I think it's better to design t

[GitHub] [incubator-dolphinscheduler] xingchun-chen commented on issue #3584: [Bug][API] The Spark task runs in Cluster mode, executes successfully but the status of the task is shown to fail

2020-08-24 Thread GitBox
xingchun-chen commented on issue #3584: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3584#issuecomment-679781340 You can check if there is an error in the worker log This is an automated message from

[GitHub] [incubator-dolphinscheduler] geosmart removed a comment on issue #3548: [Bug][UI] Monitor gauge chart display blank with same pid

2020-08-24 Thread GitBox
geosmart removed a comment on issue #3548: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3548#issuecomment-679631452 fixed [#3563 ](https://github.com/apache/incubator-dolphinscheduler/pull/3563/commits/303a8d4aa1162fc09f35bf7dde3bd1e7e68e448d)

[GitHub] [incubator-dolphinscheduler] geosmart commented on issue #3548: [Bug][UI] Monitor gauge chart display blank with same pid

2020-08-24 Thread GitBox
geosmart commented on issue #3548: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3548#issuecomment-679631452 fixed [#3563 ](https://github.com/apache/incubator-dolphinscheduler/pull/3563/commits/303a8d4aa1162fc09f35bf7dde3bd1e7e68e448d)

[GitHub] [incubator-dolphinscheduler] geosmart closed issue #3548: [Bug][UI] Monitor gauge chart display blank with same pid

2020-08-24 Thread GitBox
geosmart closed issue #3548: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3548 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-dolphinscheduler] geosmart commented on issue #3548: [Bug][UI] Monitor gauge chart display blank with same pid

2020-08-24 Thread GitBox
geosmart commented on issue #3548: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3548#issuecomment-679632132 fixed [#3563 ](https://github.com/apache/incubator-dolphinscheduler/pull/3563/commits/303a8d4aa1162fc09f35bf7dde3bd1e7e68e448d)

[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on pull request #3511: [refactor][server-test] refactor RoundRobinHostManagerTest

2020-08-24 Thread GitBox
CalvinKirs commented on pull request #3511: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3511#issuecomment-679549533 > please resolved conflicts > +1 I have completed the changes, please check Thi

[GitHub] [incubator-dolphinscheduler] breeze0812 opened a new issue #3586: [Improvement][API] Extract the function `getConnection` from the `DataSourceService.java` as a public function

2020-08-24 Thread GitBox
breeze0812 opened a new issue #3586: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3586 **Describe the question** Extract the function `getConnection(DbType` dbType, String parameter)` from the `DataSourceService.java` as a public function **What are the current

[GitHub] [incubator-dolphinscheduler] cpsky commented on issue #3567: [Feature][api] admin batch activate users

2020-08-24 Thread GitBox
cpsky commented on issue #3567: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3567#issuecomment-679537862 https://github.com/apache/incubator-dolphinscheduler/pull/3578 This is an automated message from th

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3572: [fix-3553][ui]Repair click workflow connection, select the entire path

2020-08-24 Thread GitBox
sonarcloud[bot] commented on pull request #3572: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3572#issuecomment-679535247 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3572&resolved=false&types=

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3572: [fix-3553][ui]Repair click workflow connection, select the entire path

2020-08-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3572: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3572#issuecomment-679528737 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3572&resolved=fals

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3511: [refactor][server-test] refactor RoundRobinHostManagerTest

2020-08-24 Thread GitBox
sonarcloud[bot] commented on pull request #3511: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3511#issuecomment-679534099 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3511&resolved=false&types=

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3511: [refactor][server-test] refactor RoundRobinHostManagerTest

2020-08-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3511: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3511#issuecomment-676211104 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3511&resolved=fals

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3572: [fix-3553][ui]Repair click workflow connection, select the entire path

2020-08-24 Thread GitBox
sonarcloud[bot] commented on pull request #3572: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3572#issuecomment-679528737 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3572&resolved=false&types=

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3572: [fix-3553][ui]Repair click workflow connection, select the entire path

2020-08-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3572: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3572#issuecomment-678999133 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3572&resolved=fals

[GitHub] [incubator-dolphinscheduler] zhuangchong commented on pull request #3582: [Feature][API] process definition delete api add check process instance is already running. #3581

2020-08-24 Thread GitBox
zhuangchong commented on pull request #3582: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3582#issuecomment-679512794 > please resolve conflicts > +1 ok,resolved This is an automated message from

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3582: [Feature][API] process definition delete api add check process instance is already running. #3581

2020-08-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3582: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3582#issuecomment-679455001 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3582&resolved=fals

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3582: [Feature][API] process definition delete api add check process instance is already running. #3581

2020-08-24 Thread GitBox
sonarcloud[bot] commented on pull request #3582: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3582#issuecomment-679510951 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3582&resolved=false&types=

[incubator-dolphinscheduler] branch dev updated: [Fix-3077][ui] Fix the edit duplicated name verify (#3376)

2020-08-24 Thread journey
This is an automated email from the ASF dual-hosted git repository. journey pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git The following commit(s) were added to refs/heads/dev by this push: new 555880e [Fix-3077][ui] Fix the e

[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #3376: [Fix-3077][ui] Fix the edit duplicated name verify

2020-08-24 Thread GitBox
qiaozhanwei merged pull request #3376: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3376 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[incubator-dolphinscheduler] branch dev updated (efee53b -> 26184de)

2020-08-24 Thread journey
This is an automated email from the ASF dual-hosted git repository. journey pushed a change to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git. from efee53b [Improvement][server] server model ProcessUtils.java code cleaning. (#3382) add 261

[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #3585: [FIX][dolphinscheduler-common] presto array serialization error

2020-08-24 Thread GitBox
qiaozhanwei merged pull request #3585: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3585 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[incubator-dolphinscheduler] branch dev updated (2ba529a -> efee53b)

2020-08-24 Thread journey
This is an automated email from the ASF dual-hosted git repository. journey pushed a change to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git. from 2ba529a [Improvement][alert] Optimize alarm information (#3559) add efee53b [Improvement]

[incubator-dolphinscheduler] branch dev updated (2ba529a -> efee53b)

2020-08-24 Thread journey
This is an automated email from the ASF dual-hosted git repository. journey pushed a change to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git. from 2ba529a [Improvement][alert] Optimize alarm information (#3559) add efee53b [Improvement]

[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #3382: [Improvement][server] server model ProcessUtils.java code cleaning.

2020-08-24 Thread GitBox
qiaozhanwei merged pull request #3382: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3382 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[incubator-dolphinscheduler] branch dev updated (8fea8f9 -> 2ba529a)

2020-08-24 Thread journey
This is an automated email from the ASF dual-hosted git repository. journey pushed a change to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git. from 8fea8f9 [Test][server] Add the master server test case (#3574) add 2ba529a [Improvement][al

[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #3559: [Improvement][alert] Optimize alarm information

2020-08-24 Thread GitBox
qiaozhanwei merged pull request #3559: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3559 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-dolphinscheduler] gaoyu2016 closed issue #3569: [Bug][Module Name] sqoop任务中途退出,exit before timeout, exit value:127

2020-08-24 Thread GitBox
gaoyu2016 closed issue #3569: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3569 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3585: serialization error bug fix#3583

2020-08-24 Thread GitBox
sonarcloud[bot] commented on pull request #3585: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3585#issuecomment-679477349 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3585&resolved=false&types=

[GitHub] [incubator-dolphinscheduler] codecov-commenter commented on pull request #3585: serialization error bug fix#3583

2020-08-24 Thread GitBox
codecov-commenter commented on pull request #3585: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3585#issuecomment-679473053 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3585?src=pr&el=h1) Report > Merging [#3585](https://codecov.io/gh/apac

[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #3574: [Test][server] Add the `server module` master server and `zk` e2e test case example

2020-08-24 Thread GitBox
qiaozhanwei merged pull request #3574: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3574 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[incubator-dolphinscheduler] branch dev updated: [Test][server] Add the master server test case (#3574)

2020-08-24 Thread journey
This is an automated email from the ASF dual-hosted git repository. journey pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git The following commit(s) were added to refs/heads/dev by this push: new 8fea8f9 [Test][server] Add the m

[incubator-dolphinscheduler] branch dev updated: [Improvement-3556] remove unnecessary try catch, and do the unittest … (#3563)

2020-08-24 Thread journey
This is an automated email from the ASF dual-hosted git repository. journey pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git The following commit(s) were added to refs/heads/dev by this push: new f7c4b0f [Improvement-3556] remov

[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #3563: [Improvement-3556] remove unnecessary try catch, and do the unittest …

2020-08-24 Thread GitBox
qiaozhanwei merged pull request #3563: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3563 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[incubator-dolphinscheduler] branch dev updated (c003cd1 -> 93660f4)

2020-08-24 Thread journey
This is an automated email from the ASF dual-hosted git repository. journey pushed a change to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git. from c003cd1 [Improvement-3369][api] Introduce tenant service interface for clear code (#3420) a

[incubator-dolphinscheduler] branch dev updated (93660f4 -> 34a04ac)

2020-08-24 Thread journey
This is an automated email from the ASF dual-hosted git repository. journey pushed a change to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git. from 93660f4 [Feature-2154][api] Workflow version control (#3053) add 34a04ac [Improvement][remo

[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #3580: [Improvement][remote] improvement netty eventLoopGroup

2020-08-24 Thread GitBox
qiaozhanwei merged pull request #3580: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3580 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #3053: [Feature-2154][api] Workflow version control

2020-08-24 Thread GitBox
qiaozhanwei merged pull request #3053: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3053 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-dolphinscheduler] zshit opened a new pull request #3585: serialization error bug fix#3583

2020-08-24 Thread GitBox
zshit opened a new pull request #3585: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3585 ## *Tips* - *Thanks very much for contributing to Apache DolphinScheduler.* - *Please review https://dolphinscheduler.apache.org/en-us/community/index.html before opening a pull

[GitHub] [incubator-dolphinscheduler] breeze0812 opened a new issue #3584: [Bug][API] The Spark task runs in Cluster mode, executes successfully but the status of the task is shown to fail

2020-08-24 Thread GitBox
breeze0812 opened a new issue #3584: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3584 use version 1.3.1 of Dolphinscheduler: **Describe the bug** The Spark task runs in Cluster mode, executes successfully but the status of the task is shown to fail. **T

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3053: [Feature-2154][api] Workflow version control

2020-08-24 Thread GitBox
sonarcloud[bot] commented on pull request #3053: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3053#issuecomment-679467648 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3053&resolved=false&types=

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3053: [Feature-2154][api] Workflow version control

2020-08-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3053: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3053#issuecomment-679142464 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3053&resolved=fals

[GitHub] [incubator-dolphinscheduler] zshit opened a new issue #3583: [Bug][Module Name] Bug title

2020-08-24 Thread GitBox
zshit opened a new issue #3583: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3583 **Which version of Dolphin Scheduler:** - [branch: dev ; commitId:836e86dca50ac636f66e0b2a881b183b322329e8] **Describe the bug** serialization error when presto-jdbc resultset

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] edited a comment on pull request #3053: [Feature-2154][api] Workflow version control

2020-08-24 Thread GitBox
sonarcloud[bot] edited a comment on pull request #3053: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3053#issuecomment-679142464 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3053&resolved=false

[incubator-dolphinscheduler] branch dev updated (eade9db -> c003cd1)

2020-08-24 Thread journey
This is an automated email from the ASF dual-hosted git repository. journey pushed a change to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git. from eade9db [test-2995][e2e]Optimize waiting time (#3571) add c003cd1 [Improvement-3369][api]

[incubator-dolphinscheduler] branch dev updated (eade9db -> c003cd1)

2020-08-24 Thread journey
This is an automated email from the ASF dual-hosted git repository. journey pushed a change to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git. from eade9db [test-2995][e2e]Optimize waiting time (#3571) add c003cd1 [Improvement-3369][api]

[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #3420: [Improvement-3369][api] Introduce tenant service interface for clear code

2020-08-24 Thread GitBox
qiaozhanwei merged pull request #3420: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3420 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3582: [Feature][API] process definition delete api add check process instance is already running. #3581

2020-08-24 Thread GitBox
sonarcloud[bot] commented on pull request #3582: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3582#issuecomment-679455001 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3582&resolved=false&types=

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3582: [Feature][API] process definition delete api add check process instance is already running. #3581

2020-08-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3582: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3582#issuecomment-679058857 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3582&resolved=fals

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3053: [Feature-2154][api] Workflow version control

2020-08-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3053: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3053#issuecomment-679140840 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3053: [Feature-2154][api] Workflow version control

2020-08-24 Thread GitBox
sonarcloud[bot] commented on pull request #3053: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3053#issuecomment-679142373 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3053: [Feature-2154][api] Workflow version control

2020-08-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3053: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3053#issuecomment-679142070 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3053: [Feature-2154][api] Workflow version control

2020-08-24 Thread GitBox
sonarcloud[bot] commented on pull request #3053: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3053#issuecomment-679142037 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3053: [Feature-2154][api] Workflow version control

2020-08-24 Thread GitBox
sonarcloud[bot] commented on pull request #3053: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3053#issuecomment-679140840 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3053&resolved=false&types=

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3053: [Feature-2154][api] Workflow version control

2020-08-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3053: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3053#issuecomment-679138652 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3053&resolved=fals

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3053: [Feature-2154][api] Workflow version control

2020-08-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3053: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3053#issuecomment-679133373 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3053&resolved=false&types

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3053: [Feature-2154][api] Workflow version control

2020-08-24 Thread GitBox
sonarcloud[bot] commented on pull request #3053: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3053#issuecomment-679138652 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3053&resolved=false&types=

[GitHub] [incubator-dolphinscheduler] codecov-commenter edited a comment on pull request #3053: [Feature-2154][api] Workflow version control

2020-08-24 Thread GitBox
codecov-commenter edited a comment on pull request #3053: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3053#issuecomment-659855047 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3053?src=pr&el=h1) Report > Merging [#3053](https://codecov.io/

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3053: [Feature-2154][api] Workflow version control

2020-08-24 Thread GitBox
sonarcloud[bot] commented on pull request #3053: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3053#issuecomment-679133373 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3053&resolved=false&types=BUG) [

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3053: [Feature-2154][api] Workflow version control

2020-08-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3053: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3053#issuecomment-679131377 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3053&resolved=false&types

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3053: [Feature-2154][api] Workflow version control

2020-08-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3053: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3053#issuecomment-679125925 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3053&resolved=false&types

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3053: [Feature-2154][api] Workflow version control

2020-08-24 Thread GitBox
sonarcloud[bot] commented on pull request #3053: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3053#issuecomment-679131377 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3053&resolved=false&types=BUG) [

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3053: [Feature-2154][api] Workflow version control

2020-08-24 Thread GitBox
sonarcloud[bot] commented on pull request #3053: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3053#issuecomment-679125925 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3053&resolved=false&types=BUG) [

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3053: [Feature-2154][api] Workflow version control

2020-08-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3053: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3053#issuecomment-679123328 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3053&resolved=false&types

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3053: [Feature-2154][api] Workflow version control

2020-08-24 Thread GitBox
sonarcloud[bot] commented on pull request #3053: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3053#issuecomment-679123328 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3053&resolved=false&types=BUG) [

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3580: [Improvement][remote] improvement netty eventLoopGroup

2020-08-24 Thread GitBox
sonarcloud[bot] commented on pull request #3580: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3580#issuecomment-679080732 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3580&resolved=false&types=

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3580: [Improvement][remote] improvement netty eventLoopGroup

2020-08-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3580: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3580#issuecomment-679076234 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3580&resolved=fals

[GitHub] [incubator-dolphinscheduler] codecov-commenter commented on pull request #3580: [Improvement][remote] improvement netty eventLoopGroup

2020-08-24 Thread GitBox
codecov-commenter commented on pull request #3580: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3580#issuecomment-679079654 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3580?src=pr&el=h1) Report > Merging [#3580](https://codecov.io/gh/apac

[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on pull request #3053: [Feature-2154][api] Workflow version control

2020-08-24 Thread GitBox
yangyichao-mango commented on pull request #3053: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3053#issuecomment-679078834 > @yangyichao-mango Hi,So sorry for response so late,Because the process definition json includes datasource and resources,I think it's better to des

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3580: [Improvement][remote] improvement netty eventLoopGroup

2020-08-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3580: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3580#issuecomment-679067749 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3580&resolved=fals

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3580: [Improvement][remote] improvement netty eventLoopGroup

2020-08-24 Thread GitBox
sonarcloud[bot] commented on pull request #3580: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3580#issuecomment-679076234 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3580&resolved=false&types=

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3580: [Improvement][remote] improvement netty eventLoopGroup

2020-08-24 Thread GitBox
sonarcloud[bot] commented on pull request #3580: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3580#issuecomment-679067749 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3580&resolved=false&types=

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3580: [Improvement][remote] improvement netty eventLoopGroup

2020-08-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3580: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3580#issuecomment-678920222 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3580&resolved=false&types

[GitHub] [incubator-dolphinscheduler] zhuangchong commented on pull request #3383: [Improvement][server] WATERDROP task plug-in optimization in switch case code cleaning.

2020-08-24 Thread GitBox
zhuangchong commented on pull request #3383: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3383#issuecomment-679061935 @dailidong Help. This branch code is switch case code cleaning. Can you merge Dev ? thx. --

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3582: [Feature][API] process definition delete api add check process instance is already running. #3581

2020-08-24 Thread GitBox
sonarcloud[bot] commented on pull request #3582: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3582#issuecomment-679058857 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3582&resolved=false&types=

[GitHub] [incubator-dolphinscheduler] zhuangchong opened a new pull request #3582: [Feature][API] process definition delete api add check process instance is already running. #3581

2020-08-24 Thread GitBox
zhuangchong opened a new pull request #3582: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3582 ## What is the purpose of the pull request The workflow definition deletion function is added to check whether there are running workflow instances according to the wo

[GitHub] [incubator-dolphinscheduler] zhuangchong opened a new issue #3581: [Feature][API] process definition delete api add check process instance is already running.

2020-08-24 Thread GitBox
zhuangchong opened a new issue #3581: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3581 **Describe the feature** To delete a workflow definition in the workflow definition page, check whether there is a running workflow instance. If there is a running workflow instan

[incubator-dolphinscheduler] branch dev updated: [test-2995][e2e]Optimize waiting time (#3571)

2020-08-24 Thread journey
This is an automated email from the ASF dual-hosted git repository. journey pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git The following commit(s) were added to refs/heads/dev by this push: new eade9db [test-2995][e2e]Optimize

[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #3571: [test-2995][e2e]Optimize waiting time

2020-08-24 Thread GitBox
qiaozhanwei merged pull request #3571: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3571 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3571: [test-2995][e2e]Optimize waiting time

2020-08-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3571: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3571#issuecomment-678966808 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3571&resolved=fals

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3571: [test-2995][e2e]Optimize waiting time

2020-08-24 Thread GitBox
sonarcloud[bot] commented on pull request #3571: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3571#issuecomment-678999858 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3571&resolved=false&types=

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3572: [fix-3553][ui]Repair click workflow connection, select the entire path

2020-08-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3572: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3572#issuecomment-678873988 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3572&resolved=fals

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3572: [fix-3553][ui]Repair click workflow connection, select the entire path

2020-08-24 Thread GitBox
sonarcloud[bot] commented on pull request #3572: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3572#issuecomment-678999133 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3572&resolved=false&types=

[GitHub] [incubator-dolphinscheduler] dailidong closed issue #3558: [Test][api] Improvement `DataSourceServiceTest`

2020-08-24 Thread GitBox
dailidong closed issue #3558: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3558 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-dolphinscheduler] branch dev updated: [Improvement-3558][API] Improve `DataSourceServiceTest.java` (#3579)

2020-08-24 Thread lidongdai
This is an automated email from the ASF dual-hosted git repository. lidongdai pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git The following commit(s) were added to refs/heads/dev by this push: new 78eb07b [Improvement-3558][API

[GitHub] [incubator-dolphinscheduler] dailidong merged pull request #3579: [Improvement-3558][API] Improve `DataSourceServiceTest.java`

2020-08-24 Thread GitBox
dailidong merged pull request #3579: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3579 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] edited a comment on pull request #3579: [Improvement-3558][API] Improve `DataSourceServiceTest.java`

2020-08-24 Thread GitBox
sonarcloud[bot] edited a comment on pull request #3579: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3579#issuecomment-678881191 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3579&resolved=false

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] edited a comment on pull request #3579: [Improvement-3558][API] Improve `DataSourceServiceTest.java`

2020-08-24 Thread GitBox
sonarcloud[bot] edited a comment on pull request #3579: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3579#issuecomment-678881191 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3579&resolved=false

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] edited a comment on pull request #3579: [Improvement-3558][API] Improve `DataSourceServiceTest.java`

2020-08-24 Thread GitBox
sonarcloud[bot] edited a comment on pull request #3579: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3579#issuecomment-678881191 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3579&resolved=false&types=

[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on pull request #3580: [Improvement][remote] improvement netty eventLoopGroup

2020-08-24 Thread GitBox
CalvinKirs commented on pull request #3580: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3580#issuecomment-678976538 > +1, > > But can you list any benchmarks about this improvement? Thank you very much for your review, but about this issue, I think you can

[GitHub] [incubator-dolphinscheduler] SunJiFengPlus commented on issue #3557: [Test][api] Improvement `DataAnalysisServiceTest`

2020-08-24 Thread GitBox
SunJiFengPlus commented on issue #3557: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3557#issuecomment-678971485 Change to this ``` java public Map countQueueState(User loginUser, int projectId) { Map result = new HashMap<>(5); boolea

[GitHub] [incubator-dolphinscheduler] SunJiFengPlus commented on issue #3557: [Test][api] Improvement `DataAnalysisServiceTest`

2020-08-24 Thread GitBox
SunJiFengPlus commented on issue #3557: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3557#issuecomment-678970830 Current in ```DataAnalysisServiceImpl::countQueueState```, except for project check failure, it will only return all count are 0, can i delete redundant log

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3571: [test-2995][e2e]Optimize waiting time

2020-08-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3571: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3571#issuecomment-678957410 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3571&resolved=fals

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3571: [test-2995][e2e]Optimize waiting time

2020-08-24 Thread GitBox
sonarcloud[bot] commented on pull request #3571: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3571#issuecomment-678966808 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3571&resolved=false&types=

[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on pull request #3580: [Improvement][remote] improvement netty eventLoopGroup

2020-08-24 Thread GitBox
yangyichao-mango commented on pull request #3580: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3580#issuecomment-678964086 +1, But can you list any benchmarks about this improvement? This is an autom

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3571: [test-2995][e2e]Optimize waiting time

2020-08-24 Thread GitBox
sonarcloud[bot] commented on pull request #3571: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3571#issuecomment-678957410 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3571&resolved=false&types=

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3571: [test-2995][e2e]Optimize waiting time

2020-08-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3571: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3571#issuecomment-678568353 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3571&resolved=fals

  1   2   >