[GitHub] [incubator-dolphinscheduler] gaojun2048 commented on issue #3754: [Feature][Alert] Alert module support service for other service invoke

gaojun2048 commented on issue #3754: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3754#issuecomment-703182141 > OK, I have read dolphinscheduler-alert's code, i think it can reference dubbo's design, and the core class EmailAlertPlugin has serious coupling, it can be o

[GitHub] [incubator-dolphinscheduler] hermeshephaestus commented on issue #3754: [Feature][Alert] Alert module support service for other service invoke

hermeshephaestus commented on issue #3754: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3754#issuecomment-703133999 OK, I have read dolphinscheduler-alert's code, i think it can reference dubbo's design, and the core class EmailAlertPlugin has serious coupling, it can

[GitHub] [incubator-dolphinscheduler] hermeshephaestus commented on issue #2869: [Proposal] DolphinScheduler Plugin Design

hermeshephaestus commented on issue #2869: URL: https://github.com/apache/incubator-dolphinscheduler/issues/2869#issuecomment-703129572 That's cool, dubbo's design is using a lot of Plugin Design(also called spi). User can customize function. I want to join the big feature's developpin

[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on pull request #3867: [Fix-3840][server] Fix When the tenant code is a number, it should not be saved successfully

CalvinKirs commented on pull request #3867: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3867#issuecomment-703123680 > By the way, because the change of issue #3540 is really small, i have submitted the same pr together, please check the commits. @CalvinKirs @yangyichao-

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3867: [Fix-3840][server] Fix When the tenant code is a number, it should not be saved successfully

sonarcloud[bot] commented on pull request #3867: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3867#issuecomment-703123275 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3867&resolved=false&types=

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3867: [Fix-3840][server] Fix When the tenant code is a number, it should not be saved successfully

sonarcloud[bot] removed a comment on pull request #3867: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3867#issuecomment-703119600 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3867&resolved=fals

[GitHub] [incubator-dolphinscheduler] hermeshephaestus commented on pull request #3867: [Fix-3840][server] Fix When the tenant code is a number, it should not be saved successfully

hermeshephaestus commented on pull request #3867: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3867#issuecomment-703122978 By the way, because the change of issue #3540 is really small, i have submitted the same pr together, please check the commits. @CalvinKirs @yangyic

[GitHub] [incubator-dolphinscheduler] hermeshephaestus commented on issue #3540: [Bug][api] There are annotation spelling errors in TaskRecordController

hermeshephaestus commented on issue #3540: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3540#issuecomment-703121360 OK, i will submit a pr to resolve it. @yangyichao-mango @yangxifi This is an automated

[GitHub] [incubator-dolphinscheduler] hermeshephaestus commented on a change in pull request #3867: [Fix-3840][server] Fix When the tenant code is a number, it should not be saved successfully

hermeshephaestus commented on a change in pull request #3867: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3867#discussion_r499156858 ## File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/RegexUtils.java ## @@ -0,0 +1,44 @@ +

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3867: [Fix-3840][server] Fix When the tenant code is a number, it should not be saved successfully

sonarcloud[bot] removed a comment on pull request #3867: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3867#issuecomment-702503694 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3867&resolved=fals

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3867: [Fix-3840][server] Fix When the tenant code is a number, it should not be saved successfully

sonarcloud[bot] commented on pull request #3867: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3867#issuecomment-703119600 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3867&resolved=false&types=

[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on a change in pull request #3867: [Fix-3840][server] Fix When the tenant code is a number, it should not be saved successfully

CalvinKirs commented on a change in pull request #3867: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3867#discussion_r499153863 ## File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/RegexUtils.java ## @@ -0,0 +1,44 @@ +/* + *

[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on a change in pull request #3867: [Fix-3840][server] Fix When the tenant code is a number, it should not be saved successfully

CalvinKirs commented on a change in pull request #3867: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3867#discussion_r499153697 ## File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/RegexUtils.java ## @@ -0,0 +1,44 @@ +/* + *