Re: [PR] [Feature-16396][storage-plugin] Add Tencent Cloud COS Storage Plugin [dolphinscheduler]

2024-09-22 Thread via GitHub
SbloodyS commented on code in PR #16565: URL: https://github.com/apache/dolphinscheduler/pull/16565#discussion_r1770832899 ## dolphinscheduler-storage-plugin/dolphinscheduler-storage-cos/pom.xml: ## @@ -0,0 +1,47 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://ww

Re: [PR] [Feature-16396][storage-plugin] Add Tencent Cloud COS Storage Plugin [dolphinscheduler]

2024-09-22 Thread via GitHub
fuchanghai commented on code in PR #16565: URL: https://github.com/apache/dolphinscheduler/pull/16565#discussion_r1770829102 ## dolphinscheduler-storage-plugin/dolphinscheduler-storage-cos/pom.xml: ## @@ -0,0 +1,47 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://

Re: [PR] [Feature-16396][storage-plugin] Add Tencent Cloud COS Storage Plugin [dolphinscheduler]

2024-09-22 Thread via GitHub
fuchanghai commented on code in PR #16565: URL: https://github.com/apache/dolphinscheduler/pull/16565#discussion_r1770829102 ## dolphinscheduler-storage-plugin/dolphinscheduler-storage-cos/pom.xml: ## @@ -0,0 +1,47 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://

Re: [PR] [Feature-16396][storage-plugin] Add Tencent Cloud COS Storage Plugin [dolphinscheduler]

2024-09-22 Thread via GitHub
Mighten commented on code in PR #16565: URL: https://github.com/apache/dolphinscheduler/pull/16565#discussion_r1770825420 ## dolphinscheduler-storage-plugin/dolphinscheduler-storage-cos/pom.xml: ## @@ -0,0 +1,47 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www

Re: [I] [DSIP-74] optimize workflow-related displays and filters [dolphinscheduler]

2024-09-22 Thread via GitHub
sdhzwc commented on issue #16631: URL: https://github.com/apache/dolphinscheduler/issues/16631#issuecomment-2367319532 > > ![image](https://private-user-images.githubusercontent.com/46134044/369736633-92d7806e-bd2f-47ed-b4f7-56b53dd53e68.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3Mi

Re: [PR] [Improvement-16647][UI][Workflow Instance] Remove deprecated workflow execution states [dolphinscheduler]

2024-09-22 Thread via GitHub
sonarcloud[bot] commented on PR #16648: URL: https://github.com/apache/dolphinscheduler/pull/16648#issuecomment-2367315965 Please retry analysis of this Pull-Request directly on SonarCloud -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [I] [DSIP-74] optimize workflow-related displays and filters [dolphinscheduler]

2024-09-22 Thread via GitHub
SbloodyS commented on issue #16631: URL: https://github.com/apache/dolphinscheduler/issues/16631#issuecomment-2367308017 > ![image](https://private-user-images.githubusercontent.com/46134044/369736633-92d7806e-bd2f-47ed-b4f7-56b53dd53e68.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3Mi

Re: [I] [Feature] Security Model [dolphinscheduler]

2024-09-22 Thread via GitHub
davidzollo commented on issue #16608: URL: https://github.com/apache/dolphinscheduler/issues/16608#issuecomment-2367296741 Great job! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [Improvement-16647][UI][Workflow Instance]remove deprecated workflow execution states [dolphinscheduler]

2024-09-22 Thread via GitHub
SbloodyS commented on PR #16648: URL: https://github.com/apache/dolphinscheduler/pull/16648#issuecomment-2367280832 > Like this? Yes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] [Feature-16396][storage-plugin] Add Tencent Cloud COS Storage Plugin [dolphinscheduler]

2024-09-22 Thread via GitHub
sonarcloud[bot] commented on PR #16565: URL: https://github.com/apache/dolphinscheduler/pull/16565#issuecomment-2367280785 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](http

Re: [PR] [Feature-16396][storage-plugin] Add Tencent Cloud COS Storage Plugin [dolphinscheduler]

2024-09-22 Thread via GitHub
sonarcloud[bot] commented on PR #16565: URL: https://github.com/apache/dolphinscheduler/pull/16565#issuecomment-2367280506 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](http

Re: [PR] [Improvement-16647][UI][Workflow Instance]remove deprecated workflow execution states [dolphinscheduler]

2024-09-22 Thread via GitHub
sdhzwc commented on PR #16648: URL: https://github.com/apache/dolphinscheduler/pull/16648#issuecomment-2367279471 > To to target specific issue from PR, we recommend use keyword fix: #issue_id or close: #issue_id or closes: #issue_id in your PR describe(not title, just desc). It would not

Re: [PR] [Improvement-16647][UI][Workflow Instance]remove deprecated workflow execution states [dolphinscheduler]

2024-09-22 Thread via GitHub
SbloodyS commented on PR #16648: URL: https://github.com/apache/dolphinscheduler/pull/16648#issuecomment-2367271837 To to target specific issue from PR, we recommend use keyword fix: #issue_id or close: #issue_id or closes: #issue_id in your PR describe(not title, just desc). It would not

Re: [PR] [Feature-16396][storage-plugin] Add Tencent Cloud COS Storage Plugin [dolphinscheduler]

2024-09-22 Thread via GitHub
SbloodyS commented on code in PR #16565: URL: https://github.com/apache/dolphinscheduler/pull/16565#discussion_r1770789511 ## dolphinscheduler-storage-plugin/dolphinscheduler-storage-cos/pom.xml: ## @@ -0,0 +1,47 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://ww

Re: [PR] [Feature-16396][storage-plugin] Add Tencent Cloud COS Storage Plugin [dolphinscheduler]

2024-09-22 Thread via GitHub
Mighten commented on code in PR #16565: URL: https://github.com/apache/dolphinscheduler/pull/16565#discussion_r1770777688 ## dolphinscheduler-storage-plugin/dolphinscheduler-storage-cos/pom.xml: ## @@ -0,0 +1,47 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www

(dolphinscheduler-website) branch asf-site updated: Automated deployment: 98e28613fc121ab56bfc7b84b199b626231c0e6a

2024-09-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/dolphinscheduler-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 103afbd6de Automated d

Re: [PR] [Feature-16396][storage-plugin] Add Tencent Cloud COS Storage Plugin [dolphinscheduler]

2024-09-22 Thread via GitHub
Mighten commented on code in PR #16565: URL: https://github.com/apache/dolphinscheduler/pull/16565#discussion_r1770766692 ## dolphinscheduler-storage-plugin/dolphinscheduler-storage-cos/src/main/java/org/apache/dolphinscheduler/plugin/storage/cos/CosStorageOperator.java: ## @@

Re: [PR] [Fix-16567] Unable to delete copied nodes in unsaved workflow [dolphinscheduler]

2024-09-22 Thread via GitHub
sonarcloud[bot] commented on PR #16576: URL: https://github.com/apache/dolphinscheduler/pull/16576#issuecomment-2367185279 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](http

Re: [PR] [Fix-16567] Unable to delete copied nodes in unsaved workflow [dolphinscheduler]

2024-09-22 Thread via GitHub
sonarcloud[bot] commented on PR #16576: URL: https://github.com/apache/dolphinscheduler/pull/16576#issuecomment-2367184697 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](http

Re: [PR] [Fix-16578] Fix environment resource permission [dolphinscheduler]

2024-09-22 Thread via GitHub
wangxj3 commented on code in PR #16579: URL: https://github.com/apache/dolphinscheduler/pull/16579#discussion_r1770730357 ## dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/permission/ResourcePermissionCheckServiceImpl.java: ## @@ -256,6 +256,9 @@ public stat

[PR] [Improvement-16647][UI][Workflow Instance]remove deprecated workflow execution states [dolphinscheduler]

2024-09-22 Thread via GitHub
sdhzwc opened a new pull request, #16648: URL: https://github.com/apache/dolphinscheduler/pull/16648 #16647 ## Purpose of the pull request ## Brief change log ## Verify this pull request This pull request is code cleanup without any test co

Re: [PR] [Fix-16578] Fix environment resource permission [dolphinscheduler]

2024-09-22 Thread via GitHub
ruanwenjun commented on code in PR #16579: URL: https://github.com/apache/dolphinscheduler/pull/16579#discussion_r1770722478 ## dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/permission/ResourcePermissionCheckServiceImpl.java: ## @@ -256,6 +256,9 @@ public s

Re: [I] [DSIP-74] optimize workflow-related displays and filters [dolphinscheduler]

2024-09-22 Thread via GitHub
sdhzwc commented on issue #16631: URL: https://github.com/apache/dolphinscheduler/issues/16631#issuecomment-2367123750 > > But for the column name dynamic display and hide (I am a front-end white, to achieve this for me a bit of a struggle), found > that put in a bit out of place feeling,

Re: [PR] [Fix-16573][alert] SQL task alert sending failed [dolphinscheduler]

2024-09-22 Thread via GitHub
SbloodyS commented on code in PR #16595: URL: https://github.com/apache/dolphinscheduler/pull/16595#discussion_r1770718258 ## dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java: ## @@ -253,9 +255,18 @@ p

Re: [I] [DSIP-74] optimize workflow-related displays and filters [dolphinscheduler]

2024-09-22 Thread via GitHub
sdhzwc commented on issue #16631: URL: https://github.com/apache/dolphinscheduler/issues/16631#issuecomment-2367122843 > > But for the column name dynamic display and hide (I am a front-end white, to achieve this for me a bit of a struggle), found > that put in a bit out of place feeling,

Re: [PR] [Feature-16300][registry] Added Consul-based Register implementation [dolphinscheduler]

2024-09-22 Thread via GitHub
SbloodyS closed pull request #16301: [Feature-16300][registry] Added Consul-based Register implementation URL: https://github.com/apache/dolphinscheduler/pull/16301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] [DSIP-74] optimize workflow-related displays and filters [dolphinscheduler]

2024-09-22 Thread via GitHub
SbloodyS commented on issue #16631: URL: https://github.com/apache/dolphinscheduler/issues/16631#issuecomment-2367119631 > But for the column name dynamic display and hide (I am a front-end white, to achieve this for me a bit of a struggle), found > that put in a bit out of place feeling,

Re: [PR] [Feature-16396][storage-plugin] Tencent Cloud COS Storage Plugin [dolphinscheduler]

2024-09-22 Thread via GitHub
SbloodyS commented on code in PR #16565: URL: https://github.com/apache/dolphinscheduler/pull/16565#discussion_r1770714449 ## dolphinscheduler-storage-plugin/dolphinscheduler-storage-cos/pom.xml: ## @@ -0,0 +1,47 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://ww

Re: [PR] [DSIP-38] Add plugin directory in binary package [dolphinscheduler]

2024-09-22 Thread via GitHub
EricGao888 commented on PR #16613: URL: https://github.com/apache/dolphinscheduler/pull/16613#issuecomment-2367110859 Seems there were some network issues when I clicked `Approve` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] [DSIP-38] Add plugin directory in binary package [dolphinscheduler]

2024-09-22 Thread via GitHub
SbloodyS merged PR #16613: URL: https://github.com/apache/dolphinscheduler/pull/16613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

Re: [I] [Improvement] Shade plugin jar [dolphinscheduler]

2024-09-22 Thread via GitHub
SbloodyS closed issue #16096: [Improvement] Shade plugin jar URL: https://github.com/apache/dolphinscheduler/issues/16096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[I] [Bug] [Workflow Instance] The workflow execution status has been removed from the back-end, should it not be removed from the front-end as well? [dolphinscheduler]

2024-09-22 Thread via GitHub
sdhzwc opened a new issue, #16647: URL: https://github.com/apache/dolphinscheduler/issues/16647 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened

Re: [I] [Improvement] Move plugin to plugin directory [dolphinscheduler]

2024-09-22 Thread via GitHub
SbloodyS closed issue #16097: [Improvement] Move plugin to plugin directory URL: https://github.com/apache/dolphinscheduler/issues/16097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] [Improvement-16612][Master] For logical tasks on the Master, there should be support for dry run [dolphinscheduler]

2024-09-22 Thread via GitHub
sonarcloud[bot] commented on PR #16616: URL: https://github.com/apache/dolphinscheduler/pull/16616#issuecomment-2367097464 Please retry analysis of this Pull-Request directly on SonarCloud -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] [Improvement-16612][Master] For logical tasks on the Master, there should be support for dry run [dolphinscheduler]

2024-09-22 Thread via GitHub
sonarcloud[bot] commented on PR #16616: URL: https://github.com/apache/dolphinscheduler/pull/16616#issuecomment-2367097319 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](http

Re: [PR] [Feature-16396][storage-plugin] Tencent Cloud COS Storage Plugin [dolphinscheduler]

2024-09-22 Thread via GitHub
SbloodyS commented on code in PR #16565: URL: https://github.com/apache/dolphinscheduler/pull/16565#discussion_r1770701485 ## dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/log/remote/CosRemoteLogHandler.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to t

Re: [PR] [Feature-16396][storage-plugin] Tencent Cloud COS Storage Plugin [dolphinscheduler]

2024-09-22 Thread via GitHub
fuchanghai commented on PR #16565: URL: https://github.com/apache/dolphinscheduler/pull/16565#issuecomment-2367088026 > Since we don't have any tencent cos support for integration testing. I will -1 on this until we can find a way to test against this in out UT, IT and E2E. If ```CO

Re: [I] [DSIP-74] optimize workflow-related displays and filters [dolphinscheduler]

2024-09-22 Thread via GitHub
sdhzwc commented on issue #16631: URL: https://github.com/apache/dolphinscheduler/issues/16631#issuecomment-2367087170 > > This program can be a good solution to the problem of many fields, the user can customize the choice of fields to display, > you can look at this moving picture >

Re: [I] Is there a problem with the oauth2 configuration document? [dolphinscheduler]

2024-09-22 Thread via GitHub
github-actions[bot] closed issue #15454: Is there a problem with the oauth2 configuration document? URL: https://github.com/apache/dolphinscheduler/issues/15454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [I] Is there a problem with the oauth2 configuration document? [dolphinscheduler]

2024-09-22 Thread via GitHub
github-actions[bot] commented on issue #15454: URL: https://github.com/apache/dolphinscheduler/issues/15454#issuecomment-2367041050 This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future. --

Re: [I] [Feature][DatasourcePlugin] Add DolphinDB datasource in datasource plugin [dolphinscheduler]

2024-09-22 Thread via GitHub
github-actions[bot] commented on issue #15953: URL: https://github.com/apache/dolphinscheduler/issues/15953#issuecomment-2367041027 This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity

Re: [I] [ERROR] 2024-08-21 16:36:57.120 +0800 o.a.d.a.s.i.ResourcesServiceImpl:[496] - current user does not have permission [dolphinscheduler]

2024-09-22 Thread via GitHub
github-actions[bot] commented on issue #16502: URL: https://github.com/apache/dolphinscheduler/issues/16502#issuecomment-2367040968 This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity

Re: [PR] [Fix-16567] Unable to delete copied nodes in unsaved workflow [dolphinscheduler]

2024-09-22 Thread via GitHub
sonarcloud[bot] commented on PR #16576: URL: https://github.com/apache/dolphinscheduler/pull/16576#issuecomment-2366332095 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](http

Re: [PR] [Fix-16567] Unable to delete copied nodes in unsaved workflow [dolphinscheduler]

2024-09-22 Thread via GitHub
sonarcloud[bot] commented on PR #16576: URL: https://github.com/apache/dolphinscheduler/pull/16576#issuecomment-2366327591 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](http

Re: [I] [Bug] [MASTER] When Serial Wait workflow are frequently scheduled, serially waiting workflow might get stuck [dolphinscheduler]

2024-09-22 Thread via GitHub
CloudSen commented on issue #16369: URL: https://github.com/apache/dolphinscheduler/issues/16369#issuecomment-2366306798 @Gallardot Here’s another example for `saveSerialProcess`: In concurrent scenarios (multiple parent workflows with the same scheduling cycle reference the same sub-workf

Re: [PR] [Feature-16396][storage-plugin] Tencent Cloud COS Storage Plugin [dolphinscheduler]

2024-09-22 Thread via GitHub
sonarcloud[bot] commented on PR #16565: URL: https://github.com/apache/dolphinscheduler/pull/16565#issuecomment-2366293592 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](http

Re: [PR] [Feature-16396][storage-plugin] Tencent Cloud COS Storage Plugin [dolphinscheduler]

2024-09-22 Thread via GitHub
sonarcloud[bot] commented on PR #16565: URL: https://github.com/apache/dolphinscheduler/pull/16565#issuecomment-2366293498 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](http

Re: [PR] [DSIP-38] Add plugin directory in binary package [dolphinscheduler]

2024-09-22 Thread via GitHub
sonarcloud[bot] commented on PR #16613: URL: https://github.com/apache/dolphinscheduler/pull/16613#issuecomment-2366262279 Please retry analysis of this Pull-Request directly on SonarCloud -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] [DSIP-38] Add plugin directory in binary package [dolphinscheduler]

2024-09-22 Thread via GitHub
sonarcloud[bot] commented on PR #16613: URL: https://github.com/apache/dolphinscheduler/pull/16613#issuecomment-2366262206 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](http

[I] [Improvement] Load plugins using a separate class loader [dolphinscheduler]

2024-09-22 Thread via GitHub
SbloodyS opened a new issue, #16646: URL: https://github.com/apache/dolphinscheduler/issues/16646 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement. ### Des

Re: [PR] [Feature-16396][storage-plugin] Tencent Cloud COS Storage Plugin [dolphinscheduler]

2024-09-22 Thread via GitHub
sonarcloud[bot] commented on PR #16565: URL: https://github.com/apache/dolphinscheduler/pull/16565#issuecomment-2366112273 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](http

Re: [PR] [Feature-16396][storage-plugin] Tencent Cloud COS Storage Plugin [dolphinscheduler]

2024-09-22 Thread via GitHub
sonarcloud[bot] commented on PR #16565: URL: https://github.com/apache/dolphinscheduler/pull/16565#issuecomment-2366107685 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](http

[I] [Improvement] Optimize dependency tree [dolphinscheduler]

2024-09-22 Thread via GitHub
ruanwenjun opened a new issue, #16098: URL: https://github.com/apache/dolphinscheduler/issues/16098 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement. ### D

Re: [PR] [DSIP-75] Support auto add license header by spotless [dolphinscheduler]

2024-09-22 Thread via GitHub
SbloodyS merged PR #16643: URL: https://github.com/apache/dolphinscheduler/pull/16643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

Re: [I] [DSIP-75] Support auto add license header by spotless [dolphinscheduler]

2024-09-22 Thread via GitHub
SbloodyS closed issue #16642: [DSIP-75] Support auto add license header by spotless URL: https://github.com/apache/dolphinscheduler/issues/16642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s