[GitHub] [incubator-dolphinscheduler] lonkin1 commented on pull request #3449: SqlTask result email should not throw exception

[GitBox]

lonkin1 commented on pull request #3449:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/3449#issuecomment-671723024


   When the SQL operation is successful, the processing of the results should 
not block the whole process. It is recommended to add policies to avoid 
throwing exceptions directly.
   
   ---Original---
   From: "qiaozhanwei"<notificati...@github.com&gt;
   Date: Mon, Aug 10, 2020 14:42 PM
   To: 
"apache/incubator-dolphinscheduler"<incubator-dolphinschedu...@noreply.github.com&gt;;
   Cc: "Author"<aut...@noreply.github.com&gt;;"lonkin"<247610...@qq.com&gt;;
   Subject: Re: [apache/incubator-dolphinscheduler] SqlTask result email should 
not throw exception (#3449)
   
   
   
   
    
   At the beginning of the design, it is necessary to send emails for SQL query 
tasks, otherwise the SQL will be meaningless. If the email fails to be sent, 
the task will fail. Have other advice ?
    
   设计之初是这样的，对于SQL的查询任务是需要发送邮件的，否则SQL将无意义，如果邮件发送失败，任务将失败。你有更好的建议么？
    
   —
   You are receiving this because you authored the thread.
   Reply to this email directly, view it on GitHub, or unsubscribe.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org