samz406 commented on a change in pull request #1618: before delete Udf check
exist
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/1618#discussion_r361793368
##########
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/UdfFuncService.java
##########
@@ -303,7 +303,12 @@ private boolean checkUdfFuncNameExists(String name){
@Transactional(rollbackFor = Exception.class)
public Result delete(int id) {
Result result = new Result();
-
+ //check exist
Review comment:
I have expressed a problem, this is not to say that the delete order is
adjusted. The delete method modifies the question. Order adjustment refers to
the checkUdfFuncNameExists method. My understanding is that you should first
determine if udf exists and then check if hdfs is started.
我表述的有问题，这里不是说delete顺序调整。delete方法修改的是提示问题。顺序调整是指checkUdfFuncNameExists方法。我的理解是应该先判断udf是否存在然后再去检查hdfs是否启动。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
