[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1534: Add SparkArgsUtilsTest which is the UT of SparkArgsUtils

2019-12-20 Thread GitBox
codecov-io commented on issue #1534: Add SparkArgsUtilsTest which is the UT of SparkArgsUtils URL: https://github.com/apache/incubator-dolphinscheduler/pull/1534#issuecomment-568036435 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1534?src=pr&el=h1) Report >

[GitHub] [incubator-dolphinscheduler] Yeleights opened a new pull request #1535: modify FileUtils.readFile2Str

2019-12-20 Thread GitBox
Yeleights opened a new pull request #1535: modify FileUtils.readFile2Str URL: https://github.com/apache/incubator-dolphinscheduler/pull/1535 ## What is the purpose of the pull request *modify FileUtils.readFile2Str* ## Brief change log - *modify FileUtils.readFile2Str*

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1535: modify FileUtils.readFile2Str

2019-12-20 Thread GitBox
codecov-io commented on issue #1535: modify FileUtils.readFile2Str URL: https://github.com/apache/incubator-dolphinscheduler/pull/1535#issuecomment-568144226 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1535?src=pr&el=h1) Report > Merging [#1535](https://co

[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1535: modify FileUtils.readFile2Str

2019-12-20 Thread GitBox
qiaozhanwei merged pull request #1535: modify FileUtils.readFile2Str URL: https://github.com/apache/incubator-dolphinscheduler/pull/1535 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1502: Login verification supports jwt mode

2019-12-20 Thread GitBox
codecov-io edited a comment on issue #1502: Login verification supports jwt mode URL: https://github.com/apache/incubator-dolphinscheduler/pull/1502#issuecomment-566437422 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1502?src=pr&el=h1) Report > Merging [#15

[GitHub] [incubator-dolphinscheduler] elonlo commented on issue #1465: [CI/CD]Add unit test

2019-12-21 Thread GitBox
elonlo commented on issue #1465: [CI/CD]Add unit test URL: https://github.com/apache/incubator-dolphinscheduler/issues/1465#issuecomment-568165323 I want to implement org.apache.dolphinscheduler.api.enums This is an automated

[GitHub] [incubator-dolphinscheduler] Technoboy- edited a comment on issue #1519: return result state for each interface method

2019-12-21 Thread GitBox
Technoboy- edited a comment on issue #1519: return result state for each interface method URL: https://github.com/apache/incubator-dolphinscheduler/pull/1519#issuecomment-567380815 > > > > Hi, bro, thanks for contribution. > > > > this pr looks not useful, it we add return value for the

[GitHub] [incubator-dolphinscheduler] elonlo opened a new pull request #1536: Add Status and ExecuteType class unit tests #1465

2019-12-21 Thread GitBox
elonlo opened a new pull request #1536: Add Status and ExecuteType class unit tests #1465 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1536 ## What is the purpose of the pull request - add Status class unit test - add ExecuteType class unit test ## Brief

[GitHub] [incubator-dolphinscheduler] Technoboy- commented on a change in pull request #1536: Add Status and ExecuteType class unit tests #1465

2019-12-21 Thread GitBox
Technoboy- commented on a change in pull request #1536: Add Status and ExecuteType class unit tests #1465 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1536#discussion_r360640541 ## File path: dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/enum

[GitHub] [incubator-dolphinscheduler] Technoboy- commented on a change in pull request #1536: Add Status and ExecuteType class unit tests #1465

2019-12-21 Thread GitBox
Technoboy- commented on a change in pull request #1536: Add Status and ExecuteType class unit tests #1465 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1536#discussion_r360640537 ## File path: dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/enum

[GitHub] [incubator-dolphinscheduler] Technoboy- commented on a change in pull request #1536: Add Status and ExecuteType class unit tests #1465

2019-12-21 Thread GitBox
Technoboy- commented on a change in pull request #1536: Add Status and ExecuteType class unit tests #1465 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1536#discussion_r360640528 ## File path: dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/enum

[GitHub] [incubator-dolphinscheduler] elonlo commented on issue #1536: Add Status and ExecuteType class unit tests #1465

2019-12-21 Thread GitBox
elonlo commented on issue #1536: Add Status and ExecuteType class unit tests #1465 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1536#issuecomment-568168625 o.o okay This is an automated message from the Apa

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1536: Add Status and ExecuteType class unit tests #1465

2019-12-21 Thread GitBox
codecov-io commented on issue #1536: Add Status and ExecuteType class unit tests #1465 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1536#issuecomment-568168622 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1536?src=pr&el=h1) Report > Mergin

[GitHub] [incubator-dolphinscheduler] Technoboy- commented on issue #1508: remove duplicate code

2019-12-21 Thread GitBox
Technoboy- commented on issue #1508: remove duplicate code URL: https://github.com/apache/incubator-dolphinscheduler/pull/1508#issuecomment-568168725 > remove duplicate code for this project Hi bro, how about splitting this change into more pull requests? you can do it like : 2 o

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1536: Add Status and ExecuteType class unit tests #1465

2019-12-21 Thread GitBox
codecov-io edited a comment on issue #1536: Add Status and ExecuteType class unit tests #1465 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1536#issuecomment-568168622 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1536?src=pr&el=h1) Report >

[GitHub] [incubator-dolphinscheduler] clay4444 opened a new pull request #1537: refactor zk client and zk config module

2019-12-21 Thread GitBox
clay opened a new pull request #1537: refactor zk client and zk config module URL: https://github.com/apache/incubator-dolphinscheduler/pull/1537 ## What is the purpose of the pull request the main purpose of this pr is to refactor the dependency on zk, including zk config depen

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1537: refactor zk client and zk config module

2019-12-21 Thread GitBox
codecov-io commented on issue #1537: refactor zk client and zk config module URL: https://github.com/apache/incubator-dolphinscheduler/pull/1537#issuecomment-568188281 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1537?src=pr&el=h1) Report > Merging [#1537](

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1537: refactor zk client and zk config module

2019-12-21 Thread GitBox
codecov-io edited a comment on issue #1537: refactor zk client and zk config module URL: https://github.com/apache/incubator-dolphinscheduler/pull/1537#issuecomment-568188281 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1537?src=pr&el=h1) Report > Merging

[GitHub] [incubator-dolphinscheduler] wenhemin commented on issue #1509: [Feature] packaged and deployed

2019-12-21 Thread GitBox
wenhemin commented on issue #1509: [Feature] packaged and deployed URL: https://github.com/apache/incubator-dolphinscheduler/issues/1509#issuecomment-568225691 I take a look at the dev branch, application-master.properties has 5566 port, this port has no effect. if you remove this por

[GitHub] [incubator-dolphinscheduler] samz406 commented on issue #1465: [CI/CD]Add unit test

2019-12-21 Thread GitBox
samz406 commented on issue #1465: [CI/CD]Add unit test URL: https://github.com/apache/incubator-dolphinscheduler/issues/1465#issuecomment-568237843 and I want to implements org.apache.dolphinscheduler.api.service.AccessTokenService org.apache.dolphinscheduler.api.service.QueueService

[GitHub] [incubator-dolphinscheduler] break60 opened a new pull request #1538: Script input box style fix

2019-12-21 Thread GitBox
break60 opened a new pull request #1538: Script input box style fix URL: https://github.com/apache/incubator-dolphinscheduler/pull/1538 ## *Tips* - *Thanks very much for contributing to Apache DolphinScheduler.* - *Please review https://dolphinscheduler.apache.org/en-us/community/inde

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1538: Script input box style fix

2019-12-21 Thread GitBox
codecov-io commented on issue #1538: Script input box style fix URL: https://github.com/apache/incubator-dolphinscheduler/pull/1538#issuecomment-568239139 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1538?src=pr&el=h1) Report > Merging [#1538](https://codec

[GitHub] [incubator-dolphinscheduler] clay4444 commented on issue #1537: refactor zk client and zk config module

2019-12-22 Thread GitBox
clay commented on issue #1537: refactor zk client and zk config module URL: https://github.com/apache/incubator-dolphinscheduler/pull/1537#issuecomment-568256343 > TaskQueueZkImpl is not nice. > Should not have initZkClient to init zk. > System should use the same client in Zookee

[GitHub] [incubator-dolphinscheduler] Technoboy- commented on a change in pull request #1532: fix MasterBaseTaskExecThread submit method bug

2019-12-22 Thread GitBox
Technoboy- commented on a change in pull request #1532: fix MasterBaseTaskExecThread submit method bug URL: https://github.com/apache/incubator-dolphinscheduler/pull/1532#discussion_r360705450 ## File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/m

[GitHub] [incubator-dolphinscheduler] dailidong merged pull request #1538: Script input box style fix

2019-12-22 Thread GitBox
dailidong merged pull request #1538: Script input box style fix URL: https://github.com/apache/incubator-dolphinscheduler/pull/1538 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-dolphinscheduler] zhangdehai commented on issue #1476: dolphinscheduler version:1.2.0,start API in idea,Invalid server.port specified in application-dao.properties file,The startup

2019-12-22 Thread GitBox
zhangdehai commented on issue #1476: dolphinscheduler version:1.2.0,start API in idea,Invalid server.port specified in application-dao.properties file,The startup log is as follows: URL: https://github.com/apache/incubator-dolphinscheduler/issues/1476#issuecomment-568325487 hi, hhy8545259

[GitHub] [incubator-dolphinscheduler] swxchappy opened a new issue #1539: [QUESTION] question title

2019-12-22 Thread GitBox
swxchappy opened a new issue #1539: [QUESTION] question title URL: https://github.com/apache/incubator-dolphinscheduler/issues/1539 *For better global communication, please give priority to using English description, thx! * **Describe the question** A clear and concise description

[GitHub] [incubator-dolphinscheduler] swxchappy opened a new issue #1540: [QUESTION] question title

2019-12-22 Thread GitBox
swxchappy opened a new issue #1540: [QUESTION] question title URL: https://github.com/apache/incubator-dolphinscheduler/issues/1540 *For better global communication, please give priority to using English description, thx! * **Describe the question** A clear and concise description

[GitHub] [incubator-dolphinscheduler] glxfeng commented on issue #1526: [BUG] version 1.2 "/tmp/dolphinscheduler/" 目录权限问题 directory permission

2019-12-22 Thread GitBox
glxfeng commented on issue #1526: [BUG] version 1.2 "/tmp/dolphinscheduler/" 目录权限问题 directory permission URL: https://github.com/apache/incubator-dolphinscheduler/issues/1526#issuecomment-568340409 我用dolphinscheduler用户安装了ds,不是用root用户。 I use user dolphinscheduler to install ds. 修

[GitHub] [incubator-dolphinscheduler] swxchappy commented on issue #1540: [QUESTION] question title

2019-12-22 Thread GitBox
swxchappy commented on issue #1540: [QUESTION] question title URL: https://github.com/apache/incubator-dolphinscheduler/issues/1540#issuecomment-568340379 一个流程中只有一个任务,当该任务被禁止时,执行该流程是否应该失败? This is an automated message from th

[GitHub] [incubator-dolphinscheduler] zjcnb commented on issue #1508: remove duplicate code

2019-12-22 Thread GitBox
zjcnb commented on issue #1508: remove duplicate code URL: https://github.com/apache/incubator-dolphinscheduler/pull/1508#issuecomment-568348782 > > remove duplicate code for this project > > Hi bro, how about splitting this change into more pull requests? > you can do it like : 2

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1508: remove duplicate code

2019-12-22 Thread GitBox
codecov-io commented on issue #1508: remove duplicate code URL: https://github.com/apache/incubator-dolphinscheduler/pull/1508#issuecomment-568349248 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1508?src=pr&el=h1) Report > Merging [#1508](https://codecov.io

[GitHub] [incubator-dolphinscheduler] zjcnb closed pull request #1508: remove duplicate code

2019-12-22 Thread GitBox
zjcnb closed pull request #1508: remove duplicate code URL: https://github.com/apache/incubator-dolphinscheduler/pull/1508 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-dolphinscheduler] zjcnb opened a new pull request #1541: remove duplicated code

2019-12-22 Thread GitBox
zjcnb opened a new pull request #1541: remove duplicated code URL: https://github.com/apache/incubator-dolphinscheduler/pull/1541 remove duplicated code This is an automated message from the Apache Git Service. To respond to t

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1541: remove duplicated code

2019-12-22 Thread GitBox
codecov-io commented on issue #1541: remove duplicated code URL: https://github.com/apache/incubator-dolphinscheduler/pull/1541#issuecomment-568362050 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541?src=pr&el=h1) Report > Merging [#1541](https://codecov.i

[GitHub] [incubator-dolphinscheduler] swxchappy closed issue #1539: [QUESTION] question title

2019-12-22 Thread GitBox
swxchappy closed issue #1539: [QUESTION] question title URL: https://github.com/apache/incubator-dolphinscheduler/issues/1539 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-dolphinscheduler] swxchappy removed a comment on issue #1540: [QUESTION]There is only one task in a process. Should the process fail when the task is banned?

2019-12-22 Thread GitBox
swxchappy removed a comment on issue #1540: [QUESTION]There is only one task in a process. Should the process fail when the task is banned? URL: https://github.com/apache/incubator-dolphinscheduler/issues/1540#issuecomment-568340379 一个流程中只有一个任务,当该任务被禁止时,执行该流程是否应该失败? --

[GitHub] [incubator-dolphinscheduler] lgcareer merged pull request #1534: Add SparkArgsUtilsTest which is the UT of SparkArgsUtils

2019-12-22 Thread GitBox
lgcareer merged pull request #1534: Add SparkArgsUtilsTest which is the UT of SparkArgsUtils URL: https://github.com/apache/incubator-dolphinscheduler/pull/1534 This is an automated message from the Apache Git Service. To re

[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1230: Bump bootstrap from 3.3.7 to 3.4.1 in /escheduler-ui

2019-12-22 Thread GitBox
dependabot[bot] commented on issue #1230: Bump bootstrap from 3.3.7 to 3.4.1 in /escheduler-ui URL: https://github.com/apache/incubator-dolphinscheduler/pull/1230#issuecomment-568390092 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in t

[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1232: Bump jquery from 1.12.4 to 3.4.1 in /escheduler-ui

2019-12-22 Thread GitBox
dependabot[bot] commented on issue #1232: Bump jquery from 1.12.4 to 3.4.1 in /escheduler-ui URL: https://github.com/apache/incubator-dolphinscheduler/pull/1232#issuecomment-568390129 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the

[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1231: Bump axios from 0.16.2 to 0.19.0 in /escheduler-ui/src/lib/@fedor/io

2019-12-22 Thread GitBox
dependabot[bot] commented on issue #1231: Bump axios from 0.16.2 to 0.19.0 in /escheduler-ui/src/lib/@fedor/io URL: https://github.com/apache/incubator-dolphinscheduler/pull/1231#issuecomment-568390131 Dependabot tried to update this pull request, but something went wrong. We're looking i

[GitHub] [incubator-dolphinscheduler] Yeleights commented on issue #1300: [FEATURE]Add right alignment function in sql email content

2019-12-22 Thread GitBox
Yeleights commented on issue #1300: [FEATURE]Add right alignment function in sql email content URL: https://github.com/apache/incubator-dolphinscheduler/issues/1300#issuecomment-568393488 i will do this This is an automated

[GitHub] [incubator-dolphinscheduler] Yeleights opened a new pull request #1542: #1300 Add right alignment function in sql email content

2019-12-23 Thread GitBox
Yeleights opened a new pull request #1542: #1300 Add right alignment function in sql email content URL: https://github.com/apache/incubator-dolphinscheduler/pull/1542 ## *Tips* ## What is the purpose of the pull request *Add right alignment function in sql email content* ## Brief c

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1542: #1300 Add right alignment function in sql email content

2019-12-23 Thread GitBox
codecov-io commented on issue #1542: #1300 Add right alignment function in sql email content URL: https://github.com/apache/incubator-dolphinscheduler/pull/1542#issuecomment-568399614 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1542?src=pr&el=h1) Report >

[GitHub] [incubator-dolphinscheduler] zjcnb commented on issue #1541: remove duplicated code

2019-12-23 Thread GitBox
zjcnb commented on issue #1541: remove duplicated code URL: https://github.com/apache/incubator-dolphinscheduler/pull/1541#issuecomment-568408410 > how about keeping the code the same ? > like : add TableField in Alert class I don't know,@TableField annotation,It is need to retain

[GitHub] [incubator-dolphinscheduler] Yeleights commented on issue #1542: #1300 Add right alignment function in sql email content

2019-12-23 Thread GitBox
Yeleights commented on issue #1542: #1300 Add right alignment function in sql email content URL: https://github.com/apache/incubator-dolphinscheduler/pull/1542#issuecomment-568410680 @qiaozhanwei @Technoboy- This is an auto

[GitHub] [incubator-dolphinscheduler] Technoboy- commented on issue #1541: remove duplicated code

2019-12-23 Thread GitBox
Technoboy- commented on issue #1541: remove duplicated code URL: https://github.com/apache/incubator-dolphinscheduler/pull/1541#issuecomment-568417376 > > how about keeping the code the same ? > > like : add TableField in Alert class > > I don't know,@TableField annotation,It is n

[GitHub] [incubator-dolphinscheduler] zjcnb commented on issue #1541: remove duplicated code

2019-12-23 Thread GitBox
zjcnb commented on issue #1541: remove duplicated code URL: https://github.com/apache/incubator-dolphinscheduler/pull/1541#issuecomment-568418553 > > > how about keeping the code the same ? > > > like : add TableField in Alert class > > > > > > I don't know,@TableField annotat

[GitHub] [incubator-dolphinscheduler] Technoboy- commented on issue #1541: remove duplicated code

2019-12-23 Thread GitBox
Technoboy- commented on issue #1541: remove duplicated code URL: https://github.com/apache/incubator-dolphinscheduler/pull/1541#issuecomment-568419069 > > > > how about keeping the code the same ? > > > > like : add TableField in Alert class > > > > > > > > > I don't know,@Tab

[GitHub] [incubator-dolphinscheduler] zjcnb commented on issue #1541: remove duplicated code

2019-12-23 Thread GitBox
zjcnb commented on issue #1541: remove duplicated code URL: https://github.com/apache/incubator-dolphinscheduler/pull/1541#issuecomment-568419423 > > > > > how about keeping the code the same ? > > > > > like : add TableField in Alert class > > > > > > > > > > > > I don't know

[GitHub] [incubator-dolphinscheduler] elonlo closed pull request #1502: Login verification supports jwt mode

2019-12-23 Thread GitBox
elonlo closed pull request #1502: Login verification supports jwt mode URL: https://github.com/apache/incubator-dolphinscheduler/pull/1502 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [incubator-dolphinscheduler] elonlo opened a new pull request #1543: Refactor login verification process

2019-12-23 Thread GitBox
elonlo opened a new pull request #1543: Refactor login verification process URL: https://github.com/apache/incubator-dolphinscheduler/pull/1543 ## What is the purpose of the pull request Refactor login authentication process, use interface ## Brief change log - *Authen

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1543: Refactor login verification process

2019-12-23 Thread GitBox
codecov-io commented on issue #1543: Refactor login verification process URL: https://github.com/apache/incubator-dolphinscheduler/pull/1543#issuecomment-568450522 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr&el=h1) Report > Merging [#1543](http

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1543: Refactor login verification process

2019-12-23 Thread GitBox
codecov-io edited a comment on issue #1543: Refactor login verification process URL: https://github.com/apache/incubator-dolphinscheduler/pull/1543#issuecomment-568450522 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr&el=h1) Report > Merging [#154

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1543: Refactor login verification process

2019-12-23 Thread GitBox
codecov-io edited a comment on issue #1543: Refactor login verification process URL: https://github.com/apache/incubator-dolphinscheduler/pull/1543#issuecomment-568450522 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr&el=h1) Report > Merging [#154

[GitHub] [incubator-dolphinscheduler] Technoboy- commented on a change in pull request #1537: refactor zk client and zk config module

2019-12-23 Thread GitBox
Technoboy- commented on a change in pull request #1537: refactor zk client and zk config module URL: https://github.com/apache/incubator-dolphinscheduler/pull/1537#discussion_r360910371 ## File path: dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/zk/Zooke

[GitHub] [incubator-dolphinscheduler] Yeleights commented on issue #747: Log desensitization(日志脱敏)

2019-12-23 Thread GitBox
Yeleights commented on issue #747: Log desensitization(日志脱敏) URL: https://github.com/apache/incubator-dolphinscheduler/issues/747#issuecomment-568618722 i will fix it This is an automated message from the Apache Git Service.

[GitHub] [incubator-dolphinscheduler] xingchun-chen opened a new issue #1544: The workflow import user's other project or other user's project, the database table t_ds_process_definition stores data i

2019-12-23 Thread GitBox
xingchun-chen opened a new issue #1544: The workflow import user's other project or other user's project, the database table t_ds_process_definition stores data incorrectly URL: https://github.com/apache/incubator-dolphinscheduler/issues/1544 *For better global communication, please give p

[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1488: add api/controller unit test

2019-12-23 Thread GitBox
qiaozhanwei merged pull request #1488: add api/controller unit test URL: https://github.com/apache/incubator-dolphinscheduler/pull/1488 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-dolphinscheduler] qiaozhanwei commented on a change in pull request #1532: fix MasterBaseTaskExecThread submit method bug

2019-12-23 Thread GitBox
qiaozhanwei commented on a change in pull request #1532: fix MasterBaseTaskExecThread submit method bug URL: https://github.com/apache/incubator-dolphinscheduler/pull/1532#discussion_r361069044 ## File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/

[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1536: Add Status and ExecuteType class unit tests #1465

2019-12-23 Thread GitBox
qiaozhanwei merged pull request #1536: Add Status and ExecuteType class unit tests #1465 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1536 This is an automated message from the Apache Git Service. To respon

[GitHub] [incubator-dolphinscheduler] break60 opened a new pull request #1545: Front-end compliance modification

2019-12-23 Thread GitBox
break60 opened a new pull request #1545: Front-end compliance modification URL: https://github.com/apache/incubator-dolphinscheduler/pull/1545 ## *Tips* - *Thanks very much for contributing to Apache DolphinScheduler.* - *Please review https://dolphinscheduler.apache.org/en-us/communi

[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1231: Bump axios from 0.16.2 to 0.19.0 in /escheduler-ui/src/lib/@fedor/io

2019-12-23 Thread GitBox
dependabot[bot] commented on issue #1231: Bump axios from 0.16.2 to 0.19.0 in /escheduler-ui/src/lib/@fedor/io URL: https://github.com/apache/incubator-dolphinscheduler/pull/1231#issuecomment-568660835 Dependabot tried to update this pull request, but something went wrong. We're looking i

[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1230: Bump bootstrap from 3.3.7 to 3.4.1 in /escheduler-ui

2019-12-23 Thread GitBox
dependabot[bot] commented on issue #1230: Bump bootstrap from 3.3.7 to 3.4.1 in /escheduler-ui URL: https://github.com/apache/incubator-dolphinscheduler/pull/1230#issuecomment-568660834 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in t

[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1232: Bump jquery from 1.12.4 to 3.4.1 in /escheduler-ui

2019-12-23 Thread GitBox
dependabot[bot] commented on issue #1232: Bump jquery from 1.12.4 to 3.4.1 in /escheduler-ui URL: https://github.com/apache/incubator-dolphinscheduler/pull/1232#issuecomment-568660832 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the

[GitHub] [incubator-dolphinscheduler] break60 opened a new pull request #1546: Front-end third-party js, css introduced using npm

2019-12-23 Thread GitBox
break60 opened a new pull request #1546: Front-end third-party js, css introduced using npm URL: https://github.com/apache/incubator-dolphinscheduler/pull/1546 ## *Tips* - *Thanks very much for contributing to Apache DolphinScheduler.* - *Please review https://dolphinscheduler.apache

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1546: Front-end third-party js, css introduced using npm

2019-12-23 Thread GitBox
codecov-io commented on issue #1546: Front-end third-party js, css introduced using npm URL: https://github.com/apache/incubator-dolphinscheduler/pull/1546#issuecomment-568663165 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1546?src=pr&el=h1) Report > Mergi

[GitHub] [incubator-dolphinscheduler] lgcareer merged pull request #1545: Front-end compliance modification

2019-12-23 Thread GitBox
lgcareer merged pull request #1545: Front-end compliance modification URL: https://github.com/apache/incubator-dolphinscheduler/pull/1545 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1232: Bump jquery from 1.12.4 to 3.4.1 in /escheduler-ui

2019-12-23 Thread GitBox
dependabot[bot] commented on issue #1232: Bump jquery from 1.12.4 to 3.4.1 in /escheduler-ui URL: https://github.com/apache/incubator-dolphinscheduler/pull/1232#issuecomment-568671208 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the

[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1230: Bump bootstrap from 3.3.7 to 3.4.1 in /escheduler-ui

2019-12-23 Thread GitBox
dependabot[bot] commented on issue #1230: Bump bootstrap from 3.3.7 to 3.4.1 in /escheduler-ui URL: https://github.com/apache/incubator-dolphinscheduler/pull/1230#issuecomment-568671209 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in t

[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1231: Bump axios from 0.16.2 to 0.19.0 in /escheduler-ui/src/lib/@fedor/io

2019-12-23 Thread GitBox
dependabot[bot] commented on issue #1231: Bump axios from 0.16.2 to 0.19.0 in /escheduler-ui/src/lib/@fedor/io URL: https://github.com/apache/incubator-dolphinscheduler/pull/1231#issuecomment-568671210 Dependabot tried to update this pull request, but something went wrong. We're looking i

[GitHub] [incubator-dolphinscheduler] elonlo opened a new issue #1547: [Feature] node text edit box supports full-screen magnification(节点文本编辑框支持全屏放大)

2019-12-23 Thread GitBox
elonlo opened a new issue #1547: [Feature] node text edit box supports full-screen magnification(节点文本编辑框支持全屏放大) URL: https://github.com/apache/incubator-dolphinscheduler/issues/1547 **Is your feature request related to a problem? Please describe.** The node text edit box supports full-sc

[GitHub] [incubator-dolphinscheduler] lgcareer commented on a change in pull request #1542: #1300 Add right alignment function in sql email content

2019-12-23 Thread GitBox
lgcareer commented on a change in pull request #1542: #1300 Add right alignment function in sql email content URL: https://github.com/apache/incubator-dolphinscheduler/pull/1542#discussion_r361083271 ## File path: dolphinscheduler-alert/src/main/resources/mail_templates/alert_mail

[GitHub] [incubator-dolphinscheduler] Yeleights commented on a change in pull request #1542: #1300 Add right alignment function in sql email content

2019-12-23 Thread GitBox
Yeleights commented on a change in pull request #1542: #1300 Add right alignment function in sql email content URL: https://github.com/apache/incubator-dolphinscheduler/pull/1542#discussion_r361085833 ## File path: dolphinscheduler-alert/src/main/resources/mail_templates/alert_mai

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1542: #1300 Add right alignment function in sql email content

2019-12-23 Thread GitBox
codecov-io edited a comment on issue #1542: #1300 Add right alignment function in sql email content URL: https://github.com/apache/incubator-dolphinscheduler/pull/1542#issuecomment-568399614 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1542?src=pr&el=h1) Repor

[GitHub] [incubator-dolphinscheduler] break60 opened a new pull request #1548: Front-end supplemental license

2019-12-24 Thread GitBox
break60 opened a new pull request #1548: Front-end supplemental license URL: https://github.com/apache/incubator-dolphinscheduler/pull/1548 ## *Tips* - *Thanks very much for contributing to Apache DolphinScheduler.* - *Please review https://dolphinscheduler.apache.org/en-us/community/

[GitHub] [incubator-dolphinscheduler] break60 opened a new pull request #1549: Front-end supplemental license

2019-12-24 Thread GitBox
break60 opened a new pull request #1549: Front-end supplemental license URL: https://github.com/apache/incubator-dolphinscheduler/pull/1549 ## *Tips* - *Thanks very much for contributing to Apache DolphinScheduler.* - *Please review https://dolphinscheduler.apache.org/en-us/community/

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1548: Front-end supplemental license

2019-12-24 Thread GitBox
codecov-io commented on issue #1548: Front-end supplemental license URL: https://github.com/apache/incubator-dolphinscheduler/pull/1548#issuecomment-568687947 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1548?src=pr&el=h1) Report > Merging [#1548](https://c

[GitHub] [incubator-dolphinscheduler] modehuan opened a new issue #1550: 补数据按区间执行

2019-12-24 Thread GitBox
modehuan opened a new issue #1550: 补数据按区间执行 URL: https://github.com/apache/incubator-dolphinscheduler/issues/1550 在系统初始化数据时,针对一些大的流水表数据不需要按日增量的方式跑数,几年的数据,按天的补数太慢了.做成按时间段跑数据可以有效解决这个问题.比如按年 按月  按周 或者自定义区间的每隔多少天执行一次. 例:定义补数区间从20160101-当前时间,每隔一年(或者一个月)时间跑一次任务.那就会在20170101跑一次前一年(20160101-2017

[GitHub] [incubator-dolphinscheduler] wenhemin opened a new pull request #1551: remove master server and worker server listening port (5566、7788)

2019-12-24 Thread GitBox
wenhemin opened a new pull request #1551: remove master server and worker server listening port (5566、7788) URL: https://github.com/apache/incubator-dolphinscheduler/pull/1551 1.remove unused packages `import com.google.common.collect.ArrayListMultimap; ` 2.set the swagger class t

[GitHub] [incubator-dolphinscheduler] wjyheropk commented on issue #1506: wokerServer ShutdownHook: dataSource already closed excepiton

2019-12-24 Thread GitBox
wjyheropk commented on issue #1506: wokerServer ShutdownHook: dataSource already closed excepiton URL: https://github.com/apache/incubator-dolphinscheduler/issues/1506#issuecomment-568700482 I am not sure. In workerServer, alertDao is autowired by spring, but in master(ZKMasterClient

[GitHub] [incubator-dolphinscheduler] lgcareer merged pull request #1549: Front-end supplemental license

2019-12-24 Thread GitBox
lgcareer merged pull request #1549: Front-end supplemental license URL: https://github.com/apache/incubator-dolphinscheduler/pull/1549 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1551: remove master server and worker server listening port (5566、7788)

2019-12-24 Thread GitBox
codecov-io commented on issue #1551: remove master server and worker server listening port (5566、7788) URL: https://github.com/apache/incubator-dolphinscheduler/pull/1551#issuecomment-568701257 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1551?src=pr&el=h1) Re

[GitHub] [incubator-dolphinscheduler] lgcareer merged pull request #1548: Front-end supplemental license

2019-12-24 Thread GitBox
lgcareer merged pull request #1548: Front-end supplemental license URL: https://github.com/apache/incubator-dolphinscheduler/pull/1548 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-dolphinscheduler] xingchun-chen commented on issue #1550: 补数据按区间执行

2019-12-24 Thread GitBox
xingchun-chen commented on issue #1550: 补数据按区间执行 URL: https://github.com/apache/incubator-dolphinscheduler/issues/1550#issuecomment-568701768 Please add the title in English, thanks This is an automated message from the A

[GitHub] [incubator-dolphinscheduler] xingchun-chen commented on issue #1547: [Feature] node text edit box supports full-screen magnification(节点文本编辑框支持全屏放大)

2019-12-24 Thread GitBox
xingchun-chen commented on issue #1547: [Feature] node text edit box supports full-screen magnification(节点文本编辑框支持全屏放大) URL: https://github.com/apache/incubator-dolphinscheduler/issues/1547#issuecomment-568703422 Thank you for your suggestion. For long texts, you can edit the files in the

[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1231: Bump axios from 0.16.2 to 0.19.0 in /escheduler-ui/src/lib/@fedor/io

2019-12-24 Thread GitBox
dependabot[bot] commented on issue #1231: Bump axios from 0.16.2 to 0.19.0 in /escheduler-ui/src/lib/@fedor/io URL: https://github.com/apache/incubator-dolphinscheduler/pull/1231#issuecomment-568703787 Dependabot tried to update this pull request, but something went wrong. We're looking i

[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1230: Bump bootstrap from 3.3.7 to 3.4.1 in /escheduler-ui

2019-12-24 Thread GitBox
dependabot[bot] commented on issue #1230: Bump bootstrap from 3.3.7 to 3.4.1 in /escheduler-ui URL: https://github.com/apache/incubator-dolphinscheduler/pull/1230#issuecomment-568703785 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in t

[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1232: Bump jquery from 1.12.4 to 3.4.1 in /escheduler-ui

2019-12-24 Thread GitBox
dependabot[bot] commented on issue #1232: Bump jquery from 1.12.4 to 3.4.1 in /escheduler-ui URL: https://github.com/apache/incubator-dolphinscheduler/pull/1232#issuecomment-568703784 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the

[GitHub] [incubator-dolphinscheduler] elonlo commented on issue #1547: [Feature] node text edit box supports full-screen magnification(节点文本编辑框支持全屏放大)

2019-12-24 Thread GitBox
elonlo commented on issue #1547: [Feature] node text edit box supports full-screen magnification(节点文本编辑框支持全屏放大) URL: https://github.com/apache/incubator-dolphinscheduler/issues/1547#issuecomment-568704338 Yes, this is one way. But there are many times when development is to write SQL or t

[GitHub] [incubator-dolphinscheduler] lgcareer opened a new pull request #1552: Add space or colon

2019-12-24 Thread GitBox
lgcareer opened a new pull request #1552: Add space or colon URL: https://github.com/apache/incubator-dolphinscheduler/pull/1552 ## *Tips* - *Thanks very much for contributing to Apache DolphinScheduler.* - *Please review https://dolphinscheduler.apache.org/en-us/community/index.html

[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1552: Add space or colon

2019-12-24 Thread GitBox
qiaozhanwei merged pull request #1552: Add space or colon URL: https://github.com/apache/incubator-dolphinscheduler/pull/1552 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-dolphinscheduler] huzhengfei001 opened a new issue #1553: [QUESTION] question title

2019-12-24 Thread GitBox
huzhengfei001 opened a new issue #1553: [QUESTION] question title URL: https://github.com/apache/incubator-dolphinscheduler/issues/1553 1. Whether the workflow of HTTP interface is supported now 2. The "groups" name does not exist when debugging the workserver. Do you support

[GitHub] [incubator-dolphinscheduler] xingchun-chen commented on issue #1547: [Feature] node text edit box supports full-screen magnification(节点文本编辑框支持全屏放大)

2019-12-24 Thread GitBox
xingchun-chen commented on issue #1547: [Feature] node text edit box supports full-screen magnification(节点文本编辑框支持全屏放大) URL: https://github.com/apache/incubator-dolphinscheduler/issues/1547#issuecomment-568705954 Yes, the experience can indeed be optimized,thank you very much  

[GitHub] [incubator-dolphinscheduler] Nivane opened a new pull request #1554: fix 'directory' spell bug

2019-12-24 Thread GitBox
Nivane opened a new pull request #1554: fix 'directory' spell bug URL: https://github.com/apache/incubator-dolphinscheduler/pull/1554 ## What is the purpose of the pull request This pull request fixes a spell bug ## Brief change log - fix directory spell bug

[GitHub] [incubator-dolphinscheduler] zhangdehai commented on issue #1476: dolphinscheduler version:1.2.0,start API in idea,Invalid server.port specified in application-dao.properties file,The startup

2019-12-24 Thread GitBox
zhangdehai commented on issue #1476: dolphinscheduler version:1.2.0,start API in idea,Invalid server.port specified in application-dao.properties file,The startup log is as follows: URL: https://github.com/apache/incubator-dolphinscheduler/issues/1476#issuecomment-568710816 very very ---

[GitHub] [incubator-dolphinscheduler] zhangdehai closed issue #1476: dolphinscheduler version:1.2.0,start API in idea,Invalid server.port specified in application-dao.properties file,The startup log i

2019-12-24 Thread GitBox
zhangdehai closed issue #1476: dolphinscheduler version:1.2.0,start API in idea,Invalid server.port specified in application-dao.properties file,The startup log is as follows: URL: https://github.com/apache/incubator-dolphinscheduler/issues/1476 --

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1554: fix 'directory' spell bug

2019-12-24 Thread GitBox
codecov-io commented on issue #1554: fix 'directory' spell bug URL: https://github.com/apache/incubator-dolphinscheduler/pull/1554#issuecomment-568711726 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1554?src=pr&el=h1) Report > Merging [#1554](https://codeco

[GitHub] [incubator-dolphinscheduler] break60 opened a new pull request #1555: 1.2.0 release

2019-12-24 Thread GitBox
break60 opened a new pull request #1555: 1.2.0 release URL: https://github.com/apache/incubator-dolphinscheduler/pull/1555 ## *Tips* - *Thanks very much for contributing to Apache DolphinScheduler.* - *Please review https://dolphinscheduler.apache.org/en-us/community/index.html before

[GitHub] [incubator-dolphinscheduler] break60 opened a new pull request #1556: Repair license

2019-12-24 Thread GitBox
break60 opened a new pull request #1556: Repair license URL: https://github.com/apache/incubator-dolphinscheduler/pull/1556 ## *Tips* - *Thanks very much for contributing to Apache DolphinScheduler.* - *Please review https://dolphinscheduler.apache.org/en-us/community/index.html befor

<    2   3   4   5   6   7   8   9   10   11   >