[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1604: Increase script text box to zoom in and fix log loading

2019-12-26 Thread GitBox
codecov-io commented on issue #1604: Increase script text box to zoom in and fix log loading URL: https://github.com/apache/incubator-dolphinscheduler/pull/1604#issuecomment-569208782 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1604?src=pr&el=h1) Report >

[GitHub] [incubator-dolphinscheduler] clay4444 opened a new pull request #1605: Remove lombok annocation

2019-12-26 Thread GitBox
clay opened a new pull request #1605: Remove lombok annocation URL: https://github.com/apache/incubator-dolphinscheduler/pull/1605 ## What is the purpose of the pull request This pull request is for remove lombok annocation

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1605: Remove lombok annocation

2019-12-26 Thread GitBox
codecov-io commented on issue #1605: Remove lombok annocation URL: https://github.com/apache/incubator-dolphinscheduler/pull/1605#issuecomment-569210464 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1605?src=pr&el=h1) Report > Merging [#1605](https://codecov

[GitHub] [incubator-dolphinscheduler] samz406 opened a new pull request #1606: project checkResult may NPE

2019-12-26 Thread GitBox
samz406 opened a new pull request #1606: project checkResult may NPE URL: https://github.com/apache/incubator-dolphinscheduler/pull/1606 ## What is the purpose of the pull request 1 word error 2 modify check project perm may NPE 3 modify checkResult may NPE 4 update pr

[GitHub] [incubator-dolphinscheduler] samz406 closed pull request #1606: project checkResult may NPE

2019-12-26 Thread GitBox
samz406 closed pull request #1606: project checkResult may NPE URL: https://github.com/apache/incubator-dolphinscheduler/pull/1606 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1606: project checkResult may NPE

2019-12-26 Thread GitBox
codecov-io commented on issue #1606: project checkResult may NPE URL: https://github.com/apache/incubator-dolphinscheduler/pull/1606#issuecomment-569212330 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1606?src=pr&el=h1) Report > Merging [#1606](https://cod

[GitHub] [incubator-dolphinscheduler] samz406 opened a new pull request #1607: project checkResult may NPE

2019-12-26 Thread GitBox
samz406 opened a new pull request #1607: project checkResult may NPE URL: https://github.com/apache/incubator-dolphinscheduler/pull/1607 ## What is the purpose of the pull request 1 word error 2 modify check project perm may NPE 3 modify checkResult may NPE 4 update proje

[GitHub] [incubator-dolphinscheduler] JinyLeeChina opened a new pull request #1608: 'apache#1595'

2019-12-26 Thread GitBox
JinyLeeChina opened a new pull request #1608: 'apache#1595' URL: https://github.com/apache/incubator-dolphinscheduler/pull/1608 https://github.com/apache/incubator-dolphinscheduler/issues/1595 This is an automated message from

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1607: project checkResult may NPE

2019-12-26 Thread GitBox
codecov-io commented on issue #1607: project checkResult may NPE URL: https://github.com/apache/incubator-dolphinscheduler/pull/1607#issuecomment-569213486 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1607?src=pr&el=h1) Report > Merging [#1607](https://code

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1608: 'apache#1595'

2019-12-26 Thread GitBox
codecov-io commented on issue #1608: 'apache#1595' URL: https://github.com/apache/incubator-dolphinscheduler/pull/1608#issuecomment-569213971 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1608?src=pr&el=h1) Report > Merging [#1608](https://codecov.io/gh/apac

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1608: 'apache#1595'

2019-12-26 Thread GitBox
codecov-io edited a comment on issue #1608: 'apache#1595' URL: https://github.com/apache/incubator-dolphinscheduler/pull/1608#issuecomment-569213971 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1608?src=pr&el=h1) Report > Merging [#1608](https://codecov.io/

[GitHub] [incubator-dolphinscheduler] Technoboy- commented on a change in pull request #1607: project checkResult may NPE

2019-12-27 Thread GitBox
Technoboy- commented on a change in pull request #1607: project checkResult may NPE URL: https://github.com/apache/incubator-dolphinscheduler/pull/1607#discussion_r361605678 ## File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProjectService.jav

[GitHub] [incubator-dolphinscheduler-website] gaojun2048 opened a new pull request #63: update the doc about rpmbuild

2019-12-27 Thread GitBox
gaojun2048 opened a new pull request #63: update the doc about rpmbuild URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/63 update the doc about rpmbuild This is an automated message from the Apache Git S

[GitHub] [incubator-dolphinscheduler] samz406 commented on a change in pull request #1607: project checkResult may NPE

2019-12-27 Thread GitBox
samz406 commented on a change in pull request #1607: project checkResult may NPE URL: https://github.com/apache/incubator-dolphinscheduler/pull/1607#discussion_r361607503 ## File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProjectService.java #

[GitHub] [incubator-dolphinscheduler] Technoboy- commented on a change in pull request #1607: project checkResult may NPE

2019-12-27 Thread GitBox
Technoboy- commented on a change in pull request #1607: project checkResult may NPE URL: https://github.com/apache/incubator-dolphinscheduler/pull/1607#discussion_r361608657 ## File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProjectService.jav

[GitHub] [incubator-dolphinscheduler] lgcareer opened a new pull request #1609: update assemble and rpmbuild in order to include the files of config

2019-12-27 Thread GitBox
lgcareer opened a new pull request #1609: update assemble and rpmbuild in order to include the files of config URL: https://github.com/apache/incubator-dolphinscheduler/pull/1609 ## *Tips* - *Thanks very much for contributing to Apache DolphinScheduler.* - *Please review https://

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1609: update assemble and rpmbuild in order to include the files of config

2019-12-27 Thread GitBox
codecov-io commented on issue #1609: update assemble and rpmbuild in order to include the files of config URL: https://github.com/apache/incubator-dolphinscheduler/pull/1609#issuecomment-56952 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1609?src=pr&el=h1)

[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1605: Remove lombok annocation

2019-12-27 Thread GitBox
qiaozhanwei merged pull request #1605: Remove lombok annocation URL: https://github.com/apache/incubator-dolphinscheduler/pull/1605 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-dolphinscheduler] samz406 opened a new pull request #1610: update resource may NPE

2019-12-27 Thread GitBox
samz406 opened a new pull request #1610: update resource may NPE URL: https://github.com/apache/incubator-dolphinscheduler/pull/1610 ## What is the purpose of the pull request update resource may NPE Thi

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1610: update resource may NPE

2019-12-27 Thread GitBox
codecov-io commented on issue #1610: update resource may NPE URL: https://github.com/apache/incubator-dolphinscheduler/pull/1610#issuecomment-569223392 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1610?src=pr&el=h1) Report > Merging [#1610](https://codecov.

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1604: Increase script text box to zoom in and fix log loading

2019-12-27 Thread GitBox
codecov-io edited a comment on issue #1604: Increase script text box to zoom in and fix log loading URL: https://github.com/apache/incubator-dolphinscheduler/pull/1604#issuecomment-569208782 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1604?src=pr&el=h1) Repor

[GitHub] [incubator-dolphinscheduler] gogo649 commented on issue #456: Kettle mission(Kettle任务)

2019-12-27 Thread GitBox
gogo649 commented on issue #456: Kettle mission(Kettle任务) URL: https://github.com/apache/incubator-dolphinscheduler/issues/456#issuecomment-569225043 +1!! This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-dolphinscheduler] wenhemin opened a new pull request #1611: fix:In a cluster environment, verify that nodes have matching bug.

2019-12-27 Thread GitBox
wenhemin opened a new pull request #1611: fix:In a cluster environment, verify that nodes have matching bug. URL: https://github.com/apache/incubator-dolphinscheduler/pull/1611 E.g: node1 ip : 192.168.1.6 node2 ip : 192.168.1.61, failed at startup. ---

[GitHub] [incubator-dolphinscheduler] qiaozhanwei opened a new pull request #1612: AlertMappert UT modify

2019-12-27 Thread GitBox
qiaozhanwei opened a new pull request #1612: AlertMappert UT modify URL: https://github.com/apache/incubator-dolphinscheduler/pull/1612 AlertMappert UT modify This is an automated message from the Apache Git Service. To respon

[GitHub] [incubator-dolphinscheduler] samz406 commented on issue #1607: project checkResult may NPE

2019-12-27 Thread GitBox
samz406 commented on issue #1607: project checkResult may NPE URL: https://github.com/apache/incubator-dolphinscheduler/pull/1607#issuecomment-569225539 > +1 > It's a good pr. > @qiaozhanwei But we should refactor checkProjectAndAuth and hasProjectAndPerm method . > if samz406 is

[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1600: Remove lombok annocation

2019-12-27 Thread GitBox
qiaozhanwei merged pull request #1600: Remove lombok annocation URL: https://github.com/apache/incubator-dolphinscheduler/pull/1600 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1602: delAlertgroupById add entity exist check

2019-12-27 Thread GitBox
qiaozhanwei merged pull request #1602: delAlertgroupById add entity exist check URL: https://github.com/apache/incubator-dolphinscheduler/pull/1602 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [incubator-dolphinscheduler] samz406 removed a comment on issue #1607: project checkResult may NPE

2019-12-27 Thread GitBox
samz406 removed a comment on issue #1607: project checkResult may NPE URL: https://github.com/apache/incubator-dolphinscheduler/pull/1607#issuecomment-569225539 > +1 > It's a good pr. > @qiaozhanwei But we should refactor checkProjectAndAuth and hasProjectAndPerm method . > if sam

[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1591: refactor TaskQueueZkImpl

2019-12-27 Thread GitBox
qiaozhanwei merged pull request #1591: refactor TaskQueueZkImpl URL: https://github.com/apache/incubator-dolphinscheduler/pull/1591 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-dolphinscheduler] samz406 commented on issue #1607: project checkResult may NPE

2019-12-27 Thread GitBox
samz406 commented on issue #1607: project checkResult may NPE URL: https://github.com/apache/incubator-dolphinscheduler/pull/1607#issuecomment-569226016 > +1 > It's a good pr. > @qiaozhanwei But we should refactor checkProjectAndAuth and hasProjectAndPerm method . > if samz406 is

[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1577: refactor zk tree cache

2019-12-27 Thread GitBox
qiaozhanwei merged pull request #1577: refactor zk tree cache URL: https://github.com/apache/incubator-dolphinscheduler/pull/1577 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1603: Remove lombok annocation

2019-12-27 Thread GitBox
qiaozhanwei merged pull request #1603: Remove lombok annocation URL: https://github.com/apache/incubator-dolphinscheduler/pull/1603 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1609: update assemble and rpmbuild in order to include the files of config

2019-12-27 Thread GitBox
qiaozhanwei merged pull request #1609: update assemble and rpmbuild in order to include the files of config URL: https://github.com/apache/incubator-dolphinscheduler/pull/1609 This is an automated message from the Apache Git

[GitHub] [incubator-dolphinscheduler] lgcareer commented on a change in pull request #1579: add alert server comments

2019-12-27 Thread GitBox
lgcareer commented on a change in pull request #1579: add alert server comments URL: https://github.com/apache/incubator-dolphinscheduler/pull/1579#discussion_r361618240 ## File path: dolphinscheduler-alert/src/main/java/org/apache/dolphinscheduler/alert/AlertServer.java #

[GitHub] [incubator-dolphinscheduler] wenhemin opened a new issue #1613: [BUG] In a cluster environment, verify that nodes have matching bug

2019-12-27 Thread GitBox
wenhemin opened a new issue #1613: [BUG] In a cluster environment, verify that nodes have matching bug URL: https://github.com/apache/incubator-dolphinscheduler/issues/1613 E.g: master node1 ip : 192.168.1.6 master node2 ip : 192.168.1.61, failed at startup. -

[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1232: Bump jquery from 1.12.4 to 3.4.1 in /escheduler-ui

2019-12-27 Thread GitBox
dependabot[bot] commented on issue #1232: Bump jquery from 1.12.4 to 3.4.1 in /escheduler-ui URL: https://github.com/apache/incubator-dolphinscheduler/pull/1232#issuecomment-569228359 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the

[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1231: Bump axios from 0.16.2 to 0.19.0 in /escheduler-ui/src/lib/@fedor/io

2019-12-27 Thread GitBox
dependabot[bot] commented on issue #1231: Bump axios from 0.16.2 to 0.19.0 in /escheduler-ui/src/lib/@fedor/io URL: https://github.com/apache/incubator-dolphinscheduler/pull/1231#issuecomment-569228360 Dependabot tried to update this pull request, but something went wrong. We're looking i

[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1230: Bump bootstrap from 3.3.7 to 3.4.1 in /escheduler-ui

2019-12-27 Thread GitBox
dependabot[bot] commented on issue #1230: Bump bootstrap from 3.3.7 to 3.4.1 in /escheduler-ui URL: https://github.com/apache/incubator-dolphinscheduler/pull/1230#issuecomment-569228361 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in t

[GitHub] [incubator-dolphinscheduler] dailidong opened a new issue #1614: [SUGGESTION] CI/CD check #{issueID} when submit pr

2019-12-27 Thread GitBox
dailidong opened a new issue #1614: [SUGGESTION] CI/CD check #{issueID} when submit pr URL: https://github.com/apache/incubator-dolphinscheduler/issues/1614 first submit issue, then submit pr to solve this issue. and the PR should refer the corresponding issueID

[GitHub] [incubator-dolphinscheduler] qiaozhanwei closed pull request #1612: AlertMappert UT modify

2019-12-27 Thread GitBox
qiaozhanwei closed pull request #1612: AlertMappert UT modify URL: https://github.com/apache/incubator-dolphinscheduler/pull/1612 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-dolphinscheduler] lenboo merged pull request #1610: update resource may NPE

2019-12-27 Thread GitBox
lenboo merged pull request #1610: update resource may NPE URL: https://github.com/apache/incubator-dolphinscheduler/pull/1610 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-dolphinscheduler] Nivane closed pull request #1579: add alert server comments

2019-12-27 Thread GitBox
Nivane closed pull request #1579: add alert server comments URL: https://github.com/apache/incubator-dolphinscheduler/pull/1579 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-dolphinscheduler] samz406 opened a new pull request #1615: return info is not correct

2019-12-27 Thread GitBox
samz406 opened a new pull request #1615: return info is not correct URL: https://github.com/apache/incubator-dolphinscheduler/pull/1615 ## What is the purpose of the pull request 1 when queue or queName is null,return info param is null 2 update queue may NPE -

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1615: queue return info is not correct

2019-12-27 Thread GitBox
codecov-io commented on issue #1615: queue return info is not correct URL: https://github.com/apache/incubator-dolphinscheduler/pull/1615#issuecomment-569234927 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1615?src=pr&el=h1) Report > :exclamation: No coverag

[GitHub] [incubator-dolphinscheduler] qiaozhanwei opened a new pull request #1616: AlertMappert UT modify

2019-12-27 Thread GitBox
qiaozhanwei opened a new pull request #1616: AlertMappert UT modify URL: https://github.com/apache/incubator-dolphinscheduler/pull/1616 AlertMappert UT modify This is an automated message from the Apache Git Service. To respon

[GitHub] [incubator-dolphinscheduler] qiaozhanwei commented on issue #1465: [CI/CD]Add unit test

2019-12-27 Thread GitBox
qiaozhanwei commented on issue #1465: [CI/CD]Add unit test URL: https://github.com/apache/incubator-dolphinscheduler/issues/1465#issuecomment-569236450 AlertMappert UT modify #1616 This is an automated message from the Apache

[GitHub] [incubator-dolphinscheduler] samz406 opened a new pull request #1617: before delete Udf check exist

2019-12-27 Thread GitBox
samz406 opened a new pull request #1617: before delete Udf check exist URL: https://github.com/apache/incubator-dolphinscheduler/pull/1617 ## What is the purpose of the pull request 1 Modify judgment order(调整顺序,先判断是否存在) 2 before delete check entity exist --

[GitHub] [incubator-dolphinscheduler] samz406 closed pull request #1617: before delete Udf check exist

2019-12-27 Thread GitBox
samz406 closed pull request #1617: before delete Udf check exist URL: https://github.com/apache/incubator-dolphinscheduler/pull/1617 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1617: before delete Udf check exist

2019-12-27 Thread GitBox
codecov-io commented on issue #1617: before delete Udf check exist URL: https://github.com/apache/incubator-dolphinscheduler/pull/1617#issuecomment-569240117 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1617?src=pr&el=h1) Report > Merging [#1617](https://co

[GitHub] [incubator-dolphinscheduler] samz406 opened a new pull request #1618: before delete Udf check exist

2019-12-27 Thread GitBox
samz406 opened a new pull request #1618: before delete Udf check exist URL: https://github.com/apache/incubator-dolphinscheduler/pull/1618 ## What is the purpose of the pull request 1 Modify judgment order(调整顺序,先判断是否存在) 2 before delete check entity exist --

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1618: before delete Udf check exist

2019-12-27 Thread GitBox
codecov-io commented on issue #1618: before delete Udf check exist URL: https://github.com/apache/incubator-dolphinscheduler/pull/1618#issuecomment-569241860 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1618?src=pr&el=h1) Report > Merging [#1618](https://co

[GitHub] [incubator-dolphinscheduler] samz406 opened a new pull request #1619: User update not check params

2019-12-27 Thread GitBox
samz406 opened a new pull request #1619: User update not check params URL: https://github.com/apache/incubator-dolphinscheduler/pull/1619 ## What is the purpose of the pull request 1 User update add params check 2 before grant and delete operate, check user exist

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1619: User update not check params

2019-12-27 Thread GitBox
codecov-io commented on issue #1619: User update not check params URL: https://github.com/apache/incubator-dolphinscheduler/pull/1619#issuecomment-569260681 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1619?src=pr&el=h1) Report > Merging [#1619](https://co

[GitHub] [incubator-dolphinscheduler] gnuhpc opened a new pull request #1620: Fix a out-of-date comment

2019-12-27 Thread GitBox
gnuhpc opened a new pull request #1620: Fix a out-of-date comment URL: https://github.com/apache/incubator-dolphinscheduler/pull/1620 ## *Tips* - *Thanks very much for contributing to Apache DolphinScheduler.* - *Please review https://dolphinscheduler.apache.org/en-us/communit

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1620: Fix a out-of-date comment

2019-12-27 Thread GitBox
codecov-io commented on issue #1620: Fix a out-of-date comment URL: https://github.com/apache/incubator-dolphinscheduler/pull/1620#issuecomment-569380777 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1620?src=pr&el=h1) Report > Merging [#1620](https://codeco

[GitHub] [incubator-dolphinscheduler] dailidong closed pull request #1620: Fix a out-of-date comment

2019-12-28 Thread GitBox
dailidong closed pull request #1620: Fix a out-of-date comment URL: https://github.com/apache/incubator-dolphinscheduler/pull/1620 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #1620: Fix a out-of-date comment

2019-12-28 Thread GitBox
dailidong commented on issue #1620: Fix a out-of-date comment URL: https://github.com/apache/incubator-dolphinscheduler/pull/1620#issuecomment-569408042 because this is a very small issue fix, I want to merge it when I reviewed --

[GitHub] [incubator-dolphinscheduler] Technoboy- opened a new pull request #1621: refactor getKillProcessThread method

2019-12-28 Thread GitBox
Technoboy- opened a new pull request #1621: refactor getKillProcessThread method URL: https://github.com/apache/incubator-dolphinscheduler/pull/1621 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1621: refactor getKillProcessThread method

2019-12-28 Thread GitBox
codecov-io commented on issue #1621: refactor getKillProcessThread method URL: https://github.com/apache/incubator-dolphinscheduler/pull/1621#issuecomment-569408707 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1621?src=pr&el=h1) Report > Merging [#1621](htt

[GitHub] [incubator-dolphinscheduler] Technoboy- commented on a change in pull request #1619: User update not check params

2019-12-28 Thread GitBox
Technoboy- commented on a change in pull request #1619: User update not check params URL: https://github.com/apache/incubator-dolphinscheduler/pull/1619#discussion_r361790815 ## File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/UsersService.jav

[GitHub] [incubator-dolphinscheduler] Technoboy- commented on a change in pull request #1618: before delete Udf check exist

2019-12-28 Thread GitBox
Technoboy- commented on a change in pull request #1618: before delete Udf check exist URL: https://github.com/apache/incubator-dolphinscheduler/pull/1618#discussion_r361790999 ## File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/UdfFuncService.j

[GitHub] [incubator-dolphinscheduler] Technoboy- merged pull request #1608: [fix] process instance alert bug #1595

2019-12-28 Thread GitBox
Technoboy- merged pull request #1608: [fix] process instance alert bug #1595 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1608 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-dolphinscheduler] Technoboy- merged pull request #1607: project checkResult may NPE

2019-12-28 Thread GitBox
Technoboy- merged pull request #1607: project checkResult may NPE URL: https://github.com/apache/incubator-dolphinscheduler/pull/1607 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-dolphinscheduler] Technoboy- merged pull request #1621: refactor getKillProcessThread method

2019-12-28 Thread GitBox
Technoboy- merged pull request #1621: refactor getKillProcessThread method URL: https://github.com/apache/incubator-dolphinscheduler/pull/1621 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-dolphinscheduler] Technoboy- merged pull request #1611: fix:In a cluster environment, verify that nodes have matching bug. #{1613}

2019-12-28 Thread GitBox
Technoboy- merged pull request #1611: fix:In a cluster environment, verify that nodes have matching bug. #{1613} URL: https://github.com/apache/incubator-dolphinscheduler/pull/1611 This is an automated message from the Apach

[GitHub] [incubator-dolphinscheduler] samz406 commented on a change in pull request #1619: User update not check params

2019-12-28 Thread GitBox
samz406 commented on a change in pull request #1619: User update not check params URL: https://github.com/apache/incubator-dolphinscheduler/pull/1619#discussion_r361792535 ## File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/UsersService.java

[GitHub] [incubator-dolphinscheduler] Technoboy- closed issue #1613: [BUG] In a cluster environment, verify that nodes have matching bug

2019-12-28 Thread GitBox
Technoboy- closed issue #1613: [BUG] In a cluster environment, verify that nodes have matching bug URL: https://github.com/apache/incubator-dolphinscheduler/issues/1613 This is an automated message from the Apache Git Servic

[GitHub] [incubator-dolphinscheduler] Technoboy- commented on issue #1613: [BUG] In a cluster environment, verify that nodes have matching bug

2019-12-28 Thread GitBox
Technoboy- commented on issue #1613: [BUG] In a cluster environment, verify that nodes have matching bug URL: https://github.com/apache/incubator-dolphinscheduler/issues/1613#issuecomment-569412129 #1611 This is an automate

[GitHub] [incubator-dolphinscheduler] Technoboy- commented on issue #1595: [BUG] process instance alert optimization

2019-12-28 Thread GitBox
Technoboy- commented on issue #1595: [BUG] process instance alert optimization URL: https://github.com/apache/incubator-dolphinscheduler/issues/1595#issuecomment-569412207 #1608 This is an automated message from the Apache G

[GitHub] [incubator-dolphinscheduler] Technoboy- closed issue #1595: [BUG] process instance alert optimization

2019-12-28 Thread GitBox
Technoboy- closed issue #1595: [BUG] process instance alert optimization URL: https://github.com/apache/incubator-dolphinscheduler/issues/1595 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-dolphinscheduler] qiaozhanwei commented on issue #1616: AlertMappert UT modify #1465

2019-12-28 Thread GitBox
qiaozhanwei commented on issue #1616: AlertMappert UT modify #1465 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1616#issuecomment-569412490 @Test public void testUpdate(){ Alert expectedAlert = createAlert(); expectedAlert.setAlertStatu

[GitHub] [incubator-dolphinscheduler] Technoboy- commented on issue #1506: wokerServer ShutdownHook: dataSource already closed excepiton

2019-12-28 Thread GitBox
Technoboy- commented on issue #1506: wokerServer ShutdownHook: dataSource already closed excepiton URL: https://github.com/apache/incubator-dolphinscheduler/issues/1506#issuecomment-569412688 This looks a bug We will keep the same implementation and keep code more nice. Thanks bro.

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1619: User update not check params

2019-12-28 Thread GitBox
codecov-io edited a comment on issue #1619: User update not check params URL: https://github.com/apache/incubator-dolphinscheduler/pull/1619#issuecomment-569260681 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1619?src=pr&el=h1) Report > Merging [#1619](htt

[GitHub] [incubator-dolphinscheduler] samz406 commented on a change in pull request #1618: before delete Udf check exist

2019-12-28 Thread GitBox
samz406 commented on a change in pull request #1618: before delete Udf check exist URL: https://github.com/apache/incubator-dolphinscheduler/pull/1618#discussion_r361793368 ## File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/UdfFuncService.java

[GitHub] [incubator-dolphinscheduler] Technoboy- opened a new pull request #1622: we should insert alert in DB once , and trigger this type of alert 3 times

2019-12-28 Thread GitBox
Technoboy- opened a new pull request #1622: we should insert alert in DB once , and trigger this type of alert 3 times URL: https://github.com/apache/incubator-dolphinscheduler/pull/1622 This is an automated message from the

[GitHub] [incubator-dolphinscheduler] Technoboy- commented on a change in pull request #1618: before delete Udf check exist

2019-12-28 Thread GitBox
Technoboy- commented on a change in pull request #1618: before delete Udf check exist URL: https://github.com/apache/incubator-dolphinscheduler/pull/1618#discussion_r361795630 ## File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/UdfFuncService.j

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1622: we should insert alert in DB once , and trigger this type of alert 3 times

2019-12-28 Thread GitBox
codecov-io commented on issue #1622: we should insert alert in DB once , and trigger this type of alert 3 times URL: https://github.com/apache/incubator-dolphinscheduler/pull/1622#issuecomment-569418173 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1622?src=pr&e

[GitHub] [incubator-dolphinscheduler] Technoboy- commented on a change in pull request #1618: before delete Udf check exist

2019-12-28 Thread GitBox
Technoboy- commented on a change in pull request #1618: before delete Udf check exist URL: https://github.com/apache/incubator-dolphinscheduler/pull/1618#discussion_r361795646 ## File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/UdfFuncService.j

[GitHub] [incubator-dolphinscheduler] dailidong opened a new issue #1623: [QUESTION] Why does ZookeeperOperator.java no Comment on method?

2019-12-28 Thread GitBox
dailidong opened a new issue #1623: [QUESTION] Why does ZookeeperOperator.java no Comment on method? URL: https://github.com/apache/incubator-dolphinscheduler/issues/1623 Why does ZookeeperOperator.java no Comment on method?

[GitHub] [incubator-dolphinscheduler] Jave-Chen opened a new pull request #1624: Add github action to analyze code with sonarcloud

2019-12-28 Thread GitBox
Jave-Chen opened a new pull request #1624: Add github action to analyze code with sonarcloud URL: https://github.com/apache/incubator-dolphinscheduler/pull/1624 ## What is the purpose of the pull request #1592 add github action to analyze code with sonarcloud *(For example: This pull

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1624: Add github action to analyze code with sonarcloud

2019-12-28 Thread GitBox
codecov-io commented on issue #1624: Add github action to analyze code with sonarcloud URL: https://github.com/apache/incubator-dolphinscheduler/pull/1624#issuecomment-569431394 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1624?src=pr&el=h1) Report > Mergin

[GitHub] [incubator-dolphinscheduler] khadgarmage commented on issue #1624: Add github action to analyze code with sonarcloud

2019-12-28 Thread GitBox
khadgarmage commented on issue #1624: Add github action to analyze code with sonarcloud URL: https://github.com/apache/incubator-dolphinscheduler/pull/1624#issuecomment-569431632 Pls add readme about sonarcloud info, thanks

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1624: Add github action to analyze code with sonarcloud

2019-12-28 Thread GitBox
codecov-io edited a comment on issue #1624: Add github action to analyze code with sonarcloud URL: https://github.com/apache/incubator-dolphinscheduler/pull/1624#issuecomment-569431394 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1624?src=pr&el=h1) Report >

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1624: Add github action to analyze code with sonarcloud

2019-12-28 Thread GitBox
codecov-io edited a comment on issue #1624: Add github action to analyze code with sonarcloud URL: https://github.com/apache/incubator-dolphinscheduler/pull/1624#issuecomment-569431394 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1624?src=pr&el=h1) Report >

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1624: Add github action to analyze code with sonarcloud

2019-12-28 Thread GitBox
codecov-io edited a comment on issue #1624: Add github action to analyze code with sonarcloud URL: https://github.com/apache/incubator-dolphinscheduler/pull/1624#issuecomment-569431394 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1624?src=pr&el=h1) Report >

[GitHub] [incubator-dolphinscheduler] Jave-Chen commented on issue #1624: Add github action to analyze code with sonarcloud

2019-12-28 Thread GitBox
Jave-Chen commented on issue #1624: Add github action to analyze code with sonarcloud URL: https://github.com/apache/incubator-dolphinscheduler/pull/1624#issuecomment-569433304 > Pls add readme about sonarcloud info, thanks 1. Replace Codacy Badge with Quality Gate Status 2. Add

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1624: Add github action to analyze code with sonarcloud

2019-12-28 Thread GitBox
codecov-io edited a comment on issue #1624: Add github action to analyze code with sonarcloud URL: https://github.com/apache/incubator-dolphinscheduler/pull/1624#issuecomment-569431394 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1624?src=pr&el=h1) Report >

[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1616: AlertMappert UT modify #1465

2019-12-28 Thread GitBox
qiaozhanwei merged pull request #1616: AlertMappert UT modify #1465 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1616 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [incubator-dolphinscheduler] Technoboy- commented on issue #1622: we should insert alert in DB once , and trigger this type of alert 3 times

2019-12-28 Thread GitBox
Technoboy- commented on issue #1622: we should insert alert in DB once , and trigger this type of alert 3 times URL: https://github.com/apache/incubator-dolphinscheduler/pull/1622#issuecomment-569467062 > node down is very serious,so intentionally added retries Yes, it is . But

[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1230: Bump bootstrap from 3.3.7 to 3.4.1 in /escheduler-ui

2019-12-28 Thread GitBox
dependabot[bot] commented on issue #1230: Bump bootstrap from 3.3.7 to 3.4.1 in /escheduler-ui URL: https://github.com/apache/incubator-dolphinscheduler/pull/1230#issuecomment-569467139 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in t

[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1231: Bump axios from 0.16.2 to 0.19.0 in /escheduler-ui/src/lib/@fedor/io

2019-12-28 Thread GitBox
dependabot[bot] commented on issue #1231: Bump axios from 0.16.2 to 0.19.0 in /escheduler-ui/src/lib/@fedor/io URL: https://github.com/apache/incubator-dolphinscheduler/pull/1231#issuecomment-569467140 Dependabot tried to update this pull request, but something went wrong. We're looking i

[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1232: Bump jquery from 1.12.4 to 3.4.1 in /escheduler-ui

2019-12-28 Thread GitBox
dependabot[bot] commented on issue #1232: Bump jquery from 1.12.4 to 3.4.1 in /escheduler-ui URL: https://github.com/apache/incubator-dolphinscheduler/pull/1232#issuecomment-569467138 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the

[GitHub] [incubator-dolphinscheduler] qiaozhanwei commented on issue #1622: we should insert alert in DB once , and trigger this type of alert 3 times

2019-12-28 Thread GitBox
qiaozhanwei commented on issue #1622: we should insert alert in DB once , and trigger this type of alert 3 times URL: https://github.com/apache/incubator-dolphinscheduler/pull/1622#issuecomment-569467167 OK This is an automa

[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1622: we should insert alert in DB once , and trigger this type of alert 3 times

2019-12-28 Thread GitBox
qiaozhanwei merged pull request #1622: we should insert alert in DB once , and trigger this type of alert 3 times URL: https://github.com/apache/incubator-dolphinscheduler/pull/1622 This is an automated message from the Apac

[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1619: User update not check params

2019-12-28 Thread GitBox
qiaozhanwei merged pull request #1619: User update not check params URL: https://github.com/apache/incubator-dolphinscheduler/pull/1619 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-dolphinscheduler] Technoboy- merged pull request #1615: queue return info is not correct

2019-12-28 Thread GitBox
Technoboy- merged pull request #1615: queue return info is not correct URL: https://github.com/apache/incubator-dolphinscheduler/pull/1615 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1604: Increase script text box to zoom in and fix log loading #1547 、#1247

2019-12-28 Thread GitBox
qiaozhanwei merged pull request #1604: Increase script text box to zoom in and fix log loading #1547 、#1247 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1604 This is an automated message from the Apache Git

[GitHub] [incubator-dolphinscheduler] qiaozhanwei commented on issue #1465: [CI/CD]Add unit test

2019-12-28 Thread GitBox
qiaozhanwei commented on issue #1465: [CI/CD]Add unit test URL: https://github.com/apache/incubator-dolphinscheduler/issues/1465#issuecomment-569471584 CommandMapperTest UT modify #1625 This is an automated message from the A

[GitHub] [incubator-dolphinscheduler] qiaozhanwei opened a new pull request #1625: CommandMapperTest UT modify #1465

2019-12-28 Thread GitBox
qiaozhanwei opened a new pull request #1625: CommandMapperTest UT modify #1465 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1625 CommandMapperTest UT modify This is an automated message from the Apache Git S

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1625: CommandMapperTest UT modify #1465

2019-12-28 Thread GitBox
codecov-io commented on issue #1625: CommandMapperTest UT modify #1465 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1625#issuecomment-569471716 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1625?src=pr&el=h1) Report > Merging [#1625](https:

<    5   6   7   8   9   10   11   12   13   14   >