[GitHub] [incubator-doris] worker24h opened a new pull request #3645: Add error code into error message

2020-05-20 Thread GitBox
worker24h opened a new pull request #3645: URL: https://github.com/apache/incubator-doris/pull/3645 Add error code into error message This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-doris] morningman commented on a change in pull request #3584: [OUTFILE] Support `INTO OUTFILE` to export query result

2020-05-20 Thread GitBox
morningman commented on a change in pull request #3584: URL: https://github.com/apache/incubator-doris/pull/3584#discussion_r428444348 ## File path: be/src/runtime/file_result_writer.h ## @@ -0,0 +1,132 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3638: Supoort utf-8 encoding in instr, locate, locate_pos, lpad, rpad

2020-05-20 Thread GitBox
kangkaisen commented on a change in pull request #3638: URL: https://github.com/apache/incubator-doris/pull/3638#discussion_r428454426 ## File path: be/src/exprs/string_functions.cpp ## @@ -196,28 +196,56 @@ StringVal StringFunctions::lpad( if (str.is_null || len.is_null

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3584: [OUTFILE] Support `INTO OUTFILE` to export query result

2020-05-20 Thread GitBox
kangkaisen commented on a change in pull request #3584: URL: https://github.com/apache/incubator-doris/pull/3584#discussion_r428451196 ## File path: docs/zh-CN/administrator-guide/outfile.md ## @@ -0,0 +1,183 @@ +--- +{ +"title": "导出查询结果集", +"language": "zh-CN" +} +---

[incubator-doris] branch master updated (792307a -> ef8fd1f)

2020-05-20 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 792307a [CMake] Different cmake build directories for different build types (#3623) (#3629) add

[GitHub] [incubator-doris] morningman merged pull request #3553: Support load json-data into Doris by RoutineLoad or StreamLoad

2020-05-20 Thread GitBox
morningman merged pull request #3553: URL: https://github.com/apache/incubator-doris/pull/3553 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-doris] morningman commented on pull request #3637: [Memory Engine] Add MemSubTablet, MemTablet, WriteTx, PartialRowBatch

2020-05-20 Thread GitBox
morningman commented on pull request #3637: URL: https://github.com/apache/incubator-doris/pull/3637#issuecomment-631880632 >

[GitHub] [incubator-doris] morningman commented on a change in pull request #3637: [Memory Engine] Add MemSubTablet, MemTablet, WriteTx, PartialRowBatch

2020-05-20 Thread GitBox
morningman commented on a change in pull request #3637: URL: https://github.com/apache/incubator-doris/pull/3637#discussion_r428444871 ## File path: be/src/olap/memory/write_tx.h ## @@ -0,0 +1,58 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [incubator-doris] imay commented on pull request #3626: Update Compiling environment of BE to Support C++14/17

2020-05-20 Thread GitBox
imay commented on pull request #3626: URL: https://github.com/apache/incubator-doris/pull/3626#issuecomment-631879704 @morningman I don't understand you very well. I think we can make this feature in our next release, so we can merge it right now. what's your opinion about this?

[GitHub] [incubator-doris] morningman commented on a change in pull request #3584: [OUTFILE] Support `INTO OUTFILE` to export query result

2020-05-20 Thread GitBox
morningman commented on a change in pull request #3584: URL: https://github.com/apache/incubator-doris/pull/3584#discussion_r42809 ## File path: be/src/runtime/file_result_writer.h ## @@ -0,0 +1,132 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [incubator-doris] morningman commented on a change in pull request #3584: [OUTFILE] Support `INTO OUTFILE` to export query result

2020-05-20 Thread GitBox
morningman commented on a change in pull request #3584: URL: https://github.com/apache/incubator-doris/pull/3584#discussion_r428444339 ## File path: be/src/runtime/mysql_result_writer.h ## @@ -0,0 +1,70 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [incubator-doris] morningman commented on a change in pull request #3584: [OUTFILE] Support `INTO OUTFILE` to export query result

2020-05-20 Thread GitBox
morningman commented on a change in pull request #3584: URL: https://github.com/apache/incubator-doris/pull/3584#discussion_r428443963 ## File path: be/src/runtime/mysql_result_writer.h ## @@ -0,0 +1,70 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [incubator-doris] morningman commented on a change in pull request #3584: [OUTFILE] Support `INTO OUTFILE` to export query result

2020-05-20 Thread GitBox
morningman commented on a change in pull request #3584: URL: https://github.com/apache/incubator-doris/pull/3584#discussion_r428443827 ## File path: docs/zh-CN/administrator-guide/outfile.md ## @@ -0,0 +1,183 @@ +--- +{ +"title": "导出查询结果集", +"language": "zh-CN" +} +---

[GitHub] [incubator-doris] morningman commented on a change in pull request #3584: [OUTFILE] Support `INTO OUTFILE` to export query result

2020-05-20 Thread GitBox
morningman commented on a change in pull request #3584: URL: https://github.com/apache/incubator-doris/pull/3584#discussion_r428442688 ## File path: docs/zh-CN/administrator-guide/outfile.md ## @@ -0,0 +1,183 @@ +--- +{ +"title": "导出查询结果集", +"language": "zh-CN" +} +---

[GitHub] [incubator-doris] morningman commented on a change in pull request #3584: [OUTFILE] Support `INTO OUTFILE` to export query result

2020-05-20 Thread GitBox
morningman commented on a change in pull request #3584: URL: https://github.com/apache/incubator-doris/pull/3584#discussion_r428442267 ## File path: docs/zh-CN/administrator-guide/outfile.md ## @@ -0,0 +1,183 @@ +--- +{ +"title": "导出查询结果集", +"language": "zh-CN" +} +---

[GitHub] [incubator-doris] sduzh closed issue #3623: palo_be should be compiled in different directories for different build types.

2020-05-20 Thread GitBox
sduzh closed issue #3623: URL: https://github.com/apache/incubator-doris/issues/3623 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-doris] vagetablechicken opened a new issue #3644: mem limit in NodeChannel

2020-05-20 Thread GitBox
vagetablechicken opened a new issue #3644: URL: https://github.com/apache/incubator-doris/issues/3644 We do mem limit here. https://github.com/apache/incubator-doris/blob/792307ae54ee9dbe1be8b7e6fe30b4ef90b2cca9/be/src/exec/tablet_sink.cpp#L182-L185 The sink node mem is only reduced

[GitHub] [incubator-doris] decster commented on pull request #3637: [Memory Engine] Add MemSubTablet, MemTablet, WriteTx, PartialRowBatch

2020-05-20 Thread GitBox
decster commented on pull request #3637: URL: https://github.com/apache/incubator-doris/pull/3637#issuecomment-631862702 > Hi @decster, Could you explain more about `MemSubTablet`? In your design doc you said this is for Multi Dimension Cluster. But I am not sure what it is.

[GitHub] [incubator-doris] vagetablechicken opened a new pull request #3643: fix mem limit in NodeChannel

2020-05-20 Thread GitBox
vagetablechicken opened a new pull request #3643: URL: https://github.com/apache/incubator-doris/pull/3643 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-doris] hww123 removed a comment on issue #3634: [Schema change] throw error 'Can not change default value'

2020-05-20 Thread GitBox
hww123 removed a comment on issue #3634: URL: https://github.com/apache/incubator-doris/issues/3634#issuecomment-631857164 Follow your advice, but throw error 'Error : errCode = 2, detailMessage = Invalid number format: '

[GitHub] [incubator-doris] hww123 commented on issue #3634: [Schema change] throw error 'Can not change default value'

2020-05-20 Thread GitBox
hww123 commented on issue #3634: URL: https://github.com/apache/incubator-doris/issues/3634#issuecomment-631857255 > try > `ALTER TABLE test.test1 MODIFY COLUMN field4 bigint(20) default ""` Follow your advice, but throw error 'Error : errCode = 2, detailMessage = Invalid number

[GitHub] [incubator-doris] hww123 commented on issue #3634: [Schema change] throw error 'Can not change default value'

2020-05-20 Thread GitBox
hww123 commented on issue #3634: URL: https://github.com/apache/incubator-doris/issues/3634#issuecomment-631857164 Follow your advice, but throw error 'Error : errCode = 2, detailMessage = Invalid number format: ' This is

[GitHub] [incubator-doris] decster commented on a change in pull request #3637: [Memory Engine] Add MemSubTablet, MemTablet, WriteTx, PartialRowBatch

2020-05-20 Thread GitBox
decster commented on a change in pull request #3637: URL: https://github.com/apache/incubator-doris/pull/3637#discussion_r428422061 ## File path: be/src/olap/memory/write_tx.h ## @@ -0,0 +1,58 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [incubator-doris] imay commented on issue #3600: large bitmap serialization failed because of overflow of size

2020-05-20 Thread GitBox
imay commented on issue #3600: URL: https://github.com/apache/incubator-doris/issues/3600#issuecomment-631851926 Hi, @kangpinghuang Can you explain the scenario that cause this problem? I think it will cause many problems if the body is so large. And if we are going to support it,

[GitHub] [incubator-doris] imay commented on a change in pull request #3637: [Memory Engine] Add MemSubTablet, MemTablet, WriteTx, PartialRowBatch

2020-05-20 Thread GitBox
imay commented on a change in pull request #3637: URL: https://github.com/apache/incubator-doris/pull/3637#discussion_r428414008 ## File path: be/src/olap/memory/partial_row_batch.h ## @@ -0,0 +1,140 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #3638: Supoort utf-8 encoding in instr, locate, locate_pos, lpad, rpad

2020-05-20 Thread GitBox
yangzhg commented on a change in pull request #3638: URL: https://github.com/apache/incubator-doris/pull/3638#discussion_r428406815 ## File path: be/src/exprs/string_functions.cpp ## @@ -196,28 +196,56 @@ StringVal StringFunctions::lpad( if (str.is_null || len.is_null ||

[GitHub] [incubator-doris] imay commented on pull request #3642: Fix some unit test failed

2020-05-20 Thread GitBox
imay commented on pull request #3642: URL: https://github.com/apache/incubator-doris/pull/3642#issuecomment-631817163 Hi @yangzhg Can you explain why glog will cause unit test fail in commit message? This is an automated

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3584: [OUTFILE] Support `INTO OUTFILE` to export query result

2020-05-20 Thread GitBox
kangkaisen commented on a change in pull request #3584: URL: https://github.com/apache/incubator-doris/pull/3584#discussion_r428132193 ## File path: docs/zh-CN/administrator-guide/outfile.md ## @@ -0,0 +1,183 @@ +--- +{ +"title": "导出查询结果集", +"language": "zh-CN" +} +---

[GitHub] [incubator-doris] morningman commented on a change in pull request #3637: [Memory Engine] Add MemSubTablet, MemTablet, WriteTx, PartialRowBatch

2020-05-20 Thread GitBox
morningman commented on a change in pull request #3637: URL: https://github.com/apache/incubator-doris/pull/3637#discussion_r428102043 ## File path: be/src/olap/memory/write_tx.h ## @@ -0,0 +1,58 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3638: Supoort utf-8 encoding in instr, locate, locate_pos, lpad, rpad

2020-05-20 Thread GitBox
kangkaisen commented on a change in pull request #3638: URL: https://github.com/apache/incubator-doris/pull/3638#discussion_r428101660 ## File path: be/src/exprs/string_functions.cpp ## @@ -196,28 +196,56 @@ StringVal StringFunctions::lpad( if (str.is_null || len.is_null

[GitHub] [incubator-doris] morningman commented on pull request #3637: [Memory Engine] Add MemSubTablet, MemTablet, WriteTx, PartialRowBatch

2020-05-20 Thread GitBox
morningman commented on pull request #3637: URL: https://github.com/apache/incubator-doris/pull/3637#issuecomment-631543723 Hi @decster, Could you explain more about `MemSubTablet`? In your design doc you said this is for Multi Dimension Cluster. But I am not sure what it is.

[GitHub] [incubator-doris] morningman commented on pull request #3626: Update Compiling environment of BE to Support C++14/17

2020-05-20 Thread GitBox
morningman commented on pull request #3626: URL: https://github.com/apache/incubator-doris/pull/3626#issuecomment-631484829 I suggest to merge this PR before we planing to release next version. So we can have a clear cut of the dev environment.

[GitHub] [incubator-doris] morningman commented on pull request #3638: Supoort utf-8 encoding in instr, locate, locate_pos, lpad, rpad

2020-05-20 Thread GitBox
morningman commented on pull request #3638: URL: https://github.com/apache/incubator-doris/pull/3638#issuecomment-631483236 Good work. Could please add docs for these functions? This is an automated message from the

[incubator-doris] branch master updated: [CMake] Different cmake build directories for different build types (#3623) (#3629)

2020-05-20 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 792307a [CMake] Different cmake

[GitHub] [incubator-doris] morningman merged pull request #3629: different cmake build directories for different build types

2020-05-20 Thread GitBox
morningman merged pull request #3629: URL: https://github.com/apache/incubator-doris/pull/3629 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-doris] morningman commented on a change in pull request #3641: [Bug] Ignore loading DELETE status tablet error when restarting BE

2020-05-20 Thread GitBox
morningman commented on a change in pull request #3641: URL: https://github.com/apache/incubator-doris/pull/3641#discussion_r428013303 ## File path: be/src/tools/meta_tool.cpp ## @@ -122,13 +126,131 @@ void delete_meta(DataDir* data_dir) { std::cout << "delete meta

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #3625: Support more syntax in case when clause

2020-05-20 Thread GitBox
yangzhg commented on a change in pull request #3625: URL: https://github.com/apache/incubator-doris/pull/3625#discussion_r428011341 ## File path: fe/src/main/java/org/apache/doris/analysis/CaseExpr.java ## @@ -191,7 +191,7 @@ public void analyzeImpl(Analyzer analyzer) throws

[GitHub] [incubator-doris] yangzhg opened a new pull request #3642: Fix some unit test failed

2020-05-20 Thread GitBox
yangzhg opened a new pull request #3642: URL: https://github.com/apache/incubator-doris/pull/3642 Fix some unittest failed due to glog This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-doris] kangpinghuang closed issue #3552: Support Bitmap Intersect

2020-05-20 Thread GitBox
kangpinghuang closed issue #3552: URL: https://github.com/apache/incubator-doris/issues/3552 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-doris] kangpinghuang merged pull request #3571: Support bitmap_intersect

2020-05-20 Thread GitBox
kangpinghuang merged pull request #3571: URL: https://github.com/apache/incubator-doris/pull/3571 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-doris] branch master updated: Support bitmap_intersect (#3571)

2020-05-20 Thread kangpinghuang
This is an automated email from the ASF dual-hosted git repository. kangpinghuang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 0d66e6b Support

[GitHub] [incubator-doris] kangpinghuang commented on pull request #3571: Support bitmap_intersect

2020-05-20 Thread GitBox
kangpinghuang commented on pull request #3571: URL: https://github.com/apache/incubator-doris/pull/3571#issuecomment-631463449 LGTM, +1 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-doris] HappenLee commented on pull request #3626: Update Compiling environment of BE to Support C++14/17

2020-05-20 Thread GitBox
HappenLee commented on pull request #3626: URL: https://github.com/apache/incubator-doris/pull/3626#issuecomment-631454781 @kangkaisen ok,i will update the document of doris。but about the part of docker image version. maybe we should chose a version and commid id to start use C++17.

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #3571: Support bitmap_intersect

2020-05-20 Thread GitBox
EmmyMiao87 commented on a change in pull request #3571: URL: https://github.com/apache/incubator-doris/pull/3571#discussion_r427945170 ## File path: docs/en/sql-reference/sql-functions/bitmap-functions/bitmap_intersect.md ## @@ -0,0 +1,54 @@ +--- +{ +"title":

[GitHub] [incubator-doris] WingsGo commented on pull request #2215: Optimize tablet report with expired transaction.

2020-05-20 Thread GitBox
WingsGo commented on pull request #2215: URL: https://github.com/apache/incubator-doris/pull/2215#issuecomment-631388099 The PR did a great job! In our enviorment the optimize logic can reduce the `tablet report` from about 35hours to 15s.

[GitHub] [incubator-doris] wutiangan commented on a change in pull request #3625: Support more syntax in case when clause

2020-05-20 Thread GitBox
wutiangan commented on a change in pull request #3625: URL: https://github.com/apache/incubator-doris/pull/3625#discussion_r427884222 ## File path: fe/src/main/java/org/apache/doris/analysis/CaseExpr.java ## @@ -191,7 +191,7 @@ public void analyzeImpl(Analyzer analyzer) throws

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #3584: [OUTFILE] Support `INTO OUTFILE` to export query result

2020-05-20 Thread GitBox
yangzhg commented on a change in pull request #3584: URL: https://github.com/apache/incubator-doris/pull/3584#discussion_r427873732 ## File path: be/src/runtime/result_sink.cpp ## @@ -35,6 +36,17 @@ ResultSink::ResultSink(const RowDescriptor& row_desc, const std::vector&

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #3641: [Bug] Ignore loading DELETE status tablet error when restarting BE

2020-05-20 Thread GitBox
yangzhg commented on a change in pull request #3641: URL: https://github.com/apache/incubator-doris/pull/3641#discussion_r427867432 ## File path: be/src/tools/meta_tool.cpp ## @@ -122,13 +126,131 @@ void delete_meta(DataDir* data_dir) { std::cout << "delete meta

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #3641: [Bug] Ignore loading DELETE status tablet error when restarting BE

2020-05-20 Thread GitBox
yangzhg commented on a change in pull request #3641: URL: https://github.com/apache/incubator-doris/pull/3641#discussion_r427867432 ## File path: be/src/tools/meta_tool.cpp ## @@ -122,13 +126,131 @@ void delete_meta(DataDir* data_dir) { std::cout << "delete meta

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #3641: [Bug] Ignore loading DELETE status tablet error when restarting BE

2020-05-20 Thread GitBox
yangzhg commented on a change in pull request #3641: URL: https://github.com/apache/incubator-doris/pull/3641#discussion_r427863742 ## File path: be/src/olap/data_dir.cpp ## @@ -709,13 +716,29 @@ OLAPStatus DataDir::load() { return true; }; OLAPStatus

[GitHub] [incubator-doris] EmmyMiao87 commented on pull request #3625: support more syntax in case when clause

2020-05-20 Thread GitBox
EmmyMiao87 commented on pull request #3625: URL: https://github.com/apache/incubator-doris/pull/3625#issuecomment-631320732 Please add issue and change the title of PR This is an automated message from the Apache Git

[GitHub] [incubator-doris] vagetablechicken commented on issue #3469: [Memory Engine] Write Pipeline: internal data processing and storage

2020-05-20 Thread GitBox
vagetablechicken commented on issue #3469: URL: https://github.com/apache/incubator-doris/issues/3469#issuecomment-631289944 ### WAL file format WAL file will save multiple partial rows. One write TX's WAL may be split by size => generates multiple {txn_id}_{segment_id}.wal For

[GitHub] [incubator-doris] stalary closed issue #3494: [BUG] Be all hang up

2020-05-20 Thread GitBox
stalary closed issue #3494: URL: https://github.com/apache/incubator-doris/issues/3494 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-doris] morningman opened a new pull request #3641: [Bug] Ignore loading DELETE status tablet error when restarting BE

2020-05-20 Thread GitBox
morningman opened a new pull request #3641: URL: https://github.com/apache/incubator-doris/pull/3641 Fix: #3640 Also add a `batch delete meta` feature for `meta tool` Fix #3639 This is an automated message from

[GitHub] [incubator-doris] morningman opened a new issue #3640: [Bug] BE restart failed because of reading tablet in DELETE status

2020-05-20 Thread GitBox
morningman opened a new issue #3640: URL: https://github.com/apache/incubator-doris/issues/3640 **Describe the bug** Previously, we introduced a new BE parameter(#3632 ). When a tablet fails to load, BE startup fails. We found that sometimes when the BE starts, it reads the

[GitHub] [incubator-doris] morningman opened a new issue #3639: [MetaTool] Support batch delete meta using meta_tool

2020-05-20 Thread GitBox
morningman opened a new issue #3639: URL: https://github.com/apache/incubator-doris/issues/3639 Currently, `meta_tool` only support delete meta for a single tablet. If there are thousands of tablets need to be deleted, this tool run very slow because it will open the Rocksdb for each

[GitHub] [incubator-doris] yangzhg opened a new pull request #3638: Supoort utf-8 encoding in instr, locate, locate_pos, lpad, rpad

2020-05-20 Thread GitBox
yangzhg opened a new pull request #3638: URL: https://github.com/apache/incubator-doris/pull/3638 Supoort utf-8 encoding for string function `instr`, `locate`, `locate_pos`, `lpad`, `rpad` and add unit test for them