Re: [PR] [fix][nereids] fix misunderstanding about bothSideShuffleKeysAreSameOrder [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34811: URL: https://github.com/apache/doris/pull/34811#issuecomment-2109341666 TPC-H: Total hot run time: 41995 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch

Re: [PR] [fix](nereids)4 phase agg may lost parameter in some case [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34816: URL: https://github.com/apache/doris/pull/34816#issuecomment-2109337745 TPC-DS: Total hot run time: 187790 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34812: URL: https://github.com/apache/doris/pull/34812#issuecomment-2109334381 TeamCity be ut coverage result: Function Coverage: 35.66% (8980/25180) Line Coverage: 27.32% (74237/271751) Region Coverage: 26.55% (38348/144451) Branch Coverage:

Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34812: URL: https://github.com/apache/doris/pull/34812#issuecomment-2109333158 TPC-DS: Total hot run time: 187183 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](nereids)4 phase agg may lost parameter in some case [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34816: URL: https://github.com/apache/doris/pull/34816#issuecomment-2109325705 TPC-H: Total hot run time: 40226 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch

Re: [PR] [fix][nereids] fix misunderstanding about bothSideShuffleKeysAreSameOrder [doris]

2024-05-13 Thread via GitHub
xzj7019 commented on PR #34811: URL: https://github.com/apache/doris/pull/34811#issuecomment-2109323649 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34812: URL: https://github.com/apache/doris/pull/34812#issuecomment-2109321613 TPC-H: Total hot run time: 40164 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch

Re: [PR] [improve](exchange) the sink could eos early when all queues have enough rows [doris]

2024-05-13 Thread via GitHub
zhangstar333 commented on PR #34541: URL: https://github.com/apache/doris/pull/34541#issuecomment-2109319409 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [improve](exchange) the sink could eos early when all queues have enough rows [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34541: URL: https://github.com/apache/doris/pull/34541#issuecomment-2109318366 `sh-checker report` To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/9074264655;) output. shellcheck

Re: [PR] [fix](IO) Fix async close's raii and lazily load jni's jvm max heap value [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on code in PR #34799: URL: https://github.com/apache/doris/pull/34799#discussion_r1599399596 ## be/src/io/fs/s3_file_writer.cpp: ## @@ -242,7 +242,7 @@ Status S3FileWriter::_close_impl() { } Status S3FileWriter::appendv(const Slice* data,

Re: [PR] [fix](IO) Fix async close's raii and lazily load jni's jvm max heap value [doris]

2024-05-13 Thread via GitHub
ByteYue commented on PR #34799: URL: https://github.com/apache/doris/pull/34799#issuecomment-2109310370 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](Nereids): clone the producer plan and put logicalAnchor generated by `Or_Expansion` above `logicalSink` [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34771: URL: https://github.com/apache/doris/pull/34771#issuecomment-2109307177 TPC-DS: Total hot run time: 187526 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [improve](function) add limit check for lpad/rpad function input big value of length [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34810: URL: https://github.com/apache/doris/pull/34810#issuecomment-2109303684 TPC-DS: Total hot run time: 186868 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](nereids)4 phase agg may lost parameter in some case [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34816: URL: https://github.com/apache/doris/pull/34816#issuecomment-2109301537 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your

Re: [PR] [fix](nereids)4 phase agg may lost parameter in some case [doris]

2024-05-13 Thread via GitHub
starocean999 commented on PR #34816: URL: https://github.com/apache/doris/pull/34816#issuecomment-2109301596 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] [fix](nereids)4 phase agg may lost parameter in some case [doris]

2024-05-13 Thread via GitHub
starocean999 opened a new pull request, #34816: URL: https://github.com/apache/doris/pull/34816 ## Proposed changes The last param of AggregateExpression's constructor should be agg function in phase 3 or 4-phase agg ## Further comments If this is a relatively

Re: [PR] [fix](Nereids): clone the producer plan and put logicalAnchor generated by `Or_Expansion` above `logicalSink` [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34771: URL: https://github.com/apache/doris/pull/34771#issuecomment-2109296292 TPC-H: Total hot run time: 39923 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch

Re: [PR] [fix](prepare) fix datetimev2 return err when binary_row_format [doris]

2024-05-13 Thread via GitHub
eldenmoon commented on code in PR #34662: URL: https://github.com/apache/doris/pull/34662#discussion_r1599385168 ## fe/fe-core/src/main/java/org/apache/doris/mysql/MysqlSerializer.java: ## @@ -298,6 +298,8 @@ public int getMysqlDecimals(Type type) { case DECIMAL64:

Re: [PR] [improve](function) add limit check for lpad/rpad function input big value of length [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34810: URL: https://github.com/apache/doris/pull/34810#issuecomment-2109293028 TPC-H: Total hot run time: 40653 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch

Re: [PR] [feat](Nereids): lazy get expression map [doris]

2024-05-13 Thread via GitHub
XieJiann commented on PR #34753: URL: https://github.com/apache/doris/pull/34753#issuecomment-2109288060 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [bump](fe)upgrade dependencies [doris]

2024-05-13 Thread via GitHub
CalvinKirs commented on PR #34800: URL: https://github.com/apache/doris/pull/34800#issuecomment-2109285402 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Enhancement] FE/BE print the node start time at startup [doris]

2024-05-13 Thread via GitHub
rohitrs1983 commented on PR #34499: URL: https://github.com/apache/doris/pull/34499#issuecomment-2109285442 @LemonLiTree can u please review my PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [fix](iceberg_orc)Fixed the bug that the iceberg reader did not perform position delete when reading the orc file without a predicate. [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34814: URL: https://github.com/apache/doris/pull/34814#issuecomment-2109285271 TPC-DS: Total hot run time: 188082 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [regression-test](framework) fix trino connector download bug in multi be [doris]

2024-05-13 Thread via GitHub
shuke987 commented on PR #34806: URL: https://github.com/apache/doris/pull/34806#issuecomment-2109283634 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Pick "[fix](IO) Fix async close's raii and lazily load jni's jvm max heap value #34799" [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34815: URL: https://github.com/apache/doris/pull/34815#issuecomment-2109279430 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Pick "[fix](IO) Fix async close's raii and lazily load jni's jvm max heap value #34799" [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34815: URL: https://github.com/apache/doris/pull/34815#issuecomment-2109279404 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-13 Thread via GitHub
zhiqiang- commented on code in PR #34370: URL: https://github.com/apache/doris/pull/34370#discussion_r1599375169 ## fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java: ## @@ -1466,23 +1469,27 @@ public boolean shouldCancel(List currentBackends) { //

Re: [PR] [fix](Nereids): clone the producer plan and put logicalAnchor generated by `Or_Expansion` above `logicalSink` [doris]

2024-05-13 Thread via GitHub
XieJiann commented on PR #34771: URL: https://github.com/apache/doris/pull/34771#issuecomment-2109275454 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](iceberg_orc)Fixed the bug that the iceberg reader did not perform position delete when reading the orc file without a predicate. [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34814: URL: https://github.com/apache/doris/pull/34814#issuecomment-2109274831 TPC-H: Total hot run time: 40233 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch

Re: [PR] [fix](iceberg_orc)Fixed the bug that the iceberg reader did not perform position delete when reading the orc file without a predicate. [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34814: URL: https://github.com/apache/doris/pull/34814#issuecomment-2109272821 TeamCity be ut coverage result: Function Coverage: 35.67% (8982/25180) Line Coverage: 27.32% (74256/271756) Region Coverage: 26.56% (38371/144460) Branch Coverage:

Re: [PR] [fix][nereids] fix misunderstanding about bothSideShuffleKeysAreSameOrder [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34811: URL: https://github.com/apache/doris/pull/34811#issuecomment-2109271182 TPC-DS: Total hot run time: 185826 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](short circurt) fix return default value issue [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34186: URL: https://github.com/apache/doris/pull/34186#issuecomment-2109266195 TPC-DS: Total hot run time: 186951 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](iceberg_orc)Fixed the bug that the iceberg reader did not perform position delete when reading the orc file without a predicate. [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34814: URL: https://github.com/apache/doris/pull/34814#issuecomment-2109263094 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]

2024-05-13 Thread via GitHub
yiguolei commented on code in PR #34812: URL: https://github.com/apache/doris/pull/34812#discussion_r1599364710 ## be/src/runtime/fragment_mgr.cpp: ## @@ -505,6 +505,7 @@ void FragmentMgr::_exec_actual(std::shared_ptr fragment_ex } Status

Re: [PR] [fix][nereids] fix misunderstanding about bothSideShuffleKeysAreSameOrder [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34811: URL: https://github.com/apache/doris/pull/34811#issuecomment-2109260892 TPC-H: Total hot run time: 40244 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch

Re: [PR] [feature](block) add check type in block data type and column [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34314: URL: https://github.com/apache/doris/pull/34314#issuecomment-2109260591 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [fix](iceberg_orc)Fixed the bug that the iceberg reader did not perform position delete when reading the orc file without a predicate. [doris]

2024-05-13 Thread via GitHub
hubgeter commented on PR #34814: URL: https://github.com/apache/doris/pull/34814#issuecomment-2109257886 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Pick "[fix](IO) Fix async close's raii and lazily load jni's jvm max heap value #34799" [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34815: URL: https://github.com/apache/doris/pull/34815#issuecomment-2109257869 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your

[PR] Pick "[fix](IO) Fix async close's raii and lazily load jni's jvm max heap value #34799" [doris]

2024-05-13 Thread via GitHub
ByteYue opened a new pull request, #34815: URL: https://github.com/apache/doris/pull/34815 ## Proposed changes Issue Number: close #xxx same as master #34799 ## Further comments If this is a relatively large or complex change, kick off the discussion at

Re: [PR] [fix](iceberg_orc)Fixed the bug that the iceberg reader did not perform position delete when reading the orc file without a predicate. [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34814: URL: https://github.com/apache/doris/pull/34814#issuecomment-2109257763 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your

[PR] [fix](iceberg_orc)Fixed the bug that the iceberg reader did not perform position delete when reading the orc file without a predicate. [doris]

2024-05-13 Thread via GitHub
hubgeter opened a new pull request, #34814: URL: https://github.com/apache/doris/pull/34814 ## Proposed changes fix this bug: Scenario : iceberg table uses orc storage format sql : `select * from iceberg_orc;` When executing this sql, position delete filter is not performed.

Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34812: URL: https://github.com/apache/doris/pull/34812#issuecomment-2109255921 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [feature](block) add check type in block data type and column [doris]

2024-05-13 Thread via GitHub
Mryange commented on PR #34314: URL: https://github.com/apache/doris/pull/34314#issuecomment-2109255678 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](short circurt) fix return default value issue [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34186: URL: https://github.com/apache/doris/pull/34186#issuecomment-2109256214 TPC-H: Total hot run time: 39770 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch

Re: [PR] [improve](function) add limit check for lpad/rpad function input big value of length [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34810: URL: https://github.com/apache/doris/pull/34810#issuecomment-2109255399 TPC-DS: Total hot run time: 186804 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34812: URL: https://github.com/apache/doris/pull/34812#issuecomment-2109255602 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [Bug](topn) fix dcheck failed when _tablet_reader_params.topn_filter_source_node… [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34808: URL: https://github.com/apache/doris/pull/34808#issuecomment-2109253558 ClickBench: Total hot run time: 30.64 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [debug](thrift rpc) debug thrift rpc [doris]

2024-05-13 Thread via GitHub
dataroaring commented on PR #34813: URL: https://github.com/apache/doris/pull/34813#issuecomment-2109253250 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [debug](thrift rpc) debug thrift rpc [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34813: URL: https://github.com/apache/doris/pull/34813#issuecomment-2109253215 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your

[PR] [debug](thrift rpc) debug thrift rpc [doris]

2024-05-13 Thread via GitHub
dataroaring opened a new pull request, #34813: URL: https://github.com/apache/doris/pull/34813 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at

Re: [PR] [fix](short circurt) fix return default value issue [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34186: URL: https://github.com/apache/doris/pull/34186#issuecomment-2109252694 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [optimize](information_schema) optimize the data type of table information_schema.rowsets [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34739: URL: https://github.com/apache/doris/pull/34739#issuecomment-2109252673 TPC-DS: Total hot run time: 186407 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]

2024-05-13 Thread via GitHub
Gabriel39 commented on PR #34812: URL: https://github.com/apache/doris/pull/34812#issuecomment-2109250616 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](short circurt) fix return default value issue [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34186: URL: https://github.com/apache/doris/pull/34186#issuecomment-2109250432 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34812: URL: https://github.com/apache/doris/pull/34812#issuecomment-2109250438 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your

[PR] [conf](pipeline) Disable non-pipeline engine [doris]

2024-05-13 Thread via GitHub
Gabriel39 opened a new pull request, #34812: URL: https://github.com/apache/doris/pull/34812 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at

Re: [PR] [Bug](topn) fix dcheck failed when _tablet_reader_params.topn_filter_source_node… [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34808: URL: https://github.com/apache/doris/pull/34808#issuecomment-2109248120 TPC-DS: Total hot run time: 187929 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Improvement](pipeline) blocking tasks before putting in runnable queue [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34805: URL: https://github.com/apache/doris/pull/34805#issuecomment-2109247584 TPC-DS: Total hot run time: 186686 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](short circurt) fix return default value issue [doris]

2024-05-13 Thread via GitHub
felixwluo commented on code in PR #34186: URL: https://github.com/apache/doris/pull/34186#discussion_r1599352464 ## be/src/vec/data_types/serde/data_type_nullable_serde.cpp: ## @@ -238,13 +238,14 @@ void DataTypeNullableSerDe::write_one_cell_to_jsonb(const IColumn& column,

Re: [PR] [nereids] fix misunderstanding about bothSideShuffleKeysAreSameOrder [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34811: URL: https://github.com/apache/doris/pull/34811#issuecomment-2109246240 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [nereids] fix misunderstanding about bothSideShuffleKeysAreSameOrder [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34811: URL: https://github.com/apache/doris/pull/34811#issuecomment-2109246269 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [improve](function) add limit check for lpad/rpad function input big value of length [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34810: URL: https://github.com/apache/doris/pull/34810#issuecomment-2109244787 TPC-H: Total hot run time: 40312 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch

Re: [PR] [nereids] fix misunderstanding about bothSideShuffleKeysAreSameOrder [doris]

2024-05-13 Thread via GitHub
xzj7019 commented on PR #34811: URL: https://github.com/apache/doris/pull/34811#issuecomment-2109243674 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [nereids] fix misunderstanding about bothSideShuffleKeysAreSameOrder [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34811: URL: https://github.com/apache/doris/pull/34811#issuecomment-2109243595 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your

[PR] [nereids] fix misunderstanding about bothSideShuffleKeysAreSameOrder [doris]

2024-05-13 Thread via GitHub
xzj7019 opened a new pull request, #34811: URL: https://github.com/apache/doris/pull/34811 ## Proposed changes fix misunderstanding about bothSideShuffleKeysAreSameOrder, which originally should ensure the order of shuffle column lists. ## Further comments If this is a

Re: [PR] [optimize](information_schema) optimize the data type of table information_schema.rowsets [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34739: URL: https://github.com/apache/doris/pull/34739#issuecomment-2109242079 TPC-H: Total hot run time: 39964 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch

Re: [PR] [Bug](topn) fix dcheck failed when _tablet_reader_params.topn_filter_source_node… [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34808: URL: https://github.com/apache/doris/pull/34808#issuecomment-2109241228 TeamCity be ut coverage result: Function Coverage: 35.67% (8982/25180) Line Coverage: 27.32% (74252/271741) Region Coverage: 26.55% (38356/14) Branch Coverage:

Re: [PR] [Fix](outfile) Fix the timing of setting the `_is_closed` flag in Parquet/ORC writer [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34668: URL: https://github.com/apache/doris/pull/34668#issuecomment-2109240691 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [Fix](outfile) Fix the timing of setting the `_is_closed` flag in Parquet/ORC writer [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34668: URL: https://github.com/apache/doris/pull/34668#issuecomment-2109240668 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [opt](fe) exit FE when transfer to (non)master failed [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34809: URL: https://github.com/apache/doris/pull/34809#issuecomment-2109239856 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [fix](short circurt) fix return default value issue [doris]

2024-05-13 Thread via GitHub
eldenmoon commented on PR #34186: URL: https://github.com/apache/doris/pull/34186#issuecomment-2109239624 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](short circurt) fix return default value issue [doris]

2024-05-13 Thread via GitHub
eldenmoon commented on code in PR #34186: URL: https://github.com/apache/doris/pull/34186#discussion_r1599347871 ## be/src/vec/data_types/serde/data_type_nullable_serde.cpp: ## @@ -238,13 +238,14 @@ void DataTypeNullableSerDe::write_one_cell_to_jsonb(const IColumn& column,

Re: [PR] [fix](jdbc catalog) fix jdbc table checksum and query jdbc tvf [doris]

2024-05-13 Thread via GitHub
morningman merged PR #34779: URL: https://github.com/apache/doris/pull/34779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [opt](fe) exit FE when transfer to (non)master failed [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34809: URL: https://github.com/apache/doris/pull/34809#issuecomment-2109238157 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [Bug](topn) fix dcheck failed when _tablet_reader_params.topn_filter_source_node… [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34808: URL: https://github.com/apache/doris/pull/34808#issuecomment-2109238193 TPC-H: Total hot run time: 41420 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch

(doris) branch master updated: [fix](jdbc catalog) fix jdbc table checksum and query jdbc tvf (#34779)

2024-05-13 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new fc5cde42eea [fix](jdbc catalog) fix jdbc

Re: [PR] [opt](fe) exit FE when transfer to (non)master failed [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34809: URL: https://github.com/apache/doris/pull/34809#issuecomment-2109238175 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [opt](nereids) support topn-filter for external table [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34674: URL: https://github.com/apache/doris/pull/34674#issuecomment-2109238117 TPC-DS: Total hot run time: 187237 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Improvement](pipeline) blocking tasks before putting in runnable queue [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34805: URL: https://github.com/apache/doris/pull/34805#issuecomment-2109237776 TPC-H: Total hot run time: 39843 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch

(doris) branch master updated (b9deb890218 -> 61fdbfe40cf)

2024-05-13 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from b9deb890218 [fix](runtimefilter)slot comparison bug #34791 add 61fdbfe40cf [fix](catalog) fix potential

Re: [PR] [fix](catalog) fix potential catalog cache dead lock [doris]

2024-05-13 Thread via GitHub
morningman merged PR #34609: URL: https://github.com/apache/doris/pull/34609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [opt](split) get file splits in batch mode [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34032: URL: https://github.com/apache/doris/pull/34032#issuecomment-2109236186 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [fix](catalog) fix potential catalog cache dead lock [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34609: URL: https://github.com/apache/doris/pull/34609#issuecomment-2109236104 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [fix](short circurt) fix return default value issue [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34186: URL: https://github.com/apache/doris/pull/34186#issuecomment-2109233507 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [opt](fe) exit FE when transfer to (non)master failed [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34809: URL: https://github.com/apache/doris/pull/34809#issuecomment-2109233348 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [improve](function) add limit check for lpad/rpad function input big value of length [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34810: URL: https://github.com/apache/doris/pull/34810#issuecomment-2109232160 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [opt](fe) exit FE when transfer to (non)master failed [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34809: URL: https://github.com/apache/doris/pull/34809#issuecomment-2109231494 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [Pick](repeat) fix core dump coz output slot'order on repeat node not match with pre repeat exprs [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34803: URL: https://github.com/apache/doris/pull/34803#issuecomment-2109230370 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit e786cdb7d0949499b96b84b8529a7ae2dbabc951 with default session variables Stream

Re: [PR] [fix](short circurt) fix return default value issue [doris]

2024-05-13 Thread via GitHub
felixwluo commented on PR #34186: URL: https://github.com/apache/doris/pull/34186#issuecomment-2109229712 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [opt](nereids) support topn-filter for external table [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34674: URL: https://github.com/apache/doris/pull/34674#issuecomment-2109228862 TPC-H: Total hot run time: 41575 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch

Re: [PR] [improve](function) add limit check for lpad/rpad function input big value of length [doris]

2024-05-13 Thread via GitHub
zhangstar333 commented on PR #34810: URL: https://github.com/apache/doris/pull/34810#issuecomment-2109228151 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [Pick](repeat) fix core dump coz output slot'order on repeat node not match with pre repeat exprs [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34803: URL: https://github.com/apache/doris/pull/34803#issuecomment-2109227647 ClickBench: Total hot run time: 31.77 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [optimize](information_schema) optimize the data type of table information_schema.rowsets [doris]

2024-05-13 Thread via GitHub
DarvenDuan commented on PR #34739: URL: https://github.com/apache/doris/pull/34739#issuecomment-2109227246 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [improve](function) add limit check for lpad/rpad function input big value of length [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34810: URL: https://github.com/apache/doris/pull/34810#issuecomment-2109226932 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your

[PR] [improve](function) add limit check for lpad/rpad function input big value of length [doris]

2024-05-13 Thread via GitHub
zhangstar333 opened a new pull request, #34810: URL: https://github.com/apache/doris/pull/34810 if the user input big value of length, maybe cause some memory problem or exceeded size limit of thrift, so add this check to report error for user firstly. ## Proposed changes

Re: [PR] [optimize](information_schema) optimize the data type of table information_schema.rowsets [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34739: URL: https://github.com/apache/doris/pull/34739#issuecomment-2109226623 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] [opt](fe) exit FE when transfer to (non)master failed [doris]

2024-05-13 Thread via GitHub
morningman opened a new pull request, #34809: URL: https://github.com/apache/doris/pull/34809 ## Proposed changes 1. If there is exception thrown when doing `transferToMaster` or `tranferToNonMaster`, we should catch it and exit the FE process. Otherwise, the statelistener

Re: [PR] [opt](fe) exit FE when transfer to (non)master failed [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34809: URL: https://github.com/apache/doris/pull/34809#issuecomment-2109225839 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your

Re: [PR] [Pick](repeat) fix core dump coz output slot'order on repeat node not match with pre repeat exprs [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34803: URL: https://github.com/apache/doris/pull/34803#issuecomment-2109222711 TPC-DS: Total hot run time: 202378 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Bug](topn) fix dcheck failed when _tablet_reader_params.topn_filter_source_node… [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34808: URL: https://github.com/apache/doris/pull/34808#issuecomment-2109222680 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

  1   2   3   4   5   6   7   8   >